112513 2013-03-17 00:50:35 -0700 [WK2] Build warning in didReceiveMessage() generated by messages.py 2013-04-10 20:22:03 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim andersca commit-queue zan oldest_to_newest 856686 0 gyuyoung.kim 2013-03-17 00:50:35 -0700 There are too many build warning when didReceiveMessage() is generated. *connection* parameter is added though some didReceiveMessage() don't use it. [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/DownloadProxyMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebMediaCacheManagerProxyMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebNotificationManagerProxyMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebNotificationManagerProxyMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/PluginProcessProxyMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebResourceCacheManagerProxyMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebProcessMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/DownloadProxyMessageReceiver.cpp:44:6: warning: unused parameter ‘connection’ [-Wunused-parameter] /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/DownloadProxyMessageReceiver.cpp:81:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebApplicationCacheManagerMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/CoordinatedLayerTreeHostProxyMessageReceiver.cpp:46:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/AuthenticationManagerMessageReceiver.cpp.o [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebBatteryManagerMessageReceiver.cpp.o [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebCookieManagerMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebBatteryManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebFullScreenManagerMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebCookieManagerMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebGeolocationManagerMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebInspectorProxyMessageReceiver.cpp:40:6: warning: unused parameter ‘connection’ [-Wunused-parameter] /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebInspectorProxyMessageReceiver.cpp:83:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebIconDatabaseProxyMessageReceiver.cpp.o [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebMediaCacheManagerMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/AuthenticationManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebNetworkInfoManagerMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebApplicationCacheManagerMessageReceiver.cpp:36:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebNotificationManagerMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebGeolocationManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/PluginProcessConnectionMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebIconDatabaseProxyMessageReceiver.cpp:35:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/PluginProcessConnectionManagerMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebMediaCacheManagerMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/PluginProxyMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebNetworkInfoManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebResourceCacheManagerMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebNotificationManagerMessageReceiver.cpp:38:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/StorageAreaProxyMessageReceiver.cpp.o [ 95%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebKeyValueStorageManagerMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/PluginProcessConnectionManagerMessageReceiver.cpp:39:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 96%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebDatabaseManagerMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/StorageAreaProxyMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter] [ 96%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/DrawingAreaMessageReceiver.cpp.o [ 96%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/EventDispatcherMessageReceiver.cpp.o [ 96%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/WebInspectorMessageReceiver.cpp.o /home/gyuyoung/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebDatabaseManagerMessageReceiver.cpp:39:6: warning: unused parameter ‘connection’ [-Wunused-parameter] 859222 1 zan 2013-03-20 03:34:40 -0700 Do you still see these warnings? 867531 2 gyuyoung.kim 2013-04-01 21:29:01 -0700 (In reply to comment #1) > Do you still see these warnings? Yes, this warnings are still being shown. Are you interested in this bug ? 870662 3 196837 gyuyoung.kim 2013-04-08 01:11:30 -0700 Created attachment 196837 WIP (Temporary Fix) 871422 4 gyuyoung.kim 2013-04-08 21:32:41 -0700 CC'ing Anders, I wonder whether this patch can be accepted, could you give your comment ? 871910 5 andersca 2013-04-09 09:34:01 -0700 Looks like a good fix. Legacy receivers are ultimately going away anyway. 872603 6 197208 gyuyoung.kim 2013-04-09 22:35:41 -0700 Created attachment 197208 Patch 872604 7 gyuyoung.kim 2013-04-09 22:40:35 -0700 (In reply to comment #5) > Looks like a good fix. Legacy receivers are ultimately going away anyway. Thank you for your comment. I request review. Could you review this ? 873511 8 197208 commit-queue 2013-04-10 20:22:01 -0700 Comment on attachment 197208 Patch Clearing flags on attachment: 197208 Committed r148169: <http://trac.webkit.org/changeset/148169> 873512 9 commit-queue 2013-04-10 20:22:03 -0700 All reviewed patches have been landed. Closing bug. 196837 2013-04-08 01:11:30 -0700 2013-04-09 22:35:32 -0700 WIP (Temporary Fix) bug-112513-20130408171114.patch text/plain 1952 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3ODkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjhjZmM2YjUyODkxMDcx Y2Y1ZDkwZDRkZTI5NzQ0YjdjZjczZDZlNi4uNTJmNTNjNGQxMTY0OGYzYmZiNjMyODNkMTgyOGNk ZGZkZjBjNDAxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA0LTA4ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dLMl0gQnVp bGQgd2FybmluZyBpbiBkaWRSZWNlaXZlTWVzc2FnZSgpIGdlbmVyYXRlZCBmdW5jdGlvbiAKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjUxMworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXQyL21lc3NhZ2VzLnB5OgorICAgICAgICAoZ2VuZXJhdGVfbWVzc2FnZV9oYW5kbGVyKToK KwogMjAxMy0wNC0wNyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIFJlbW92ZSB0aGUgcmVzdCBvZiBTVkdfRE9NX09CSkNfQklORElOR1MKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9tZXNzYWdlcy5weSBiL1NvdXJjZS9XZWJL aXQyL1NjcmlwdHMvd2Via2l0Mi9tZXNzYWdlcy5weQppbmRleCA4NjgwNGIxMzcwNWJhODY5ZTMw NzA3YmI0ZWRhZDhiZDgyMDhiYTI1Li5kMDYyYTE3NDFlNjVjYTkyM2RmZmI2ODE5MDE5NTc1Yzlk NzJlMzAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TY3JpcHRzL3dlYmtpdDIvbWVzc2Fn ZXMucHkKKysrIGIvU291cmNlL1dlYktpdDIvU2NyaXB0cy93ZWJraXQyL21lc3NhZ2VzLnB5CkBA IC01NjYsNiArNTY2LDggQEAgZGVmIGdlbmVyYXRlX21lc3NhZ2VfaGFuZGxlcihmaWxlKToKIAog ICAgICAgICByZXN1bHQuYXBwZW5kKCd7XG4nKQogICAgICAgICByZXN1bHQgKz0gW2FzeW5jX21l c3NhZ2Vfc3RhdGVtZW50KHJlY2VpdmVyLCBtZXNzYWdlKSBmb3IgbWVzc2FnZSBpbiBhc3luY19t ZXNzYWdlc10KKyAgICAgICAgaWYgbm90IHJlY2VpdmVyLmhhc19hdHRyaWJ1dGUoTEVHQUNZX1JF Q0VJVkVSX0FUVFJJQlVURSk6CisgICAgICAgICAgICByZXN1bHQuYXBwZW5kKCcgICAgVU5VU0VE X1BBUkFNKGNvbm5lY3Rpb24pO1xuJykKICAgICAgICAgcmVzdWx0LmFwcGVuZCgnICAgIEFTU0VS VF9OT1RfUkVBQ0hFRCgpO1xuJykKICAgICAgICAgcmVzdWx0LmFwcGVuZCgnfVxuJykKIApAQCAt NTc3LDYgKzU3OSw4IEBAIGRlZiBnZW5lcmF0ZV9tZXNzYWdlX2hhbmRsZXIoZmlsZSk6CiAgICAg ICAgICAgICByZXN1bHQuYXBwZW5kKCd2b2lkICVzOjpkaWRSZWNlaXZlU3luY01lc3NhZ2UoQ29y ZUlQQzo6Q29ubmVjdGlvbiogY29ubmVjdGlvbiwgQ29yZUlQQzo6TWVzc2FnZURlY29kZXImIGRl Y29kZXIsIE93blB0cjxDb3JlSVBDOjpNZXNzYWdlRW5jb2Rlcj4mIHJlcGx5RW5jb2Rlcilcbicg JSAocmVjZWl2ZXIubmFtZSkpCiAgICAgICAgIHJlc3VsdC5hcHBlbmQoJ3tcbicpCiAgICAgICAg IHJlc3VsdCArPSBbc3luY19tZXNzYWdlX3N0YXRlbWVudChyZWNlaXZlciwgbWVzc2FnZSkgZm9y IG1lc3NhZ2UgaW4gc3luY19tZXNzYWdlc10KKyAgICAgICAgaWYgbm90IHJlY2VpdmVyLmhhc19h dHRyaWJ1dGUoTEVHQUNZX1JFQ0VJVkVSX0FUVFJJQlVURSk6CisgICAgICAgICAgICByZXN1bHQu YXBwZW5kKCcgICAgVU5VU0VEX1BBUkFNKGNvbm5lY3Rpb24pO1xuJykKICAgICAgICAgcmVzdWx0 LmFwcGVuZCgnICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpO1xuJykKICAgICAgICAgcmVzdWx0LmFw cGVuZCgnfVxuJykKIAo= 197208 2013-04-09 22:35:41 -0700 2013-04-10 20:22:01 -0700 Patch bug-112513-20130410143522.patch text/plain 2082 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjJjYWFhMzdiZTZmNjBj ZTVkN2IyMTcyYjQ1M2FkYmExMjk1OTA1My4uMzJjZmExNDAxZGI0NDc2NzNlODFlMDQxNjRhNGYw ZWNhOTZhZjIzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTA5ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dLMl0gQnVp bGQgd2FybmluZyBpbiBkaWRSZWNlaXZlTWVzc2FnZSgpIGdlbmVyYXRlZCBieSBtZXNzYWdlcy5w eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNTEz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGVnYWN5 IHJlY2VpdmVyIG1ha2VzIC1XdW51c2VkLXBhcmFtZXRlciBidWlsZCB3YXJuaW5ncy4gVGhpcyBw YXRjaCBpcyB0byBmaXggdGhlbS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0Mi9tZXNzYWdl cy5weToKKyAgICAgICAgKGdlbmVyYXRlX21lc3NhZ2VfaGFuZGxlcik6CisKIDIwMTMtMDQtMDkg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNT SU9OIChyMTQ3NDU0KTogWW91dHViZSBhbm5vdGF0aW9uIGxpbmtzIHRvIG5ldyB3aW5kb3cgYnJv a2VuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TY3JpcHRzL3dlYmtpdDIvbWVzc2FnZXMu cHkgYi9Tb3VyY2UvV2ViS2l0Mi9TY3JpcHRzL3dlYmtpdDIvbWVzc2FnZXMucHkKaW5kZXggODY4 MDRiMTM3MDViYTg2OWUzMDcwN2JiNGVkYWQ4YmQ4MjA4YmEyNS4uZDA2MmExNzQxZTY1Y2E5MjNk ZmZiNjgxOTAxOTU3NWM5ZDcyZTMwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2NyaXB0 cy93ZWJraXQyL21lc3NhZ2VzLnB5CisrKyBiL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0 Mi9tZXNzYWdlcy5weQpAQCAtNTY2LDYgKzU2Niw4IEBAIGRlZiBnZW5lcmF0ZV9tZXNzYWdlX2hh bmRsZXIoZmlsZSk6CiAKICAgICAgICAgcmVzdWx0LmFwcGVuZCgne1xuJykKICAgICAgICAgcmVz dWx0ICs9IFthc3luY19tZXNzYWdlX3N0YXRlbWVudChyZWNlaXZlciwgbWVzc2FnZSkgZm9yIG1l c3NhZ2UgaW4gYXN5bmNfbWVzc2FnZXNdCisgICAgICAgIGlmIG5vdCByZWNlaXZlci5oYXNfYXR0 cmlidXRlKExFR0FDWV9SRUNFSVZFUl9BVFRSSUJVVEUpOgorICAgICAgICAgICAgcmVzdWx0LmFw cGVuZCgnICAgIFVOVVNFRF9QQVJBTShjb25uZWN0aW9uKTtcbicpCiAgICAgICAgIHJlc3VsdC5h cHBlbmQoJyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTtcbicpCiAgICAgICAgIHJlc3VsdC5hcHBl bmQoJ31cbicpCiAKQEAgLTU3Nyw2ICs1NzksOCBAQCBkZWYgZ2VuZXJhdGVfbWVzc2FnZV9oYW5k bGVyKGZpbGUpOgogICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCgndm9pZCAlczo6ZGlkUmVjZWl2 ZVN5bmNNZXNzYWdlKENvcmVJUEM6OkNvbm5lY3Rpb24qIGNvbm5lY3Rpb24sIENvcmVJUEM6Ok1l c3NhZ2VEZWNvZGVyJiBkZWNvZGVyLCBPd25QdHI8Q29yZUlQQzo6TWVzc2FnZUVuY29kZXI+JiBy ZXBseUVuY29kZXIpXG4nICUgKHJlY2VpdmVyLm5hbWUpKQogICAgICAgICByZXN1bHQuYXBwZW5k KCd7XG4nKQogICAgICAgICByZXN1bHQgKz0gW3N5bmNfbWVzc2FnZV9zdGF0ZW1lbnQocmVjZWl2 ZXIsIG1lc3NhZ2UpIGZvciBtZXNzYWdlIGluIHN5bmNfbWVzc2FnZXNdCisgICAgICAgIGlmIG5v dCByZWNlaXZlci5oYXNfYXR0cmlidXRlKExFR0FDWV9SRUNFSVZFUl9BVFRSSUJVVEUpOgorICAg ICAgICAgICAgcmVzdWx0LmFwcGVuZCgnICAgIFVOVVNFRF9QQVJBTShjb25uZWN0aW9uKTtcbicp CiAgICAgICAgIHJlc3VsdC5hcHBlbmQoJyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTtcbicpCiAg ICAgICAgIHJlc3VsdC5hcHBlbmQoJ31cbicpCiAK