11251 2006-10-10 20:45:16 -0700 fill methods in <canvas> throw JS exceptions for 0 size elements 2007-07-03 14:39:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ PC OS X 10.4 CLOSED FIXED HasReduction, Regression P2 Normal --- 1 oliver oliver oldest_to_newest 53593 0 oliver 2006-10-10 20:45:16 -0700 Canvas currently throws JS exceptions when JS attempts to draw 0 size elements (eg. when width, height, or radius, etc are 0). These should just be ignored per the spec. 53594 1 11028 oliver 2006-10-10 20:50:02 -0700 Created attachment 11028 Simple test case Simple test case, if it fails, it presents a red square, if it succeeds it presents a green square. 53596 2 11029 oliver 2006-10-10 21:28:13 -0700 Created attachment 11029 patch Patch that fixes problem 53597 3 11029 aroben 2006-10-10 21:34:06 -0700 Comment on attachment 11029 patch r=me. Please turn the testcase into a layout test and include it when you check in. 53628 4 11029 darin 2006-10-11 11:56:20 -0700 Comment on attachment 11029 patch This patch breaks handling of NaN. We need to add test cases that pass non-numeric values (which turn into NaN) and then fix the code to say things like: if (!(r >= 0)) rather than if (r < 0) because expressions with NaN always yield false. 10885 5 darin 2007-05-05 08:17:29 -0700 Looks like Oliver landed this patch long ago and didn't notice my review-. http://trac.webkit.org/projects/webkit/changeset/16993 10933 6 oliver 2007-05-06 00:16:02 -0700 Eek, i even discussed that one with you post landing ... will bang out a correction to the logic :( 5635 7 oliver 2007-07-03 14:39:17 -0700 Fxed this a while back (with correct inf handling) 11028 2006-10-10 20:50:02 -0700 2006-10-10 20:50:02 -0700 Simple test case rect.html text/html 735 oliver PCEtLQ0KICBDcmVhdGVzIGEgY2FudmFzIHdoaWNoIGlzIGZpbGxlZCByZWQsIHRoZW4gYXR0ZW1w dHMgdG8NCiAgZmlsbCBhIG51bWJlciBvZiAwIHNpemUgcmVjdHMsIGZpbmFsbHkgZmlsbHMgd2l0 aCBncmVlbi4NCg0KICBGaWxsIGEgMC1zaXplZCByZWN0IHNob3VsZCBub3QgdGhyb3cgYW4gZXhj ZXB0aW9uLCBzbyANCiAgd2UgZXhwZWN0ZWQgdGhlIG91dHB1dCB0byBiZSBhIGdyZWVuIHJlY3Qu DQotLT4NCjxodG1sPg0KPGhlYWQ+DQo8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+DQp3 aW5kb3cub25sb2FkID0gZnVuY3Rpb24oKSB7DQoJdmFyIGNhbnZhcyA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJ0ZXN0Iik7CQkNCgl2YXIgY29udGV4dCA9IGNhbnZhcy5nZXRDb250ZXh0KCIy ZCIpOw0KCWNvbnRleHQuZmlsbFN0eWxlID0gJyNmMDAnOw0KCWNvbnRleHQuZmlsbFJlY3QoMCwg MCwgY2FudmFzLndpZHRoLCBjYW52YXMuaGVpZ2h0KTsNCgljb250ZXh0LmZpbGxSZWN0KDAsIDAs IDAsIDApOw0KCWNvbnRleHQuZmlsbFN0eWxlID0gJyMwZjAnOw0KCWNvbnRleHQuZmlsbFJlY3Qo MCwgMCwgY2FudmFzLndpZHRoLCBjYW52YXMuaGVpZ2h0KTsNCn0NCjwvc2NyaXB0Pg0KPHRpdGxl PmJvcmtlZG5lc3M8L3RpdGxlPg0KPC9oZWFkPg0KPGJvZHk+DQo8Y2FudmFzIGlkPSJ0ZXN0IiB3 aWR0aD0iMTAwIiBoZWlnaHQ9IjEwMCI+PC9jYW52YXM+DQo8L2JvZHk+DQo8L2h0bWw+ 11029 2006-10-10 21:28:13 -0700 2006-10-11 11:56:20 -0700 patch canvas3.patch text/plain 1847 oliver SW5kZXg6IGh0bWwvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBo dG1sL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAJKHJldmlzaW9uIDE2OTgxKQorKysgaHRt bC9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zODcsNyAr Mzg3LDcgQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmJlemllckN1cgogdm9pZCBD YW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmFyY1RvKGZsb2F0IHgwLCBmbG9hdCB5MCwgZmxvYXQg eDEsIGZsb2F0IHkxLCBmbG9hdCByLCBFeGNlcHRpb25Db2RlJiBlYykKIHsKICAgICBlYyA9IDA7 Ci0gICAgaWYgKCEociA+IDApKSB7CisgICAgaWYgKHIgPCAwKSB7CiAgICAgICAgIGVjID0gSU5E RVhfU0laRV9FUlI7CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC0zOTcsNyArMzk3LDcgQEAg dm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmFyY1RvKGZsbwogdm9pZCBDYW52YXNSZW5k ZXJpbmdDb250ZXh0MkQ6OmFyYyhmbG9hdCB4LCBmbG9hdCB5LCBmbG9hdCByLCBmbG9hdCBzYSwg ZmxvYXQgZWEsIGJvb2wgY2xvY2t3aXNlLCBFeGNlcHRpb25Db2RlJiBlYykKIHsKICAgICBlYyA9 IDA7Ci0gICAgaWYgKCEociA+IDApKSB7CisgICAgaWYgKHIgPCAwKSB7CiAgICAgICAgIGVjID0g SU5ERVhfU0laRV9FUlI7CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC00MDcsNyArNDA3LDcg QEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmFyYyhmbG9hdAogdm9pZCBDYW52YXNS ZW5kZXJpbmdDb250ZXh0MkQ6OnJlY3QoZmxvYXQgeCwgZmxvYXQgeSwgZmxvYXQgd2lkdGgsIGZs b2F0IGhlaWdodCwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7CiAgICAgZWMgPSAwOwotICAgIGlmICgh KHdpZHRoID4gMCAmJiBoZWlnaHQgPiAwKSkgeworICAgIGlmICh3aWR0aCA8IDAgfHwgaGVpZ2h0 IDwgMCkgewogICAgICAgICBlYyA9IElOREVYX1NJWkVfRVJSOwogICAgICAgICByZXR1cm47CiAg ICAgfQpAQCAtNDgyLDcgKzQ4Miw3IEBAIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpj bGlwKCkKIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpjbGVhclJlY3QoZmxvYXQgeCwg ZmxvYXQgeSwgZmxvYXQgd2lkdGgsIGZsb2F0IGhlaWdodCwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7 CiAgICAgZWMgPSAwOwotICAgIGlmICghKHdpZHRoID4gMCAmJiBoZWlnaHQgPiAwKSkgeworICAg IGlmICh3aWR0aCA8IDAgfHwgaGVpZ2h0IDwgMCkgewogICAgICAgICBlYyA9IElOREVYX1NJWkVf RVJSOwogICAgICAgICByZXR1cm47CiAgICAgfQpAQCAtNDk4LDcgKzQ5OCw3IEBAIHZvaWQgQ2Fu dmFzUmVuZGVyaW5nQ29udGV4dDJEOjpmaWxsUmVjdCgKIHsKICAgICBlYyA9IDA7CiAKLSAgICBp ZiAoISh3aWR0aCA+IDAgJiYgaGVpZ2h0ID4gMCkpIHsKKyAgICBpZiAod2lkdGggPCAwIHx8IGhl aWdodCA8IDApIHsKICAgICAgICAgZWMgPSBJTkRFWF9TSVpFX0VSUjsKICAgICAgICAgcmV0dXJu OwogICAgIH0KQEAgLTUzNSw3ICs1MzUsNyBAQCB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQy RDo6c3Ryb2tlUmVjCiB7CiAgICAgZWMgPSAwOwogCi0gICAgaWYgKCEod2lkdGggPiAwICYmIGhl aWdodCA+IDAgJiYgbGluZVdpZHRoID4gMCkpIHsKKyAgICBpZiAod2lkdGggPCAwIHx8IGhlaWdo dCA8IDAgfHwgbGluZVdpZHRoIDwgMCkgewogICAgICAgICBlYyA9IElOREVYX1NJWkVfRVJSOwog ICAgICAgICByZXR1cm47CiAgICAgfQo=