112495 2013-03-16 01:34:17 -0700 [iOS] Make a UChar string equal() based on the LChar version 2013-03-18 19:16:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin barraclough cmarcelo ojan.autocc webkit.review.bot oldest_to_newest 856542 0 benjamin 2013-03-16 01:34:17 -0700 [iOS] Make a UChar string equal() based on the LChar version 856544 1 193430 benjamin 2013-03-16 01:39:08 -0700 Created attachment 193430 Patch 856545 2 benjamin 2013-03-16 01:40:31 -0700 I'll get perf numbers before landing but I am confident that should be similar to the other function. UChar is easier as it only takes 2 characters to offset the extra cost of the function. 857669 3 193430 ddkilzer 2013-03-18 16:05:10 -0700 Comment on attachment 193430 Patch r=me (with help from Ben for my questions about arm assembly syntax) 857853 4 benjamin 2013-03-18 19:16:29 -0700 Committed r146170: <http://trac.webkit.org/changeset/146170> 193430 2013-03-16 01:39:08 -0700 2013-03-18 16:05:09 -0700 Patch bug-112495-20130316013503.patch text/plain 2610 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1OTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGY1MDkyYjU4YWRiZTBiOTdjNTQ0ZmE5 Njg5MzJkMmIwMjBmZGRjYTUuLjI1ZGFlYjZmZDk4ZGYwOTY2MmYxNzUzOGE4OGE4YTdmOTAwYWY3 OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDMtMTYgIEJlbmphbWluIFBvdWxhaW4gIDxi ZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIFtpT1NdIE1ha2UgYSBVQ2hhciBzdHJpbmcg ZXF1YWwoKSBiYXNlZCBvbiB0aGUgTENoYXIgdmVyc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNDk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdJbXBsLmg6CisgICAg ICAgIChXVEY6OmVxdWFsKToKKyAgICAgICAgQ3JlYXRlIGEgZXF1YWwoKSBmdW5jdGlvbiBmb3Ig VUNoYXIgYmFzZWQgb24gdGhlIHdvcmsgZG9uZSBmb3IgTENoYXIuCisKIDIwMTMtMDMtMTUgIEJl bmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gVXBk YXRlIFN0cmluZ0ltcGwncyBlcXVhbCB0byBoYXZlIGEgc2luZ2xlIHZlcnNpb24gb24gYWxsIHN1 cHBvcnRlZCBBcHBsZSBDUFVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmlu Z0ltcGwuaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCmluZGV4IDIzYWNlOWFk YjgzMTM2YjE2MWI5YzIwZDRiNTE0NDBhMDRjNTNlN2UuLjBkZjQ4MjMwZjVjMzQ3ZDlhNTE1MTY1 OTJmMGVjYzViNmRkNDA0YzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5n SW1wbC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCkBAIC05NjksNyAr OTY5LDQxIEBAIEFMV0FZU19JTkxJTkUgYm9vbCBlcXVhbChjb25zdCBMQ2hhciogYSwgY29uc3Qg TENoYXIqIGIsIHVuc2lnbmVkIGxlbmd0aCkKIAogQUxXQVlTX0lOTElORSBib29sIGVxdWFsKGNv bnN0IFVDaGFyKiBhLCBjb25zdCBVQ2hhciogYiwgdW5zaWduZWQgbGVuZ3RoKQogewotICAgIHJl dHVybiAhbWVtY21wKGEsIGIsIGxlbmd0aCAqIHNpemVvZihVQ2hhcikpOworICAgIGJvb2wgaXNF cXVhbCA9IGZhbHNlOworICAgIHVpbnQzMl90IGFWYWx1ZTsKKyAgICB1aW50MzJfdCBiVmFsdWU7 CisgICAgYXNtKCJzdWJzICAgJVtsZW5ndGhdLCAjMlxuIgorICAgICAgICAiYmxvICAgIDFmXG4i CisKKyAgICAgICAgIjA6XG4iIC8vIExhYmVsIDAgPSBTdGFydCBvZiBsb29wIG92ZXIgMzIgYml0 cy4KKyAgICAgICAgImxkciAgICAlW2FWYWx1ZV0sIFslW2FdXSwgIzRcbiIKKyAgICAgICAgImxk ciAgICAlW2JWYWx1ZV0sIFslW2JdXSwgIzRcbiIKKyAgICAgICAgImNtcCAgICAlW2FWYWx1ZV0s ICVbYlZhbHVlXVxuIgorICAgICAgICAiYm5lICAgIDY2ZlxuIgorICAgICAgICAic3VicyAgICVb bGVuZ3RoXSwgIzJcbiIKKyAgICAgICAgImJocyAgICAwYlxuIgorCisgICAgICAgIC8vIEF0IHRo aXMgcG9pbnQsIGxlbmd0aCBjYW4gYmU6CisgICAgICAgIC8vIC0wOiAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMCAoMCBieXRlcyBsZWZ0KQorICAgICAgICAvLyAtMTogMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTEgKDEgY2hhcmFjdGVyIGxlZnQsIDIgYnl0ZXMpCisgICAg ICAgIC8vIC0yOiAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMCAobGVuZ3RoIHdhcyB6 ZXJvKQorICAgICAgICAvLyBUaGUgcG9pbnRlcnMgYXJlIGF0IHRoZSBjb3JyZWN0IHBvc2l0aW9u LgorICAgICAgICAiMTpcbiIgLy8gTGFiZWwgMSA9IENoZWNrIGZvciBhIHNpbmdsZSBjaGFyYWN0 ZXIgbGVmdC4KKyAgICAgICAgInRzdCAgICAlW2xlbmd0aF0sICMxXG4iCisgICAgICAgICJiZXEg ICAgNDJmXG4iCisgICAgICAgICJsZHJoICAgJVthVmFsdWVdLCBbJVthXV1cbiIKKyAgICAgICAg ImxkcmggICAlW2JWYWx1ZV0sIFslW2JdXVxuIgorICAgICAgICAiY21wICAgICVbYVZhbHVlXSwg JVtiVmFsdWVdXG4iCisgICAgICAgICJibmUgICAgNjZmXG4iCisKKyAgICAgICAgIjQyOlxuIiAv LyBMYWJlbCA0MiA9IFN1Y2Nlc3MuCisgICAgICAgICJtb3YgICAgJVtpc0VxdWFsXSwgIzFcbiIK KyAgICAgICAgIjY2OlxuIiAvLyBMYWJlbCA2NiA9IEVuZCB3aXRob3V0IGNoYW5naW5nIGlzRXF1 YWwgdG8gMS4KKyAgICAgICAgOiBbbGVuZ3RoXSIrciIobGVuZ3RoKSwgW2lzRXF1YWxdIityIihp c0VxdWFsKSwgW2FdIityIihhKSwgW2JdIityIihiKSwgW2FWYWx1ZV0iK3IiKGFWYWx1ZSksIFti VmFsdWVdIityIihiVmFsdWUpCisgICAgICAgIDoKKyAgICAgICAgOgorICAgICAgICApOworICAg IHJldHVybiBpc0VxdWFsOwogfQogI2Vsc2UKIEFMV0FZU19JTkxJTkUgYm9vbCBlcXVhbChjb25z dCBMQ2hhciogYSwgY29uc3QgTENoYXIqIGIsIHVuc2lnbmVkIGxlbmd0aCkK