112489 2013-03-15 21:22:27 -0700 [WebKit2][GTK] Initialize gettext also in the UIProcess side 2017-03-11 10:49:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 gustavo gustavo bugs-noreply cgarcia mrobinson piotrdrag svillar webkit.review.bot xan.lopez oldest_to_newest 856498 0 gustavo 2013-03-15 21:22:27 -0700 [WebKit2][GTK] Initialize gettext also in the UIProcess side 856499 1 193421 gustavo 2013-03-15 21:24:22 -0700 Created attachment 193421 Patch 856501 2 webkit.review.bot 2013-03-15 21:27:49 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 856535 3 193421 cgarcia 2013-03-16 01:20:29 -0700 Comment on attachment 193421 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193421&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.cpp:56 > +static __attribute__((constructor)) void wkInitialize() I guess we don't need to check whether constructor is supported by the compiler because we now require GCC >= 4.7 and Clang >= 3.0, right? 856702 4 gustavo 2013-03-17 07:21:20 -0700 Right! I checked clang supports this gcc extension, too. 976993 5 193421 kling 2014-02-05 11:20:36 -0800 Comment on attachment 193421 Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag. 977271 6 svillar 2014-02-06 00:12:47 -0800 I think this is still valid 193421 2013-03-15 21:24:22 -0700 2014-02-05 11:20:35 -0800 Patch bug-112489-20130316012016.patch text/plain 1742 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1OTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTNjN2IwMjY1NjJlMDFj NmVmNjc4M2YyMDcwM2JmNjJkMDRjOWUxZS4uNzFmNDFhNjkyODQxMWY2MjBmYWM5YzIwNTFhYThk MWFhODQ1YjNlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTE1ICBHdXN0 YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgorCisgICAgICAgIFtXZWJLaXQyXVtH VEtdIEluaXRpYWxpemUgZ2V0dGV4dCBhbHNvIGluIHRoZSBVSVByb2Nlc3Mgc2lkZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNDg5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRQcml2YXRlLmNwcDoKKyAgICAgICAgKHdrSW5pdGlhbGl6ZSk6IHNldCB0ZXh0 IGRvbWFpbiBhbmQgY29kZXNldCBmb3IgdGhlIGxpYnJhcnkgb24KKyAgICAgICAgcHJvY2VzcyBz dGFydHVwLCB0aGUgZmlyc3Qgb25lIGlzIHJlcXVpcmVkIGZvciB0cmFuc2xhdGlvbnMgdG8gYmUK KyAgICAgICAgZm91bmQgd2hlbiBub3QgaW5zdGFsbGVkIG9uIHRoZSBtYWluIHN5c3RlbSBkaXJl Y3RvcmllcyBzZWFyY2hlZAorICAgICAgICBieSBnZXR0ZXh0LCB0aGUgc2Vjb25kIG9uZSBpcyB0 byBwbGVhc2UgZ2xpYiBhbmQgR1RLKworCiAyMDEzLTAzLTE1ICBOYXRlIENoYXBpbiAgPGphcGhl dEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSGlkZSBNYWluUmVzb3VyY2VMb2FkZXIgZnJvbSB0 aGUgb3V0c2lkZSB3b3JsZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0UHJpdmF0ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRQcml2YXRlLmNwcAppbmRleCBkMzRiOWM0NzE3MWEwOGFmOWRjZWIyNzc2ZDg3OWJh OGU4ZTQyNjBiLi4xZjc1ZGJkY2QzNjg2ODU5YmVhNDk5OGE5ZTkxMWNmMDhhNzQyZDE0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRQcml2YXRlLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRQcml2YXRlLmNw cApAQCAtMjEsNiArMjEsNyBAQAogI2luY2x1ZGUgIldlYktpdFByaXZhdGUuaCIKIAogI2luY2x1 ZGUgPGdkay9nZGsuaD4KKyNpbmNsdWRlIDxsaWJpbnRsLmg+CiAKIHVuc2lnbmVkIHdrRXZlbnRN b2RpZmllcnNUb0dka01vZGlmaWVycyhXS0V2ZW50TW9kaWZpZXJzIHdrTW9kaWZpZXJzKQogewpA QCAtNTEsMyArNTIsOSBAQCB1bnNpZ25lZCB3a0V2ZW50TW91c2VCdXR0b25Ub1dlYktpdE1vdXNl QnV0dG9uKFdLRXZlbnRNb3VzZUJ1dHRvbiB3a0J1dHRvbikKICAgICBBU1NFUlRfTk9UX1JFQUNI RUQoKTsKICAgICByZXR1cm4gMDsKIH0KKworc3RhdGljIF9fYXR0cmlidXRlX18oKGNvbnN0cnVj dG9yKSkgdm9pZCB3a0luaXRpYWxpemUoKQoreworICAgIGJpbmR0ZXh0ZG9tYWluKEdFVFRFWFRf UEFDS0FHRSwgUEFDS0FHRV9MT0NBTEVfRElSKTsKKyAgICBiaW5kX3RleHRkb21haW5fY29kZXNl dChHRVRURVhUX1BBQ0tBR0UsICJVVEYtOCIpOworfQo=