112478 2013-03-15 16:48:48 -0700 plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async 2013-03-15 17:22:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110973 1 jochen jochen abarth webkit.review.bot oldest_to_newest 856402 0 jochen 2013-03-15 16:48:48 -0700 plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async 856403 1 193398 jochen 2013-03-15 16:49:29 -0700 Created attachment 193398 Patch 856405 2 jochen 2013-03-15 16:51:24 -0700 This one is slightly different from the original patch: in the pass different npp struct test, I first invoke waitUntilDone() and then load the plugin. 856409 3 193398 tony 2013-03-15 16:56:48 -0700 Comment on attachment 193398 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193398&action=review > LayoutTests/platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt:-1 > -This tests that a hidden plug-in gets a correct NPP_SetWindow the first time. I see, this output is from before the log message came back from the plugin, right? 856410 4 193398 tony 2013-03-15 16:58:05 -0700 Comment on attachment 193398 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193398&action=review > LayoutTests/plugins/pass-different-npp-struct.html:5 > + if (window.testRunner) { > + testRunner.dumpAsText(); The mixing of 2 and 4 space indents is confusing, but I guess the old code was like that. 856411 5 193398 jochen 2013-03-15 16:58:22 -0700 Comment on attachment 193398 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193398&action=review >> LayoutTests/platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt:-1 >> -This tests that a hidden plug-in gets a correct NPP_SetWindow the first time. > > I see, this output is from before the log message came back from the plugin, right? Right. wk2 also uses out-of-process plugins, and has the same problem as content shell 856421 6 193398 webkit.review.bot 2013-03-15 17:22:24 -0700 Comment on attachment 193398 Patch Clearing flags on attachment: 193398 Committed r145967: <http://trac.webkit.org/changeset/145967> 856422 7 webkit.review.bot 2013-03-15 17:22:27 -0700 All reviewed patches have been landed. Closing bug. 193398 2013-03-15 16:49:29 -0700 2013-03-15 17:22:24 -0700 Patch bug-112478-20130316004523.patch text/plain 6043 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NDI0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTY2NDEwZTMxYmE2YjU4NjU4MmU3MDM0MzAwNzVjOGUw MGFmM2NlYS4uN2RkMWVlYTkyYjJhZTA3NjVhOTg3MmY3MDJjNzRmNGY3MGExMWY1YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEzLTAzLTE1ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIHBsdWdpbnMvbmV0c2NhcGUtcGx1Z2luLXNldHdpbmRvdy1zaXplKi5odG1sIGFu ZCBwbHVnaW5zL3Bhc3MtZGlmZmVyZW50LW5wcC1zdHJ1Y3QuaHRtbCBzaG91bGQgYmUgYXN5bmMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjQ3OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGlz IG5vdGhpbmcgdGhhdCBlbnN1cmVzIHRoYXQgdGhlIGxvZyBtZXNzYWdlcyBmcm9tIHRoZSBwbHVn aW4KKyAgICAgICAgY29tZSBpbiBiZWZvcmUgdGhlIGxheW91dCB0ZXN0IGZpbmlzaGVkIGxvYWRp bmcuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vVGVzdHMv UGFzc0RpZmZlcmVudE5QUFN0cnVjdC5jcHA6CisgICAgICAgIChQYXNzRGlmZmVyZW50TlBQU3Ry dWN0OjpOUFBfU2V0V2luZG93KToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2Nh cGVQbHVnSW4vbWFpbi5jcHA6CisgICAgICAgIChOUFBfU2V0V2luZG93KToKKwogMjAxMy0wMi0y OCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBNZXJnZSBQZXJm VGVzdFJ1bm5lci5fcnVuX3NpbmdsZV90ZXN0IGludG8gUGVyZlRlc3RSdW5uZXIuX3J1bl90ZXN0 c19zZXQKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJ bi9UZXN0cy9QYXNzRGlmZmVyZW50TlBQU3RydWN0LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L1Rlc3ROZXRzY2FwZVBsdWdJbi9UZXN0cy9QYXNzRGlmZmVyZW50TlBQU3RydWN0LmNwcAppbmRl eCBjOWFmNDljNTliNzlmOTM3MDI2NTExNjJjMDFlZTJhYmYwYzExMDRmLi5kNzhhMjliYWUyZjU0 MGQyZjg4MDIzYTUzZTRkMWJiMDg4ZDc3MTMxIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVy VHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vVGVzdHMvUGFzc0RpZmZlcmVudE5QUFN0cnVjdC5jcHAK KysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1Rlc3RzL1Bhc3NE aWZmZXJlbnROUFBTdHJ1Y3QuY3BwCkBAIC01OCw5ICs1OCwxMSBAQCBwcml2YXRlOgogCiAgICAg ICAgIGlmIChlcnJvciAhPSBOUEVSUl9OT19FUlJPUikgewogICAgICAgICAgICAgbG9nKCJOUE5f R2V0VmFsdWUoTlBOVnByaXZhdGVNb2RlQm9vbCkgd2l0aCBhIGRpZmZlcmVudCBOUFAgc3RydWN0 IGZhaWxlZCB3aXRoIGVycm9yICVkIiwgZXJyb3IpOworICAgICAgICAgICAgbm90aWZ5RG9uZSgp OwogICAgICAgICAgICAgcmV0dXJuIE5QRVJSX0dFTkVSSUNfRVJST1I7CiAgICAgICAgIH0KICAg ICAgICAgbG9nKCJOUE5fR2V0VmFsdWUoTlBOVnByaXZhdGVNb2RlQm9vbCkgd2l0aCBhIGRpZmZl cmVudCBOUFAgc3RydWN0IHN1Y2NlZWRlZCIpOworICAgICAgICBub3RpZnlEb25lKCk7CiAgICAg ICAgIHJldHVybiBOUEVSUl9OT19FUlJPUjsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9tYWluLmNwcCBiL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9tYWluLmNwcAppbmRleCA5N2E0Y2YzODk4ZjY3MDBl ZmRmMTVkNThlNjdiY2Q3YTc4YjJkZjY1Li4yNTZhY2MwMDNmMWUzNGNjNjIwMjgzZTZiMzQzMDM4 MDY2ZTBhYTY5IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQ bHVnSW4vbWFpbi5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1 Z0luL21haW4uY3BwCkBAIC0zNTEsNiArMzUxLDcgQEAgTlBFcnJvciBOUFBfU2V0V2luZG93KE5Q UCBpbnN0YW5jZSwgTlBXaW5kb3cgKndpbmRvdykKICAgICAgICAgaWYgKG9iai0+bG9nU2V0V2lu ZG93KSB7CiAgICAgICAgICAgICBwbHVnaW5Mb2coaW5zdGFuY2UsICJOUFBfU2V0V2luZG93OiAl ZCAlZCIsIChpbnQpd2luZG93LT53aWR0aCwgKGludCl3aW5kb3ctPmhlaWdodCk7CiAgICAgICAg ICAgICBvYmotPmxvZ1NldFdpbmRvdyA9IEZBTFNFOworICAgICAgICAgICAgZXhlY3V0ZVNjcmlw dChvYmosICJ0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsiKTsKICAgICAgICAgfQogCiAgICAgICAg IGlmIChvYmotPm9uU2V0V2luZG93KQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDhiYTg3ZDBkMTczZmE1OTVhNTJiYzM2MTM1 NTAxN2JmYjQwOTgwZWYuLjMxMzU0ZWRiZDk5MzhhNWE4M2JjMmFkYTI0NDFiMzg3ZTZjOGM3ODMg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0wMy0xNSAgSm9jaGVuIEVpc2luZ2VyICA8am9j aGVuQGNocm9taXVtLm9yZz4KKworICAgICAgICBwbHVnaW5zL25ldHNjYXBlLXBsdWdpbi1zZXR3 aW5kb3ctc2l6ZSouaHRtbCBhbmQgcGx1Z2lucy9wYXNzLWRpZmZlcmVudC1ucHAtc3RydWN0Lmh0 bWwgc2hvdWxkIGJlIGFzeW5jCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTI0NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGVyZSBpcyBub3RoaW5nIHRoYXQgZW5zdXJlcyB0aGF0IHRoZSBsb2cgbWVz c2FnZXMgZnJvbSB0aGUgcGx1Z2luCisgICAgICAgIGNvbWUgaW4gYmVmb3JlIHRoZSBsYXlvdXQg dGVzdCBmaW5pc2hlZCBsb2FkaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi9wbHVn aW5zL25ldHNjYXBlLXBsdWdpbi1zZXR3aW5kb3ctc2l6ZS0yLWV4cGVjdGVkLnR4dDogUmVtb3Zl ZC4KKyAgICAgICAgKiBwbHVnaW5zL25ldHNjYXBlLXBsdWdpbi1zZXR3aW5kb3ctc2l6ZS0yLmh0 bWw6CisgICAgICAgICogcGx1Z2lucy9uZXRzY2FwZS1wbHVnaW4tc2V0d2luZG93LXNpemUuaHRt bDoKKyAgICAgICAgKiBwbHVnaW5zL3Bhc3MtZGlmZmVyZW50LW5wcC1zdHJ1Y3QuaHRtbDoKKwog MjAxMy0wMi0yOCAgVGFrYXNoaSBUb3lvc2hpbWEgIDx0b3lvc2hpbUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCBjaHJvbWl1bSBnYXJkZW5pbmcKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy13azIvcGx1Z2lucy9uZXRzY2FwZS1wbHVnaW4tc2V0d2luZG93 LXNpemUtMi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL3BsdWdp bnMvbmV0c2NhcGUtcGx1Z2luLXNldHdpbmRvdy1zaXplLTItZXhwZWN0ZWQudHh0CmRlbGV0ZWQg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwZjkzYTdiZDUwZmRmMjBhMDRlYjRiZTYyMTA0MDk3OGNk ZjQwM2U2Li4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvcGx1Z2lucy9uZXRzY2FwZS1wbHVnaW4tc2V0d2lu ZG93LXNpemUtMi1leHBlY3RlZC50eHQKKysrIC9kZXYvbnVsbApAQCAtMSArMCwwIEBACi1UaGlz IHRlc3RzIHRoYXQgYSBoaWRkZW4gcGx1Zy1pbiBnZXRzIGEgY29ycmVjdCBOUFBfU2V0V2luZG93 IHRoZSBmaXJzdCB0aW1lLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGx1Z2lucy9uZXRzY2Fw ZS1wbHVnaW4tc2V0d2luZG93LXNpemUtMi5odG1sIGIvTGF5b3V0VGVzdHMvcGx1Z2lucy9uZXRz Y2FwZS1wbHVnaW4tc2V0d2luZG93LXNpemUtMi5odG1sCmluZGV4IDE0MDYxOWExYWFkODAzNmZj YjRkNWNlMmI0YjA2MTU4MmYzOTVjNTYuLjE4MDM0OWI3YmMxYTkyOWRlMmM1MjlkMzMzNjYwOGZk YmZiNjYzODkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsdWdpbnMvbmV0c2NhcGUtcGx1Z2lu LXNldHdpbmRvdy1zaXplLTIuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9wbHVnaW5zL25ldHNjYXBl LXBsdWdpbi1zZXR3aW5kb3ctc2l6ZS0yLmh0bWwKQEAgLTMsNiArMyw3IEBACiA8c2NyaXB0Pgog ICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewogICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1Rl eHQoKTsKKyAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CiAgICAgICAgIHRlc3RS dW5uZXIuc2V0V2luZG93SXNLZXkoZmFsc2UpOwogICAgIH0KICAgICAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsdWdpbnMvbmV0c2NhcGUtcGx1Z2luLXNldHdpbmRvdy1zaXplLmh0bWwgYi9M YXlvdXRUZXN0cy9wbHVnaW5zL25ldHNjYXBlLXBsdWdpbi1zZXR3aW5kb3ctc2l6ZS5odG1sCmlu ZGV4IDlkNDAyMDVmOTY3MGYwMjA5M2M3NTZkNGM0MDBkMTdlMGVkYjUwOWMuLjYyYmNjYmZiM2Fk ZDQyYWEyMDlmMjMzZTQ5MTA1ZGM2NWZkYWE4NGMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs dWdpbnMvbmV0c2NhcGUtcGx1Z2luLXNldHdpbmRvdy1zaXplLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvcGx1Z2lucy9uZXRzY2FwZS1wbHVnaW4tc2V0d2luZG93LXNpemUuaHRtbApAQCAtMSw4ICsx LDEwIEBACiA8aHRtbD4KIDxoZWFkPgogPHNjcmlwdD4KLSAgICBpZiAod2luZG93LnRlc3RSdW5u ZXIpCisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CiAgICAgICAgIHRlc3RSdW5uZXIuZHVt cEFzVGV4dCgpOworICAgICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB9CiA8 L3NjcmlwdD4KIDxib2R5IHN0eWxlPSJtYXJnaW46MHB4O292ZXJmbG93OmhpZGRlbiI+CiA8ZW1i ZWQgaWQ9InRlc3RQbHVnaW4iIHR5cGU9ImFwcGxpY2F0aW9uL3gtd2Via2l0LXRlc3QtbmV0c2Nh cGUiIGxvZ2ZpcnN0c2V0d2luZG93PSJ0cnVlIiB3aWR0aD0iMTAwJSIgaGVpZ2h0PSIyMDAiPjwv ZW1iZWQ+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbHVnaW5zL3Bhc3MtZGlmZmVyZW50LW5w cC1zdHJ1Y3QuaHRtbCBiL0xheW91dFRlc3RzL3BsdWdpbnMvcGFzcy1kaWZmZXJlbnQtbnBwLXN0 cnVjdC5odG1sCmluZGV4IDFiOGRlMzU2ZTdiMzBmOGU5ZmY1NzdmNmQwZGY2ZTY4NTIzYjRjNGQu LjZmYWZkYWRkNjU0ODE1MDhmNjhlODE0MzhlNTMxYjExMWU4NDQwN2MgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsdWdpbnMvcGFzcy1kaWZmZXJlbnQtbnBwLXN0cnVjdC5odG1sCisrKyBiL0xh eW91dFRlc3RzL3BsdWdpbnMvcGFzcy1kaWZmZXJlbnQtbnBwLXN0cnVjdC5odG1sCkBAIC0xLDUg KzEsMTIgQEAKIDxodG1sPgogPGhlYWQ+Cis8c2NyaXB0PgorICBpZiAod2luZG93LnRlc3RSdW5u ZXIpIHsKKyAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgICAgdGVzdFJ1bm5lci53 YWl0VW50aWxEb25lKCk7CisgIH0KKzwvc2NyaXB0PgorPC9oZWFkPgogPGJvZHk+CiA8ZW1iZWQg aWQ9InRlc3RQbHVnaW4iIAogICAgICAgIHR5cGU9ImFwcGxpY2F0aW9uL3gtd2Via2l0LXRlc3Qt bmV0c2NhcGUiCkBAIC0xMCwxMCArMTcsNiBAQAogPGRpdj4KICAgICBUaGlzIHRlc3RzIHRoYXQg bm8gYXNzZXJ0aW9ucyBmaXJlIHdoZW4gYSBwbHVnaW4gcGFzc2VzIGEgZGlmZmVyZW50IE5QUCBz dHJ1Y3QgdG8gb25lIG9mIHRoZSBOUE4qIGZ1bmN0aW9ucyAoc3BlY2lmaWNhbGx5LCBOUE5fR2V0 VmFsdWUpLgogPC9kaXY+Ci08c2NyaXB0PgotICBpZiAod2luZG93LnRlc3RSdW5uZXIpCi0gICAg ICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKLTwvc2NyaXB0PgogPC9ib2R5PgogPC9odG1sPgog Cg==