112474 2013-03-15 15:57:43 -0700 REGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTransferPlatformData() 2013-03-15 16:13:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aestes aestes thorton oldest_to_newest 856364 0 aestes 2013-03-15 15:57:43 -0700 REGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTransferPlatformData() 856368 1 193391 aestes 2013-03-15 16:00:39 -0700 Created attachment 193391 Patch 856370 2 193391 simon.fraser 2013-03-15 16:02:42 -0700 Comment on attachment 193391 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193391&action=review > Source/WebCore/platform/cf/SharedBufferCF.cpp:86 > + RetainPtr<CFDataRef> cfData(AdoptCF, m_cfData.leakRef()); This should just assign. 856376 3 193391 simon.fraser 2013-03-15 16:08:21 -0700 Comment on attachment 193391 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193391&action=review >> Source/WebCore/platform/cf/SharedBufferCF.cpp:86 >> + RetainPtr<CFDataRef> cfData(AdoptCF, m_cfData.leakRef()); > > This should just assign. This is OK, after discussion. 856382 4 aestes 2013-03-15 16:13:44 -0700 Committed r145958: <http://trac.webkit.org/changeset/145958> 193391 2013-03-15 16:00:39 -0700 2013-03-15 16:08:21 -0700 Patch bug-112474-20130315155639.patch text/plain 1704 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1OTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmYyMDE2OTUyZGFhNzMz Mjg1NWFlMDBiYWI2ODM1Yzc2MTc5ZGU4NC4uODA5OTU0ZjIzODg2MTM3Y2U4N2E1MjFkMTViMGFk YzM1ZTFmMGI4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTAzLTE1ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBSRUdSRVNTSU9OIChyMTQ1ODIw KTogU3RvcCBvdmVyLXJldGFpbmluZyBDRkRhdGFSZWZzIGluIFNoYXJlZEJ1ZmZlcjo6bWF5YmVU cmFuc2ZlclBsYXRmb3JtRGF0YSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTI0NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUcmFuc2ZlciBvd25lcnNoaXAgb2YgbV9jZkRhdGEgdG8gdGhlIGxvY2Fs IHZhcmlhYmxlIHJhdGhlciB0aGFuIGxlYWtpbmcgYSByZWZlcmVuY2UuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9jZi9TaGFyZWRCdWZmZXJDRi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaGFyZWRC dWZmZXI6Om1heWJlVHJhbnNmZXJQbGF0Zm9ybURhdGEpOgorCisyMDEzLTAzLTE1ICBBbmR5IEVz dGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKwogICAgICAgICBSRUdSRVNTSU9OIChyMTI3Mjc3KTog Q1NTIFVSSXMgd2l0aCBtdWx0aS1ieXRlIFVuaWNvZGUgZXNjYXBlIHNlcXVlbmNlcyBmYWlsIHRv IHBhcnNlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTI0MzYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2YvU2hhcmVkQnVm ZmVyQ0YuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2YvU2hhcmVkQnVmZmVyQ0YuY3Bw CmluZGV4IDlkZGIxMzgzNDc2ZTRkYjNkNzhiZGNjZWNjNGY5NDU2Njc0MDk4ZmMuLmQ1ODdlNzU5 ODFkODU3YTc4MzUxNWY2Mzc3MTYwMzE0Njk3ZGE1ODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2NmL1NoYXJlZEJ1ZmZlckNGLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9jZi9TaGFyZWRCdWZmZXJDRi5jcHAKQEAgLTgzLDcgKzgzLDcgQEAgdm9pZCBTaGFy ZWRCdWZmZXI6Om1heWJlVHJhbnNmZXJQbGF0Zm9ybURhdGEoKQogICAgIAogICAgIC8vIEhhbmcg b24gdG8gdGhlIG1fY2ZEYXRhIHBvaW50ZXIgaW4gYSBsb2NhbCBwb2ludGVyIGFzIGFwcGVuZCgp IHdpbGwgcmUtZW50ZXIgbWF5YmVUcmFuc2ZlclBsYXRmb3JtRGF0YSgpCiAgICAgLy8gYW5kIHdl IG5lZWQgdG8gbWFrZSBzdXJlIHRvIGVhcmx5IHJldHVybiB3aGVuIGl0IGRvZXMuCi0gICAgUmV0 YWluUHRyPENGRGF0YVJlZj4gY2ZEYXRhID0gbV9jZkRhdGEubGVha1JlZigpOworICAgIFJldGFp blB0cjxDRkRhdGFSZWY+IGNmRGF0YShBZG9wdENGLCBtX2NmRGF0YS5sZWFrUmVmKCkpOwogCiAg ICAgYXBwZW5kKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+KENGRGF0YUdldEJ5dGVQdHIo Y2ZEYXRhLmdldCgpKSksIENGRGF0YUdldExlbmd0aChjZkRhdGEuZ2V0KCkpKTsKIH0K