<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>112460</bug_id>
          
          <creation_ts>2013-03-15 13:15:01 -0700</creation_ts>
          <short_desc>Support Windows HTMLSelectElement keystrokes on Chromium win</short_desc>
          <delta_ts>2013-03-18 16:13:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Forms</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows 7</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>112540</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dominic Mazzoni">dmazzoni</reporter>
          <assigned_to name="Dominic Mazzoni">dmazzoni</assigned_to>
          <cc>antonm</cc>
    
    <cc>dglazkov</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>mifenton</cc>
    
    <cc>ojan.autocc</cc>
    
    <cc>tkent</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>856227</commentid>
    <comment_count>0</comment_count>
    <who name="Dominic Mazzoni">dmazzoni</who>
    <bug_when>2013-03-15 13:15:01 -0700</bug_when>
    <thetext>This bug added support for Windows-specific keystrokes to drop down the option list from a combo box:

    https://bugs.webkit.org/show_bug.cgi?id=22232 - Alt + Down Arrow in Combo box should show the drop down option box, as should F4) fixed 

However, this code is only compiled on PLATFORM(WINDOWS). We should be using it on all platforms, when OS(WINDOWS).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>856228</commentid>
    <comment_count>1</comment_count>
    <who name="Dominic Mazzoni">dmazzoni</who>
    <bug_when>2013-03-15 13:15:28 -0700</bug_when>
    <thetext>Chromium bug: http://crbug.com/1945</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>856534</commentid>
    <comment_count>2</comment_count>
      <attachid>193426</attachid>
    <who name="Dominic Mazzoni">dmazzoni</who>
    <bug_when>2013-03-16 01:14:40 -0700</bug_when>
    <thetext>Created attachment 193426
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>856537</commentid>
    <comment_count>3</comment_count>
      <attachid>193426</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-03-16 01:23:26 -0700</bug_when>
    <thetext>Comment on attachment 193426
Patch

Attachment 193426 did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17114586</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>856540</commentid>
    <comment_count>4</comment_count>
      <attachid>193428</attachid>
    <who name="Dominic Mazzoni">dmazzoni</who>
    <bug_when>2013-03-16 01:32:46 -0700</bug_when>
    <thetext>Created attachment 193428
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>856546</commentid>
    <comment_count>5</comment_count>
      <attachid>193428</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-03-16 01:44:03 -0700</bug_when>
    <thetext>Comment on attachment 193428
Patch

Attachment 193428 did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17184237</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>856547</commentid>
    <comment_count>6</comment_count>
      <attachid>193431</attachid>
    <who name="Dominic Mazzoni">dmazzoni</who>
    <bug_when>2013-03-16 01:48:18 -0700</bug_when>
    <thetext>Created attachment 193431
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>856759</commentid>
    <comment_count>7</comment_count>
      <attachid>193431</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2013-03-17 15:05:08 -0700</bug_when>
    <thetext>Comment on attachment 193431
Patch

ok.
Using OS() and PLATFORM() in WebCore is not nice, but they already exist in these files.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>856855</commentid>
    <comment_count>8</comment_count>
      <attachid>193431</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-03-17 23:28:06 -0700</bug_when>
    <thetext>Comment on attachment 193431
Patch

Clearing flags on attachment: 193431

Committed r146035: &lt;http://trac.webkit.org/changeset/146035&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>856856</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-03-17 23:28:09 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>856898</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-03-18 01:34:24 -0700</bug_when>
    <thetext>Re-opened since this is blocked by bug 112540</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>856901</commentid>
    <comment_count>11</comment_count>
    <who name="anton muhin">antonm</who>
    <bug_when>2013-03-18 01:35:17 -0700</bug_when>
    <thetext>That lead to Windows debug build failures:

32&gt;..\html\HTMLSelectElementWin.cpp(53): error C2220: warning treated as error - no &apos;object&apos; file generated
32&gt;..\html\HTMLSelectElementWin.cpp(53): warning C4018: &apos;&lt;&apos; : signed/unsigned mismatch

I&apos;ve reverted the patch?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>857178</commentid>
    <comment_count>12</comment_count>
    <who name="Dominic Mazzoni">dmazzoni</who>
    <bug_when>2013-03-18 09:14:23 -0700</bug_when>
    <thetext>Sorry about the build failure. That&apos;s weird, I definitely built Chromium on Windows to test this patch, so I&apos;m not sure why I didn&apos;t see that failure. Anyway, should be easy to fix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>857184</commentid>
    <comment_count>13</comment_count>
    <who name="anton muhin">antonm</who>
    <bug_when>2013-03-18 09:17:35 -0700</bug_when>
    <thetext>(In reply to comment #12)
&gt; Sorry about the build failure. That&apos;s weird, I definitely built Chromium on Windows to test this patch, so I&apos;m not sure why I didn&apos;t see that failure. Anyway, should be easy to fix.

Maybe you forgot to do debug build, just wildguessing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>857185</commentid>
    <comment_count>14</comment_count>
      <attachid>193579</attachid>
    <who name="Dominic Mazzoni">dmazzoni</who>
    <bug_when>2013-03-18 09:18:22 -0700</bug_when>
    <thetext>Created attachment 193579
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>857659</commentid>
    <comment_count>15</comment_count>
      <attachid>193579</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2013-03-18 15:54:09 -0700</bug_when>
    <thetext>Comment on attachment 193579
Patch

ok</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>857679</commentid>
    <comment_count>16</comment_count>
      <attachid>193579</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-03-18 16:13:16 -0700</bug_when>
    <thetext>Comment on attachment 193579
Patch

Clearing flags on attachment: 193579

Committed r146145: &lt;http://trac.webkit.org/changeset/146145&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>857680</commentid>
    <comment_count>17</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-03-18 16:13:20 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>193426</attachid>
            <date>2013-03-16 01:14:40 -0700</date>
            <delta_ts>2013-03-16 01:32:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-112460-20130316011034.patch</filename>
            <type>text/plain</type>
            <size>2202</size>
            <attacher name="Dominic Mazzoni">dmazzoni</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjdiOWIxZDU4NDczNjY1
NGE0N2EzYWU5MjA3ODFiY2EzMjJlZGQyNy4uYWFiNDNjMWI1ZGM0NzM2ZmRhOTI5MTFiZTQzM2I2
OTQyYWEwMmMyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTE2ICBEb21p
bmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgorCisgICAgICAgIFN1cHBvcnQgV2lu
ZG93cyBIVE1MU2VsZWN0RWxlbWVudCBrZXlzdHJva2VzIG9uIENocm9taXVtIHdpbgorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNDYwCisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29tcGlsZSBpbiB0aGUg
d2luZG93cy1zcGVjaWZpYyB2YXJpYW50IG9mCisgICAgICAgIEhUTUxTZWxlY3RFbGVtZW50Ojpw
bGF0Zm9ybUhhbmRsZUtleWRvd25FdmVudAorICAgICAgICBvbiBDaHJvbWl1bSB3aW4sIGluIGFk
ZGl0aW9uIHRvIFBMQVRGT1JNKFdJTikuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cGk6CisgICAg
ICAgICAgICBBZGQgaHRtbC9IVE1MU2VsZWN0RWxlbWVudFdpbi5jcHAuCisgICAgICAgICogaHRt
bC9IVE1MU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAgICAgICBEb24ndCBjb21waWxlIGdlbmVy
aWMgcGxhdGZvcm1IYW5kbGVLZXlkb3duRXZlbnQgb24KKyAgICAgICAgICAgIENocm9taXVtIHdp
bi4KKyAgICAgICAgKFdlYkNvcmUpOgorCiAyMDEzLTAzLTEyICBWc2V2b2xvZCBWbGFzb3YgIDx2
c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlc291cmNlU2Ny
aXB0RmlsZSBkaXZlcmdlZCBzdGF0ZSBzaG91bGQgYmUgY29ycmVjdGx5IHJlc2V0IGFmdGVyIGRl
YnVnZ2VyIHJlc2V0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBpIGIv
U291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBpCmluZGV4IDRkNWYyYmUzY2M3NzA4MzdmYjk0MWMy
NGVhODcxZjAyYTZiYzI2ZjguLmQyNzY1M2VkNjg0ODI1NDAxYmMxNGQ1M2FiNzhjN2RmYjYyNDM0
ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwaQorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9XZWJDb3JlLmd5cGkKQEAgLTMyOTIsNiArMzI5Miw3IEBACiAgICAgICAgICAgICAn
aHRtbC9IVE1MU2NyaXB0RWxlbWVudC5oJywKICAgICAgICAgICAgICdodG1sL0hUTUxTZWxlY3RF
bGVtZW50LmNwcCcsCiAgICAgICAgICAgICAnaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5oJywKKyAg
ICAgICAgICAgICdodG1sL0hUTUxTZWxlY3RFbGVtZW50V2luLmNwcCcsCiAgICAgICAgICAgICAn
aHRtbC9IVE1MU291cmNlRWxlbWVudC5jcHAnLAogICAgICAgICAgICAgJ2h0bWwvSFRNTFNvdXJj
ZUVsZW1lbnQuaCcsCiAgICAgICAgICAgICAnaHRtbC9IVE1MU3BhbkVsZW1lbnQuY3BwJywKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwIGIvU291
cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAKaW5kZXggNDc4N2YzZTZkMGI0
NTg5OTJhNmE1OTVkMjAyMzliOTE2ZmQzMjBkMi4uYTliZmNhZWJmMmNkZmRkZDczNGM2MTM5ZDg4
MDkxMjk1YjgyOGYyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0
RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5j
cHAKQEAgLTEwNTksNyArMTA1OSw3IEBAIHZvaWQgSFRNTFNlbGVjdEVsZW1lbnQ6OnJlc2V0KCkK
ICAgICBzZXROZWVkc1ZhbGlkaXR5Q2hlY2soKTsKIH0KIAotI2lmICFQTEFURk9STShXSU4pIHx8
IE9TKFdJTkNFKQorI2lmICghUExBVEZPUk0oV0lOKSAmJiAhKFBMQVRGT1JNKENIUk9NSVVNKSAm
JiBPUyhXSU5ET1dTKSkpIHx8IE9TKFdJTkNFKQogYm9vbCBIVE1MU2VsZWN0RWxlbWVudDo6cGxh
dGZvcm1IYW5kbGVLZXlkb3duRXZlbnQoS2V5Ym9hcmRFdmVudCogZXZlbnQpCiB7CiAgICAgY29u
c3QgUGFnZSogcGFnZSA9IGRvY3VtZW50KCktPnBhZ2UoKTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>193428</attachid>
            <date>2013-03-16 01:32:46 -0700</date>
            <delta_ts>2013-03-16 01:48:15 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-112460-20130316012840.patch</filename>
            <type>text/plain</type>
            <size>2893</size>
            <attacher name="Dominic Mazzoni">dmazzoni</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjdiOWIxZDU4NDczNjY1
NGE0N2EzYWU5MjA3ODFiY2EzMjJlZGQyNy4uMGI1MGQ2YjliOWZhYTJjZmY5NDEyZGZhMTYwNTZk
M2JlNmFlYzg3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAzLTE2ICBEb21p
bmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgorCisgICAgICAgIFN1cHBvcnQgV2lu
ZG93cyBIVE1MU2VsZWN0RWxlbWVudCBrZXlzdHJva2VzIG9uIENocm9taXVtIHdpbgorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNDYwCisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29tcGlsZSBpbiB0aGUg
d2luZG93cy1zcGVjaWZpYyB2YXJpYW50IG9mCisgICAgICAgIEhUTUxTZWxlY3RFbGVtZW50Ojpw
bGF0Zm9ybUhhbmRsZUtleWRvd25FdmVudAorICAgICAgICBvbiBDaHJvbWl1bSB3aW4sIGluIGFk
ZGl0aW9uIHRvIFBMQVRGT1JNKFdJTikuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cGk6CisgICAg
ICAgICAgICBBZGQgaHRtbC9IVE1MU2VsZWN0RWxlbWVudFdpbi5jcHAuCisgICAgICAgICogaHRt
bC9IVE1MU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAgICAgICBEb24ndCBjb21waWxlIGdlbmVy
aWMgcGxhdGZvcm1IYW5kbGVLZXlkb3duRXZlbnQgb24KKyAgICAgICAgICAgIENocm9taXVtIHdp
bi4KKyAgICAgICAgKiBodG1sL0hUTUxTZWxlY3RFbGVtZW50V2luLmNwcDoKKyAgICAgICAgICAg
IE9ubHkgY29tcGlsZSBwbGF0Zm9ybUhhbmRsZUtleWRvd25FdmVudCBvbiBXaW5kb3dzLgorICAg
ICAgICAoV2ViQ29yZSk6CisKIDIwMTMtMDMtMTIgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0Bj
aHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVzb3VyY2VTY3JpcHRGaWxl
IGRpdmVyZ2VkIHN0YXRlIHNob3VsZCBiZSBjb3JyZWN0bHkgcmVzZXQgYWZ0ZXIgZGVidWdnZXIg
cmVzZXQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkgYi9Tb3VyY2Uv
V2ViQ29yZS9XZWJDb3JlLmd5cGkKaW5kZXggNGQ1ZjJiZTNjYzc3MDgzN2ZiOTQxYzI0ZWE4NzFm
MDJhNmJjMjZmOC4uZDI3NjUzZWQ2ODQ4MjU0MDFiYzE0ZDUzYWI3OGM3ZGZiNjI0MzRkNiAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBpCisrKyBiL1NvdXJjZS9XZWJDb3Jl
L1dlYkNvcmUuZ3lwaQpAQCAtMzI5Miw2ICszMjkyLDcgQEAKICAgICAgICAgICAgICdodG1sL0hU
TUxTY3JpcHRFbGVtZW50LmgnLAogICAgICAgICAgICAgJ2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQu
Y3BwJywKICAgICAgICAgICAgICdodG1sL0hUTUxTZWxlY3RFbGVtZW50LmgnLAorICAgICAgICAg
ICAgJ2h0bWwvSFRNTFNlbGVjdEVsZW1lbnRXaW4uY3BwJywKICAgICAgICAgICAgICdodG1sL0hU
TUxTb3VyY2VFbGVtZW50LmNwcCcsCiAgICAgICAgICAgICAnaHRtbC9IVE1MU291cmNlRWxlbWVu
dC5oJywKICAgICAgICAgICAgICdodG1sL0hUTUxTcGFuRWxlbWVudC5jcHAnLApkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2Vi
Q29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAppbmRleCA0Nzg3ZjNlNmQwYjQ1ODk5MmE2
YTU5NWQyMDIzOWI5MTZmZDMyMGQyLi5hOWJmY2FlYmYyY2RmZGRkNzM0YzYxMzlkODgwOTEyOTVi
ODI4ZjIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50
LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcApAQCAt
MTA1OSw3ICsxMDU5LDcgQEAgdm9pZCBIVE1MU2VsZWN0RWxlbWVudDo6cmVzZXQoKQogICAgIHNl
dE5lZWRzVmFsaWRpdHlDaGVjaygpOwogfQogCi0jaWYgIVBMQVRGT1JNKFdJTikgfHwgT1MoV0lO
Q0UpCisjaWYgKCFQTEFURk9STShXSU4pICYmICEoUExBVEZPUk0oQ0hST01JVU0pICYmIE9TKFdJ
TkRPV1MpKSkgfHwgT1MoV0lOQ0UpCiBib29sIEhUTUxTZWxlY3RFbGVtZW50OjpwbGF0Zm9ybUhh
bmRsZUtleWRvd25FdmVudChLZXlib2FyZEV2ZW50KiBldmVudCkKIHsKICAgICBjb25zdCBQYWdl
KiBwYWdlID0gZG9jdW1lbnQoKS0+cGFnZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv
aHRtbC9IVE1MU2VsZWN0RWxlbWVudFdpbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxT
ZWxlY3RFbGVtZW50V2luLmNwcAppbmRleCBiYmRhYzNhNjc1Zjk1Yzk0NDI4M2IzODY5ODIzN2Q3
YTU1Y2YyMzNiLi42NmE1MmU2MzZkNzM1MzllOTBhY2NjMTViZWRkMGJlMGM3NmMxNGRhIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50V2luLmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50V2luLmNwcApAQCAtMjYsNiAr
MjYsOCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkhUTUxTZWxlY3RFbGVtZW50
LmgiCiAKKyNpZiAhT1MoV0lORE9XUykKKwogI2luY2x1ZGUgIkVsZW1lbnQuaCIKICNpbmNsdWRl
ICJLZXlib2FyZEV2ZW50LmgiCiAjaW5jbHVkZSAiUmVuZGVyTWVudUxpc3QuaCIKQEAgLTU1LDMg
KzU3LDUgQEAgYm9vbCBIVE1MU2VsZWN0RWxlbWVudDo6cGxhdGZvcm1IYW5kbGVLZXlkb3duRXZl
bnQoS2V5Ym9hcmRFdmVudCogZXZlbnQpCiB9CiAKIH0KKworI2VuZGlmCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>193431</attachid>
            <date>2013-03-16 01:48:18 -0700</date>
            <delta_ts>2013-03-18 09:18:14 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-112460-20130316014412.patch</filename>
            <type>text/plain</type>
            <size>2892</size>
            <attacher name="Dominic Mazzoni">dmazzoni</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjdiOWIxZDU4NDczNjY1
NGE0N2EzYWU5MjA3ODFiY2EzMjJlZGQyNy4uMGI1MGQ2YjliOWZhYTJjZmY5NDEyZGZhMTYwNTZk
M2JlNmFlYzg3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAzLTE2ICBEb21p
bmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgorCisgICAgICAgIFN1cHBvcnQgV2lu
ZG93cyBIVE1MU2VsZWN0RWxlbWVudCBrZXlzdHJva2VzIG9uIENocm9taXVtIHdpbgorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNDYwCisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29tcGlsZSBpbiB0aGUg
d2luZG93cy1zcGVjaWZpYyB2YXJpYW50IG9mCisgICAgICAgIEhUTUxTZWxlY3RFbGVtZW50Ojpw
bGF0Zm9ybUhhbmRsZUtleWRvd25FdmVudAorICAgICAgICBvbiBDaHJvbWl1bSB3aW4sIGluIGFk
ZGl0aW9uIHRvIFBMQVRGT1JNKFdJTikuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cGk6CisgICAg
ICAgICAgICBBZGQgaHRtbC9IVE1MU2VsZWN0RWxlbWVudFdpbi5jcHAuCisgICAgICAgICogaHRt
bC9IVE1MU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAgICAgICBEb24ndCBjb21waWxlIGdlbmVy
aWMgcGxhdGZvcm1IYW5kbGVLZXlkb3duRXZlbnQgb24KKyAgICAgICAgICAgIENocm9taXVtIHdp
bi4KKyAgICAgICAgKiBodG1sL0hUTUxTZWxlY3RFbGVtZW50V2luLmNwcDoKKyAgICAgICAgICAg
IE9ubHkgY29tcGlsZSBwbGF0Zm9ybUhhbmRsZUtleWRvd25FdmVudCBvbiBXaW5kb3dzLgorICAg
ICAgICAoV2ViQ29yZSk6CisKIDIwMTMtMDMtMTIgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0Bj
aHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVzb3VyY2VTY3JpcHRGaWxl
IGRpdmVyZ2VkIHN0YXRlIHNob3VsZCBiZSBjb3JyZWN0bHkgcmVzZXQgYWZ0ZXIgZGVidWdnZXIg
cmVzZXQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkgYi9Tb3VyY2Uv
V2ViQ29yZS9XZWJDb3JlLmd5cGkKaW5kZXggNGQ1ZjJiZTNjYzc3MDgzN2ZiOTQxYzI0ZWE4NzFm
MDJhNmJjMjZmOC4uZDI3NjUzZWQ2ODQ4MjU0MDFiYzE0ZDUzYWI3OGM3ZGZiNjI0MzRkNiAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBpCisrKyBiL1NvdXJjZS9XZWJDb3Jl
L1dlYkNvcmUuZ3lwaQpAQCAtMzI5Miw2ICszMjkyLDcgQEAKICAgICAgICAgICAgICdodG1sL0hU
TUxTY3JpcHRFbGVtZW50LmgnLAogICAgICAgICAgICAgJ2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQu
Y3BwJywKICAgICAgICAgICAgICdodG1sL0hUTUxTZWxlY3RFbGVtZW50LmgnLAorICAgICAgICAg
ICAgJ2h0bWwvSFRNTFNlbGVjdEVsZW1lbnRXaW4uY3BwJywKICAgICAgICAgICAgICdodG1sL0hU
TUxTb3VyY2VFbGVtZW50LmNwcCcsCiAgICAgICAgICAgICAnaHRtbC9IVE1MU291cmNlRWxlbWVu
dC5oJywKICAgICAgICAgICAgICdodG1sL0hUTUxTcGFuRWxlbWVudC5jcHAnLApkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2Vi
Q29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAppbmRleCA0Nzg3ZjNlNmQwYjQ1ODk5MmE2
YTU5NWQyMDIzOWI5MTZmZDMyMGQyLi5hOWJmY2FlYmYyY2RmZGRkNzM0YzYxMzlkODgwOTEyOTVi
ODI4ZjIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50
LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcApAQCAt
MTA1OSw3ICsxMDU5LDcgQEAgdm9pZCBIVE1MU2VsZWN0RWxlbWVudDo6cmVzZXQoKQogICAgIHNl
dE5lZWRzVmFsaWRpdHlDaGVjaygpOwogfQogCi0jaWYgIVBMQVRGT1JNKFdJTikgfHwgT1MoV0lO
Q0UpCisjaWYgKCFQTEFURk9STShXSU4pICYmICEoUExBVEZPUk0oQ0hST01JVU0pICYmIE9TKFdJ
TkRPV1MpKSkgfHwgT1MoV0lOQ0UpCiBib29sIEhUTUxTZWxlY3RFbGVtZW50OjpwbGF0Zm9ybUhh
bmRsZUtleWRvd25FdmVudChLZXlib2FyZEV2ZW50KiBldmVudCkKIHsKICAgICBjb25zdCBQYWdl
KiBwYWdlID0gZG9jdW1lbnQoKS0+cGFnZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv
aHRtbC9IVE1MU2VsZWN0RWxlbWVudFdpbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxT
ZWxlY3RFbGVtZW50V2luLmNwcAppbmRleCBiYmRhYzNhNjc1Zjk1Yzk0NDI4M2IzODY5ODIzN2Q3
YTU1Y2YyMzNiLi43NWUyZDg0Nzk1YjUzNjI1N2FjNGNkMjA4Y2M4ODIwZDBlYjVlYzBlIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50V2luLmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50V2luLmNwcApAQCAtMjYsNiAr
MjYsOCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkhUTUxTZWxlY3RFbGVtZW50
LmgiCiAKKyNpZiBPUyhXSU5ET1dTKQorCiAjaW5jbHVkZSAiRWxlbWVudC5oIgogI2luY2x1ZGUg
IktleWJvYXJkRXZlbnQuaCIKICNpbmNsdWRlICJSZW5kZXJNZW51TGlzdC5oIgpAQCAtNTUsMyAr
NTcsNSBAQCBib29sIEhUTUxTZWxlY3RFbGVtZW50OjpwbGF0Zm9ybUhhbmRsZUtleWRvd25FdmVu
dChLZXlib2FyZEV2ZW50KiBldmVudCkKIH0KIAogfQorCisjZW5kaWYK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>193579</attachid>
            <date>2013-03-18 09:18:22 -0700</date>
            <delta_ts>2013-03-18 16:13:16 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-112460-20130318091414.patch</filename>
            <type>text/plain</type>
            <size>3173</size>
            <attacher name="Dominic Mazzoni">dmazzoni</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTZkNGM4ZDM3N2Q0MGU1
MzVmNzQ2MWYwYmQwZWM5YjZjYjFjMGM5MS4uNzM3ODYwZmUwZDdmZGJlNzQ3MDMzMmVhYjE4Y2Rl
ZmU4MDdlZDZkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAzLTE4ICBEb21p
bmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgorCisgICAgICAgIFN1cHBvcnQgV2lu
ZG93cyBIVE1MU2VsZWN0RWxlbWVudCBrZXlzdHJva2VzIG9uIENocm9taXVtIHdpbgorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyNDYwCisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29tcGlsZSBpbiB0aGUg
d2luZG93cy1zcGVjaWZpYyB2YXJpYW50IG9mCisgICAgICAgIEhUTUxTZWxlY3RFbGVtZW50Ojpw
bGF0Zm9ybUhhbmRsZUtleWRvd25FdmVudAorICAgICAgICBvbiBDaHJvbWl1bSB3aW4sIGluIGFk
ZGl0aW9uIHRvIFBMQVRGT1JNKFdJTikuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cGk6CisgICAg
ICAgICAgICBBZGQgaHRtbC9IVE1MU2VsZWN0RWxlbWVudFdpbi5jcHAuCisgICAgICAgICogaHRt
bC9IVE1MU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAgICAgICBEb24ndCBjb21waWxlIGdlbmVy
aWMgcGxhdGZvcm1IYW5kbGVLZXlkb3duRXZlbnQgb24KKyAgICAgICAgICAgIENocm9taXVtIHdp
bi4KKyAgICAgICAgKiBodG1sL0hUTUxTZWxlY3RFbGVtZW50V2luLmNwcDoKKyAgICAgICAgICAg
IE9ubHkgY29tcGlsZSBwbGF0Zm9ybUhhbmRsZUtleWRvd25FdmVudCBvbiBXaW5kb3dzLgorICAg
ICAgICAgICAgRml4IGNvbXBpbGUgZXJyb3IgaW4gYXNzZXJ0aW9uLgorICAgICAgICAoV2ViQ29y
ZSk6CisKIDIwMTMtMDMtMTUgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwu
Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNDU4MDIuCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3Jl
Lmd5cGkKaW5kZXggOWUwOGE5M2I5NWM5NzUyYzQzYmM0OTU3M2I5NTcxMTFjMTM5ODFiZS4uYmVj
YmFjODIwNjI2ZDYwOTg5YTJmYmNiY2E2N2VjNGRiOTY3NGEzOCAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvV2ViQ29yZS5neXBpCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwaQpA
QCAtMzMwNiw2ICszMzA2LDcgQEAKICAgICAgICAgICAgICdodG1sL0hUTUxTY3JpcHRFbGVtZW50
LmgnLAogICAgICAgICAgICAgJ2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwJywKICAgICAgICAg
ICAgICdodG1sL0hUTUxTZWxlY3RFbGVtZW50LmgnLAorICAgICAgICAgICAgJ2h0bWwvSFRNTFNl
bGVjdEVsZW1lbnRXaW4uY3BwJywKICAgICAgICAgICAgICdodG1sL0hUTUxTb3VyY2VFbGVtZW50
LmNwcCcsCiAgICAgICAgICAgICAnaHRtbC9IVE1MU291cmNlRWxlbWVudC5oJywKICAgICAgICAg
ICAgICdodG1sL0hUTUxTcGFuRWxlbWVudC5jcHAnLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv
cmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxT
ZWxlY3RFbGVtZW50LmNwcAppbmRleCA0Nzg3ZjNlNmQwYjQ1ODk5MmE2YTU5NWQyMDIzOWI5MTZm
ZDMyMGQyLi5hOWJmY2FlYmYyY2RmZGRkNzM0YzYxMzlkODgwOTEyOTViODI4ZjIwIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcApAQCAtMTA1OSw3ICsxMDU5LDcg
QEAgdm9pZCBIVE1MU2VsZWN0RWxlbWVudDo6cmVzZXQoKQogICAgIHNldE5lZWRzVmFsaWRpdHlD
aGVjaygpOwogfQogCi0jaWYgIVBMQVRGT1JNKFdJTikgfHwgT1MoV0lOQ0UpCisjaWYgKCFQTEFU
Rk9STShXSU4pICYmICEoUExBVEZPUk0oQ0hST01JVU0pICYmIE9TKFdJTkRPV1MpKSkgfHwgT1Mo
V0lOQ0UpCiBib29sIEhUTUxTZWxlY3RFbGVtZW50OjpwbGF0Zm9ybUhhbmRsZUtleWRvd25FdmVu
dChLZXlib2FyZEV2ZW50KiBldmVudCkKIHsKICAgICBjb25zdCBQYWdlKiBwYWdlID0gZG9jdW1l
bnQoKS0+cGFnZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0
RWxlbWVudFdpbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50V2lu
LmNwcAppbmRleCBiYmRhYzNhNjc1Zjk1Yzk0NDI4M2IzODY5ODIzN2Q3YTU1Y2YyMzNiLi4yMDFj
NmE1ZDEwNzk5YTdjOTc5MzhhNTM1OTBhYzNjZTFkMTljZTIyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50V2luLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y
ZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50V2luLmNwcApAQCAtMjYsNiArMjYsOCBAQAogI2luY2x1
ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkhUTUxTZWxlY3RFbGVtZW50LmgiCiAKKyNpZiBPUyhX
SU5ET1dTKQorCiAjaW5jbHVkZSAiRWxlbWVudC5oIgogI2luY2x1ZGUgIktleWJvYXJkRXZlbnQu
aCIKICNpbmNsdWRlICJSZW5kZXJNZW51TGlzdC5oIgpAQCAtNDgsMTAgKzUwLDEyIEBAIGJvb2wg
SFRNTFNlbGVjdEVsZW1lbnQ6OnBsYXRmb3JtSGFuZGxlS2V5ZG93bkV2ZW50KEtleWJvYXJkRXZl
bnQqIGV2ZW50KQogCiAgICAgaW50IGluZGV4ID0gc2VsZWN0ZWRJbmRleCgpOwogICAgIEFTU0VS
VChpbmRleCA+PSAwKTsKLSAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihpbmRl
eCA8IGxpc3RJdGVtcygpLnNpemUoKSk7CisgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElD
QVRJT04oaW5kZXggPCBzdGF0aWNfY2FzdDxpbnQ+KGxpc3RJdGVtcygpLnNpemUoKSkpOwogICAg
IHNldFNlbGVjdGVkSW5kZXgoaW5kZXgpOwogICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgp
OwogICAgIHJldHVybiB0cnVlOwogfQogCiB9CisKKyNlbmRpZgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>