112456 2013-03-15 11:28:33 -0700 Style Checker false pass 2013-12-03 04:28:49 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kpiascik webkit-unassigned commit-queue glenn kpiascik ossy oldest_to_newest 856132 0 kpiascik 2013-03-15 11:28:33 -0700 When the style checker ran on this patch https://bugs.webkit.org/attachment.cgi?id=193319&action=review it passed both locally with webkit-patch and remotely on EWS's style checker. 856137 1 kpiascik 2013-03-15 11:29:44 -0700 (In reply to comment #0) > When the style checker ran on this patch https://bugs.webkit.org/attachment.cgi?id=193319&action=review it passed both locally with webkit-patch and remotely on EWS's style checker. This patch has "No new tests (OOPS!)." so I would expect it to fail style. 954910 2 218043 gbalogh.u-szeged 2013-11-29 01:58:24 -0800 Created attachment 218043 patch I just correct the regular expression for "No new tests (OOPS!)." 954914 3 218043 ossy 2013-11-29 02:12:18 -0800 Comment on attachment 218043 patch Please update its unittest and the comment above too. 954947 4 218054 gbalogh.u-szeged 2013-11-29 05:25:59 -0800 Created attachment 218054 patch fix 954949 5 218054 commit-queue 2013-11-29 05:38:08 -0800 Comment on attachment 218054 patch fix Rejecting attachment 218054 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 218054, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/39318135 954952 6 218054 ossy 2013-11-29 05:42:49 -0800 Comment on attachment 218054 patch fix View in context: https://bugs.webkit.org/attachment.cgi?id=218054&action=review > Tools/ChangeLog:10 > + simple regex fix to check "No new tests (OOPS!)." Hehe, this comment killed the CQ. :) 954959 7 218056 gbalogh.u-szeged 2013-11-29 06:15:27 -0800 Created attachment 218056 patch fix HOPPA! == OOPS! 955856 8 218056 ossy 2013-12-03 04:27:20 -0800 Comment on attachment 218056 patch fix View in context: https://bugs.webkit.org/attachment.cgi?id=218056&action=review > Tools/ChangeLog:10 > + simple regex fix to check "No new tests (HOPPA!)." We shouldn't write "hoppá", otherwise LGTM. 955857 9 ossy 2013-12-03 04:28:38 -0800 Landed in http://trac.webkit.org/changeset/159997 218043 2013-11-29 01:58:24 -0800 2013-11-29 05:25:59 -0800 patch f2615.diff text/plain 1397 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZWYw MDMyLi4xZTQyZTlmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMTEtMjkgIEdlcmdvIEJhbG9naCAgPGdlcnl4 eXpAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFN0eWxlIENoZWNrZXIgZmFsc2UgcGFzcy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjQ1Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2cucHk6CisgICAgICAgIChDaGFuZ2VM b2dDaGVja2VyLmNoZWNrX2VudHJ5KToKKyAgICAgICAgc2ltcGxlIHJlZ2V4IGZpeCB0byBjaGVj ayAiTm8gbmV3IHRlc3RzIChPT1BTISkuIgorCiAyMDEzLTExLTI4ICBDb21taXQgUXVldWUgIDxj b21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMTU5ODM5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jaGFuZ2Vsb2cucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NoYW5nZWxvZy5weQppbmRleCA2MWRhZGI0Li42NmZlMTFmIDEwMDY0NAotLS0gYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZy5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZy5weQpAQCAtNjksNyArNjks NyBAQCBjbGFzcyBDaGFuZ2VMb2dDaGVja2VyKG9iamVjdCk6CiAgICAgICAgIGxpbmVfbm8gPSBm aXJzdF9saW5lX2NoZWNrZWQgLSAxCiAgICAgICAgIGZvciBsaW5lIGluIGVudHJ5X2xpbmVzOgog ICAgICAgICAgICAgbGluZV9ubyA9IGxpbmVfbm8gKyAxCi0gICAgICAgICAgICBpZiBtYXRjaCgn XHMqTm8gbmV3IHRlc3RzLiBcKE9PUFMhXCkkJywgbGluZSk6CisgICAgICAgICAgICBpZiBtYXRj aCgnXHMqTm8gbmV3IHRlc3RzIFwoT09QUyFcKVwuJCcsIGxpbmUpOgogICAgICAgICAgICAgICAg IHNlbGYuaGFuZGxlX3N0eWxlX2Vycm9yKGxpbmVfbm8sCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgImNoYW5nZWxvZy9ub25ld3Rlc3RzIiwgNSwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiWW91IHNob3VsZCByZW1vdmUgdGhlICdObyBu ZXcgdGVzdHMnIGFuZCBlaXRoZXIgYWRkIGFuZCBsaXN0IHRlc3RzLCBvciBleHBsYWluIHdoeSBu byBuZXcgdGVzdHMgd2VyZSBwb3NzaWJsZS4iKQo= 218054 2013-11-29 05:25:59 -0800 2013-11-29 06:15:27 -0800 patch fix f2615.diff text/plain 2633 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZWYw MDMyLi5iMDUwNWRhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMTEtMjkgIEdlcmdvIEJhbG9naCAgPGdlcnl4 eXpAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFN0eWxlIENoZWNrZXIgZmFsc2UgcGFzcy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjQ1Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2cucHk6CisgICAgICAgIChDaGFuZ2VM b2dDaGVja2VyLmNoZWNrX2VudHJ5KToKKyAgICAgICAgc2ltcGxlIHJlZ2V4IGZpeCB0byBjaGVj ayAiTm8gbmV3IHRlc3RzIChPT1BTISkuIgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcnMvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5OgorICAgICAgICAoQ2hhbmdlTG9nQ2hl Y2tlclRlc3QudGVzdF9ub19uZXdfdGVzdHMpOgorCiAyMDEzLTExLTI4ICBDb21taXQgUXVldWUg IDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n IG91dCByMTU5ODM5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jaGFuZ2Vsb2cucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NoYW5nZWxvZy5weQppbmRleCA2MWRhZGI0Li5kY2U4NWFmIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZy5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZy5weQpAQCAtNjUsMTEg KzY1LDExIEBAIGNsYXNzIENoYW5nZUxvZ0NoZWNrZXIob2JqZWN0KToKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICJjaGFuZ2Vsb2cvZmlsZWNoYW5nZWRlc2NyaXB0aW9ud2hp dGVzcGFjZSIsIDUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiTmVlZCB3 aGl0ZXNwYWNlIGJldHdlZW4gY29sb24gYW5kIGRlc2NyaXB0aW9uIikKIAotICAgICAgICAjIGNo ZWNrIGZvciBhIGxpbmdlcmluZyAiTm8gbmV3IHRlc3RzLiAoT09QUyEpIiBsZWZ0IG92ZXIgZnJv bSBwcmVwYXJlLWNoYW5nZUxvZy4KKyAgICAgICAgIyBjaGVjayBmb3IgYSBsaW5nZXJpbmcgIk5v IG5ldyB0ZXN0cyAoT09QUyEpLiIgbGVmdCBvdmVyIGZyb20gcHJlcGFyZS1jaGFuZ2VMb2cuCiAg ICAgICAgIGxpbmVfbm8gPSBmaXJzdF9saW5lX2NoZWNrZWQgLSAxCiAgICAgICAgIGZvciBsaW5l IGluIGVudHJ5X2xpbmVzOgogICAgICAgICAgICAgbGluZV9ubyA9IGxpbmVfbm8gKyAxCi0gICAg ICAgICAgICBpZiBtYXRjaCgnXHMqTm8gbmV3IHRlc3RzLiBcKE9PUFMhXCkkJywgbGluZSk6Cisg ICAgICAgICAgICBpZiBtYXRjaCgnXHMqTm8gbmV3IHRlc3RzIFwoT09QUyFcKVwuJCcsIGxpbmUp OgogICAgICAgICAgICAgICAgIHNlbGYuaGFuZGxlX3N0eWxlX2Vycm9yKGxpbmVfbm8sCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImNoYW5nZWxvZy9ub25ld3Rlc3Rz IiwgNSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiWW91IHNob3Vs ZCByZW1vdmUgdGhlICdObyBuZXcgdGVzdHMnIGFuZCBlaXRoZXIgYWRkIGFuZCBsaXN0IHRlc3Rz LCBvciBleHBsYWluIHdoeSBubyBuZXcgdGVzdHMgd2VyZSBwb3NzaWJsZS4iKQpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2dfdW5pdHRl c3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZ191 bml0dGVzdC5weQppbmRleCAwZWMwZWMyLi4yNjkwNGJiIDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZ191bml0dGVzdC5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZ191bml0dGVzdC5w eQpAQCAtMTI1LDcgKzEyNSw3IEBAIGNsYXNzIENoYW5nZUxvZ0NoZWNrZXJUZXN0KHVuaXR0ZXN0 LlRlc3RDYXNlKToKICAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgICAgICAgRXhhbXBsZUJ1 Z1xuJwogICAgICAgICAgICAgICAgICAgICAgICAgICAnICAgICAgICBodHRwOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM0NVxuJwogICAgICAgICAgICAgICAgICAgICAgICAg ICAnXG4nCi0gICAgICAgICAgICAgICAgICAgICAgICAgICcgICAgICAgIE5vIG5ldyB0ZXN0cy4g KE9PUFMhKVxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAnICAgICAgICBObyBuZXcgdGVz dHMgKE9PUFMhKS5cbicKICAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgICAgICAgKiAgU291 cmNlL1Rvb2xzL3JhbmRvbS1zY3JpcHQucHk6IEZpeGVkJykKIAogICAgIGRlZiB0ZXN0X25vX2Vy cm9yKHNlbGYpOgo= 218056 2013-11-29 06:15:27 -0800 2013-12-03 04:28:49 -0800 patch fix f2615.diff text/plain 2634 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZWYw MDMyLi5iMDUwNWRhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMTEtMjkgIEdlcmdvIEJhbG9naCAgPGdlcnl4 eXpAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFN0eWxlIENoZWNrZXIgZmFsc2UgcGFzcy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjQ1Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2cucHk6CisgICAgICAgIChDaGFuZ2VM b2dDaGVja2VyLmNoZWNrX2VudHJ5KToKKyAgICAgICAgc2ltcGxlIHJlZ2V4IGZpeCB0byBjaGVj ayAiTm8gbmV3IHRlc3RzIChIT1BQQSEpLiIKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NoYW5nZWxvZ191bml0dGVzdC5weToKKyAgICAgICAgKENoYW5nZUxvZ0No ZWNrZXJUZXN0LnRlc3Rfbm9fbmV3X3Rlc3RzKToKKwogMjAxMy0xMS0yOCAgQ29tbWl0IFF1ZXVl ICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGlu ZyBvdXQgcjE1OTgzOS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY2hhbmdlbG9nLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jaGFuZ2Vsb2cucHkKaW5kZXggNjFkYWRiNC4uZGNlODVhZiAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2cucHkKKysrIGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2cucHkKQEAgLTY1LDEx ICs2NSwxMSBAQCBjbGFzcyBDaGFuZ2VMb2dDaGVja2VyKG9iamVjdCk6CiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiY2hhbmdlbG9nL2ZpbGVjaGFuZ2VkZXNjcmlwdGlvbndo aXRlc3BhY2UiLCA1LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIk5lZWQg d2hpdGVzcGFjZSBiZXR3ZWVuIGNvbG9uIGFuZCBkZXNjcmlwdGlvbiIpCiAKLSAgICAgICAgIyBj aGVjayBmb3IgYSBsaW5nZXJpbmcgIk5vIG5ldyB0ZXN0cy4gKE9PUFMhKSIgbGVmdCBvdmVyIGZy b20gcHJlcGFyZS1jaGFuZ2VMb2cuCisgICAgICAgICMgY2hlY2sgZm9yIGEgbGluZ2VyaW5nICJO byBuZXcgdGVzdHMgKE9PUFMhKS4iIGxlZnQgb3ZlciBmcm9tIHByZXBhcmUtY2hhbmdlTG9nLgog ICAgICAgICBsaW5lX25vID0gZmlyc3RfbGluZV9jaGVja2VkIC0gMQogICAgICAgICBmb3IgbGlu ZSBpbiBlbnRyeV9saW5lczoKICAgICAgICAgICAgIGxpbmVfbm8gPSBsaW5lX25vICsgMQotICAg ICAgICAgICAgaWYgbWF0Y2goJ1xzKk5vIG5ldyB0ZXN0cy4gXChPT1BTIVwpJCcsIGxpbmUpOgor ICAgICAgICAgICAgaWYgbWF0Y2goJ1xzKk5vIG5ldyB0ZXN0cyBcKE9PUFMhXClcLiQnLCBsaW5l KToKICAgICAgICAgICAgICAgICBzZWxmLmhhbmRsZV9zdHlsZV9lcnJvcihsaW5lX25vLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJjaGFuZ2Vsb2cvbm9uZXd0ZXN0 cyIsIDUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIllvdSBzaG91 bGQgcmVtb3ZlIHRoZSAnTm8gbmV3IHRlc3RzJyBhbmQgZWl0aGVyIGFkZCBhbmQgbGlzdCB0ZXN0 cywgb3IgZXhwbGFpbiB3aHkgbm8gbmV3IHRlc3RzIHdlcmUgcG9zc2libGUuIikKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY2hhbmdlbG9nX3VuaXR0 ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2df dW5pdHRlc3QucHkKaW5kZXggMGVjMGVjMi4uMjY5MDRiYiAxMDA2NDQKLS0tIGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2dfdW5pdHRlc3QucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2dfdW5pdHRlc3Qu cHkKQEAgLTEyNSw3ICsxMjUsNyBAQCBjbGFzcyBDaGFuZ2VMb2dDaGVja2VyVGVzdCh1bml0dGVz dC5UZXN0Q2FzZSk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAgICAgIEV4YW1wbGVC dWdcbicKICAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgICAgICAgaHR0cDovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNDVcbicKICAgICAgICAgICAgICAgICAgICAgICAg ICAgJ1xuJwotICAgICAgICAgICAgICAgICAgICAgICAgICAnICAgICAgICBObyBuZXcgdGVzdHMu IChPT1BTISlcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgICAgICAgTm8gbmV3IHRl c3RzIChPT1BTISkuXG4nCiAgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAgICAgICogIFNv dXJjZS9Ub29scy9yYW5kb20tc2NyaXB0LnB5OiBGaXhlZCcpCiAKICAgICBkZWYgdGVzdF9ub19l cnJvcihzZWxmKToK