112429 2013-03-15 04:36:41 -0700 Web Inspector: Timeline. Clear button doesn't clean Memory graph in Overview pane. 2013-06-05 05:37:00 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 116924 1 loislo rtakacs apavlov commit-queue keishi loislo pfeldman pmuellr rtakacs vsevik web-inspector-bugs yurys oldest_to_newest 855891 0 loislo 2013-03-15 04:36:41 -0700 EOM 897181 1 203767 rtakacs 2013-06-05 01:21:10 -0700 Created attachment 203767 patch With this patch we can remove the memory graph from the canvas. 897190 2 203767 noam 2013-06-05 01:44:17 -0700 Comment on attachment 203767 patch View in context: https://bugs.webkit.org/attachment.cgi?id=203767&action=review > Source/WebCore/ChangeLog:8 > + There is too early return from TimelineMemoryOverview.update() when There is an early return > Source/WebCore/ChangeLog:9 > + record array is empty. Thats why if you clik onto the clear button, click > Source/WebCore/ChangeLog:13 > + I've moved this "return condition" after the canvas size definition > + because we need to know the canvas size for refreshing. > + I've overridden TimelineOverviewBase's reset function to clear I've moved -> Moved I've overridden -> Overridden 897225 3 203783 rtakacs 2013-06-05 03:19:48 -0700 Created attachment 203783 patch 897315 4 203783 commit-queue 2013-06-05 05:36:57 -0700 Comment on attachment 203783 patch Clearing flags on attachment: 203783 Committed r151217: <http://trac.webkit.org/changeset/151217> 897316 5 commit-queue 2013-06-05 05:37:00 -0700 All reviewed patches have been landed. Closing bug. 203767 2013-06-05 01:21:10 -0700 2013-06-05 03:19:48 -0700 patch graph_cleaner.diff text/plain 2239 rtakacs ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZThiZTc3Li5iN2FiOWJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMDYtMDUgIFJvbGFuZCBUYWthY3MgIDxydGFrYWNzQGluZi51LXN6ZWdlZC5odT4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBDbGVhciBidXR0b24gZG9lc24ndCBjbGVhciBNZW1v cnkgZ3JhcGggaW4gT3ZlcnZpZXcgcGFuZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMjQyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZXJlIGlzIHRvbyBlYXJseSByZXR1cm4gZnJvbSBUaW1lbGlu ZU1lbW9yeU92ZXJ2aWV3LnVwZGF0ZSgpIHdoZW4KKyAgICAgICAgcmVjb3JkIGFycmF5IGlzIGVt cHR5LiBUaGF0cyB3aHkgaWYgeW91IGNsaWsgb250byB0aGUgY2xlYXIgYnV0dG9uLAorICAgICAg ICB0aGUgY2FudmFzIHdvbid0IGJlIHVwZGF0ZWQuCisgICAgICAgIEkndmUgbW92ZWQgdGhpcyAi cmV0dXJuIGNvbmRpdGlvbiIgYWZ0ZXIgdGhlIGNhbnZhcyBzaXplIGRlZmluaXRpb24KKyAgICAg ICAgYmVjYXVzZSB3ZSBuZWVkIHRvIGtub3cgdGhlIGNhbnZhcyBzaXplIGZvciByZWZyZXNoaW5n LgorICAgICAgICBJJ3ZlIG92ZXJyaWRkZW4gVGltZWxpbmVPdmVydmlld0Jhc2UncyByZXNldCBm dW5jdGlvbiB0byBjbGVhcgorICAgICAgICBIZWFwU2l6ZUxhYmVscycgY29udGVudC4KKyAgICAg ICAgCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZU92ZXJ2aWV3UGFuZS5q czoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZU1lbW9yeU92ZXJ2aWV3LnByb3RvdHlw ZS5yZXNldCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVNZW1vcnlPdmVydmlldy5w cm90b3R5cGUudXBkYXRlKToKKwogMjAxMy0wNi0wNCAgUGV0ZXIgR2FsICA8Z2FscGV0ZXJAaW5m LnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFtjdXJsXSBIZWFkZXJzIHNob3VsZCBiZSBwYXJzZWQg YXMgdXRmOCBpZiBwb3NzaWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9UaW1lbGluZU92ZXJ2aWV3UGFuZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvVGltZWxpbmVPdmVydmlld1BhbmUuanMKaW5kZXggNGYzN2FmOS4uNDA5 NmI0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1l bGluZU92ZXJ2aWV3UGFuZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1RpbWVsaW5lT3ZlcnZpZXdQYW5lLmpzCkBAIC00MzYsMTYgKzQzNiwyMiBAQCBXZWJJbnNw ZWN0b3IuVGltZWxpbmVNZW1vcnlPdmVydmlldyA9IGZ1bmN0aW9uKG1vZGVsKQogfQogCiBXZWJJ bnNwZWN0b3IuVGltZWxpbmVNZW1vcnlPdmVydmlldy5wcm90b3R5cGUgPSB7Ci0gICAgdXBkYXRl OiBmdW5jdGlvbigpCisgICAgcmVzZXQ6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIHZhciBy ZWNvcmRzID0gdGhpcy5fbW9kZWwucmVjb3JkczsKLSAgICAgICAgaWYgKCFyZWNvcmRzLmxlbmd0 aCkKLSAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgdGhpcy5fbWF4SGVhcFNpemVMYWJlbC50 ZXh0Q29udGVudCA9ICIiOworICAgICAgICB0aGlzLl9taW5IZWFwU2l6ZUxhYmVsLnRleHRDb250 ZW50ID0gIiI7CisgICAgfSwKIAorICAgIHVwZGF0ZTogZnVuY3Rpb24oKQorICAgIHsKICAgICAg ICAgY29uc3QgeVBhZGRpbmcgPSA1OwogICAgICAgICB0aGlzLl9jYW52YXMud2lkdGggPSB0aGlz LmVsZW1lbnQuY2xpZW50V2lkdGg7CiAgICAgICAgIHRoaXMuX2NhbnZhcy5oZWlnaHQgPSB0aGlz LmVsZW1lbnQuY2xpZW50SGVpZ2h0IC0geVBhZGRpbmc7CiAKKyAgICAgICAgdmFyIHJlY29yZHMg PSB0aGlzLl9tb2RlbC5yZWNvcmRzOworICAgICAgICBpZiAoIXJlY29yZHMubGVuZ3RoKQorICAg ICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIGNvbnN0IGxvd2VyT2Zmc2V0ID0gMzsKICAgICAg ICAgdmFyIG1heFVzZWRIZWFwU2l6ZSA9IDA7CiAgICAgICAgIHZhciBtaW5Vc2VkSGVhcFNpemUg PSAxMDAwMDAwMDAwMDA7Cg== 203783 2013-06-05 03:19:48 -0700 2013-06-05 05:36:57 -0700 patch graph_cleaner.diff text/plain 2241 rtakacs ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZGNlOWU3Li5mNjU5NDU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMDYtMDUgIFJvbGFuZCBUYWthY3MgIDxydGFrYWNzQGluZi51LXN6ZWdlZC5odT4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBDbGVhciBidXR0b24gZG9lc24ndCBjbGVhbiBNZW1v cnkgZ3JhcGggaW4gT3ZlcnZpZXcgcGFuZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMjQyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5vYW0gUm9z ZW50aGFsLgorCisgICAgICAgIFRoZXJlIGlzIGFuIGVhcmx5IHJldHVybiBmcm9tIFRpbWVsaW5l TWVtb3J5T3ZlcnZpZXcudXBkYXRlKCkgd2hlbgorICAgICAgICByZWNvcmQgYXJyYXkgaXMgZW1w dHkuIFRoYXRzIHdoeSBpZiB5b3UgY2xpY2sgb250byB0aGUgY2xlYXIgYnV0dG9uLAorICAgICAg ICB0aGUgY2FudmFzIHdvbid0IGJlIHVwZGF0ZWQuCisgICAgICAgIE1vdmVkIHRoaXMgInJldHVy biBjb25kaXRpb24iIGFmdGVyIHRoZSBjYW52YXMgc2l6ZSBkZWZpbml0aW9uCisgICAgICAgIGJl Y2F1c2Ugd2UgbmVlZCB0byBrbm93IHRoZSBjYW52YXMgc2l6ZSBmb3IgcmVmcmVzaGluZy4KKyAg ICAgICAgT3ZlcnJpZGRlbiBUaW1lbGluZU92ZXJ2aWV3QmFzZSdzIHJlc2V0IGZ1bmN0aW9uIHRv IGNsZWFyCisgICAgICAgIEhlYXBTaXplTGFiZWxzJyBjb250ZW50LgorCisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZU92ZXJ2aWV3UGFuZS5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5UaW1lbGluZU1lbW9yeU92ZXJ2aWV3LnByb3RvdHlwZS5yZXNldCk6CisgICAgICAg IChXZWJJbnNwZWN0b3IuVGltZWxpbmVNZW1vcnlPdmVydmlldy5wcm90b3R5cGUudXBkYXRlKToK KwogMjAxMy0wNi0wNSAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQGRpZ2lh LmNvbT4KIAogICAgICAgICBbUXRdIEZvbnQ6OnNob3VsZFVzZVNtb290aGluZygpIGhhcyBmYWtl IGRlcGVuZGVuY3kgb24gUXQgNS4xCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RpbWVsaW5lT3ZlcnZpZXdQYW5lLmpzIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZU92ZXJ2aWV3UGFuZS5qcwppbmRleCA0ZjM3YWY5Li40 MDk2YjRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Rp bWVsaW5lT3ZlcnZpZXdQYW5lLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvVGltZWxpbmVPdmVydmlld1BhbmUuanMKQEAgLTQzNiwxNiArNDM2LDIyIEBAIFdlYklu c3BlY3Rvci5UaW1lbGluZU1lbW9yeU92ZXJ2aWV3ID0gZnVuY3Rpb24obW9kZWwpCiB9CiAKIFdl Ykluc3BlY3Rvci5UaW1lbGluZU1lbW9yeU92ZXJ2aWV3LnByb3RvdHlwZSA9IHsKLSAgICB1cGRh dGU6IGZ1bmN0aW9uKCkKKyAgICByZXNldDogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgdmFy IHJlY29yZHMgPSB0aGlzLl9tb2RlbC5yZWNvcmRzOwotICAgICAgICBpZiAoIXJlY29yZHMubGVu Z3RoKQotICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB0aGlzLl9tYXhIZWFwU2l6ZUxhYmVs LnRleHRDb250ZW50ID0gIiI7CisgICAgICAgIHRoaXMuX21pbkhlYXBTaXplTGFiZWwudGV4dENv bnRlbnQgPSAiIjsKKyAgICB9LAogCisgICAgdXBkYXRlOiBmdW5jdGlvbigpCisgICAgewogICAg ICAgICBjb25zdCB5UGFkZGluZyA9IDU7CiAgICAgICAgIHRoaXMuX2NhbnZhcy53aWR0aCA9IHRo aXMuZWxlbWVudC5jbGllbnRXaWR0aDsKICAgICAgICAgdGhpcy5fY2FudmFzLmhlaWdodCA9IHRo aXMuZWxlbWVudC5jbGllbnRIZWlnaHQgLSB5UGFkZGluZzsKIAorICAgICAgICB2YXIgcmVjb3Jk cyA9IHRoaXMuX21vZGVsLnJlY29yZHM7CisgICAgICAgIGlmICghcmVjb3Jkcy5sZW5ndGgpCisg ICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgY29uc3QgbG93ZXJPZmZzZXQgPSAzOwogICAg ICAgICB2YXIgbWF4VXNlZEhlYXBTaXplID0gMDsKICAgICAgICAgdmFyIG1pblVzZWRIZWFwU2l6 ZSA9IDEwMDAwMDAwMDAwMDsK