112420 2013-03-15 02:18:59 -0700 Call release() when a RefPtr is returned. 2013-03-15 03:24:51 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ljaehun.lim webkit-unassigned alancutter esprehn+autocc macpherson menard ojan.autocc webkit.review.bot oldest_to_newest 855817 0 ljaehun.lim 2013-03-15 02:18:59 -0700 release() should be called on a RefPtr to convert it to a PassRefPtr. 855825 1 193262 ljaehun.lim 2013-03-15 02:31:00 -0700 Created attachment 193262 Patch 855833 2 alancutter 2013-03-15 02:43:21 -0700 I believe this happens implicitly: http://trac.webkit.org/browser/trunk/Source/WTF/wtf/PassRefPtr.h#L96 855849 3 193262 eric 2013-03-15 03:18:15 -0700 Comment on attachment 193262 Patch Looks right. 855855 4 193262 webkit.review.bot 2013-03-15 03:24:47 -0700 Comment on attachment 193262 Patch Clearing flags on attachment: 193262 Committed r145892: <http://trac.webkit.org/changeset/145892> 855856 5 webkit.review.bot 2013-03-15 03:24:51 -0700 All reviewed patches have been landed. Closing bug. 193262 2013-03-15 02:31:00 -0700 2013-03-15 03:24:47 -0700 Patch bug-112420-20130315182654.patch text/plain 1598 ljaehun.lim U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1ODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjFmY2E4NjEzOGJkZTA3 NzA2MGNlYmI3NDU3NGYxM2NkNzFkZTUyMy4uYjZkOGEzNGQ2NGE0Njg1MWEyODc4MjQwNjhmMDY1 NWM2ZjQzMTJlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTE1ICBKYWVo dW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgQ2FsbCByZWxlYXNl KCkgd2hlbiBhIFJlZlB0ciBpcyByZXR1cm5lZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjQyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIHJlbGVhc2UoKSBzaG91bGQgYmUgY2FsbGVkIG9uIGEgUmVm UHRyIHRvIGNvbnZlcnQgaXQgdG8gYSBQYXNzUmVmUHRyLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cyBuZWVkZWQsIG5vIGJlaGF2aW9yIGNoYW5nZXMuCisKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2Vy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VJbWFnZVJlc29sdXRpb24p OgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZUltYWdlU2V0KToKKwogMjAxMy0w My0xNSAgTWlobmVhIE92aWRlbmllICA8bWlobmVhQGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NT IFJlZ2lvbnNdIFNlbGVjdGluZyB0ZXh0IGluc2lkZSBhbiBlbXB0eSByZWdpb24gY2F1c2VzIHNl bGVjdGlvbiBvdXRzaWRlIHRoZSByZWdpb24gYXJlYQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApp bmRleCA1NWE0OGUxNGVlMmQ5ZmRjMmY5Nzc2ZWM0MGI1NTlmNTRiZjE5ZDFlLi4wOGQ4MzZjY2Rm NThiNmUyN2YzYmY1NDJjZjhjZmQxZGZmOWIzMWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNw cApAQCAtNzkwNyw3ICs3OTA3LDcgQEAgUGFzc1JlZlB0cjxDU1NWYWx1ZT4gQ1NTUGFyc2VyOjpw YXJzZUltYWdlUmVzb2x1dGlvbihDU1NQYXJzZXJWYWx1ZUxpc3QqIHZhbHVlTGkKICAgICAgICAg cmV0dXJuIDA7CiAgICAgaWYgKCFoYXZlRnJvbUltYWdlICYmICFoYXZlUmVzb2x1dGlvbikKICAg ICAgICAgcmV0dXJuIDA7Ci0gICAgcmV0dXJuIGxpc3Q7CisgICAgcmV0dXJuIGxpc3QucmVsZWFz ZSgpOwogfQogI2VuZGlmCiAKQEAgLTc5NjYsNyArNzk2Niw3IEBAIFBhc3NSZWZQdHI8Q1NTVmFs dWU+IENTU1BhcnNlcjo6cGFyc2VJbWFnZVNldChDU1NQYXJzZXJWYWx1ZUxpc3QqIHZhbHVlTGlz dCkKICAgICAgICAgYXJnID0gZnVuY3Rpb25BcmdzLT5uZXh0KCk7CiAgICAgfQogCi0gICAgcmV0 dXJuIGltYWdlU2V0OworICAgIHJldHVybiBpbWFnZVNldC5yZWxlYXNlKCk7CiB9CiAjZW5kaWYK IAo=