112406 2013-03-14 22:35:38 -0700 Redundant if statement in RenderTextControlSingleLine::layout should be removed 2013-03-14 23:25:08 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dominicc dominicc cbiesinger eric esprehn+autocc mifenton ojan.autocc ojan tkent webkit.review.bot oldest_to_newest 855705 0 dominicc 2013-03-14 22:35:38 -0700 This scree was added in r145239. 855709 1 193237 dominicc 2013-03-14 22:38:04 -0700 Created attachment 193237 Patch 855729 2 193237 webkit.review.bot 2013-03-14 23:25:04 -0700 Comment on attachment 193237 Patch Clearing flags on attachment: 193237 Committed r145877: <http://trac.webkit.org/changeset/145877> 855730 3 webkit.review.bot 2013-03-14 23:25:08 -0700 All reviewed patches have been landed. Closing bug. 193237 2013-03-14 22:38:04 -0700 2013-03-14 23:25:04 -0700 Patch bug-112406-20130315143400.patch text/plain 1653 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1ODczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTZmOWVhMGQ4MzliOWRi NDMzM2FmZDk2OWYxNzgyNTkwNTMzYTU0Yi4uYjBmNzYwZTA5ODViMDU3MDQ5NDgxN2MzY2IwNjFl YzAwNGY0OTAyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTE0ICBEb21p bmljIENvb25leSAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZWR1bmRhbnQg aWYgc3RhdGVtZW50IGluIFJlbmRlclRleHRDb250cm9sU2luZ2xlTGluZTo6bGF5b3V0IHNob3Vs ZCBiZSByZW1vdmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTI0MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzIGFkZGVkIGluIHIxNDUyMzkuCisKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlclRleHRDb250cm9sU2luZ2xlTGluZTo6bGF5b3V0KToKKwogMjAxMy0w My0xNCAgSGF5YXRvIEl0byAgPGhheWF0b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1NoYWRv dyBEb21dOiBOb24gQnViYmxpbmcgZXZlbnRzIGluIFNoYWRvd0RPTSBkaXNwYXRjaCBpbiBhbiBp bmNvcnJlY3Qgb3JkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHAKaW5kZXggZmYzMzMxODZhMjJiZTFjMGNjMmJk ZjgyNzU3NmYwZmY3OTk5NzMxYi4uODU5MjUzMTczNWVhNmNhMjVkZThkZmVlZjMxNDI1NGFhODg5 YWQwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250 cm9sU2luZ2xlTGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRl eHRDb250cm9sU2luZ2xlTGluZS5jcHAKQEAgLTEzNSw4ICsxMzUsNyBAQCB2b2lkIFJlbmRlclRl eHRDb250cm9sU2luZ2xlTGluZTo6bGF5b3V0KCkKIAogICAgICAgICBtX2Rlc2lyZWRJbm5lclRl eHRMb2dpY2FsSGVpZ2h0ID0gZGVzaXJlZExvZ2ljYWxIZWlnaHQ7CiAKLSAgICAgICAgaWYgKGlu bmVyVGV4dFJlbmRlcmVyKQotICAgICAgICAgICAgaW5uZXJUZXh0UmVuZGVyZXItPnN0eWxlKCkt PnNldExvZ2ljYWxIZWlnaHQoTGVuZ3RoKGRlc2lyZWRMb2dpY2FsSGVpZ2h0LCBGaXhlZCkpOwor ICAgICAgICBpbm5lclRleHRSZW5kZXJlci0+c3R5bGUoKS0+c2V0TG9naWNhbEhlaWdodChMZW5n dGgoZGVzaXJlZExvZ2ljYWxIZWlnaHQsIEZpeGVkKSk7CiAgICAgICAgIGlmIChpbm5lckJsb2Nr UmVuZGVyZXIpCiAgICAgICAgICAgICBpbm5lckJsb2NrUmVuZGVyZXItPnN0eWxlKCktPnNldExv Z2ljYWxIZWlnaHQoTGVuZ3RoKGRlc2lyZWRMb2dpY2FsSGVpZ2h0LCBGaXhlZCkpOwogICAgIH0K