112402 2013-03-14 21:58:56 -0700 Web Inspector: [Resources] Local Storage: duplicate keys are processed inappropriately. 2013-03-18 05:55:10 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eustas eustas apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 855686 0 eustas 2013-03-14 21:58:56 -0700 Original issue: https://code.google.com/p/chromium/issues/detail?id=195100 Dev Tools -- Resources -- Unable to delete newly added keys under Local Storage. Recent changes removed forced "refresh" on editing. So duplicate keys do not combine with existing ones in UI. 855809 1 eustas 2013-03-15 01:55:30 -0700 Qualification: in case value is changed - all goes well. But in case value is not changed (it was already empty) - we receive no notification -> dupe is not removed. 855834 2 193265 eustas 2013-03-15 02:49:44 -0700 Created attachment 193265 Patch 856964 3 193521 eustas 2013-03-18 03:52:39 -0700 Created attachment 193521 Patch less-invasive-patch 856978 4 193521 apavlov 2013-03-18 04:23:00 -0700 Comment on attachment 193521 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193521&action=review > Source/WebCore/ChangeLog:8 > + Avoid duplicates in case value is not updated (consequently, Please give a more detailed description of what's wrong and how this patch fixes the bug (the issue summary is not helpful either.) > Source/WebCore/inspector/front-end/DOMStorageItemsView.js:250 > + masterNode.select(); Either this line should follow the method call or the method should be named, _removeDupesAndSelect. 857010 5 193521 eustas 2013-03-18 05:15:42 -0700 Comment on attachment 193521 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193521&action=review >> Source/WebCore/ChangeLog:8 >> + Avoid duplicates in case value is not updated (consequently, > > Please give a more detailed description of what's wrong and how this patch fixes the bug (the issue summary is not helpful either.) Done. >> Source/WebCore/inspector/front-end/DOMStorageItemsView.js:250 >> + masterNode.select(); > > Either this line should follow the method call or the method should be named, _removeDupesAndSelect. Addressed. 857014 6 193539 eustas 2013-03-18 05:21:05 -0700 Created attachment 193539 Patch 857033 7 193539 webkit.review.bot 2013-03-18 05:55:07 -0700 Comment on attachment 193539 Patch Clearing flags on attachment: 193539 Committed r146057: <http://trac.webkit.org/changeset/146057> 857034 8 webkit.review.bot 2013-03-18 05:55:10 -0700 All reviewed patches have been landed. Closing bug. 193265 2013-03-15 02:49:44 -0700 2013-03-18 03:52:35 -0700 Patch bug-112402-20130315134539.patch text/plain 4855 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1ODg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmJjZmJlOTUzY2Q0NzJi NDAyZWU1ZWIwOWZjMDczYjk5Y2ViYmY4NC4uNDE2ZmFmMjI0NmEwMWFmNmRjZTU5OTBiOTM0MzI0 M2QwNzNmODk0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTE1ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtSZXNvdXJjZXNdIExvY2FsIFN0b3JhZ2U6IGR1cGxpY2F0ZSBrZXlzIGFyZSBwcm9j ZXNzZWQgaW5hcHByb3ByaWF0ZWx5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTEyNDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQXZvaWQgZHVwbGljYXRlcyBpbiBjYXNlIHZhbHVlIGlzIG5vdCB1cGRh dGVkIChjb25zZXF1ZW50bHksCisgICAgICAgIG5vIG5vdGlmaWNhdGlvbiBmaXJlZCkuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0RPTVN0b3JhZ2VJdGVtc1ZpZXcuanM6CisgICAg ICAgIEV4dHJhY3RlZCAic2FuYXRpb24iIGNvZGUgdGhhdCBkZWFscyB3aXRoIGR1cGxpY2F0ZXMu CisKIDIwMTMtMDMtMTUgIFRha2FzaGkgU2FrYW1vdG8gIDx0YXNha0Bnb29nbGUuY29tPgogCiAg ICAgICAgIENyYXNoIGF0IFJlbmRlclN0eWxlOjppbmhlcml0RnJvbSByZXBvcnRlZCBieSBmdXp6 ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9NU3Rv cmFnZUl0ZW1zVmlldy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9N U3RvcmFnZUl0ZW1zVmlldy5qcwppbmRleCBjYzc1MzQzZDk4ZjhiZDEwM2M1NjllNzEyOTNmYzNi MGYwNDFiMzJjLi5kODlmNmM3ZTIwZWMxZmVhMjAyMmI1YzE5ODRiMTg0YzMwYWViNGMzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RPTVN0b3JhZ2VJdGVt c1ZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01TdG9y YWdlSXRlbXNWaWV3LmpzCkBAIC05NSwxNCArOTUsMTIgQEAgV2ViSW5zcGVjdG9yLkRPTVN0b3Jh Z2VJdGVtc1ZpZXcucHJvdG90eXBlID0gewogCiAgICAgICAgIGV2ZW50LmNvbnN1bWUodHJ1ZSk7 CiAKLSAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBjaGlsZHJlbi5sZW5ndGg7ICsraSkgewor ICAgICAgICBmb3IgKHZhciBpID0gY2hpbGRyZW4ubGVuZ3RoIC0gMTsgaSA+PSAwOyAtLWkpIHsK ICAgICAgICAgICAgIHZhciBjaGlsZE5vZGUgPSBjaGlsZHJlbltpXTsKLSAgICAgICAgICAgIGlm IChjaGlsZE5vZGUuZGF0YS5rZXkgPT09IHN0b3JhZ2VEYXRhLmtleSkgeworICAgICAgICAgICAg aWYgKGNoaWxkTm9kZS5kYXRhLmtleSA9PT0gc3RvcmFnZURhdGEua2V5KQogICAgICAgICAgICAg ICAgIHJvb3ROb2RlLnJlbW92ZUNoaWxkKGNoaWxkTm9kZSk7Ci0gICAgICAgICAgICAgICAgdGhp cy5kZWxldGVCdXR0b24udmlzaWJsZSA9IChjaGlsZHJlbi5sZW5ndGggPiAxKTsKLSAgICAgICAg ICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICB9CiAgICAgICAgIH0KKyAgICAgICAgdGhpcy5k ZWxldGVCdXR0b24udmlzaWJsZSA9IChjaGlsZHJlbi5sZW5ndGggPiAxKTsKICAgICB9LAogCiAg ICAgLyoqCkBAIC0xMTMsMTkgKzExMSwxMyBAQCBXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZUl0ZW1z Vmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmICghdGhpcy5pc1Nob3dpbmcoKSkKICAgICAg ICAgICAgIHJldHVybjsKIAotICAgICAgICB2YXIgc3RvcmFnZURhdGEgPSBldmVudC5kYXRhOwot ICAgICAgICB2YXIgcm9vdE5vZGUgPSB0aGlzLl9kYXRhR3JpZC5yb290Tm9kZSgpOwotICAgICAg ICB2YXIgY2hpbGRyZW4gPSByb290Tm9kZS5jaGlsZHJlbjsKLQogICAgICAgICBldmVudC5jb25z dW1lKHRydWUpOwotICAgICAgICB0aGlzLmRlbGV0ZUJ1dHRvbi52aXNpYmxlID0gdHJ1ZTsKIAot ICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGNoaWxkcmVuLmxlbmd0aDsgKytpKQotICAgICAg ICAgICAgaWYgKGNoaWxkcmVuW2ldLmRhdGEua2V5ID09PSBzdG9yYWdlRGF0YS5rZXkpCi0gICAg ICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB2YXIgc3RvcmFnZURhdGEgPSBldmVudC5kYXRh OworICAgICAgICBpZiAoIXRoaXMuX3VwZGF0ZUl0ZW0oc3RvcmFnZURhdGEua2V5LCBzdG9yYWdl RGF0YS5uZXdWYWx1ZSkpCisgICAgICAgICAgICB0aGlzLl9kYXRhR3JpZC5yb290Tm9kZSgpLmFw cGVuZENoaWxkKG5ldyBXZWJJbnNwZWN0b3IuRGF0YUdyaWROb2RlKHtrZXk6IHN0b3JhZ2VEYXRh LmtleSwgdmFsdWU6IHN0b3JhZ2VEYXRhLm5ld1ZhbHVlfSwgZmFsc2UpKTsKIAotICAgICAgICB2 YXIgY2hpbGROb2RlID0gbmV3IFdlYkluc3BlY3Rvci5EYXRhR3JpZE5vZGUoe2tleTogc3RvcmFn ZURhdGEua2V5LCB2YWx1ZTogc3RvcmFnZURhdGEubmV3VmFsdWV9LCBmYWxzZSk7Ci0gICAgICAg IHJvb3ROb2RlLmluc2VydENoaWxkKGNoaWxkTm9kZSwgY2hpbGRyZW4ubGVuZ3RoIC0gMSk7Cisg ICAgICAgIHRoaXMuZGVsZXRlQnV0dG9uLnZpc2libGUgPSB0cnVlOwogICAgIH0sCiAKICAgICAv KioKQEAgLTEzNiwyOCArMTI4LDM5IEBAIFdlYkluc3BlY3Rvci5ET01TdG9yYWdlSXRlbXNWaWV3 LnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKCF0aGlzLmlzU2hvd2luZygpKQogICAgICAgICAg ICAgcmV0dXJuOwogCisgICAgICAgIGV2ZW50LmNvbnN1bWUodHJ1ZSk7CisKICAgICAgICAgdmFy IHN0b3JhZ2VEYXRhID0gZXZlbnQuZGF0YTsKKyAgICAgICAgdGhpcy5kZWxldGVCdXR0b24udmlz aWJsZSA9IHRoaXMuX3VwZGF0ZUl0ZW0oc3RvcmFnZURhdGEua2V5LCBzdG9yYWdlRGF0YS5uZXdW YWx1ZSk7CisgICAgfSwKKworICAgIC8qKgorICAgICAqIEBwYXJhbSB7c3RyaW5nfSBrZXkKKyAg ICAgKiBAcGFyYW0ge3N0cmluZ30gdmFsdWUKKyAgICAgKiBAcmV0dXJuIHtib29sZWFufQorICAg ICAqLworICAgIF91cGRhdGVJdGVtOiBmdW5jdGlvbihrZXksIHZhbHVlKQorICAgIHsKICAgICAg ICAgdmFyIHJvb3ROb2RlID0gdGhpcy5fZGF0YUdyaWQucm9vdE5vZGUoKTsKICAgICAgICAgdmFy IGNoaWxkcmVuID0gcm9vdE5vZGUuY2hpbGRyZW47Ci0KLSAgICAgICAgZXZlbnQuY29uc3VtZSh0 cnVlKTsKLQogICAgICAgICB2YXIga2V5Rm91bmQgPSBmYWxzZTsKLSAgICAgICAgZm9yICh2YXIg aSA9IDA7IGkgPCBjaGlsZHJlbi5sZW5ndGg7ICsraSkgeworCisgICAgICAgIGZvciAodmFyIGkg PSBjaGlsZHJlbi5sZW5ndGggLSAxOyBpID49IDA7IC0taSkgewogICAgICAgICAgICAgdmFyIGNo aWxkTm9kZSA9IGNoaWxkcmVuW2ldOwotICAgICAgICAgICAgaWYgKGNoaWxkTm9kZS5kYXRhLmtl eSA9PT0gc3RvcmFnZURhdGEua2V5KSB7Ci0gICAgICAgICAgICAgICAgaWYgKGtleUZvdW5kKSB7 Ci0gICAgICAgICAgICAgICAgICAgIHJvb3ROb2RlLnJlbW92ZUNoaWxkKGNoaWxkTm9kZSk7Ci0g ICAgICAgICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAg ICAgICAga2V5Rm91bmQgPSB0cnVlOwotICAgICAgICAgICAgICAgIGNoaWxkTm9kZS5kYXRhLnZh bHVlID0gc3RvcmFnZURhdGEubmV3VmFsdWU7Ci0gICAgICAgICAgICAgICAgY2hpbGROb2RlLnJl ZnJlc2goKTsKLSAgICAgICAgICAgICAgICBjaGlsZE5vZGUuc2VsZWN0KCk7Ci0gICAgICAgICAg ICAgICAgY2hpbGROb2RlLnJldmVhbCgpOwotICAgICAgICAgICAgICAgIHRoaXMuZGVsZXRlQnV0 dG9uLnZpc2libGUgPSB0cnVlOworICAgICAgICAgICAgaWYgKGNoaWxkTm9kZS5kYXRhLmtleSAh PT0ga2V5KQorICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgaWYgKGtleUZv dW5kKSB7CisgICAgICAgICAgICAgICAgcm9vdE5vZGUucmVtb3ZlQ2hpbGQoY2hpbGROb2RlKTsK KyAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGtl eUZvdW5kID0gdHJ1ZTsKKyAgICAgICAgICAgIGNoaWxkTm9kZS5kYXRhLnZhbHVlID0gdmFsdWU7 CisgICAgICAgICAgICBjaGlsZE5vZGUucmVmcmVzaCgpOworICAgICAgICAgICAgY2hpbGROb2Rl LnNlbGVjdCgpOworICAgICAgICAgICAgY2hpbGROb2RlLnJldmVhbCgpOwogICAgICAgICB9CisK KyAgICAgICAgcmV0dXJuIGtleUZvdW5kOwogICAgIH0sCiAKICAgICBfdXBkYXRlOiBmdW5jdGlv bigpCkBAIC0yMjYsOCArMjI5LDggQEAgV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VJdGVtc1ZpZXcu cHJvdG90eXBlID0gewogICAgICAgICBpZiAoImtleSIgPT09IGNvbHVtbklkZW50aWZpZXIpIHsK ICAgICAgICAgICAgIGlmIChvbGRUZXh0KQogICAgICAgICAgICAgICAgIGRvbVN0b3JhZ2UucmVt b3ZlSXRlbShvbGRUZXh0KTsKLQogICAgICAgICAgICAgZG9tU3RvcmFnZS5zZXRJdGVtKG5ld1Rl eHQsIGVkaXRpbmdOb2RlLmRhdGEudmFsdWUpOworICAgICAgICAgICAgdGhpcy5fdXBkYXRlSXRl bShuZXdUZXh0LCBlZGl0aW5nTm9kZS5kYXRhLnZhbHVlKTsKICAgICAgICAgfSBlbHNlCiAgICAg ICAgICAgICBkb21TdG9yYWdlLnNldEl0ZW0oZWRpdGluZ05vZGUuZGF0YS5rZXksIG5ld1RleHQp OwogICAgIH0sCg== 193521 2013-03-18 03:52:39 -0700 2013-03-18 05:21:00 -0700 Patch bug-112402-20130318144830.patch text/plain 2943 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjY2YjQ2NjViZTA4MDNk MjU3NTA5YTQzYmE5YjYzMmVhZmNkNDZjNi4uZjJjMjNhN2NjZDI2MWNkMGYyODFjOGQ2ZWM3ZjFh YTFhOGQyOTI2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTE1ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtSZXNvdXJjZXNdIExvY2FsIFN0b3JhZ2U6IGR1cGxpY2F0ZSBrZXlzIGFyZSBwcm9j ZXNzZWQgaW5hcHByb3ByaWF0ZWx5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTEyNDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQXZvaWQgZHVwbGljYXRlcyBpbiBjYXNlIHZhbHVlIGlzIG5vdCB1cGRh dGVkIChjb25zZXF1ZW50bHksCisgICAgICAgIG5vIG5vdGlmaWNhdGlvbiBmaXJlZCkuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0RPTVN0b3JhZ2VJdGVtc1ZpZXcuanM6CisgICAg ICAgIEV4dHJhY3RlZCAic2FuYXRpb24iIGNvZGUgdGhhdCBkZWFscyB3aXRoIGR1cGxpY2F0ZXMu CisKIDIwMTMtMDMtMTcgIEt1bmloaWtvIFNha2Ftb3RvICA8a3Nha2Ftb3RvQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBJTlBVVF9NVUxUSVBMRV9GSUVMRFNfVUk6IFN0ZXAtdXAvLWRvd24gb2Yg bWludXRlL3NlY29uZC9taWxsaXNlY29uZCBmaWVsZHMgc2hvdWxkIHJlc3BlY3QgbWluL21heCBh dHRyaWJ1dGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0RPTVN0b3JhZ2VJdGVtc1ZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL0RPTVN0b3JhZ2VJdGVtc1ZpZXcuanMKaW5kZXggYjNkMzNjMTM5Yzg0MGYxYzliNWYxMDUz YjBiOGM2NGY5MTljNDYwMS4uNGUxM2I3YzU0MWM2YWU0NDYyODhiZDc4NGFlOGU0ZjZmNjRjNzI5 NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01TdG9y YWdlSXRlbXNWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv RE9NU3RvcmFnZUl0ZW1zVmlldy5qcwpAQCAtMTUxLDEwICsxNTEsMTIgQEAgV2ViSW5zcGVjdG9y LkRPTVN0b3JhZ2VJdGVtc1ZpZXcucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIGtleUZvdW5kID0gdHJ1 ZTsKLSAgICAgICAgICAgICAgICBjaGlsZE5vZGUuZGF0YS52YWx1ZSA9IHN0b3JhZ2VEYXRhLm5l d1ZhbHVlOwotICAgICAgICAgICAgICAgIGNoaWxkTm9kZS5yZWZyZXNoKCk7Ci0gICAgICAgICAg ICAgICAgY2hpbGROb2RlLnNlbGVjdCgpOwotICAgICAgICAgICAgICAgIGNoaWxkTm9kZS5yZXZl YWwoKTsKKyAgICAgICAgICAgICAgICBpZiAoY2hpbGROb2RlLmRhdGEudmFsdWUgIT09IHN0b3Jh Z2VEYXRhLm5ld1ZhbHVlKSB7CisgICAgICAgICAgICAgICAgICAgIGNoaWxkTm9kZS5kYXRhLnZh bHVlID0gc3RvcmFnZURhdGEubmV3VmFsdWU7CisgICAgICAgICAgICAgICAgICAgIGNoaWxkTm9k ZS5yZWZyZXNoKCk7CisgICAgICAgICAgICAgICAgICAgIGNoaWxkTm9kZS5zZWxlY3QoKTsKKyAg ICAgICAgICAgICAgICAgICAgY2hpbGROb2RlLnJldmVhbCgpOworICAgICAgICAgICAgICAgIH0K ICAgICAgICAgICAgICAgICB0aGlzLmRlbGV0ZUJ1dHRvbi52aXNpYmxlID0gdHJ1ZTsKICAgICAg ICAgICAgIH0KICAgICAgICAgfQpAQCAtMjI3LDEyICsyMjksMjcgQEAgV2ViSW5zcGVjdG9yLkRP TVN0b3JhZ2VJdGVtc1ZpZXcucHJvdG90eXBlID0gewogICAgICAgICBpZiAoImtleSIgPT09IGNv bHVtbklkZW50aWZpZXIpIHsKICAgICAgICAgICAgIGlmIChvbGRUZXh0KQogICAgICAgICAgICAg ICAgIGRvbVN0b3JhZ2UucmVtb3ZlSXRlbShvbGRUZXh0KTsKLQogICAgICAgICAgICAgZG9tU3Rv cmFnZS5zZXRJdGVtKG5ld1RleHQsIGVkaXRpbmdOb2RlLmRhdGEudmFsdWUpOworICAgICAgICAg ICAgdGhpcy5fcmVtb3ZlRHVwZXMoZWRpdGluZ05vZGUpOwogICAgICAgICB9IGVsc2UKICAgICAg ICAgICAgIGRvbVN0b3JhZ2Uuc2V0SXRlbShlZGl0aW5nTm9kZS5kYXRhLmtleSwgbmV3VGV4dCk7 CiAgICAgfSwKIAorICAgIC8qKgorICAgICAqIEBwYXJhbSB7IVdlYkluc3BlY3Rvci5EYXRhR3Jp ZE5vZGV9IG1hc3Rlck5vZGUKKyAgICAgKi8KKyAgICBfcmVtb3ZlRHVwZXM6IGZ1bmN0aW9uKG1h c3Rlck5vZGUpCisgICAgeworICAgICAgICB2YXIgcm9vdE5vZGUgPSB0aGlzLl9kYXRhR3JpZC5y b290Tm9kZSgpOworICAgICAgICB2YXIgY2hpbGRyZW4gPSByb290Tm9kZS5jaGlsZHJlbjsKKyAg ICAgICAgZm9yICh2YXIgaSA9IGNoaWxkcmVuLmxlbmd0aCAtIDE7IGkgPj0gMDsgLS1pKSB7Cisg ICAgICAgICAgICB2YXIgY2hpbGROb2RlID0gY2hpbGRyZW5baV07CisgICAgICAgICAgICBpZiAo KGNoaWxkTm9kZS5kYXRhLmtleSA9PT0gbWFzdGVyTm9kZS5kYXRhLmtleSkgJiYgKG1hc3Rlck5v ZGUgIT09IGNoaWxkTm9kZSkpCisgICAgICAgICAgICAgICAgcm9vdE5vZGUucmVtb3ZlQ2hpbGQo Y2hpbGROb2RlKTsKKyAgICAgICAgfQorICAgICAgICBtYXN0ZXJOb2RlLnNlbGVjdCgpOworICAg IH0sCisKICAgICBfZGVsZXRlQ2FsbGJhY2s6IGZ1bmN0aW9uKG5vZGUpCiAgICAgewogICAgICAg ICBpZiAoIW5vZGUgfHwgbm9kZS5pc0NyZWF0aW9uTm9kZSkK 193539 2013-03-18 05:21:05 -0700 2013-03-18 05:55:06 -0700 Patch bug-112402-20130318161656.patch text/plain 3426 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTcxMmExMjYzOGQ3OGYy ZjZiMzQ0YmU2MjZhMDhmODg5Yzk3NGRiNy4uNjQ0ZjEwYjZlOTJlZmY4MGRkOGI0MWZiMzJjYzU3 Yzg3MWM2NjgyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEzLTAzLTE1ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtSZXNvdXJjZXNdIExvY2FsIFN0b3JhZ2U6IGR1cGxpY2F0ZSBrZXlzIGFyZSBwcm9j ZXNzZWQgaW5hcHByb3ByaWF0ZWx5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTEyNDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2hlbiB1c2VyIGNyZWF0ZXMgbmV3IGl0ZW1zIG9yIHJlbmFtZXMgZXhp c3Rpbmcgb25lIHNvbWUgZXhpc3RpbmcgaXRlbQorICAgICAgICBtYXkgYmUgb3ZlcnJpZGVuLiBJ ZiB2YWx1ZSBpcyBjaGFuZ2VkLCB0aGVuIGZyb250ZW5kIHdpbGwgcmVjZWl2ZQorICAgICAgICBu b3RpZmljYXRpb24gYW5kIHVwZGF0ZSByZWNvcmQgYXBwcm9wcmlhdGVseS4KKworICAgICAgICBJ ZiBpdGVtIHZhbHVlIGhhc24ndCBiZWVuIGNoYW5nZWQsIHRoZW4gbm8gbm90aWZpY2F0aW9uIGNv bWVzLgorICAgICAgICBCdXQgVUkgc3RpbGwgZXhwZWN0IC8gcmVseSBvbiB0aGlzIG5vdGlmaWNh dGlvbi4KKworICAgICAgICBXaXRoIHRoaXMgcGF0Y2ggdGhlICJubyBub3RpZmljYXRpb24iIHNj ZW5hcmlvIGlzIGZpeGVkOgorICAgICAgICBkdXBsaWNhdGUgaXRlbXMgYXJlIHJlbW92ZWQuCisK KyAgICAgICAgQW5vdGhlciBzY2VuYXJpbyBpcyB3aGVuIHVwZGF0ZSBub3RpZmljYXRpb24gY29t ZXMgd2hlbiB3ZSBzdGFydGVkCisgICAgICAgIGVkaXRpbmcgdmFsdWUgKGFmdGVyIGVudGVyaW5n IC8gcmVuYW1pbmcga2V5KS4gSW4gdGhpcyBjYXNlCisgICAgICAgIHNlbGVjdGVkIG5vZGUgc2hv dWxkIG5vdCBiZSBjaGFuZ2VkIHRvIGxlYXZlIHVzZXIgaW4gZWRpdGluZyBtb2RlLgorCisgICAg ICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9ET01TdG9yYWdlSXRlbXNWaWV3LmpzOgorICAgICAg ICBBZGRlZCB3b3JrYXJvdW5kcyBmb3IgIm5vIG5vdGlmaWNhdGlvbiIgYW5kICJ1c2VsZXNzIG5v dGlmaWNhdGlvbiIuCisKIDIwMTMtMDMtMTggIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFu LmplbnNlbkBkaWdpYS5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgUmVuZGVyRnJhbWVTZXQ6Om5v ZGVBdFBvaW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0RPTVN0b3JhZ2VJdGVtc1ZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL0RPTVN0b3JhZ2VJdGVtc1ZpZXcuanMKaW5kZXggYjNkMzNjMTM5Yzg0MGYxYzliNWYxMDUz YjBiOGM2NGY5MTljNDYwMS4uOTUwNmQ5OTI2Mzk0ZTcwNWFlMDJmNTllMDc4ZGQ5MzNjMDY0ZjNm YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01TdG9y YWdlSXRlbXNWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv RE9NU3RvcmFnZUl0ZW1zVmlldy5qcwpAQCAtMTUxLDEwICsxNTEsMTIgQEAgV2ViSW5zcGVjdG9y LkRPTVN0b3JhZ2VJdGVtc1ZpZXcucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIGtleUZvdW5kID0gdHJ1 ZTsKLSAgICAgICAgICAgICAgICBjaGlsZE5vZGUuZGF0YS52YWx1ZSA9IHN0b3JhZ2VEYXRhLm5l d1ZhbHVlOwotICAgICAgICAgICAgICAgIGNoaWxkTm9kZS5yZWZyZXNoKCk7Ci0gICAgICAgICAg ICAgICAgY2hpbGROb2RlLnNlbGVjdCgpOwotICAgICAgICAgICAgICAgIGNoaWxkTm9kZS5yZXZl YWwoKTsKKyAgICAgICAgICAgICAgICBpZiAoY2hpbGROb2RlLmRhdGEudmFsdWUgIT09IHN0b3Jh Z2VEYXRhLm5ld1ZhbHVlKSB7CisgICAgICAgICAgICAgICAgICAgIGNoaWxkTm9kZS5kYXRhLnZh bHVlID0gc3RvcmFnZURhdGEubmV3VmFsdWU7CisgICAgICAgICAgICAgICAgICAgIGNoaWxkTm9k ZS5yZWZyZXNoKCk7CisgICAgICAgICAgICAgICAgICAgIGNoaWxkTm9kZS5zZWxlY3QoKTsKKyAg ICAgICAgICAgICAgICAgICAgY2hpbGROb2RlLnJldmVhbCgpOworICAgICAgICAgICAgICAgIH0K ICAgICAgICAgICAgICAgICB0aGlzLmRlbGV0ZUJ1dHRvbi52aXNpYmxlID0gdHJ1ZTsKICAgICAg ICAgICAgIH0KICAgICAgICAgfQpAQCAtMjI3LDEyICsyMjksMjYgQEAgV2ViSW5zcGVjdG9yLkRP TVN0b3JhZ2VJdGVtc1ZpZXcucHJvdG90eXBlID0gewogICAgICAgICBpZiAoImtleSIgPT09IGNv bHVtbklkZW50aWZpZXIpIHsKICAgICAgICAgICAgIGlmIChvbGRUZXh0KQogICAgICAgICAgICAg ICAgIGRvbVN0b3JhZ2UucmVtb3ZlSXRlbShvbGRUZXh0KTsKLQogICAgICAgICAgICAgZG9tU3Rv cmFnZS5zZXRJdGVtKG5ld1RleHQsIGVkaXRpbmdOb2RlLmRhdGEudmFsdWUpOworICAgICAgICAg ICAgdGhpcy5fcmVtb3ZlRHVwZXMoZWRpdGluZ05vZGUpOwogICAgICAgICB9IGVsc2UKICAgICAg ICAgICAgIGRvbVN0b3JhZ2Uuc2V0SXRlbShlZGl0aW5nTm9kZS5kYXRhLmtleSwgbmV3VGV4dCk7 CiAgICAgfSwKIAorICAgIC8qKgorICAgICAqIEBwYXJhbSB7IVdlYkluc3BlY3Rvci5EYXRhR3Jp ZE5vZGV9IG1hc3Rlck5vZGUKKyAgICAgKi8KKyAgICBfcmVtb3ZlRHVwZXM6IGZ1bmN0aW9uKG1h c3Rlck5vZGUpCisgICAgeworICAgICAgICB2YXIgcm9vdE5vZGUgPSB0aGlzLl9kYXRhR3JpZC5y b290Tm9kZSgpOworICAgICAgICB2YXIgY2hpbGRyZW4gPSByb290Tm9kZS5jaGlsZHJlbjsKKyAg ICAgICAgZm9yICh2YXIgaSA9IGNoaWxkcmVuLmxlbmd0aCAtIDE7IGkgPj0gMDsgLS1pKSB7Cisg ICAgICAgICAgICB2YXIgY2hpbGROb2RlID0gY2hpbGRyZW5baV07CisgICAgICAgICAgICBpZiAo KGNoaWxkTm9kZS5kYXRhLmtleSA9PT0gbWFzdGVyTm9kZS5kYXRhLmtleSkgJiYgKG1hc3Rlck5v ZGUgIT09IGNoaWxkTm9kZSkpCisgICAgICAgICAgICAgICAgcm9vdE5vZGUucmVtb3ZlQ2hpbGQo Y2hpbGROb2RlKTsKKyAgICAgICAgfQorICAgIH0sCisKICAgICBfZGVsZXRlQ2FsbGJhY2s6IGZ1 bmN0aW9uKG5vZGUpCiAgICAgewogICAgICAgICBpZiAoIW5vZGUgfHwgbm9kZS5pc0NyZWF0aW9u Tm9kZSkK