112394 2013-03-14 17:01:26 -0700 WebKit doesn't build Tools/GtkLauncher/Programs_GtkLauncher-main.o if --disable-video due to missing gstreamer flags 2013-03-15 00:16:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 tobiasmue webkit-unassigned calvaris gustavo mrobinson pnormand webkit.review.bot oldest_to_newest 855579 0 tobiasmue 2013-03-14 17:01:26 -0700 WebKit doesn't build Tools/GtkLauncher/Programs_GtkLauncher-main.o if --disable-video due to missing gstreamer flags 855595 1 193208 tobiasmue 2013-03-14 17:17:34 -0700 Created attachment 193208 Patch guarding gst header inclusion and gst function usage WebKit was configured with the following options: $ ./autogen.sh --prefix /opt/gnome2 --libdir /opt/gnome2/lib64 --enable-introspection --with-gstreamer=1.0 --disable-static --disable-scrollkeeper --disable-gtk-doc --disable-docs --enable-gtk-doc=no --enable-gtk-doc-html=no --enable-gtk-doc-pdf=no --enable-webkit1 --disable-spellcheck --disable-glx --disable-egl --disable-gles2 --disable-gamepad --disable-video --disable-mediastream --enable-xslt --disable-geolocation --disable-svg --disable-svg-fonts --disable-web-audio --disable-coverage --disable-webgl --disable-gtk-doc-html --disable-accelerated-compositing Build configuration: Enable debugging (slow) : no Compile with debug symbols (slow) : no Enable GCC build optimization : yes Code coverage support : no Optimized memory allocator : yes Accelerated rendering backend : opengl(gl) Features: ======= WebKit1 support : yes WebKit2 support : yes Accelerated Compositing : no Gamepad support : no Geolocation support : no HTML5 video element support : no JIT compilation : autodetect Opcode stats : no SVG fonts support : no SVG support : no Spellcheck support : no Web Audio support : no WebGL : no GTK+ configuration: GTK+ version : 3.0 GDK target : x11 Introspection support : yes Generate documentation : no CC Tools/GtkLauncher/Programs_GtkLauncher-LauncherInspectorWindow.o CC Tools/GtkLauncher/Programs_GtkLauncher-main.o CC Tools/MiniBrowser/gtk/Programs_MiniBrowser-BrowserCellRendererVariant.o Tools/GtkLauncher/main.c:31:21: fatal error: gst/gst.h: No such file or directory compilation terminated. make[1]: *** [Tools/GtkLauncher/Programs_GtkLauncher-main.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/tmp/wk-noting-but-wk1' make: *** [all] Error 2 gcc -DHAVE_CONFIG_H -I. -I./Source/WebKit/gtk -I./Source/WebCore/platform/network/soup/cache/ -I./Source/WebKit/gtk -I./DerivedSources -DWEBKIT_EXEC_PATH=\"/home/muelli/svn/gnome2/WebKit/./Programs/\" -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wno-parentheses -fno-exceptions -DBUILDING_CAIRO__ -DBUILDING_GTK__ -DBUILDING_WEBKIT2__ -I./Source -I./Source/JavaScriptCore -I./Source/JavaScriptCore/API -I./Source/JavaScriptCore/assembler -I./Source/JavaScriptCore/bytecode -I./Source/JavaScriptCore/bytecompiler -I./Source/JavaScriptCore/dfg -I./Source/JavaScriptCore/disassembler -I./Source/JavaScriptCore/heap -I./Source/JavaScriptCore/debugger -I./Source/JavaScriptCore/ForwardingHeaders -I./Source/JavaScriptCore/interpreter -I./Source/JavaScriptCore/jit -I./Source/JavaScriptCore/jit -I./Source/JavaScriptCore/llint -I./Source/JavaScriptCore/parser -I./Source/JavaScriptCore/profiler -I./Source/JavaScriptCore/runtime -I./Source/JavaScriptCore/tools -I./Source/JavaScriptCore/yarr -I./DerivedSources/JavaScriptCore -I./Source/WTF -ansi -fno-strict-aliasing -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib64/glib-2.0/include -I/opt/gnome2/include/harfbuzz -I/usr/include/cairo -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng15 -pthread -I/opt/gnome2/include/gtk-3.0 -I/opt/gnome2/include/atk-1.0 -I/opt/gnome2/include/at-spi2-atk/2.0 -I/opt/gnome2/include/pango-1.0 -I/opt/gnome2/include/gio-unix-2.0/ -I/opt/gnome2/include/gdk-pixbuf-2.0 -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib64/glib-2.0/include -I/opt/gnome2/include/harfbuzz -I/usr/include/cairo -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng15 -pthread -I/opt/gnome2/include/libsoup-2.4 -I/opt/gnome2/include/libxml2 -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib64/glib-2.0/include -std=c99 -O2 -MT Tools/GtkLauncher/Programs_GtkLauncher-main.o -MD -MP -MF Tools/GtkLauncher/.deps/Programs_GtkLauncher-main.Tpo -c -o Tools/GtkLauncher/Programs_GtkLauncher-main.o `test -f 'Tools/GtkLauncher/main.c' || echo './'`Tools/GtkLauncher/main.c mv -f Tools/DumpRenderTree/gtk/.deps/Programs_DumpRenderTree-TextInputController.Tpo Tools/DumpRenderTree/gtk/.deps/Programs_DumpRenderTree-TextInputController.Po Tools/GtkLauncher/main.c:31:21: fatal error: gst/gst.h: No such file or directory compilation terminated. make[1]: *** [Tools/GtkLauncher/Programs_GtkLauncher-main.o] Error 1 Note that gstreamer was not installed. With the patch attached it builds fine. Interestingly though, I couldn't find any other user of WTF_USE_GSTREAMER. 855753 2 193208 pnormand 2013-03-15 00:11:14 -0700 Comment on attachment 193208 Patch guarding gst header inclusion and gst function usage Thanks! 855758 3 193208 webkit.review.bot 2013-03-15 00:16:08 -0700 Comment on attachment 193208 Patch guarding gst header inclusion and gst function usage Clearing flags on attachment: 193208 Committed r145881: <http://trac.webkit.org/changeset/145881> 855759 4 webkit.review.bot 2013-03-15 00:16:11 -0700 All reviewed patches have been landed. Closing bug. 193208 2013-03-14 17:17:34 -0700 2013-03-15 00:16:08 -0700 Patch guarding gst header inclusion and gst function usage gst.patch text/plain 1530 tobiasmue ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1NGRl ZTBiLi4xNzEyMDY1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDMtMTQgIFRvYmlhcyBNdWVsbGVyICA8dG9i aWFzbXVlQGdub21lLm9yZz4KKworICAgICAgICBCdWlsZCBmaXggZm9yIFRvb2xzL0d0a0xhdW5j aGVyL1Byb2dyYW1zX0d0a0xhdW5jaGVyLW1haW4ubyBpZiBnc3RyZWFtZXIgaXMgbm90IGluc3Rh bGxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEy Mzk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBH dGtMYXVuY2hlci9tYWluLmM6CisgICAgICAgIChtYWluKTogR3VhcmQgdXNpbmcgdGhlIGdzdHJl YW1lciBmdW5jdGlvbiB3aXRoICNpZmRlZiBXVEZfVVNFX0dTVFJFQU1FUgorCiAyMDEzLTAzLTEz ICBFbGxpb3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2 aWV3ZWQuIE5vdyBJJ20gYSByZXZpZXdlciA6KQpkaWZmIC0tZ2l0IGEvVG9vbHMvR3RrTGF1bmNo ZXIvbWFpbi5jIGIvVG9vbHMvR3RrTGF1bmNoZXIvbWFpbi5jCmluZGV4IDMyYmFmNGEuLjg0Yzg4 MzMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0d0a0xhdW5jaGVyL21haW4uYworKysgYi9Ub29scy9HdGtM YXVuY2hlci9tYWluLmMKQEAgLTI4LDcgKzI4LDkgQEAKICNpbmNsdWRlICJhdXRvdG9vbHNjb25m aWcuaCIKICNpbmNsdWRlICJMYXVuY2hlckluc3BlY3RvcldpbmRvdy5oIgogI2luY2x1ZGUgPGVy cm5vLmg+CisjaWZkZWYgV1RGX1VTRV9HU1RSRUFNRVIKICNpbmNsdWRlIDxnc3QvZ3N0Lmg+Cisj ZW5kaWYKICNpbmNsdWRlIDxndGsvZ3RrLmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5jbHVk ZSA8c3RyaW5nLmg+CkBAIC00ODksOCArNDkxLDkgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIq IGFyZ3ZbXSkKICAgICBHT3B0aW9uQ29udGV4dCAqY29udGV4dCA9IGdfb3B0aW9uX2NvbnRleHRf bmV3KDApOwogICAgIGdfb3B0aW9uX2NvbnRleHRfYWRkX21haW5fZW50cmllcyhjb250ZXh0LCBj b21tYW5kTGluZU9wdGlvbnMsIDApOwogICAgIGdfb3B0aW9uX2NvbnRleHRfYWRkX2dyb3VwKGNv bnRleHQsIGd0a19nZXRfb3B0aW9uX2dyb3VwKFRSVUUpKTsKKyNpZmRlZiBXVEZfVVNFX0dTVFJF QU1FUgogICAgIGdfb3B0aW9uX2NvbnRleHRfYWRkX2dyb3VwKGNvbnRleHQsIGdzdF9pbml0X2dl dF9vcHRpb25fZ3JvdXAoKSk7Ci0KKyNlbmRpZgogICAgIHdlYmtpdFNldHRpbmdzID0gd2Via2l0 X3dlYl9zZXR0aW5nc19uZXcoKTsKICAgICBnX29iamVjdF9zZXQod2Via2l0U2V0dGluZ3MsICJl bmFibGUtZGV2ZWxvcGVyLWV4dHJhcyIsIFRSVUUsIE5VTEwpOwogICAgIGlmICghYWRkV2ViU2V0 dGluZ3NHcm91cFRvQ29udGV4dChjb250ZXh0LCB3ZWJraXRTZXR0aW5ncykpIHsK