112390 2013-03-14 16:30:25 -0700 [chromium] Remove the zoom filter operation ifdef 2013-03-17 10:15:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj abarth dglazkov fishd jamesr senorblanco tkent+wkapi webkit.review.bot oldest_to_newest 855553 0 danakj 2013-03-14 16:30:25 -0700 [chromium] Remove the zoom filter operation ifdef 855554 1 193198 danakj 2013-03-14 16:31:21 -0700 Created attachment 193198 Patch 855556 2 danakj 2013-03-14 16:31:49 -0700 This should land once https://codereview.chromium.org/12630014/ lands. 855559 3 webkit.review.bot 2013-03-14 16:34:30 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 856719 4 193198 webkit.review.bot 2013-03-17 10:03:43 -0700 Comment on attachment 193198 Patch Rejecting attachment 193198 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ty/skia/gyp --revision 8166 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 103. Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' Died at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2628. Full output: http://webkit-commit-queue.appspot.com/results/17215343 856721 5 193198 webkit.review.bot 2013-03-17 10:15:00 -0700 Comment on attachment 193198 Patch Clearing flags on attachment: 193198 Committed r146013: <http://trac.webkit.org/changeset/146013> 856722 6 webkit.review.bot 2013-03-17 10:15:03 -0700 All reviewed patches have been landed. Closing bug. 193198 2013-03-14 16:31:21 -0700 2013-03-17 10:15:00 -0700 Patch bug-112390-20130314192717.patch text/plain 1725 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1Nzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBjNjllNDM1MTdiNjhk OWVmYjE2MzA5M2QxZWY0ZmFiMWY0NzBkYjdkLi5kNTc3MmZjY2JhZDYzMjM1MTdiMGUxNDhiNTYx MzVhZWQ5NTM0ZWE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0wMy0xNCAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IFJlbW92ZSB0aGUgem9vbSBmaWx0ZXIgb3BlcmF0aW9uIGlmZGVmCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIzOTAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlmZGVmIGlzIG5vdCBuZWVkZWQg b25jZSB0aGUgY2hhbmdlIHRoYXQgaW50cm9kdWNlZCBpdCBpcworICAgICAgICByb2xsZWQgaW50 byBjaHJvbWl1bSwgYW5kIHRoZSBjaHJvbWl1bSBzaWRlIGd1YXJkcyBvbiB0aGUgaWZkZWYKKyAg ICAgICAgYXJlIHJlbW92ZWQuIFRoZW4gaXQganVzdCBkb2VzIG5vdGhpbmcgYW5kIHNob3VsZCBi ZSBkZWxldGVkLgorCisgICAgICAgICogY2hyb21pdW0vcHVibGljL1dlYkZpbHRlck9wZXJhdGlv bi5oOgorCiAyMDEzLTAzLTEyICBEYW5hIEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFtjaHJvbWl1bV0gTWFrZSB6b29tIGZpbHRlciBpbmRlcGVuZGVudCBvZiB0aGUg bGF5ZXIgc2l6ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMv V2ViRmlsdGVyT3BlcmF0aW9uLmggYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dl YkZpbHRlck9wZXJhdGlvbi5oCmluZGV4IGJiNWJiMmRhNmIzNDk2ZjA0YTE2ZDZmYjgwMmViYjQ3 MjA4MTJlNTMuLjU2MzFmZTcyZDIxM2I2MGE1MGQ2NDdiYmMyZjk0NzRhNWE1MDU4MjQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViRmlsdGVyT3BlcmF0aW9u LmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJGaWx0ZXJPcGVyYXRp b24uaApAQCAtOTEsOSArOTEsNiBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBtX3pvb21JbnNl dDsKICAgICB9CiAKLSAgICAvLyBGSVhNRTogUmVtb3ZlIHRoaXMgYW5kIHRoZSBjaGVjayBmb3Ig aXQgaW4gY2hyb21pdW0uCi0jZGVmaW5lIE5FV19aT09NX0ZJTFRFUgotCiAgICAgc3RhdGljIFdl YkZpbHRlck9wZXJhdGlvbiBjcmVhdGVHcmF5c2NhbGVGaWx0ZXIoZmxvYXQgYW1vdW50KSB7IHJl dHVybiBXZWJGaWx0ZXJPcGVyYXRpb24oRmlsdGVyVHlwZUdyYXlzY2FsZSwgYW1vdW50KTsgfQog ICAgIHN0YXRpYyBXZWJGaWx0ZXJPcGVyYXRpb24gY3JlYXRlU2VwaWFGaWx0ZXIoZmxvYXQgYW1v dW50KSB7IHJldHVybiBXZWJGaWx0ZXJPcGVyYXRpb24oRmlsdGVyVHlwZVNlcGlhLCBhbW91bnQp OyB9CiAgICAgc3RhdGljIFdlYkZpbHRlck9wZXJhdGlvbiBjcmVhdGVTYXR1cmF0ZUZpbHRlcihm bG9hdCBhbW91bnQpIHsgcmV0dXJuIFdlYkZpbHRlck9wZXJhdGlvbihGaWx0ZXJUeXBlU2F0dXJh dGUsIGFtb3VudCk7IH0K