112385 2013-03-14 15:01:22 -0700 [Chromium] Focus Plugin on TouchStart 2013-03-15 16:03:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fsamuel fsamuel abarth fishd sadrul webkit.review.bot oldest_to_newest 855515 0 fsamuel 2013-03-14 15:01:22 -0700 [Chromium] Focus Plugin on TouchStart 855516 1 193193 fsamuel 2013-03-14 15:01:36 -0700 Created attachment 193193 Patch 855521 2 sadrul 2013-03-14 15:18:50 -0700 Since we do this for mouse-down events, I think it makes sense to do this on touch-press events too. LGTM 856110 3 193193 abarth 2013-03-15 11:03:56 -0700 Comment on attachment 193193 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193193&action=review > Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:779 > + Frame* containingFrame = static_cast<FrameView*>(parent())->frame(); > + if (Page* currentPage = containingFrame->page()) > + currentPage->focusController()->setFocusedNode(m_element, containingFrame); > + else > + containingFrame->document()->setFocusedNode(m_element); This seems copy/pasted from WebPluginContainerImpl::handleMouseEvent. Can we create a small helper function rather than copy/pasting code? 856239 4 193366 fsamuel 2013-03-15 13:25:12 -0700 Created attachment 193366 Patch 856371 5 193366 webkit.review.bot 2013-03-15 16:03:38 -0700 Comment on attachment 193366 Patch Clearing flags on attachment: 193366 Committed r145957: <http://trac.webkit.org/changeset/145957> 856372 6 webkit.review.bot 2013-03-15 16:03:42 -0700 All reviewed patches have been landed. Closing bug. 193193 2013-03-14 15:01:36 -0700 2013-03-15 13:25:09 -0700 Patch bug-112385-20130314175732.patch text/plain 1790 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1ODA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGU2N2VkY2E0MzE0MmQ1OTNkYWU5NTQ1MzkxMjQ0NDllYzIyZjU2NmMuLmRmNjA5NTNhOGVjNDZi Njc2NWEyYWM3OTcwY2QxZGExYmQwYzY4MTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTMtMDMtMTQgIEZhZHkgU2FtdWVsICA8ZnNhbXVlbEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBGb2N1cyBQbHVnaW4gb24gVG91Y2hTdGFydAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMzg1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzcmMvV2Vi UGx1Z2luQ29udGFpbmVySW1wbC5jcHA6CisKIDIwMTMtMDMtMTQgIE1hcmphIEjDtmx0dMOkICA8 bWFyamFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtWOF0gU3RvcmUgbWFpbiB3b3JsZCBhbmQg bm9uLW1haW4gd29ybGQgdGVtcGxhdGVzIHNlcGFyYXRlbHkuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCmluZGV4IDkxMDM0 OTY0NzIwYTcyNzU5OGQ5Njc5OTYzYzIyZTA5ZmQ1MDhhZmMuLjQzYWQxYTJkZjMzODc4ZGQxNjM3 NGRlN2QzM2FlZTcxYzI1NTdhZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCkBAIC03NzAsNiArNzcwLDE1IEBAIHZv aWQgV2ViUGx1Z2luQ29udGFpbmVySW1wbDo6aGFuZGxlVG91Y2hFdmVudChUb3VjaEV2ZW50KiBl dmVudCkKICAgICAgICAgV2ViVG91Y2hFdmVudEJ1aWxkZXIgd2ViRXZlbnQodGhpcywgbV9lbGVt ZW50LT5yZW5kZXJlcigpLCAqZXZlbnQpOwogICAgICAgICBpZiAod2ViRXZlbnQudHlwZSA9PSBX ZWJJbnB1dEV2ZW50OjpVbmRlZmluZWQpCiAgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAg aWYgKGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLnRvdWNoc3RhcnRFdmVudCkgeworICAg ICAgICAgICAgRnJhbWUqIGNvbnRhaW5pbmdGcmFtZSA9IHN0YXRpY19jYXN0PEZyYW1lVmlldyo+ KHBhcmVudCgpKS0+ZnJhbWUoKTsKKyAgICAgICAgICAgIGlmIChQYWdlKiBjdXJyZW50UGFnZSA9 IGNvbnRhaW5pbmdGcmFtZS0+cGFnZSgpKQorICAgICAgICAgICAgICAgIGN1cnJlbnRQYWdlLT5m b2N1c0NvbnRyb2xsZXIoKS0+c2V0Rm9jdXNlZE5vZGUobV9lbGVtZW50LCBjb250YWluaW5nRnJh bWUpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIGNvbnRhaW5pbmdGcmFtZS0+ ZG9jdW1lbnQoKS0+c2V0Rm9jdXNlZE5vZGUobV9lbGVtZW50KTsKKyAgICAgICAgfQorCiAgICAg ICAgIFdlYkN1cnNvckluZm8gY3Vyc29ySW5mbzsKICAgICAgICAgaWYgKG1fd2ViUGx1Z2luLT5o YW5kbGVJbnB1dEV2ZW50KHdlYkV2ZW50LCBjdXJzb3JJbmZvKSkKICAgICAgICAgICAgIGV2ZW50 LT5zZXREZWZhdWx0SGFuZGxlZCgpOwo= 193366 2013-03-15 13:25:12 -0700 2013-03-15 16:03:38 -0700 Patch bug-112385-20130315162107.patch text/plain 3634 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1OTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDQ4NWJkMjE0MjZlNjkzYzZmMWVjZDRlYTc4YjJmYzAzNjc2MGIwZTYuLjJmNTAxYTJiOWU5N2Mz OTYxOTc3OTYyMjhhYTA5ZjE3NDk0M2RlZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTMtMDMtMTUgIEZhZHkgU2FtdWVsICA8ZnNhbXVlbEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBGb2N1cyBQbHVnaW4gb24gVG91Y2hTdGFydAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMzg1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KKworICAgICAgICAqIHNyYy9XZWJQbHVn aW5Db250YWluZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGx1Z2luQ29udGFpbmVy SW1wbDo6aGFuZGxlTW91c2VFdmVudCk6CisgICAgICAgICogc3JjL1dlYlBsdWdpbkNvbnRhaW5l ckltcGwuaDoKKyAgICAgICAgKFdlYlBsdWdpbkNvbnRhaW5lckltcGwpOgorCiAyMDEzLTAzLTE1 ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkLiAgUm9sbGVkIENocm9taXVtIERFUFMgdG8gcjE4ODQxOC4gIFJlcXVlc3RlZCBi eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFp bmVySW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWlu ZXJJbXBsLmNwcAppbmRleCBlY2IxYzE4OTk1OTA2YTBkZTk1NGUzNmFmMjhlMTA4YWMwZGQyYTA0 Li5iODg3OTI1MDA5NjI3MzdiY2RjYjFmNTQ5NWNlN2VkOGU2ZDA0YTU0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcApA QCAtNjUxLDEzICs2NTEsOCBAQCB2b2lkIFdlYlBsdWdpbkNvbnRhaW5lckltcGw6OmhhbmRsZU1v dXNlRXZlbnQoTW91c2VFdmVudCogZXZlbnQpCiAgICAgaWYgKHdlYkV2ZW50LnR5cGUgPT0gV2Vi SW5wdXRFdmVudDo6VW5kZWZpbmVkKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAoZXZlbnQt PnR5cGUoKSA9PSBldmVudE5hbWVzKCkubW91c2Vkb3duRXZlbnQpIHsKLSAgICAgICAgRnJhbWUq IGNvbnRhaW5pbmdGcmFtZSA9IHBhcmVudFZpZXctPmZyYW1lKCk7Ci0gICAgICAgIGlmIChQYWdl KiBjdXJyZW50UGFnZSA9IGNvbnRhaW5pbmdGcmFtZS0+cGFnZSgpKQotICAgICAgICAgICAgY3Vy cmVudFBhZ2UtPmZvY3VzQ29udHJvbGxlcigpLT5zZXRGb2N1c2VkTm9kZShtX2VsZW1lbnQsIGNv bnRhaW5pbmdGcmFtZSk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIGNvbnRhaW5pbmdGcmFt ZS0+ZG9jdW1lbnQoKS0+c2V0Rm9jdXNlZE5vZGUobV9lbGVtZW50KTsKLSAgICB9CisgICAgaWYg KGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLm1vdXNlZG93bkV2ZW50KQorICAgICAgICBm b2N1c1BsdWdpbigpOwogCiAgICAgaWYgKG1fc2Nyb2xsYmFyR3JvdXApIHsKICAgICAgICAgLy8g VGhpcyBuZWVkcyB0byBiZSBzZXQgYmVmb3JlIHRoZSBvdGhlciBjYWxsYmFja3MgaW4gdGhpcyBz Y29wZSwgc2luY2UKQEAgLTc3MCw2ICs3NjUsMTAgQEAgdm9pZCBXZWJQbHVnaW5Db250YWluZXJJ bXBsOjpoYW5kbGVUb3VjaEV2ZW50KFRvdWNoRXZlbnQqIGV2ZW50KQogICAgICAgICBXZWJUb3Vj aEV2ZW50QnVpbGRlciB3ZWJFdmVudCh0aGlzLCBtX2VsZW1lbnQtPnJlbmRlcmVyKCksICpldmVu dCk7CiAgICAgICAgIGlmICh3ZWJFdmVudC50eXBlID09IFdlYklucHV0RXZlbnQ6OlVuZGVmaW5l ZCkKICAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBpZiAoZXZlbnQtPnR5cGUoKSA9PSBl dmVudE5hbWVzKCkudG91Y2hzdGFydEV2ZW50KQorICAgICAgICAgICAgZm9jdXNQbHVnaW4oKTsK KwogICAgICAgICBXZWJDdXJzb3JJbmZvIGN1cnNvckluZm87CiAgICAgICAgIGlmIChtX3dlYlBs dWdpbi0+aGFuZGxlSW5wdXRFdmVudCh3ZWJFdmVudCwgY3Vyc29ySW5mbykpCiAgICAgICAgICAg ICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKQEAgLTgyMyw2ICs4MjIsMTUgQEAgdm9pZCBX ZWJQbHVnaW5Db250YWluZXJJbXBsOjpzeW50aGVzaXplTW91c2VFdmVudElmUG9zc2libGUoVG91 Y2hFdmVudCogZXZlbnQpCiAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOwogfQog Cit2b2lkIFdlYlBsdWdpbkNvbnRhaW5lckltcGw6OmZvY3VzUGx1Z2luKCkKK3sKKyAgICBGcmFt ZSogY29udGFpbmluZ0ZyYW1lID0gc3RhdGljX2Nhc3Q8RnJhbWVWaWV3Kj4ocGFyZW50KCkpLT5m cmFtZSgpOworICAgIGlmIChQYWdlKiBjdXJyZW50UGFnZSA9IGNvbnRhaW5pbmdGcmFtZS0+cGFn ZSgpKQorICAgICAgICBjdXJyZW50UGFnZS0+Zm9jdXNDb250cm9sbGVyKCktPnNldEZvY3VzZWRO b2RlKG1fZWxlbWVudCwgY29udGFpbmluZ0ZyYW1lKTsKKyAgICBlbHNlCisgICAgICAgIGNvbnRh aW5pbmdGcmFtZS0+ZG9jdW1lbnQoKS0+c2V0Rm9jdXNlZE5vZGUobV9lbGVtZW50KTsKK30KKwog dm9pZCBXZWJQbHVnaW5Db250YWluZXJJbXBsOjpjYWxjdWxhdGVHZW9tZXRyeShjb25zdCBJbnRS ZWN0JiBmcmFtZVJlY3QsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIEludFJlY3QmIHdpbmRvd1JlY3QsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIEludFJlY3QmIGNsaXBSZWN0LApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5oIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5oCmluZGV4IDE5ZDM5N2Qy NDdhYWQyZGU4MDM5Mzg5NDkyNWJhNmNkMDYzYjcxNWMuLmUxYjZlNzBmZTcwN2IyYjE0YmJlNTM4 ZmQ1NDNjNTY5ODY2NWNkOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlBsdWdpbkNvbnRhaW5lckltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmgKQEAgLTE3Myw2ICsxNzMsOCBAQCBwcml2YXRlOgog CiAgICAgdm9pZCBzeW50aGVzaXplTW91c2VFdmVudElmUG9zc2libGUoV2ViQ29yZTo6VG91Y2hF dmVudCopOwogCisgICAgdm9pZCBmb2N1c1BsdWdpbigpOworCiAgICAgdm9pZCBjYWxjdWxhdGVH ZW9tZXRyeShjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiBmcmFtZVJlY3QsCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICBXZWJDb3JlOjpJbnRSZWN0JiB3aW5kb3dSZWN0LAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgV2ViQ29yZTo6SW50UmVjdCYgY2xpcFJlY3QsCg==