112378 2013-03-14 12:33:24 -0700 [Chromium] Access setttings.defaultVideoPosterURL 2013-03-18 09:15:56 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 michaelbai michaelbai abarth darin dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 855424 0 michaelbai 2013-03-14 12:33:24 -0700 The defaultVideoPosterURL setting has been added in https://bugs.webkit.org/show_bug.cgi?id=110263, this added methods to access it in Chromium. 855427 1 193173 michaelbai 2013-03-14 12:38:04 -0700 Created attachment 193173 Patch 855428 2 webkit.review.bot 2013-03-14 12:39:50 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 856013 3 193316 michaelbai 2013-03-15 08:46:26 -0700 Created attachment 193316 Patch 857182 4 193316 webkit.review.bot 2013-03-18 09:15:52 -0700 Comment on attachment 193316 Patch Clearing flags on attachment: 193316 Committed r146070: <http://trac.webkit.org/changeset/146070> 857183 5 webkit.review.bot 2013-03-18 09:15:56 -0700 All reviewed patches have been landed. Closing bug. 193173 2013-03-14 12:38:04 -0700 2013-03-15 08:46:23 -0700 Patch bug-112378-20130314123400.patch text/plain 3129 michaelbai U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1ODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDYyNjA2MmRiOGY3OGZiNWI1NDg5N2ZlOWUxMWRkNDJlYWNhNWU5NjUuLjIwNjYwMzViYTQ3YmYw ZmYzN2JiYjRhNWExMzYyZmU5OGY5NDAzZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTMtMDMtMTQgIFRhbyBCYWkgIDxtaWNoYWVsYmFpQGNocm9taXVt Lm9yZz4KKworICAgICAgICBBY2Nlc3Mgc2V0dHRpbmdzLmRlZmF1bHRWaWRlb1Bvc3RlclVSTAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMzc4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGRlZmF1 bHRWaWRlb1Bvc3RlclVSTCBzZXR0aW5nIGhhcyBiZWVuIGFkZGVkIGluCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAyNjMsCisgICAgICAgIHRoaXMg YWRkZWQgbWV0aG9kcyB0byBhY2Nlc3MgaXQgaW4gQ2hyb21pdW0uCisKKyAgICAgICAgKiBwdWJs aWMvV2ViU2V0dGluZ3MuaDogYWRkIHNldERlZmF1bHRWaWRlb1Bvc3RlclVSTAorICAgICAgICAq IHNyYy9XZWJTZXR0aW5nc0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJTZXR0aW5nc0lt cGw6OnNldERlZmF1bHRWaWRlb1Bvc3RlclVSTCk6IHNldCBkZWZhdWx0VmlkZW9Qb3N0ZXJVUkwK KyAgICAgICAgKiBzcmMvV2ViU2V0dGluZ3NJbXBsLmg6IGFkZCBzZXREZWZhdWx0VmlkZW9Qb3N0 ZXJVUkwKKwogMjAxMy0wMy0xNCAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJlcGxhY2Ugc3RhdGljX2Nhc3RzIHdpdGggdG8qIGhlbHBlciBmdW5jdGlv bnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0aW5n cy5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2V0dGluZ3MuaAppbmRleCBm MTkyMGQ3MTk2NDg2ZTk2MTI3ZTQwNGY0NGM3NTRiZWYwYjU3N2M1Li42MzZmMGIzYzNjYzQ4ZmRm YWFmNTc3OGE5NGUyNzIwYjM3MmI0YzNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJTZXR0aW5ncy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYlNldHRpbmdzLmgKQEAgLTg5LDYgKzg5LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwg dm9pZCBzZXREZWZhdWx0Rm9udFNpemUoaW50KSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldERl ZmF1bHRUZXh0RW5jb2RpbmdOYW1lKGNvbnN0IFdlYlN0cmluZyYpID0gMDsKICAgICB2aXJ0dWFs IHZvaWQgc2V0RGVmYXVsdFRpbGVTaXplKFdlYlNpemUpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQg c2V0RGVmYXVsdFZpZGVvUG9zdGVyVVJMKGNvbnN0IFdlYlN0cmluZyYpID0gMDsKICAgICB2aXJ0 dWFsIHZvaWQgc2V0RGVmZXJyZWQyZENhbnZhc0VuYWJsZWQoYm9vbCkgPSAwOwogICAgIHZpcnR1 YWwgdm9pZCBzZXREZWZlcnJlZEltYWdlRGVjb2RpbmdFbmFibGVkKGJvb2wpID0gMDsKICAgICB2 aXJ0dWFsIHZvaWQgc2V0RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZChib29sKSA9IDA7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuY3BwIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcAppbmRleCAyNjRjNzU2 YThkYjljMDYxZWM1MDc4NzAyODQwNjcwMTUwM2UwN2I3Li5lOGQ3MzdhNTVkMDhiZjQyY2ZiZWM3 YWU5OGUwY2Q3Mzg0MWY4ZTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJTZXR0aW5nc0ltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlNldHRpbmdzSW1wbC5jcHAKQEAgLTExNSw2ICsxMTUsMTEgQEAgdm9pZCBXZWJTZXR0aW5nc0lt cGw6OnNldERlZmF1bHRGaXhlZEZvbnRTaXplKGludCBzaXplKQogICAgIG1fc2V0dGluZ3MtPnNl dERlZmF1bHRGaXhlZEZvbnRTaXplKHNpemUpOwogfQogCit2b2lkIFdlYlNldHRpbmdzSW1wbDo6 c2V0RGVmYXVsdFZpZGVvUG9zdGVyVVJMKGNvbnN0IFdlYlN0cmluZyYgdXJsKQoreworICAgIG1f c2V0dGluZ3MtPnNldERlZmF1bHRWaWRlb1Bvc3RlclVSTCh1cmwpOworfQorCiB2b2lkIFdlYlNl dHRpbmdzSW1wbDo6c2V0TWluaW11bUZvbnRTaXplKGludCBzaXplKQogewogICAgIG1fc2V0dGlu Z3MtPnNldE1pbmltdW1Gb250U2l6ZShzaXplKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViU2V0dGluZ3NJbXBsLmgKaW5kZXggNzJhM2UzMTI3NDExMTUzMDhkMGEwNGFlYzUxNmMx YzVhNWVlYTgxYi4uNThiN2ExYTc0ZWUzM2RkM2ExYzRiYWQ1MmZlNDNkOWE1OTNjMjA4YyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgKKysr IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgKQEAgLTgyLDYg KzgyLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXREZWZhdWx0Rm9udFNpemUoaW50 KTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0RGVmYXVsdFRleHRFbmNvZGluZ05hbWUoY29uc3QgV2Vi U3RyaW5nJik7CiAgICAgdmlydHVhbCB2b2lkIHNldERlZmF1bHRUaWxlU2l6ZShXZWJTaXplKTsK KyAgICB2aXJ0dWFsIHZvaWQgc2V0RGVmYXVsdFZpZGVvUG9zdGVyVVJMKGNvbnN0IFdlYlN0cmlu ZyYpOwogICAgIHZpcnR1YWwgdm9pZCBzZXREZWZlcnJlZDJkQ2FudmFzRW5hYmxlZChib29sKTsK ICAgICB2aXJ0dWFsIHZvaWQgc2V0RGVmZXJyZWRJbWFnZURlY29kaW5nRW5hYmxlZChib29sKTsK ICAgICB2aXJ0dWFsIHZvaWQgc2V0RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZChib29sKTsK 193316 2013-03-15 08:46:26 -0700 2013-03-18 09:15:52 -0700 Patch bug-112378-20130315084221.patch text/plain 3225 michaelbai U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGM5YzEyODYwYTUzOTQ5MWFkNGZkM2E4NWI1ODVlNjc3YTExM2M3MDMuLjc4ZWIzZWI5OGYyNjJh N2Y5ZWNhOGU4NmFiYTMzZjA4N2ZjMjdlNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTMtMDMtMTQgIFRhbyBCYWkgIDxtaWNoYWVsYmFpQGNocm9taXVt Lm9yZz4KKworICAgICAgICBBY2Nlc3Mgc2V0dGluZ3MuZGVmYXVsdFZpZGVvUG9zdGVyVVJMCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIzNzgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZGVmYXVs dFZpZGVvUG9zdGVyVVJMIHNldHRpbmcgaGFzIGJlZW4gYWRkZWQgaW4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDI2MywKKyAgICAgICAgdGhpcyBh ZGRlZCBtZXRob2RzIHRvIGFjY2VzcyBpdCBpbiBDaHJvbWl1bS4KKyAgICAgICAgVGhlIHNldHRp bmdzIHdpbGwgYmUgdXNlZCBieSBBbmRyb2lkIFdlYlZpZXcgQVBJCisgICAgICAgIFdlYkNocm9t ZUNsaWVudC5nZXREZWZhdWx0VmlkZW9Qb3N0ZXIoKQorCisgICAgICAgICogcHVibGljL1dlYlNl dHRpbmdzLmg6IGFkZCBzZXREZWZhdWx0VmlkZW9Qb3N0ZXJVUkwKKyAgICAgICAgKiBzcmMvV2Vi U2V0dGluZ3NJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViU2V0dGluZ3NJbXBsOjpzZXRE ZWZhdWx0VmlkZW9Qb3N0ZXJVUkwpOiBzZXQgZGVmYXVsdFZpZGVvUG9zdGVyVVJMCisgICAgICAg ICogc3JjL1dlYlNldHRpbmdzSW1wbC5oOiBhZGQgc2V0RGVmYXVsdFZpZGVvUG9zdGVyVVJMCisK IDIwMTMtMDMtMTUgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNDU4MDIuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0aW5ncy5oIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViU2V0dGluZ3MuaAppbmRleCAxMjQ2YzRjOTQ4MzEyZDQ1NDkw ZDM0OTAxYThiMjI1ZTViNmNmMTYxLi4zZTViZjExNjEyMTRjNTAzZmU1MDEyZGRjYzQ5NjlmMjVm Yzc1Y2Y1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0 aW5ncy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNldHRpbmdzLmgK QEAgLTg5LDYgKzg5LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXREZWZhdWx0Rm9u dFNpemUoaW50KSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldERlZmF1bHRUZXh0RW5jb2RpbmdO YW1lKGNvbnN0IFdlYlN0cmluZyYpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0RGVmYXVsdFRp bGVTaXplKFdlYlNpemUpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0RGVmYXVsdFZpZGVvUG9z dGVyVVJMKGNvbnN0IFdlYlN0cmluZyYpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0RGVmZXJy ZWQyZENhbnZhc0VuYWJsZWQoYm9vbCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXREZWZlcnJl ZEltYWdlRGVjb2RpbmdFbmFibGVkKGJvb2wpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0RGV2 ZWxvcGVyRXh0cmFzRW5hYmxlZChib29sKSA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcAppbmRleCA2NmVmNTFhMzM2MTNlOWZjMTk0OTk1MWRl M2ZiNTcxZGI0NTRmMWU5Li42MTA2NjcxZGE5N2RhNTNhMmVhN2U3MWYxYTA4M2MxZmI1OTVkNTU5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5jcHAK QEAgLTExNSw2ICsxMTUsMTEgQEAgdm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldERlZmF1bHRGaXhl ZEZvbnRTaXplKGludCBzaXplKQogICAgIG1fc2V0dGluZ3MtPnNldERlZmF1bHRGaXhlZEZvbnRT aXplKHNpemUpOwogfQogCit2b2lkIFdlYlNldHRpbmdzSW1wbDo6c2V0RGVmYXVsdFZpZGVvUG9z dGVyVVJMKGNvbnN0IFdlYlN0cmluZyYgdXJsKQoreworICAgIG1fc2V0dGluZ3MtPnNldERlZmF1 bHRWaWRlb1Bvc3RlclVSTCh1cmwpOworfQorCiB2b2lkIFdlYlNldHRpbmdzSW1wbDo6c2V0TWlu aW11bUZvbnRTaXplKGludCBzaXplKQogewogICAgIG1fc2V0dGluZ3MtPnNldE1pbmltdW1Gb250 U2l6ZShzaXplKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNl dHRpbmdzSW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBs LmgKaW5kZXggYWQyYzkzZmNmZTlkZTBkN2FjZjdhZWRkNTlmOGFiYTU5YWNjNjY1My4uNDIxOGMy NjhkODJjYjBkZWY2ZTlhYTUxZDcxZDllZDViNzUxZDAzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgKQEAgLTgyLDYgKzgyLDcgQEAgcHVibGljOgog ICAgIHZpcnR1YWwgdm9pZCBzZXREZWZhdWx0Rm9udFNpemUoaW50KTsKICAgICB2aXJ0dWFsIHZv aWQgc2V0RGVmYXVsdFRleHRFbmNvZGluZ05hbWUoY29uc3QgV2ViU3RyaW5nJik7CiAgICAgdmly dHVhbCB2b2lkIHNldERlZmF1bHRUaWxlU2l6ZShXZWJTaXplKTsKKyAgICB2aXJ0dWFsIHZvaWQg c2V0RGVmYXVsdFZpZGVvUG9zdGVyVVJMKGNvbnN0IFdlYlN0cmluZyYpOwogICAgIHZpcnR1YWwg dm9pZCBzZXREZWZlcnJlZDJkQ2FudmFzRW5hYmxlZChib29sKTsKICAgICB2aXJ0dWFsIHZvaWQg c2V0RGVmZXJyZWRJbWFnZURlY29kaW5nRW5hYmxlZChib29sKTsKICAgICB2aXJ0dWFsIHZvaWQg c2V0RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZChib29sKTsK