112365 2013-03-14 10:50:07 -0700 [BlackBerry] Enable USE_SYSTEM_MALLOC by default 2013-03-19 10:55:01 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned benjamin cgarcia cmarcelo dbates ojan.autocc webkit.review.bot xan.lopez oldest_to_newest 855319 0 berto 2013-03-14 10:50:07 -0700 I'm getting lots of these otherwise: In file included from /home/berto/devel/code/webkit/Source/WTF/config.h:30:0, from /home/berto/devel/code/webkit/Source/WTF/wtf/HashTable.cpp:20: /home/berto/devel/code/webkit/Source/WTF/wtf/Platform.h:501:0: warning: "USE_SYSTEM_MALLOC" redefined [enabled by default] /home/berto/devel/code/webkit/WebKitBuild/armle-v7/Release/cmakeconfig.h:131:0: note: this is the location of the previous definition 855322 1 193150 berto 2013-03-14 10:52:23 -0700 Created attachment 193150 Patch 857289 2 193600 berto 2013-03-18 10:44:43 -0700 Created attachment 193600 Patch Since there's the build option to enable/disable it, we don't need to hardcode its value in wtf/Platform.h 857409 3 193600 benjamin 2013-03-18 12:20:03 -0700 Comment on attachment 193600 Patch I guess you only build with build-webkit? 858101 4 berto 2013-03-19 03:03:26 -0700 (In reply to comment #3) > (From update of attachment 193600 [details]) > I guess you only build with build-webkit? Exactly 858470 5 193600 webkit.review.bot 2013-03-19 10:54:58 -0700 Comment on attachment 193600 Patch Clearing flags on attachment: 193600 Committed r146222: <http://trac.webkit.org/changeset/146222> 858471 6 webkit.review.bot 2013-03-19 10:55:01 -0700 All reviewed patches have been landed. Closing bug. 193150 2013-03-14 10:52:23 -0700 2013-03-18 10:44:43 -0700 Patch 112365.diff text/plain 1321 berto ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiZDky MDE1Li41ZTMzOTJlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDMtMTQgIEFsYmVydG8gR2FyY2lhICA8YWdh cmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBFbmFibGUgVVNFX1NZU1RF TV9NQUxMT0MgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTEyMzY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG06CisKIDIwMTMt MDMtMTQgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5AZGlnaWEuY29tPgogCiAgICAg ICAgIFtRdF0gRGlzYWJsZSBEUlQgb24gV2luZG93cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0Zl YXR1cmVMaXN0LnBtCmluZGV4IDc3ODY1OTUuLjFkN2E1OTYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHBlcmwvRmVhdHVyZUxpc3QucG0KQEAgLTQyOSw3ICs0MjksNyBAQCBteSBAZmVhdHVyZXMgPSAo CiAgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9TVkdfRk9OVFMiLCBkZWZhdWx0ID0+IDEsIHZhbHVl ID0+IFwkc3ZnRm9udHNTdXBwb3J0IH0sCiAKICAgICB7IG9wdGlvbiA9PiAic3lzdGVtLW1hbGxv YyIsIGRlc2MgPT4gIlRvZ2dsZSBzeXN0ZW0gYWxsb2NhdG9yIGluc3RlYWQgb2YgVENtYWxsb2Mi LAotICAgICAgZGVmaW5lID0+ICJVU0VfU1lTVEVNX01BTExPQyIsIGRlZmF1bHQgPT4gaXNXaW5D RSgpLCB2YWx1ZSA9PiBcJHN5c3RlbU1hbGxvY1N1cHBvcnQgfSwKKyAgICAgIGRlZmluZSA9PiAi VVNFX1NZU1RFTV9NQUxMT0MiLCBkZWZhdWx0ID0+IChpc0JsYWNrQmVycnkoKSB8fCBpc1dpbkNF KCkpLCB2YWx1ZSA9PiBcJHN5c3RlbU1hbGxvY1N1cHBvcnQgfSwKIAogICAgIHsgb3B0aW9uID0+ ICJ0ZW1wbGF0ZS1lbGVtZW50IiwgZGVzYyA9PiAiVG9nZ2xlIEhUTUxUZW1wbGF0ZUVsZW1lbnQg c3VwcG9ydCIsCiAgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9URU1QTEFURV9FTEVNRU5UIiwgZGVm YXVsdCA9PiAoaXNFZmwoKSB8fCBpc0d0aygpKSwgdmFsdWUgPT4gXCR0ZW1wbGF0ZUVsZW1lbnRT dXBwb3J0IH0sCg== 193600 2013-03-18 10:44:43 -0700 2013-03-19 10:54:57 -0700 Patch 112365.diff text/plain 2485 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZjUwOTJiNS4uODk4MDUyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wMy0xOCAg QWxiZXJ0byBHYXJjaWEgIDxhZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVy cnldIEVuYWJsZSBVU0VfU1lTVEVNX01BTExPQyBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIzNjUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgVVNFX1NZU1RFTV9NQUxMT0Mg YnkgZGVmYXVsdCB2aWEgRmVhdHVyZUxpc3QucG0gaW5zdGVhZCBvZgorICAgICAgICBoYXJjb2Rp bmcgaXQgaW4gd3RmL1BsYXRmb3JtLmgKKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAy MDEzLTAzLTE1ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFtpT1NdIFVwZGF0ZSBTdHJpbmdJbXBsJ3MgZXF1YWwgdG8gaGF2ZSBhIHNpbmdsZSB2ZXJz aW9uIG9uIGFsbCBzdXBwb3J0ZWQgQXBwbGUgQ1BVcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvUGxhdGZvcm0uaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKaW5kZXggZDEzMTg0ZC4u OTM1MjEyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3Vy Y2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCkBAIC00OTcsMTAgKzQ5Nyw2IEBACiAjZW5kaWYKICNlbmRp ZgogCi0jaWYgT1MoUU5YKQotI2RlZmluZSBVU0VfU1lTVEVNX01BTExPQyAxCi0jZW5kaWYKLQog I2lmIFBMQVRGT1JNKEJMQUNLQkVSUlkpCiAjZGVmaW5lIFdURl9VU0VfU0tJQSAxCiAjZGVmaW5l IFdURl9VU0VfTE9XX1FVQUxJVFlfSU1BR0VfSU5URVJQT0xBVElPTiAxCmRpZmYgLS1naXQgYS9U b29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWFkN2M0OC4uNjFhOGM1YSAx MDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDEzLTAzLTE4ICBBbGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNv bT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRW5hYmxlIFVTRV9TWVNURU1fTUFMTE9DIGJ5IGRl ZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx MjM2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVu YWJsZSBVU0VfU1lTVEVNX01BTExPQyBieSBkZWZhdWx0IHZpYSBGZWF0dXJlTGlzdC5wbSBpbnN0 ZWFkIG9mCisgICAgICAgIGhhcmNvZGluZyBpdCBpbiB3dGYvUGxhdGZvcm0uaAorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtOgorCiAyMDEzLTAzLTE3ICBNb3J0 ZW4gU3RlbnNob3JuZSAgPG1zdGVuc2hvQG9wZXJhLmNvbT4KIAogICAgICAgICBBZGQgcmVsb2Fk IGJ1dHRvbiAoYW5kIEY1IGFjY2VsZXJhdG9yKSB0byB0aGUgR3RrTGF1bmNoZXIgdG9vbGJhcgpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtIGIvVG9v bHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtCmluZGV4IDc3ODY1OTUuLjFkN2E1 OTYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG0KQEAgLTQyOSw3ICs0 MjksNyBAQCBteSBAZmVhdHVyZXMgPSAoCiAgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9TVkdfRk9O VFMiLCBkZWZhdWx0ID0+IDEsIHZhbHVlID0+IFwkc3ZnRm9udHNTdXBwb3J0IH0sCiAKICAgICB7 IG9wdGlvbiA9PiAic3lzdGVtLW1hbGxvYyIsIGRlc2MgPT4gIlRvZ2dsZSBzeXN0ZW0gYWxsb2Nh dG9yIGluc3RlYWQgb2YgVENtYWxsb2MiLAotICAgICAgZGVmaW5lID0+ICJVU0VfU1lTVEVNX01B TExPQyIsIGRlZmF1bHQgPT4gaXNXaW5DRSgpLCB2YWx1ZSA9PiBcJHN5c3RlbU1hbGxvY1N1cHBv cnQgfSwKKyAgICAgIGRlZmluZSA9PiAiVVNFX1NZU1RFTV9NQUxMT0MiLCBkZWZhdWx0ID0+IChp c0JsYWNrQmVycnkoKSB8fCBpc1dpbkNFKCkpLCB2YWx1ZSA9PiBcJHN5c3RlbU1hbGxvY1N1cHBv cnQgfSwKIAogICAgIHsgb3B0aW9uID0+ICJ0ZW1wbGF0ZS1lbGVtZW50IiwgZGVzYyA9PiAiVG9n Z2xlIEhUTUxUZW1wbGF0ZUVsZW1lbnQgc3VwcG9ydCIsCiAgICAgICBkZWZpbmUgPT4gIkVOQUJM RV9URU1QTEFURV9FTEVNRU5UIiwgZGVmYXVsdCA9PiAoaXNFZmwoKSB8fCBpc0d0aygpKSwgdmFs dWUgPT4gXCR0ZW1wbGF0ZUVsZW1lbnRTdXBwb3J0IH0sCg==