112358 2013-03-14 10:11:04 -0700 [GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)" 2013-03-14 11:39:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 calvaris calvaris philn webkit.review.bot oldest_to_newest 855280 0 calvaris 2013-03-14 10:11:04 -0700 [GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)" 855282 1 193144 calvaris 2013-03-14 10:12:00 -0700 Created attachment 193144 Patch Guarding with #if ENABLE(VIDEO). 855287 2 193144 pnormand 2013-03-14 10:17:22 -0700 Comment on attachment 193144 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193144&action=review Looks good! But please provide a changelog > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Missing change explanation... 855290 3 193145 calvaris 2013-03-14 10:23:31 -0700 Created attachment 193145 Patch Clarified changelog. 855294 4 193145 pnormand 2013-03-14 10:26:57 -0700 Comment on attachment 193145 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193145&action=review > Source/WebCore/ChangeLog:9 > + Guarded with ENABLE(VIDEO) to prevent problems when it is not > + enabled. > + > + Reviewed by NOBODY (OOPS!). Reviewed by usually goes before the explanation. 855367 5 193145 webkit.review.bot 2013-03-14 11:39:40 -0700 Comment on attachment 193145 Patch Clearing flags on attachment: 193145 Committed r145831: <http://trac.webkit.org/changeset/145831> 855368 6 webkit.review.bot 2013-03-14 11:39:43 -0700 All reviewed patches have been landed. Closing bug. 193144 2013-03-14 10:12:00 -0700 2013-03-14 10:23:27 -0700 Patch bug-112358-20130314180755.patch text/plain 2662 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1ODExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkyMzQ1ZTQ5ZWRlODA2 ODI3OTIwNTNiMzY5NzczNWNhNjQ4M2VjNy4uZjRlYzNjMGJhNTYzYWQyZTE2NjFmODJjMmQ1ZmFi ZjJlNjE5MGU4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDEyIEBACiAyMDEzLTAzLTE0ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CiAKKyAgICAgICAgW0dT dHJlYW1lcl0gc2ltdWxhdGVBdWRpb0ludGVycnVwdGlvbiBuZWVkcyB0byBiZSBndWFyZGVkIGJ5 IEVOQUJMRShWSURFTykiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTIzNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor MjAxMy0wMy0xNCAgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2FsaWEuY29t PgorCiAgICAgICAgIFtHU3RyZWFtZXJdIFN0b3BwaW5nIHBsYXliYWNrIG9mIGh0bWw1IG1lZGlh IHdoZW4gcmVjZWl2aW5nIGEgaGlnaGVyIHByaW9yaXR5IGF1ZGlvIGV2ZW50IG5lZWRzIGltcGxl bWVudGF0aW9uCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05MTYxMQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5j cHAgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKaW5kZXggMGMyNGZiMmMz MTMyMTRjMzE3NDIxYWQ2MmM4YmUzMzczOGE1NzYyMi4uODUyMGQ5YjgwMTkyNTRiNDBiYWUzZmM5 MWE4MDRkOGJjZTk0ZGNmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRl cm5hbHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcApAQCAt NTEsNyArNTEsOSBAQAogI2luY2x1ZGUgIkZyYW1lVmlldy5oIgogI2luY2x1ZGUgIkhUTUxDb250 ZW50RWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxJbnB1dEVsZW1lbnQuaCIKKyNpZiBFTkFCTEUo VklERU8pCiAjaW5jbHVkZSAiSFRNTE1lZGlhRWxlbWVudC5oIgorI2VuZGlmCiAjaW5jbHVkZSAi SFRNTE5hbWVzLmgiCiAjaW5jbHVkZSAiSFRNTFRleHRBcmVhRWxlbWVudC5oIgogI2luY2x1ZGUg Ikhpc3RvcnlJdGVtLmgiCkBAIC0yMDcyLDYgKzIwNzQsNyBAQCBTdHJpbmcgSW50ZXJuYWxzOjpn ZXRJbWFnZVNvdXJjZVVSTChFbGVtZW50KiBlbGVtZW50LCBFeGNlcHRpb25Db2RlJiBlYykKICAg ICByZXR1cm4gZWxlbWVudC0+aW1hZ2VTb3VyY2VVUkwoKTsKIH0KIAorI2lmIEVOQUJMRShWSURF TykKIHZvaWQgSW50ZXJuYWxzOjpzaW11bGF0ZUF1ZGlvSW50ZXJydXB0aW9uKE5vZGUqIG5vZGUp CiB7CiAjaWYgVVNFKEdTVFJFQU1FUikKQEAgLTIwODEsNSArMjA4NCw2IEBAIHZvaWQgSW50ZXJu YWxzOjpzaW11bGF0ZUF1ZGlvSW50ZXJydXB0aW9uKE5vZGUqIG5vZGUpCiAgICAgVU5VU0VEX1BB UkFNKG5vZGUpOwogI2VuZGlmCiB9CisjZW5kaWYKIAogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJu YWxzLmgKaW5kZXggM2ZkYjNiY2Y1MjQzZDdmYTA3ODI5OTFhZjc5Y2E3NDdlMzVmMTY5MC4uZmMx OGMzN2I1ZGIzOTAwNGQ1MWI1NzZkM2Q3MTQ5ZjNjZmE0MjRkMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5n L0ludGVybmFscy5oCkBAIC0yOTksOCArMjk5LDEwIEBAIHB1YmxpYzoKICNlbmRpZgogCiAgICAg U3RyaW5nIGdldEltYWdlU291cmNlVVJMKEVsZW1lbnQqLCBFeGNlcHRpb25Db2RlJik7Ci0gICAg ICAgICAgICAgICAgICAgIAorCisjaWYgRU5BQkxFKFZJREVPKQogICAgIHZvaWQgc2ltdWxhdGVB dWRpb0ludGVycnVwdGlvbihOb2RlKik7CisjZW5kaWYKIAogcHJpdmF0ZToKICAgICBleHBsaWNp dCBJbnRlcm5hbHMoRG9jdW1lbnQqKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3Rp bmcvSW50ZXJuYWxzLmlkbCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmlkbApp bmRleCAzNjIwZDBlZTUxN2Q5YmM5Nzk3NWRmMDhmYTAxNGIxYzI3OWM4OTJlLi5hZGViMTAwYzBi YzY0NTczNGQxNzA4OGE3MzMzN2FlOGZhNjA1MzlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS90ZXN0aW5nL0ludGVybmFscy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRl cm5hbHMuaWRsCkBAIC0yNTksNyArMjU5LDcgQEAKIAogICAgIHZvaWQgZm9yY2VSZWxvYWQoaW4g Ym9vbGVhbiBlbmRUb0VuZCk7CiAKLSAgICB2b2lkIHNpbXVsYXRlQXVkaW9JbnRlcnJ1cHRpb24o aW4gTm9kZSBub2RlKTsKKyAgICBbQ29uZGl0aW9uYWw9VklERU9dIHZvaWQgc2ltdWxhdGVBdWRp b0ludGVycnVwdGlvbihpbiBOb2RlIG5vZGUpOwogCiAgICAgW0NvbmRpdGlvbmFsPUVOQ1JZUFRF RF9NRURJQV9WMl0gdm9pZCBpbml0aWFsaXplTW9ja0NETSgpOwogCg== 193145 2013-03-14 10:23:31 -0700 2013-03-14 11:39:40 -0700 Patch bug-112358-20130314181927.patch text/plain 2753 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1ODExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkyMzQ1ZTQ5ZWRlODA2 ODI3OTIwNTNiMzY5NzczNWNhNjQ4M2VjNy4uZjMyMWI0ZjQ1MThmNjhjOTNkYzVhMjJlY2Y3OTEz MjZiNjhkNWE2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDEzLTAzLTE0ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CiAKKyAgICAgICAgW0dT dHJlYW1lcl0gc2ltdWxhdGVBdWRpb0ludGVycnVwdGlvbiBuZWVkcyB0byBiZSBndWFyZGVkIGJ5 IEVOQUJMRShWSURFTykiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTIzNTgKKworICAgICAgICBHdWFyZGVkIHdpdGggRU5BQkxFKFZJREVPKSB0byBw cmV2ZW50IHByb2JsZW1zIHdoZW4gaXQgaXMgbm90CisgICAgICAgIGVuYWJsZWQuCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKzIwMTMtMDMtMTQgIFhhYmllciBSb2Ry aWd1ZXogQ2FsdmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1N0cmVhbWVy XSBTdG9wcGluZyBwbGF5YmFjayBvZiBodG1sNSBtZWRpYSB3aGVuIHJlY2VpdmluZyBhIGhpZ2hl ciBwcmlvcml0eSBhdWRpbyBldmVudCBuZWVkcyBpbXBsZW1lbnRhdGlvbgogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE2MTEKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwIGIvU291cmNlL1dlYkNvcmUvdGVz dGluZy9JbnRlcm5hbHMuY3BwCmluZGV4IDBjMjRmYjJjMzEzMjE0YzMxNzQyMWFkNjJjOGJlMzM3 MzhhNTc2MjIuLjg1MjBkOWI4MDE5MjU0YjQwYmFlM2ZjOTFhODA0ZDhiY2U5NGRjZjQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKQEAgLTUxLDcgKzUxLDkgQEAKICNpbmNsdWRl ICJGcmFtZVZpZXcuaCIKICNpbmNsdWRlICJIVE1MQ29udGVudEVsZW1lbnQuaCIKICNpbmNsdWRl ICJIVE1MSW5wdXRFbGVtZW50LmgiCisjaWYgRU5BQkxFKFZJREVPKQogI2luY2x1ZGUgIkhUTUxN ZWRpYUVsZW1lbnQuaCIKKyNlbmRpZgogI2luY2x1ZGUgIkhUTUxOYW1lcy5oIgogI2luY2x1ZGUg IkhUTUxUZXh0QXJlYUVsZW1lbnQuaCIKICNpbmNsdWRlICJIaXN0b3J5SXRlbS5oIgpAQCAtMjA3 Miw2ICsyMDc0LDcgQEAgU3RyaW5nIEludGVybmFsczo6Z2V0SW1hZ2VTb3VyY2VVUkwoRWxlbWVu dCogZWxlbWVudCwgRXhjZXB0aW9uQ29kZSYgZWMpCiAgICAgcmV0dXJuIGVsZW1lbnQtPmltYWdl U291cmNlVVJMKCk7CiB9CiAKKyNpZiBFTkFCTEUoVklERU8pCiB2b2lkIEludGVybmFsczo6c2lt dWxhdGVBdWRpb0ludGVycnVwdGlvbihOb2RlKiBub2RlKQogewogI2lmIFVTRShHU1RSRUFNRVIp CkBAIC0yMDgxLDUgKzIwODQsNiBAQCB2b2lkIEludGVybmFsczo6c2ltdWxhdGVBdWRpb0ludGVy cnVwdGlvbihOb2RlKiBub2RlKQogICAgIFVOVVNFRF9QQVJBTShub2RlKTsKICNlbmRpZgogfQor I2VuZGlmCiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxz LmggYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5oCmluZGV4IDNmZGIzYmNmNTI0 M2Q3ZmEwNzgyOTkxYWY3OWNhNzQ3ZTM1ZjE2OTAuLmZjMThjMzdiNWRiMzkwMDRkNTFiNTc2ZDNk NzE0OWYzY2ZhNDI0ZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJu YWxzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaApAQCAtMjk5LDgg KzI5OSwxMCBAQCBwdWJsaWM6CiAjZW5kaWYKIAogICAgIFN0cmluZyBnZXRJbWFnZVNvdXJjZVVS TChFbGVtZW50KiwgRXhjZXB0aW9uQ29kZSYpOwotICAgICAgICAgICAgICAgICAgICAKKworI2lm IEVOQUJMRShWSURFTykKICAgICB2b2lkIHNpbXVsYXRlQXVkaW9JbnRlcnJ1cHRpb24oTm9kZSop OworI2VuZGlmCiAKIHByaXZhdGU6CiAgICAgZXhwbGljaXQgSW50ZXJuYWxzKERvY3VtZW50Kik7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5pZGwgYi9Tb3Vy Y2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5pZGwKaW5kZXggMzYyMGQwZWU1MTdkOWJjOTc5 NzVkZjA4ZmEwMTRiMWMyNzljODkyZS4uYWRlYjEwMGMwYmM2NDU3MzRkMTcwODhhNzMzMzdhZThm YTYwNTM5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaWRs CisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmlkbApAQCAtMjU5LDcgKzI1 OSw3IEBACiAKICAgICB2b2lkIGZvcmNlUmVsb2FkKGluIGJvb2xlYW4gZW5kVG9FbmQpOwogCi0g ICAgdm9pZCBzaW11bGF0ZUF1ZGlvSW50ZXJydXB0aW9uKGluIE5vZGUgbm9kZSk7CisgICAgW0Nv bmRpdGlvbmFsPVZJREVPXSB2b2lkIHNpbXVsYXRlQXVkaW9JbnRlcnJ1cHRpb24oaW4gTm9kZSBu b2RlKTsKIAogICAgIFtDb25kaXRpb25hbD1FTkNSWVBURURfTUVESUFfVjJdIHZvaWQgaW5pdGlh bGl6ZU1vY2tDRE0oKTsKIAo=