112351 2013-03-14 08:28:44 -0700 Web Inspector: nuke bottom up CPU profile calculation on backend 2013-03-14 09:17:17 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys abarth apavlov graouts haraken japhet joepeck keishi loislo pfeldman pmuellr timothy vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 855210 0 yurys 2013-03-14 08:28:44 -0700 Bottom-up CPU profile is calculated on the front-end base on the top-down profile. No need to do the work twice. 855214 1 193126 yurys 2013-03-14 08:30:49 -0700 Created attachment 193126 Patch 855243 2 193126 webkit.review.bot 2013-03-14 09:17:13 -0700 Comment on attachment 193126 Patch Clearing flags on attachment: 193126 Committed r145819: <http://trac.webkit.org/changeset/145819> 855244 3 webkit.review.bot 2013-03-14 09:17:17 -0700 All reviewed patches have been landed. Closing bug. 193126 2013-03-14 08:30:49 -0700 2013-03-14 09:17:13 -0700 Patch bug-112351-20130314192645.patch text/plain 5750 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1ODExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkyMzQ1ZTQ5ZWRlODA2 ODI3OTIwNTNiMzY5NzczNWNhNjQ4M2VjNy4uMDQ4MWNlYjFjYWMzODdhZDdiZmQ3ZjcxMWIwZGFi Y2NmMDMxMjQyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTAzLTE0ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IG51a2UgYm90dG9tIHVwIENQVSBwcm9maWxlIGNhbGN1bGF0aW9uIG9uIGJhY2tlbmQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjM1MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgY29k ZSB0aGF0IGJ1aWxkcyBib3R0b20tdXAgQ1BVIHByb2ZpbGUgb24gdGhlIGluc3BlY3RvcgorICAg ICAgICBiYWNrZW5kLiBCb3R0b20tdXAgdmlldyBpcyBhbHJlYWR5IGJ1aWx0IG9uIHRoZSBmcm9u dC1lbmQgZnJvbQorICAgICAgICB0aGUgdG9wLWRvd24gcHJvZmlsZSBkYXRhLgorCisgICAgICAg ICogYmluZGluZ3MvanMvU2NyaXB0UHJvZmlsZS5jcHA6CisgICAgICAgICogYmluZGluZ3MvanMv U2NyaXB0UHJvZmlsZS5oOgorICAgICAgICAoU2NyaXB0UHJvZmlsZSk6CisgICAgICAgICogYmlu ZGluZ3MvdjgvU2NyaXB0UHJvZmlsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRQcm9m aWxlOjpidWlsZEluc3BlY3Rvck9iamVjdEZvckhlYWQpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4 L1NjcmlwdFByb2ZpbGUuaDoKKyAgICAgICAgKFNjcmlwdFByb2ZpbGUpOgorICAgICAgICAqIGlu c3BlY3Rvci9JbnNwZWN0b3IuanNvbjoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yUHJv ZmlsZXJBZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JQcm9maWxlckFnZW50 OjpnZXRDUFVQcm9maWxlKToKKwogMjAxMy0wMy0xNCAgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIg IDxjYWx2YXJpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIFN0b3BwaW5nIHBs YXliYWNrIG9mIGh0bWw1IG1lZGlhIHdoZW4gcmVjZWl2aW5nIGEgaGlnaGVyIHByaW9yaXR5IGF1 ZGlvIGV2ZW50IG5lZWRzIGltcGxlbWVudGF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9TY3JpcHRQcm9maWxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL1NjcmlwdFByb2ZpbGUuY3BwCmluZGV4IDcwNjFkZWZkNjk2MGYyZTZiYzUyZWRmNWZmOGRi OWEyZDcxNjcyOTQuLjkxZGQzZDM2ZGE3ZGYwZGY5YzMzN2QxY2MxMGQ5ODNlNzhjMzY4Y2UgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFByb2ZpbGUuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFByb2ZpbGUuY3BwCkBAIC02OCwx MyArNjgsNiBAQCBTY3JpcHRQcm9maWxlTm9kZSogU2NyaXB0UHJvZmlsZTo6aGVhZCgpIGNvbnN0 CiAgICAgcmV0dXJuIG1fcHJvZmlsZS0+aGVhZCgpOwogfQogCi1QYXNzUmVmUHRyPFNjcmlwdFBy b2ZpbGVOb2RlPiBTY3JpcHRQcm9maWxlOjpib3R0b21VcEhlYWQoKSBjb25zdAotewotICAgIC8v IEZJWE1FOiBpbXBsZW1lbnQgYnVpbGRpbmcgYm90dG9tLXVwIHByb2ZpbGVzIGluIEMrKyBjb2Rl LAotICAgIC8vIGJ1dCBjb25zaWRlciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjQ2MDQKLSAgICByZXR1cm4gMDsKLX0KLQogZG91YmxlIFNjcmlwdFByb2ZpbGU6Omlk bGVUaW1lKCkgY29uc3QKIHsKICAgICByZXR1cm4gMC4wOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvU2NyaXB0UHJvZmlsZS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvU2NyaXB0UHJvZmlsZS5oCmluZGV4IDI3NTUzZGUyNmVhZTJjMGU5NWNkYjY3M2E3Yzc3 ZWVhMTRiMzllNjkuLjgwOTVmZTg3YTRlYWVlNmRmMWZhYjk1YTNiOGMxMWU4N2FhYTkwZDEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFByb2ZpbGUuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRQcm9maWxlLmgKQEAgLTU0LDcgKzU0 LDYgQEAgcHVibGljOgogICAgIFN0cmluZyB0aXRsZSgpIGNvbnN0OwogICAgIHVuc2lnbmVkIGlu dCB1aWQoKSBjb25zdDsKICAgICBTY3JpcHRQcm9maWxlTm9kZSogaGVhZCgpIGNvbnN0OwotICAg IFBhc3NSZWZQdHI8U2NyaXB0UHJvZmlsZU5vZGU+IGJvdHRvbVVwSGVhZCgpIGNvbnN0OwogICAg IGRvdWJsZSBpZGxlVGltZSgpIGNvbnN0OwogCiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGUuY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZS5jcHAKaW5kZXggMjU1YjZlMjg4 MjNiMTJlZWZhZjA0OTk2ZWFkNGZjOWFjMDk0NzlkOS4uNTRmZTU0MmIxNjk3OTFiOTMzMmY1YjNi MzIxODY4ZjkwMWM0ZGVmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv U2NyaXB0UHJvZmlsZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0 UHJvZmlsZS5jcHAKQEAgLTYwLDExICs2MCw2IEBAIFBhc3NSZWZQdHI8U2NyaXB0UHJvZmlsZU5v ZGU+IFNjcmlwdFByb2ZpbGU6OmhlYWQoKSBjb25zdAogICAgIHJldHVybiBTY3JpcHRQcm9maWxl Tm9kZTo6Y3JlYXRlKG1fcHJvZmlsZS0+R2V0VG9wRG93blJvb3QoKSk7CiB9CiAKLVBhc3NSZWZQ dHI8U2NyaXB0UHJvZmlsZU5vZGU+IFNjcmlwdFByb2ZpbGU6OmJvdHRvbVVwSGVhZCgpIGNvbnN0 Ci17Ci0gICAgcmV0dXJuIFNjcmlwdFByb2ZpbGVOb2RlOjpjcmVhdGUobV9wcm9maWxlLT5HZXRC b3R0b21VcFJvb3QoKSk7Ci19Ci0KIGRvdWJsZSBTY3JpcHRQcm9maWxlOjppZGxlVGltZSgpIGNv bnN0CiB7CiAgICAgcmV0dXJuIG1faWRsZVRpbWU7CkBAIC05OSwxMSArOTQsNiBAQCBQYXNzUmVm UHRyPFR5cGVCdWlsZGVyOjpQcm9maWxlcjo6Q1BVUHJvZmlsZU5vZGU+IFNjcmlwdFByb2ZpbGU6 OmJ1aWxkSW5zcGVjdG9yTwogewogICAgIHJldHVybiBidWlsZEluc3BlY3Rvck9iamVjdEZvciht X3Byb2ZpbGUtPkdldFRvcERvd25Sb290KCkpOwogfQotCi1QYXNzUmVmUHRyPFR5cGVCdWlsZGVy OjpQcm9maWxlcjo6Q1BVUHJvZmlsZU5vZGU+IFNjcmlwdFByb2ZpbGU6OmJ1aWxkSW5zcGVjdG9y T2JqZWN0Rm9yQm90dG9tVXBIZWFkKCkgY29uc3QKLXsKLSAgICByZXR1cm4gYnVpbGRJbnNwZWN0 b3JPYmplY3RGb3IobV9wcm9maWxlLT5HZXRCb3R0b21VcFJvb3QoKSk7Ci19CiAjZW5kaWYKIAog fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvU2NyaXB0UHJvZmlsZS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0 UHJvZmlsZS5oCmluZGV4IGExNTc4MjNjM2Y5NmI3MWM3OTUwMjU0M2M3NDFlYjFiN2RiMzVlNzAu LmJkY2NmZDM5MTI4ZDAxMGZjZWFlZTc0ODNlOWE0MjQ0ODM2YWI5Y2YgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGUuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlLmgKQEAgLTYwLDEyICs2MCwxMCBAQCBwdWJs aWM6CiAgICAgU3RyaW5nIHRpdGxlKCkgY29uc3Q7CiAgICAgdW5zaWduZWQgaW50IHVpZCgpIGNv bnN0OwogICAgIFBhc3NSZWZQdHI8U2NyaXB0UHJvZmlsZU5vZGU+IGhlYWQoKSBjb25zdDsKLSAg ICBQYXNzUmVmUHRyPFNjcmlwdFByb2ZpbGVOb2RlPiBib3R0b21VcEhlYWQoKSBjb25zdDsKICAg ICBkb3VibGUgaWRsZVRpbWUoKSBjb25zdDsKIAogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAg UGFzc1JlZlB0cjxUeXBlQnVpbGRlcjo6UHJvZmlsZXI6OkNQVVByb2ZpbGVOb2RlPiBidWlsZElu c3BlY3Rvck9iamVjdEZvckhlYWQoKSBjb25zdDsKLSAgICBQYXNzUmVmUHRyPFR5cGVCdWlsZGVy OjpQcm9maWxlcjo6Q1BVUHJvZmlsZU5vZGU+IGJ1aWxkSW5zcGVjdG9yT2JqZWN0Rm9yQm90dG9t VXBIZWFkKCkgY29uc3Q7CiAjZW5kaWYKIAogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3IuanNvbiBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3IuanNvbgppbmRleCBjYTgzM2Q1OTI0MzMzNGQ1OGNmYjk0OTQxOWRkZTE0MzI5 NWM1ZWQ0Li45Y2ZlNmE2ZGZmM2JlMGRkYjE1YWNmZjk5YmM4MDNlYTU3NDA1Zjg4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yLmpzb24KKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvci5qc29uCkBAIC0zMTExLDcgKzMxMTEsNiBAQAog ICAgICAgICAgICAgICAgICJkZXNjcmlwdGlvbiI6ICJQcm9maWxlLiIsCiAgICAgICAgICAgICAg ICAgInByb3BlcnRpZXMiOiBbCiAgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAiaGVhZCIs ICIkcmVmIjogIkNQVVByb2ZpbGVOb2RlIiwgIm9wdGlvbmFsIjogdHJ1ZSB9LAotICAgICAgICAg ICAgICAgICAgICB7ICJuYW1lIjogImJvdHRvbVVwSGVhZCIsICIkcmVmIjogIkNQVVByb2ZpbGVO b2RlIiwgIm9wdGlvbmFsIjogdHJ1ZSB9LAogICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjog ImlkbGVUaW1lIiwgInR5cGUiOiAibnVtYmVyIiwgIm9wdGlvbmFsIjogdHJ1ZSB9CiAgICAgICAg ICAgICAgICAgXQogICAgICAgICAgICAgfSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JQcm9maWxlckFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JQcm9maWxlckFnZW50LmNwcAppbmRleCAzOWIzNWRjOTE3OWM2MDJjODdi MWNhZDRjZjdkMDc4ODViNmJmNzMzLi5kZWY1MGIxNzkyZjVmYmMzZjAwY2VkMmFhYjhlZjNkNzZl YjI0ZmZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUHJv ZmlsZXJBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclBy b2ZpbGVyQWdlbnQuY3BwCkBAIC0yOTIsOCArMjkyLDYgQEAgdm9pZCBJbnNwZWN0b3JQcm9maWxl ckFnZW50OjpnZXRDUFVQcm9maWxlKEVycm9yU3RyaW5nKiBlcnJvclN0cmluZywgaW50IHJhd1Vp ZCwKICAgICB9CiAgICAgcHJvZmlsZU9iamVjdCA9IFR5cGVCdWlsZGVyOjpQcm9maWxlcjo6Q1BV UHJvZmlsZTo6Y3JlYXRlKCk7CiAgICAgcHJvZmlsZU9iamVjdC0+c2V0SGVhZChpdC0+dmFsdWUt PmJ1aWxkSW5zcGVjdG9yT2JqZWN0Rm9ySGVhZCgpKTsKLSAgICBpZiAoaXQtPnZhbHVlLT5ib3R0 b21VcEhlYWQoKSkKLSAgICAgICAgcHJvZmlsZU9iamVjdC0+c2V0Qm90dG9tVXBIZWFkKGl0LT52 YWx1ZS0+YnVpbGRJbnNwZWN0b3JPYmplY3RGb3JCb3R0b21VcEhlYWQoKSk7CiAgICAgcHJvZmls ZU9iamVjdC0+c2V0SWRsZVRpbWUoaXQtPnZhbHVlLT5pZGxlVGltZSgpKTsKIH0KIAo=