112342 2013-03-14 05:43:36 -0700 Expose whether a UserGestureToken still has gestures via WebKit API 2013-03-15 14:54:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen abarth dglazkov esprehn+autocc fishd jamesr ojan.autocc rego+ews tkent+wkapi webkit.review.bot xan.lopez oldest_to_newest 855143 0 jochen 2013-03-14 05:43:36 -0700 Expose whether a UserGestureToken still has gestures via WebKit API 855144 1 193109 jochen 2013-03-14 05:43:56 -0700 Created attachment 193109 Patch 855146 2 jochen 2013-03-14 05:45:37 -0700 The PPAPI uses WebScopedUserGestures and WebUserGestureTokens to indicate user gestures up to 10s after the gesture happened. When no gesture is active, a corresponding error is reported back to the plugin. With this change, the PPAPI can check whether a token was consumed and cancel the 10s period. 855148 3 webkit.review.bot 2013-03-14 05:46:43 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 856192 4 193109 abarth 2013-03-15 12:28:24 -0700 Comment on attachment 193109 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193109&action=review > Source/WebCore/dom/UserGestureIndicator.h:45 > + virtual bool hasGestures() const = 0; Why do we have this virtual interface. Are there other implementations of UserGestureToken? 856203 5 193109 jochen 2013-03-15 12:52:14 -0700 Comment on attachment 193109 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193109&action=review >> Source/WebCore/dom/UserGestureIndicator.h:45 >> + virtual bool hasGestures() const = 0; > > Why do we have this virtual interface. Are there other implementations of UserGestureToken? no, I just want to hide the addGesture() call, so nobody comes up with the idea of adding gestures to a token 856306 6 193109 webkit.review.bot 2013-03-15 14:54:38 -0700 Comment on attachment 193109 Patch Clearing flags on attachment: 193109 Committed r145944: <http://trac.webkit.org/changeset/145944> 856307 7 webkit.review.bot 2013-03-15 14:54:41 -0700 All reviewed patches have been landed. Closing bug. 193109 2013-03-14 05:43:56 -0700 2013-03-15 14:54:37 -0700 Patch bug-112342-20130314133952.patch text/plain 5189 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1ODA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGVmYjdiMjk3OTRhYWFi MTdkYWJiM2Q3ZDkyZTg1YjAzYjAwMTIyYi4uZGM3ZjkwYzY5MzI4ZDUxZGZlNDI2NTNlYmZiNjI0 ZWRjNmIxNWNjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAzLTE0ICBKb2No ZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEV4cG9zZSB3aGV0 aGVyIGEgVXNlckdlc3R1cmVUb2tlbiBzdGlsbCBoYXMgZ2VzdHVyZXMgdmlhIFdlYktpdCBBUEkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjM0Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL1Vz ZXJHZXN0dXJlSW5kaWNhdG9yLmNwcDoKKyAgICAgICAgKiBkb20vVXNlckdlc3R1cmVJbmRpY2F0 b3IuaDoKKyAgICAgICAgKFVzZXJHZXN0dXJlVG9rZW4pOgorCiAyMDEzLTAzLTE0ICBTaW1vbiBI YXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQGRpZ2lhLmNvbT4KIAogICAgICAgICBbUXRdIEltcHJv dmUgdGhlIGhhbmRsaW5nIG9mIG1vY2sgZ2VvbG9jYXRpb24sIGRldmljZSBvcmllbnRhdGlvbiBh bmQgbW90aW9uIGNsaWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZTY3ZWRjYTQz MTQyZDU5M2RhZTk1NDUzOTEyNDQ0OWVjMjJmNTY2Yy4uZWNmMmJkODllMWU5ZGY2NWNjZjE0OTk4 YTFhYzc4ZTdiYWM1ZDlmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx OCBAQAorMjAxMy0wMy0xNCAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9taXVtLm9yZz4K KworICAgICAgICBFeHBvc2Ugd2hldGhlciBhIFVzZXJHZXN0dXJlVG9rZW4gc3RpbGwgaGFzIGdl c3R1cmVzIHZpYSBXZWJLaXQgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTIzNDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHB1YmxpYy9XZWJVc2VyR2VzdHVyZVRva2VuLmg6CisgICAgICAgIChX ZWJVc2VyR2VzdHVyZVRva2VuKToKKyAgICAgICAgKiBzcmMvV2ViVXNlckdlc3R1cmVUb2tlbi5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYlVzZXJHZXN0dXJlVG9rZW46Omhhc0dlc3R1cmVzKToK KyAgICAgICAgKFdlYktpdCk6CisgICAgICAgICogdGVzdHMvV2ViVXNlckdlc3R1cmVUb2tlblRl c3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VEVTVCk6CisKIDIwMTMtMDMtMTQgIE1hcmphIEjD tmx0dMOkICA8bWFyamFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtWOF0gU3RvcmUgbWFpbiB3 b3JsZCBhbmQgbm9uLW1haW4gd29ybGQgdGVtcGxhdGVzIHNlcGFyYXRlbHkuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9kb20vVXNlckdlc3R1cmVJbmRpY2F0b3IuY3BwIGIvU291cmNlL1dl YkNvcmUvZG9tL1VzZXJHZXN0dXJlSW5kaWNhdG9yLmNwcAppbmRleCA2MWQwNDBhNjcxYjNiNmU3 ZmEzNjFlNzU1YmQxYjFmMzZkM2RiYjQ1Li5kYjAwNzY2N2I1NTJlODY5MzQ0NmM4YmY2MWYyOGI3 N2ZmOWFmZGViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vVXNlckdlc3R1cmVJbmRp Y2F0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Vc2VyR2VzdHVyZUluZGljYXRvci5j cHAKQEAgLTM1LDYgKzM1LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPFVzZXJH ZXN0dXJlVG9rZW4+IGNyZWF0ZSgpIHsgcmV0dXJuIGFkb3B0UmVmKG5ldyBHZXN0dXJlVG9rZW4p OyB9CiAKICAgICB2aXJ0dWFsIH5HZXN0dXJlVG9rZW4oKSB7IH0KKyAgICB2aXJ0dWFsIGJvb2wg aGFzR2VzdHVyZXMoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiBtX2NvbnN1bWFibGVHZXN0dXJl cyA+IDA7IH0KIAogICAgIHZvaWQgYWRkR2VzdHVyZSgpIHsgbV9jb25zdW1hYmxlR2VzdHVyZXMr KzsgfQogICAgIGJvb2wgY29uc3VtZUdlc3R1cmUoKQpAQCAtNDQsNyArNDUsNiBAQCBwdWJsaWM6 CiAgICAgICAgIG1fY29uc3VtYWJsZUdlc3R1cmVzLS07CiAgICAgICAgIHJldHVybiB0cnVlOwog ICAgIH0KLSAgICBib29sIGhhc0dlc3R1cmVzKCkgY29uc3QgeyByZXR1cm4gbV9jb25zdW1hYmxl R2VzdHVyZXMgPiAwOyB9CiAKIHByaXZhdGU6CiAgICAgR2VzdHVyZVRva2VuKCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Vc2VyR2VzdHVyZUluZGljYXRvci5oIGIvU291cmNlL1dl YkNvcmUvZG9tL1VzZXJHZXN0dXJlSW5kaWNhdG9yLmgKaW5kZXggOTMzMjkyMGJiODk0OGVjZDYy OGUyODlhYmUwMzRhNzQ4OTZmODE4Zi4uODgxMjJmYjljZTQwM2FlODkyMjM2YTcxZjZhZDNjZGE4 OWMzMTA1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1VzZXJHZXN0dXJlSW5kaWNh dG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1VzZXJHZXN0dXJlSW5kaWNhdG9yLmgKQEAg LTQyLDYgKzQyLDcgQEAgZW51bSBQcm9jZXNzaW5nVXNlckdlc3R1cmVTdGF0ZSB7CiBjbGFzcyBV c2VyR2VzdHVyZVRva2VuIDogcHVibGljIFJlZkNvdW50ZWQ8VXNlckdlc3R1cmVUb2tlbj4gewog cHVibGljOgogICAgIHZpcnR1YWwgflVzZXJHZXN0dXJlVG9rZW4oKSB7IH0KKyAgICB2aXJ0dWFs IGJvb2wgaGFzR2VzdHVyZXMoKSBjb25zdCA9IDA7CiB9OwogCiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlVzZXJHZXN0dXJlVG9rZW4uaCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlVzZXJHZXN0dXJlVG9rZW4uaAppbmRleCAwZmEzNWFj MDcyMWRmYTUxYTk5YjQ4YmQ3NjY1NmU4NDRmMmE1N2YwLi5lODFiNjI2MmI4MTliOWZiYmFiYjY2 NTlmOTRlNjQ4YTkwOTYxMDVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJVc2VyR2VzdHVyZVRva2VuLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViVXNlckdlc3R1cmVUb2tlbi5oCkBAIC01Myw2ICs1Myw3IEBAIHB1YmxpYzoKICAg ICB9CiAgICAgfldlYlVzZXJHZXN0dXJlVG9rZW4oKSB7IHJlc2V0KCk7IH0KIAorICAgIFdFQktJ VF9FWFBPUlQgYm9vbCBoYXNHZXN0dXJlcygpIGNvbnN0OwogICAgIGJvb2wgaXNOdWxsKCkgY29u c3QgeyByZXR1cm4gbV90b2tlbi5pc051bGwoKTsgfQogCiAjaWYgV0VCS0lUX0lNUExFTUVOVEFU SU9OCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVc2VyR2VzdHVy ZVRva2VuLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVzZXJHZXN0dXJlVG9r ZW4uY3BwCmluZGV4IDBmMjM0ZWVlZjg5M2ZhODU3MmE1NGFjOTk5MDhhOGFlNTdmNzIxNGIuLjMw ZWNlMzFlNWM0OThhOTEzOTJjMjFiNzljODk2NzZmY2RkZGM0NTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVzZXJHZXN0dXJlVG9rZW4uY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVzZXJHZXN0dXJlVG9rZW4uY3BwCkBAIC0zNSw2ICsz NSwxMSBAQAogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAorYm9vbCBXZWJVc2VyR2VzdHVyZVRva2Vu OjpoYXNHZXN0dXJlcygpIGNvbnN0Cit7CisgICAgcmV0dXJuICFtX3Rva2VuLmlzTnVsbCgpICYm IG1fdG9rZW4tPmhhc0dlc3R1cmVzKCk7Cit9CisKIFdlYlVzZXJHZXN0dXJlVG9rZW46OldlYlVz ZXJHZXN0dXJlVG9rZW4oUGFzc1JlZlB0cjxXZWJDb3JlOjpVc2VyR2VzdHVyZVRva2VuPiB0b2tl bikKIHsKICAgICBtX3Rva2VuID0gdG9rZW47CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3Rlc3RzL1dlYlVzZXJHZXN0dXJlVG9rZW5UZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vdGVzdHMvV2ViVXNlckdlc3R1cmVUb2tlblRlc3QuY3BwCmluZGV4IDliNzRjN2Q4 ZmUxMTgwYjc2NjhjODEzMjY2MzczMjhkNGE1MzNjMzAuLmVkODc0ZDA4M2MwMmJmOWQ3ZjFmNmZm MWEwMGVjMGU1ODA4YzY0MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVz dHMvV2ViVXNlckdlc3R1cmVUb2tlblRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvV2ViVXNlckdlc3R1cmVUb2tlblRlc3QuY3BwCkBAIC00NSw2ICs0NSw3IEBAIG5h bWVzcGFjZSB7CiBURVNUKFdlYlVzZXJHZXN0dXJlVG9rZW5UZXN0LCBCYXNpYykKIHsKICAgICBX ZWJVc2VyR2VzdHVyZVRva2VuIHRva2VuOworICAgIEVYUEVDVF9GQUxTRSh0b2tlbi5oYXNHZXN0 dXJlcygpKTsKIAogICAgIHsKICAgICAgICAgV2ViU2NvcGVkVXNlckdlc3R1cmUgaW5kaWNhdG9y KHRva2VuKTsKQEAgLTU3LDYgKzU4LDcgQEAgVEVTVChXZWJVc2VyR2VzdHVyZVRva2VuVGVzdCwg QmFzaWMpCiAgICAgICAgIHRva2VuID0gV2ViVXNlckdlc3R1cmVJbmRpY2F0b3I6OmN1cnJlbnRV c2VyR2VzdHVyZVRva2VuKCk7CiAgICAgfQogCisgICAgRVhQRUNUX1RSVUUodG9rZW4uaGFzR2Vz dHVyZXMoKSk7CiAgICAgRVhQRUNUX0ZBTFNFKFdlYlVzZXJHZXN0dXJlSW5kaWNhdG9yOjppc1By b2Nlc3NpbmdVc2VyR2VzdHVyZSgpKTsKIAogICAgIHsKQEAgLTY2LDYgKzY4LDggQEAgVEVTVChX ZWJVc2VyR2VzdHVyZVRva2VuVGVzdCwgQmFzaWMpCiAgICAgICAgIEVYUEVDVF9GQUxTRShXZWJV c2VyR2VzdHVyZUluZGljYXRvcjo6aXNQcm9jZXNzaW5nVXNlckdlc3R1cmUoKSk7CiAgICAgfQog CisgICAgRVhQRUNUX0ZBTFNFKHRva2VuLmhhc0dlc3R1cmVzKCkpOworCiAgICAgewogICAgICAg ICBXZWJTY29wZWRVc2VyR2VzdHVyZSBpbmRpY2F0b3IodG9rZW4pOwogICAgICAgICBFWFBFQ1Rf RkFMU0UoV2ViVXNlckdlc3R1cmVJbmRpY2F0b3I6OmlzUHJvY2Vzc2luZ1VzZXJHZXN0dXJlKCkp Owo=