112340 2013-03-14 03:49:15 -0700 [Qt] Removing no-ops and simple setters/getters from TestRunnerQt 2013-03-14 04:48:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 109677 1 zeno zeno abecsi hausmann pierre.rossi oldest_to_newest 855117 0 zeno 2013-03-14 03:49:15 -0700 [Qt] Removing no-ops and simple setters/getters from TestRunnerQt 855119 1 193104 zeno 2013-03-14 03:52:04 -0700 Created attachment 193104 Patch 855132 2 193104 zeno 2013-03-14 04:48:23 -0700 Comment on attachment 193104 Patch Clearing flags on attachment: 193104 Committed r145804: <http://trac.webkit.org/changeset/145804> 855133 3 zeno 2013-03-14 04:48:28 -0700 All reviewed patches have been landed. Closing bug. 193104 2013-03-14 03:52:04 -0700 2013-03-14 04:48:23 -0700 Patch bug-112340-20130314114800.patch text/plain 6315 zeno U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1ODAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTJhMDZmZmMzZWRkZjE0ODAwZmUxNmEyNDg4OGNiNjAw OTk2NGFkYy4uNDg1NzU4ZDJmNWFiZTc4ODBiOWQ3MGUwODczOWQyYjFmNGU2MGJjYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIx IEBACiAyMDEzLTAzLTE0ICBaZW5vIEFsYmlzc2VyICA8emVub0B3ZWJraXQub3JnPgogCisgICAg ICAgIFtRdF0gUmVtb3Zpbmcgbm8tb3BzIGFuZCBzaW1wbGUgc2V0dGVycy9nZXR0ZXJzIGZyb20g VGVzdFJ1bm5lclF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTIzNDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwOgorICAgICAgICAo RHVtcFJlbmRlclRyZWU6OmR1bXApOgorICAgICAgICAgICAgUmVwbGFjZSBzaG91bGREdW1wQmFj a0ZvcndhcmRMaXN0KCkgd2l0aCBUZXN0Q29udHJvbGxlcjpkdW1wQmFja0ZvcndhcmRMaXN0KCku CisgICAgICAgIChEdW1wUmVuZGVyVHJlZTo6ZHVtcEFwcGxpY2F0aW9uQ2FjaGVRdW90YSk6Cisg ICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvVGVzdFJ1bm5lclF0LmNwcDoKKyAgICAgICAgKFRl c3RSdW5uZXJRdDo6cmVzZXQpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L1Rlc3RSdW5u ZXJRdC5oOgorICAgICAgICAoVGVzdFJ1bm5lclF0KToKKworMjAxMy0wMy0xNCAgWmVubyBBbGJp c3NlciAgPHplbm9Ad2Via2l0Lm9yZz4KKwogICAgICAgICBbUXRdIFBvcnQgRFJUIHRvIHVzZSBU ZXN0UnVubmVyOjpkdW1wQXNUZXh0KCkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExMjI2MAogCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJl ZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBS ZW5kZXJUcmVlUXQuY3BwCmluZGV4IGYyMWFkZTM5NTFmMDExMWVlMTUwMDRhOTMwMjM0ODgyNDcx YTFjYzQuLmRhYTgwODdjYWI0ODE1OTNlNDVjMjJjMTc5NDg2OTQyN2JlZDBlN2QgMTAwNzU1Ci0t LSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwCisrKyBiL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwCkBAIC05ODQsNyArOTg0 LDcgQEAgdm9pZCBEdW1wUmVuZGVyVHJlZTo6ZHVtcCgpCiAgICAgICAgIGZwcmludGYoc3Rkb3V0 LCAiQ29udGVudC1UeXBlOiAlc1xuIiwgcmVzdWx0Q29udGVudFR5cGUudG9VdGY4KCkuY29uc3RE YXRhKCkpOwogICAgICAgICBmcHJpbnRmKHN0ZG91dCwgIiVzIiwgcmVzdWx0U3RyaW5nLnRvVXRm OCgpLmNvbnN0RGF0YSgpKTsKIAotICAgICAgICBpZiAobV9jb250cm9sbGVyLT5zaG91bGREdW1w QmFja0ZvcndhcmRMaXN0KCkpIHsKKyAgICAgICAgaWYgKG1fanNjQ29udHJvbGxlci0+ZHVtcEJh Y2tGb3J3YXJkTGlzdCgpKSB7CiAgICAgICAgICAgICBmcHJpbnRmKHN0ZG91dCwgIiVzIiwgZHVt cEJhY2tGb3J3YXJkTGlzdCh3ZWJQYWdlKCkpLnRvVXRmOCgpLmNvbnN0RGF0YSgpKTsKICAgICAg ICAgICAgIGZvcmVhY2ggKFFPYmplY3QqIHdpZGdldCwgd2luZG93cykgewogICAgICAgICAgICAg ICAgIFFXZWJQYWdlKiBwYWdlID0gcW9iamVjdF9jYXN0PFFXZWJQYWdlKj4od2lkZ2V0LT5maW5k Q2hpbGQ8UVdlYlBhZ2UqPigpKTsKQEAgLTExMjUsNyArMTEyNSw3IEBAIHZvaWQgRHVtcFJlbmRl clRyZWU6OmR1bXBBcHBsaWNhdGlvbkNhY2hlUXVvdGEoUVdlYlNlY3VyaXR5T3JpZ2luKiBvcmln aW4sIHF1aW50CiAgICAgICAgICAgICAgICApOwogICAgIH0KIAotICAgIGlmIChtX2NvbnRyb2xs ZXItPnNob3VsZERpc2FsbG93SW5jcmVhc2VGb3JBcHBsaWNhdGlvbkNhY2hlUXVvdGEoKSkKKyAg ICBpZiAobV9qc2NDb250cm9sbGVyLT5kaXNhbGxvd0luY3JlYXNlRm9yQXBwbGljYXRpb25DYWNo ZVF1b3RhKCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIG9yaWdpbi0+c2V0QXBwbGljYXRpb25D YWNoZVF1b3RhKGRlZmF1bHRPcmlnaW5RdW90YSk7CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9xdC9UZXN0UnVubmVyUXQuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvVGVz dFJ1bm5lclF0LmNwcAppbmRleCBhNWI4MWYzZWZhYjA4YzhiMDMzMzk3OTQ5NGIyZWQ2NmZlYTE3 Njg2Li5kYzQxN2FiNjFiOTg4YjdjMWViZjM5ZjZkMmVjODBjMGI3Y2NjMjc1IDEwMDY0NAotLS0g YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9UZXN0UnVubmVyUXQuY3BwCisrKyBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L1Rlc3RSdW5uZXJRdC5jcHAKQEAgLTU4LDEyICs1OCwxMCBAQCB2b2lk IFRlc3RSdW5uZXJRdDo6cmVzZXQoKQogICAgIG1faGFzRHVtcGVkID0gZmFsc2U7CiAgICAgbV9s b2FkRmluaXNoZWQgPSBmYWxzZTsKICAgICBtX2F1ZGlvRHVtcCA9IGZhbHNlOwotICAgIG1fZHVt cEJhY2tGb3J3YXJkTGlzdCA9IGZhbHNlOwogICAgIG1fZHVtcENoaWxkcmVuQXNUZXh0ID0gZmFs c2U7CiAgICAgbV9kdW1wQ2hpbGRGcmFtZVNjcm9sbFBvc2l0aW9ucyA9IGZhbHNlOwogICAgIG1f Y2FuT3BlbldpbmRvd3MgPSBmYWxzZTsKICAgICBtX3dhaXRGb3JEb25lID0gZmFsc2U7Ci0gICAg bV9kaXNhbGxvd0luY3JlYXNlRm9yQXBwbGljYXRpb25DYWNoZVF1b3RhID0gZmFsc2U7CiAgICAg bV9kdW1wVGl0bGVDaGFuZ2VzID0gZmFsc2U7CiAgICAgbV9kdW1wRGF0YWJhc2VDYWxsYmFja3Mg PSBmYWxzZTsKICAgICBtX2R1bXBBcHBsaWNhdGlvbkNhY2hlRGVsZWdhdGVDYWxsYmFja3MgPSBm YWxzZTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L1Rlc3RSdW5uZXJRdC5o IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvVGVzdFJ1bm5lclF0LmgKaW5kZXggMmM4MjNmZmYw NjAyNWNiM2ExYzliZjcyYTIxNTEzNTdmMTMyMzNiNy4uMTNmNmE2OGZhZTYwNzUwMjc1ZTFmZmU2 YjgxODhlN2M4MjIxZjE3NyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvVGVz dFJ1bm5lclF0LmgKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvVGVzdFJ1bm5lclF0LmgK QEAgLTU4LDkgKzU4LDcgQEAgY2xhc3MgVGVzdFJ1bm5lclF0IDogcHVibGljIFFPYmplY3Qgewog cHVibGljOgogICAgIFRlc3RSdW5uZXJRdChEdW1wUmVuZGVyVHJlZSopOwogCi0gICAgYm9vbCBz aG91bGREaXNhbGxvd0luY3JlYXNlRm9yQXBwbGljYXRpb25DYWNoZVF1b3RhKCkgY29uc3QgeyBy ZXR1cm4gbV9kaXNhbGxvd0luY3JlYXNlRm9yQXBwbGljYXRpb25DYWNoZVF1b3RhOyB9CiAgICAg Ym9vbCBzaG91bGREdW1wQXNBdWRpbygpIGNvbnN0IHsgcmV0dXJuIG1fYXVkaW9EdW1wOyB9Ci0g ICAgYm9vbCBzaG91bGREdW1wQmFja0ZvcndhcmRMaXN0KCkgY29uc3QgeyByZXR1cm4gbV9kdW1w QmFja0ZvcndhcmRMaXN0OyB9CiAgICAgYm9vbCBzaG91bGREdW1wQ2hpbGRyZW5Bc1RleHQoKSBj b25zdCB7IHJldHVybiBtX2R1bXBDaGlsZHJlbkFzVGV4dDsgfQogICAgIGJvb2wgc2hvdWxkRHVt cENoaWxkRnJhbWVTY3JvbGxQb3NpdGlvbnMoKSBjb25zdCB7IHJldHVybiBtX2R1bXBDaGlsZEZy YW1lU2Nyb2xsUG9zaXRpb25zOyB9CiAgICAgYm9vbCBzaG91bGREdW1wRGF0YWJhc2VDYWxsYmFj a3MoKSBjb25zdCB7IHJldHVybiBtX2R1bXBEYXRhYmFzZUNhbGxiYWNrczsgfQpAQCAtOTYsNyAr OTQsNiBAQCBRX1NJR05BTFM6CiAKIHB1YmxpYyBRX1NMT1RTOgogICAgIHZvaWQgbWF5YmVEdW1w KGJvb2wgb2spOwotICAgIHZvaWQgZGlzYWxsb3dJbmNyZWFzZUZvckFwcGxpY2F0aW9uQ2FjaGVR dW90YSgpIHsgbV9kaXNhbGxvd0luY3JlYXNlRm9yQXBwbGljYXRpb25DYWNoZVF1b3RhID0gdHJ1 ZTsgfQogICAgIHZvaWQgZHVtcENoaWxkRnJhbWVzQXNUZXh0KCkgeyBtX2R1bXBDaGlsZHJlbkFz VGV4dCA9IHRydWU7IH0KICAgICB2b2lkIGR1bXBDaGlsZEZyYW1lU2Nyb2xsUG9zaXRpb25zKCkg eyBtX2R1bXBDaGlsZEZyYW1lU2Nyb2xsUG9zaXRpb25zID0gdHJ1ZTsgfQogICAgIHZvaWQgZHVt cERhdGFiYXNlQ2FsbGJhY2tzKCkgeyBtX2R1bXBEYXRhYmFzZUNhbGxiYWNrcyA9IHRydWU7IH0K QEAgLTEwOSw3ICsxMDYsNiBAQCBwdWJsaWMgUV9TTE9UUzoKICAgICBpbnQgd2ViSGlzdG9yeUl0 ZW1Db3VudCgpOwogICAgIHZvaWQga2VlcFdlYkhpc3RvcnkoKTsKICAgICB2b2lkIG5vdGlmeURv bmUoKTsKLSAgICB2b2lkIGR1bXBCYWNrRm9yd2FyZExpc3QoKSB7IG1fZHVtcEJhY2tGb3J3YXJk TGlzdCA9IHRydWU7IH0KICAgICBib29sIGdsb2JhbEZsYWcoKSBjb25zdCB7IHJldHVybiBtX2ds b2JhbEZsYWc7IH0KICAgICB2b2lkIHNldEdsb2JhbEZsYWcoYm9vbCBmbGFnKSB7IG1fZ2xvYmFs RmxhZyA9IGZsYWc7IH0KICAgICB2b2lkIGhhbmRsZUVycm9yUGFnZXMoKSB7IG1faGFuZGxlRXJy b3JQYWdlcyA9IHRydWU7IH0KQEAgLTEzMiw3ICsxMjgsNiBAQCBwdWJsaWMgUV9TTE9UUzoKICAg ICB2b2lkIHF1ZXVlTG9hZGluZ1NjcmlwdChjb25zdCBRU3RyaW5nJiBzY3JpcHQpOwogICAgIHZv aWQgcXVldWVOb25Mb2FkaW5nU2NyaXB0KGNvbnN0IFFTdHJpbmcmIHNjcmlwdCk7CiAgICAgdm9p ZCBwcm92aXNpb25hbExvYWQoKTsKLSAgICB2b2lkIHNldENsb3NlUmVtYWluaW5nV2luZG93c1do ZW5Db21wbGV0ZShib29sID0gZmFsc2UpIHsgfQogICAgIGludCB3aW5kb3dDb3VudCgpOwogICAg IHZvaWQgaWdub3JlTGVnYWN5V2ViTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RzKCk7CiAg ICAgdm9pZCBzaW11bGF0ZUxlZ2FjeVdlYk5vdGlmaWNhdGlvbkNsaWNrKGNvbnN0IFFTdHJpbmcm IHRpdGxlKTsKQEAgLTIwMiwxMyArMTk3LDYgQEAgcHVibGljIFFfU0xPVFM6CiAgICAgdm9pZCBz ZXRVc2VyU3R5bGVTaGVldEVuYWJsZWQoYm9vbCk7CiAgICAgdm9pZCBzZXREb21haW5SZWxheGF0 aW9uRm9yYmlkZGVuRm9yVVJMU2NoZW1lKGJvb2wgZm9yYmlkZGVuLCBjb25zdCBRU3RyaW5nJiBz Y2hlbWUpOwogICAgIGJvb2wgY2FsbFNob3VsZENsb3NlT25XZWJWaWV3KCk7Ci0gICAgLy8gRm9y IG5vdywgdGhpcyBpcyBhIG5vLW9wLiBUaGlzIG1heSBjaGFuZ2UgZGVwZW5kaW5nIG9uIG91dGNv bWUgb2YKLSAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMz MzMKLSAgICB2b2lkIHNldENhbGxDbG9zZU9uV2ViVmlld3MoKSB7IH0KLSAgICAvLyBUaGlzIGlz IGEgbm8tb3AgLSBpdCBhbGxvd3MgdXMgdG8gcGFzcwotICAgIC8vIHBsdWdpbnMvZ2V0LXVybC10 aGF0LXRoZS1yZXNvdXJjZS1sb2FkLWRlbGVnYXRlLXdpbGwtZGlzYWxsb3cuaHRtbAotICAgIC8v IHdoaWNoIGlzIGEgTWFjLXNwZWNpZmljIHRlc3QuCi0gICAgdm9pZCBhZGREaXNhbGxvd2VkVVJM KGNvbnN0IFFTdHJpbmcmKSB7IH0KIAogICAgIHZvaWQgc2V0TW9ja0RldmljZU9yaWVudGF0aW9u KGJvb2wgY2FuUHJvdmlkZUFscGhhLCBkb3VibGUgYWxwaGEsIGJvb2wgY2FuUHJvdmlkZUJldGEs IGRvdWJsZSBiZXRhLCBib29sIGNhblByb3ZpZGVHYW1tYSwgZG91YmxlIGdhbW1hKTsKIApAQCAt MjI4LDkgKzIxNiw2IEBAIHB1YmxpYyBRX1NMT1RTOgogCiAgICAgdm9pZCBzZXRBdXRvbWF0aWNM aW5rRGV0ZWN0aW9uRW5hYmxlZChib29sKTsKIAotICAgIC8vIEVtcHR5IHN0dWIgbWV0aG9kIHRv IGtlZXAgcGFyaXR5IHdpdGggb2JqZWN0IG1vZGVsIGV4cG9zZWQgYnkgZ2xvYmFsIFRlc3RSdW5u ZXIuCi0gICAgdm9pZCBhYm9ydE1vZGFsKCkgeyB9Ci0KICAgICB2b2lkIGFkZFVSTFRvUmVkaXJl Y3QoY29uc3QgUVN0cmluZyYgb3JpZ2luLCBjb25zdCBRU3RyaW5nJiBkZXN0aW5hdGlvbik7CiAK ICAgICAvKgpAQCAtMjcwLDcgKzI1NSw2IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX2hhc0R1bXBl ZDsKICAgICBib29sIG1fYXVkaW9EdW1wOwogICAgIGJvb2wgbV9kaXNhbGxvd0luY3JlYXNlRm9y QXBwbGljYXRpb25DYWNoZVF1b3RhOwotICAgIGJvb2wgbV9kdW1wQmFja0ZvcndhcmRMaXN0Owog ICAgIGJvb2wgbV9kdW1wQ2hpbGRyZW5Bc1RleHQ7CiAgICAgYm9vbCBtX2R1bXBDaGlsZEZyYW1l U2Nyb2xsUG9zaXRpb25zOwogICAgIGJvb2wgbV9jYW5PcGVuV2luZG93czsK