112337 2013-03-14 03:10:54 -0700 Web Inspector: Flame Chart. Support scroll and zoom with help of mouse wheel. 2013-03-14 06:38:22 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 855106 0 loislo 2013-03-14 03:10:54 -0700 EOM 855110 1 193099 loislo 2013-03-14 03:21:06 -0700 Created attachment 193099 Patch 855141 2 193099 yurys 2013-03-14 05:33:07 -0700 Comment on attachment 193099 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193099&action=review > Source/WebCore/inspector/front-end/FlameChart.js:224 > + this._xScaleFactor = --this._xScaleFactor > minXScaleFactor ? this._xScaleFactor : minXScaleFactor; if (--this._xScaleFactor < minScaleFactor) this._xScaleFactor = minScaleFactor; Also this._xScaleFactor is a floating point number, should it be int? 855159 3 loislo 2013-03-14 06:35:27 -0700 (In reply to comment #2) > (From update of attachment 193099 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=193099&action=review > > > Source/WebCore/inspector/front-end/FlameChart.js:224 > > + this._xScaleFactor = --this._xScaleFactor > minXScaleFactor ? this._xScaleFactor : minXScaleFactor; > > if (--this._xScaleFactor < minScaleFactor) > this._xScaleFactor = minScaleFactor; > > Also this._xScaleFactor is a floating point number, should it be int? Actually it has to be 2^n where n could be negative. 855162 4 loislo 2013-03-14 06:38:22 -0700 Committed r145807: <http://trac.webkit.org/changeset/145807> 193099 2013-03-14 03:21:06 -0700 2013-03-14 05:33:07 -0700 Patch bug-112337-20130314141702.patch text/plain 5912 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1Nzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmYzOThiMmZhNGEyMTFk MGIzOWRjN2UyMzg2MGY0MGE0ZmE3MWJmMC4uMWEyZjlmMGIxMTUyNDE0ZDU5YjZhMWYzNjA0NjA0 NDdlYzVkZjFiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEzLTAzLTE0ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAorICAgICAgICBXZWIgSW5zcGVj dG9yOiBGbGFtZSBDaGFydC4gU3VwcG9ydCBzY3JvbGwgYW5kIHpvb20gd2l0aCBoZWxwIG9mIG1v dXNlIHdoZWVsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTEyMzM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTmV3IG1lbWJlciB2YXJpYWJsZSBfeE9mZnNldCB3ZXJlIGludHJvZHVjZWQuCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0ZsYW1lQ2hhcnQuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuRmxhbWVDaGFydCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRmxhbWVDaGFydC5wcm90 b3R5cGUuX29uTW91c2VNb3ZlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5GbGFtZUNoYXJ0LnBy b3RvdHlwZS5fYWRqdXN0WE9mZnNldCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRmxhbWVDaGFy dC5wcm90b3R5cGUuX2FkanVzdFhTY2FsZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRmxhbWVD aGFydC5wcm90b3R5cGUuX29uTW91c2VXaGVlbCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRmxh bWVDaGFydC5wcm90b3R5cGUuX2Nvb3JkaW5hdGVzVG9Ob2RlSW5kZXgpOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLkZsYW1lQ2hhcnQucHJvdG90eXBlLm9uUmVzaXplKToKKyAgICAgICAgKFdlYklu c3BlY3Rvci5GbGFtZUNoYXJ0LnByb3RvdHlwZS5kcmF3KToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5GbGFtZUNoYXJ0LnByb3RvdHlwZS5fc2NoZWR1bGVVcGRhdGUpOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkZsYW1lQ2hhcnQucHJvdG90eXBlLnVwZGF0ZSk6CisKKzIwMTMtMDMtMTQgIElseWEg VGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEZsYW1lIENoYXJ0LiBNaW5vciBjaGFuZ2VzIGZvciB0aGUgcG9wb3Zlci4KICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjMzMQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0ZsYW1lQ2hhcnQuanMgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0ZsYW1lQ2hhcnQuanMKaW5kZXggYzQx OTY0ODFiZDI4MzI3Yjc3ZDk5NzBjYzYxZDNkNDEyNDhjYzBiZC4uZDc5MjBjZTFkMmZhZTY4NDU5 NDdkMTk5ZmI0NWY5NTRlZmI4M2ZkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9GbGFtZUNoYXJ0LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvRmxhbWVDaGFydC5qcwpAQCAtNDEsMTAgKzQxLDEyIEBAIFdlYkluc3BlY3Rv ci5GbGFtZUNoYXJ0ID0gZnVuY3Rpb24oY3B1UHJvZmlsZVZpZXcpCiAgICAgdGhpcy5lbGVtZW50 LmNsYXNzTmFtZSA9ICJmbGFtZS1jaGFydCI7CiAgICAgdGhpcy5fY2FudmFzID0gdGhpcy5lbGVt ZW50LmNyZWF0ZUNoaWxkKCJjYW52YXMiKTsKICAgICB0aGlzLl9jcHVQcm9maWxlVmlldyA9IGNw dVByb2ZpbGVWaWV3OwotICAgIHRoaXMuX3hTY2FsZUZhY3RvciA9IDAuMDsKKyAgICB0aGlzLl94 U2NhbGVGYWN0b3IgPSA1LjA7CisgICAgdGhpcy5feE9mZnNldCA9IDA7CiAgICAgdGhpcy5fYmFy SGVpZ2h0ID0gMTA7CiAgICAgdGhpcy5fbWluV2lkdGggPSAxOwogICAgIHRoaXMuZWxlbWVudC5v bm1vdXNlbW92ZSA9IHRoaXMuX29uTW91c2VNb3ZlLmJpbmQodGhpcyk7CisgICAgdGhpcy5lbGVt ZW50Lm9ubW91c2V3aGVlbCA9IHRoaXMuX29uTW91c2VXaGVlbC5iaW5kKHRoaXMpOwogICAgIHRo aXMuZWxlbWVudC5vbmNsaWNrID0gdGhpcy5fb25DbGljay5iaW5kKHRoaXMpOwogICAgIHRoaXMu X3BvcG92ZXJIZWxwZXIgPSBuZXcgV2ViSW5zcGVjdG9yLlBvcG92ZXJIZWxwZXIodGhpcy5lbGVt ZW50LCB0aGlzLl9nZXRQb3BvdmVyQW5jaG9yLmJpbmQodGhpcyksIHRoaXMuX3Nob3dQb3BvdmVy LmJpbmQodGhpcykpOwogICAgIHRoaXMuX3BvcG92ZXJIZWxwZXIuc2V0VGltZW91dCgyNTApOwpA QCAtMjAzLDEwICsyMDUsMzggQEAgV2ViSW5zcGVjdG9yLkZsYW1lQ2hhcnQucHJvdG90eXBlID0g ewogICAgICAgICB2YXIgc3R5bGUgPSB0aGlzLl9hbmNob3JFbGVtZW50LnN0eWxlOwogICAgICAg ICBzdHlsZS53aWR0aCA9IE1hdGguZmxvb3IodGltZWxpbmVEYXRhLmR1cmF0aW9uc1tub2RlSW5k ZXhdICogdGhpcy5feFNjYWxlRmFjdG9yKSArICJweCI7CiAgICAgICAgIHN0eWxlLmhlaWdodCA9 IHRoaXMuX2JhckhlaWdodCArICJweCI7Ci0gICAgICAgIHN0eWxlLmxlZnQgPSBNYXRoLmZsb29y KHRpbWVsaW5lRGF0YS5zdGFydFRpbWVzW25vZGVJbmRleF0gKiB0aGlzLl94U2NhbGVGYWN0b3Ip ICsgInB4IjsKKyAgICAgICAgc3R5bGUubGVmdCA9IE1hdGguZmxvb3IodGltZWxpbmVEYXRhLnN0 YXJ0VGltZXNbbm9kZUluZGV4XSAqIHRoaXMuX3hTY2FsZUZhY3RvciAtIHRoaXMuX3hPZmZzZXQp ICsgInB4IjsKICAgICAgICAgc3R5bGUudG9wID0gTWF0aC5mbG9vcih0aGlzLl9jYW52YXMuaGVp Z2h0IC0gKHRpbWVsaW5lRGF0YS5kZXB0aHNbbm9kZUluZGV4XSArIDEpICogdGhpcy5fYmFySGVp Z2h0KSArICJweCI7CiAgICAgfSwKIAorICAgIF9hZGp1c3RYT2Zmc2V0OiBmdW5jdGlvbihkaXJl Y3Rpb24pCisgICAgeworICAgICAgICB2YXIgc3RlcCA9IHRoaXMuX3hTY2FsZUZhY3RvciAqIDU7 CisgICAgICAgIHRoaXMuX3hPZmZzZXQgKz0gZGlyZWN0aW9uID4gMCA/IHN0ZXAgOiAtc3RlcDsK KyAgICAgICAgaWYgKHRoaXMuX3hPZmZzZXQgPCAwKQorICAgICAgICAgICAgdGhpcy5feE9mZnNl dCA9IDA7CisgICAgfSwKKworICAgIF9hZGp1c3RYU2NhbGU6IGZ1bmN0aW9uKGRpcmVjdGlvbiwg eCkKKyAgICB7CisgICAgICAgIHZhciBtaW5YU2NhbGVGYWN0b3IgPSAxLjA7CisgICAgICAgIGlm IChkaXJlY3Rpb24gPiAwKQorICAgICAgICAgICAgdGhpcy5feFNjYWxlRmFjdG9yID0gLS10aGlz Ll94U2NhbGVGYWN0b3IgPiBtaW5YU2NhbGVGYWN0b3IgPyB0aGlzLl94U2NhbGVGYWN0b3IgOiBt aW5YU2NhbGVGYWN0b3I7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgICsrdGhpcy5feFNjYWxl RmFjdG9yOworICAgIH0sCisKKyAgICBfb25Nb3VzZVdoZWVsOiBmdW5jdGlvbihlKQorICAgIHsK KyAgICAgICAgaWYgKGUuc2hpZnRLZXkpCisgICAgICAgICAgICB0aGlzLl9hZGp1c3RYU2NhbGUo ZS53aGVlbERlbHRhLCBlLngpOworICAgICAgICBlbHNlCisgICAgICAgICAgICB0aGlzLl9hZGp1 c3RYT2Zmc2V0KGUud2hlZWxEZWx0YSk7CisKKyAgICAgICAgdGhpcy5faGlkZVBvcG92ZXIoKTsK KyAgICAgICAgdGhpcy5fc2NoZWR1bGVVcGRhdGUoKTsKKyAgICB9LAorCiAgICAgLyoqCiAgICAg ICogQHBhcmFtIHshbnVtYmVyfSB4CiAgICAgICogQHBhcmFtIHshbnVtYmVyfSB5CkBAIC0yMTYs NyArMjQ2LDcgQEAgV2ViSW5zcGVjdG9yLkZsYW1lQ2hhcnQucHJvdG90eXBlID0gewogICAgICAg ICB2YXIgdGltZWxpbmVEYXRhID0gdGhpcy5fdGltZWxpbmVEYXRhOwogICAgICAgICBpZiAoIXRp bWVsaW5lRGF0YSkKICAgICAgICAgICAgIHJldHVybiAtMTsKLSAgICAgICAgdmFyIGN1cnNvclRp bWUgPSB4IC8gdGhpcy5feFNjYWxlRmFjdG9yOworICAgICAgICB2YXIgY3Vyc29yVGltZSA9ICh4 ICsgdGhpcy5feE9mZnNldCkgLyB0aGlzLl94U2NhbGVGYWN0b3I7CiAgICAgICAgIHZhciBjdXJz b3JMZXZlbCA9IE1hdGguZmxvb3IoKHRoaXMuX2NhbnZhcy5oZWlnaHQgLSB5KSAvIHRoaXMuX2Jh ckhlaWdodCk7CiAKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0aW1lbGluZURhdGEubm9k ZUNvdW50OyArK2kpIHsKQEAgLTIzMiw3ICsyNjIsNyBAQCBXZWJJbnNwZWN0b3IuRmxhbWVDaGFy dC5wcm90b3R5cGUgPSB7CiAgICAgb25SZXNpemU6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAg IHRoaXMuX2hpZGVQb3BvdmVyKCk7Ci0gICAgICAgIHRoaXMudXBkYXRlKCk7CisgICAgICAgIHRo aXMuX3NjaGVkdWxlVXBkYXRlKCk7CiAgICAgfSwKIAogICAgIC8qKgpAQCAtMjQ2LDE3ICsyNzYs MjAgQEAgV2ViSW5zcGVjdG9yLkZsYW1lQ2hhcnQucHJvdG90eXBlID0gewogICAgICAgICAgICAg cmV0dXJuOwogICAgICAgICB0aGlzLl9jYW52YXMuaGVpZ2h0ID0gaGVpZ2h0OwogICAgICAgICB0 aGlzLl9jYW52YXMud2lkdGggPSB3aWR0aDsKLSAgICAgICAgdmFyIHhTY2FsZUZhY3RvciA9IHRo aXMuX3hTY2FsZUZhY3RvciA9IHdpZHRoIC8gdGltZWxpbmVEYXRhLnRvdGFsVGltZTsKKyAgICAg ICAgdmFyIHhTY2FsZUZhY3RvciA9IHRoaXMuX3hTY2FsZUZhY3RvcjsKICAgICAgICAgdmFyIGJh ckhlaWdodCA9IHRoaXMuX2JhckhlaWdodDsKKyAgICAgICAgdmFyIHhPZmZzZXQgPSB0aGlzLl94 T2Zmc2V0OwogCiAgICAgICAgIHZhciBjb250ZXh0ID0gdGhpcy5fY2FudmFzLmdldENvbnRleHQo IjJkIik7CiAKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0aW1lbGluZURhdGEubm9kZUNv dW50OyArK2kpIHsKKyAgICAgICAgICAgIHZhciB4ID0gTWF0aC5mbG9vcih0aW1lbGluZURhdGEu c3RhcnRUaW1lc1tpXSAqIHhTY2FsZUZhY3RvcikgLSB4T2Zmc2V0OworICAgICAgICAgICAgaWYg KHggPiB3aWR0aCkKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIHZhciB5ID0g aGVpZ2h0IC0gKHRpbWVsaW5lRGF0YS5kZXB0aHNbaV0gKyAxKSAqIGJhckhlaWdodDsKICAgICAg ICAgICAgIHZhciBiYXJXaWR0aCA9IE1hdGguZmxvb3IodGltZWxpbmVEYXRhLmR1cmF0aW9uc1tp XSAqIHhTY2FsZUZhY3Rvcik7CiAgICAgICAgICAgICBpZiAoYmFyV2lkdGggPCB0aGlzLl9taW5X aWR0aCkKICAgICAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgICAgIHZhciB4ID0gTWF0 aC5mbG9vcih0aW1lbGluZURhdGEuc3RhcnRUaW1lc1tpXSAqIHhTY2FsZUZhY3Rvcik7Ci0gICAg ICAgICAgICB2YXIgeSA9IGhlaWdodCAtICh0aW1lbGluZURhdGEuZGVwdGhzW2ldICsgMSkgKiBi YXJIZWlnaHQ7CiAKICAgICAgICAgICAgIHZhciBjb2xvclBhaXIgPSB0aW1lbGluZURhdGEuY29s b3JQYWlyc1tpXTsKICAgICAgICAgICAgIHZhciBjb2xvcjsKQEAgLTI3Miw4ICszMDUsMTYgQEAg V2ViSW5zcGVjdG9yLkZsYW1lQ2hhcnQucHJvdG90eXBlID0gewogICAgICAgICB9CiAgICAgfSwK IAorICAgIF9zY2hlZHVsZVVwZGF0ZTogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgaWYgKHRo aXMuX3VwZGF0ZVRpbWVySWQpCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIHRoaXMuX3Vw ZGF0ZVRpbWVySWQgPSBzZXRUaW1lb3V0KHRoaXMudXBkYXRlLmJpbmQodGhpcyksIDEwKTsKKyAg ICB9LAorCiAgICAgdXBkYXRlOiBmdW5jdGlvbigpCiAgICAgeworICAgICAgICB0aGlzLl91cGRh dGVUaW1lcklkID0gMDsKICAgICAgICAgdGhpcy5kcmF3KHRoaXMuZWxlbWVudC5jbGllbnRXaWR0 aCwgdGhpcy5lbGVtZW50LmNsaWVudEhlaWdodCk7CiAgICAgfSwKIAo=