112319 2013-03-13 21:10:00 -0700 Cannot select a canvas element at the beginning or the end of a document 2013-06-20 20:19:02 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 117860 1 rniwa rniwa ap darin enrica eric esprehn+autocc junov leviw morrita ojan.autocc ojan senorblanco webkit-bug-importer webkit.review.bot oldest_to_newest 854924 0 193057 rniwa 2013-03-13 21:10:00 -0700 Created attachment 193057 Demo With the following markup, you can select the second canvas but not the first or the third canvas elements. <!DOCTYPE html> <html> <body> <canvas width="100" height="100" style="border: 1px solid black"></canvas> some text <canvas width="100" height="100" style="border: 1px solid black"></canvas> some more text <canvas width="100" height="100" style="border: 1px solid black"></canvas> </body> </html> 854936 1 webkit-bug-importer 2013-03-13 21:30:55 -0700 <rdar://problem/13417656> 854995 2 193075 rniwa 2013-03-13 23:41:26 -0700 Created attachment 193075 Fixes the bug 855001 3 193075 eric 2013-03-13 23:52:05 -0700 Comment on attachment 193075 Fixes the bug OK. 855006 4 rniwa 2013-03-13 23:54:38 -0700 Committed r145788: <http://trac.webkit.org/changeset/145788> 895938 5 junov 2013-05-31 10:56:45 -0700 (In reply to comment #4) > Committed r145788: <http://trac.webkit.org/changeset/145788> Just so you know, this patch caused a regression: https://code.google.com/p/chromium/issues/detail?id=244289 We are likely to revert it in Blink, and look for an alternate solution. Cheers! 897411 6 senorblanco 2013-06-05 07:33:47 -0700 FYI: this seems to break mouse up event handling on many canvas sites. See: https://code.google.com/p/chromium/issues/detail?id=244289. rniwa: was there a follow-up patch that fixed this issue? 193057 2013-03-13 21:10:00 -0700 2013-03-13 21:10:00 -0700 Demo canvas-select.html text/html 296 rniwa PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8Ym9keT4KPGNhbnZhcyB3aWR0aD0iMTAwIiBoZWlnaHQ9 IjEwMCIgc3R5bGU9ImJvcmRlcjogMXB4IHNvbGlkIGJsYWNrIj48L2NhbnZhcz4Kc29tZSB0ZXh0 CjxjYW52YXMgd2lkdGg9IjEwMCIgaGVpZ2h0PSIxMDAiIHN0eWxlPSJib3JkZXI6IDFweCBzb2xp ZCBibGFjayI+PC9jYW52YXM+CnNvbWUgbW9yZSB0ZXh0CjxjYW52YXMgd2lkdGg9IjEwMCIgaGVp Z2h0PSIxMDAiIHN0eWxlPSJib3JkZXI6IDFweCBzb2xpZCBibGFjayI+PC9jYW52YXM+CjwvYm9k eT4KPC9odG1sPgo= 193075 2013-03-13 23:41:26 -0700 2013-03-13 23:52:04 -0700 Fixes the bug bug-112319-20130313233724.patch text/plain 4995 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NTc4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTEzICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENhbm5vdCBzZWxlY3QgYSBjYW52 YXMgZWxlbWVudCBhdCB0aGUgYmVnaW5uaW5nIG9yIHRoZSBlbmQgb2YgYSBkb2N1bWVudAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMzE5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGJ1ZyB3YXMg Y2F1c2VkIGJ5IHRoZSBlZGl0aW5nIGNvZGUgdHJlYXRpbmcgY2FudmFzIGVsZW1lbnQgYXMgaWYg YW4gZW1wdHkgaW5saW5lIGVsZW1lbnQuCisgICAgICAgIFRyZWF0IGl0IGFzIGFuICJhdG9taWMi IGVsZW1lbnQgZm9yIHRoZSBwdXJwb3NlIG9mIGRldGVybWluaW5nIHdoZXRoZXIgc2VsZWN0aW9u IGNhbiBoYXZlCisgICAgICAgIGFuIGVuZCBwb2ludCBpbiBpdCBvciBub3QuCisKKyAgICAgICAg VGVzdDogZWRpdGluZy9wYXN0ZWJvYXJkL2NvcHktcGFzdGUtY29udGVudC1zdGFydGluZy1hbmQt ZW5kaW5nLWNhbnZhcy5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxDYW52YXNFbGVtZW50Lmg6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MQ2FudmFzRWxlbWVudDo6Y2FuQ29udGFpblJhbmdlRW5k UG9pbnQpOiBBZGRlZC4KKwogMjAxMy0wMy0xMyAgS3VuaWhpa28gU2FrYW1vdG8gIDxrc2FrYW1v dG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEltcGxlbWVudCBGb250TG9hZGVyIGludGVyZmFj ZQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuaAkocmV2aXNpb24g MTQ1Nzg2KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMzksNiArMTM5LDggQEAgcHVibGljOgogCiAgICAgZmxvYXQgZGV2aWNl U2NhbGVGYWN0b3IoKSBjb25zdCB7IHJldHVybiBtX2RldmljZVNjYWxlRmFjdG9yOyB9CiAKKyAg ICB2aXJ0dWFsIGJvb2wgY2FuQ29udGFpblJhbmdlRW5kUG9pbnQoKSBjb25zdCB7IHJldHVybiBm YWxzZTsgfQorCiAgICAgdmlydHVhbCB2b2lkIHJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVj dEluZm8qKSBjb25zdCBPVkVSUklERTsKIAogcHJpdmF0ZToKSW5kZXg6IExheW91dFRlc3RzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0 NTc4NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE1IEBACisyMDEzLTAzLTEzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisg ICAgICAgIENhbm5vdCBzZWxlY3QgYSBjYW52YXMgZWxlbWVudCBhdCB0aGUgYmVnaW5uaW5nIG9y IHRoZSBlbmQgb2YgYSBkb2N1bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTEyMzE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIGEgcmVncmVzc2lvbiB0ZXN0IHRvIGNvcHkgYW5kIHBhc3RlIGEg Y29udGVudCB3aXRoIGNhbnZhcyBlbGVtZW50cy4KKworICAgICAgICAqIGVkaXRpbmcvcGFzdGVi b2FyZC9jb3B5LXBhc3RlLWNvbnRlbnQtc3RhcnRpbmctYW5kLWVuZGluZy1jYW52YXMtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL3Bhc3RlYm9hcmQvY29weS1wYXN0ZS1j b250ZW50LXN0YXJ0aW5nLWFuZC1lbmRpbmctY2FudmFzLmh0bWw6IEFkZGVkLgorCiAyMDEzLTAz LTEzICBLdW5paGlrbyBTYWthbW90byAgPGtzYWthbW90b0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgSW1wbGVtZW50IEZvbnRMb2FkZXIgaW50ZXJmYWNlCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0 aW5nL3Bhc3RlYm9hcmQvY29weS1wYXN0ZS1jb250ZW50LXN0YXJ0aW5nLWFuZC1lbmRpbmctY2Fu dmFzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3Rl Ym9hcmQvY29weS1wYXN0ZS1jb250ZW50LXN0YXJ0aW5nLWFuZC1lbmRpbmctY2FudmFzLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9j b3B5LXBhc3RlLWNvbnRlbnQtc3RhcnRpbmctYW5kLWVuZGluZy1jYW52YXMtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQ3IEBACitUaGlzIHRlc3RzIHNlbGVjdGluZyBhbGws IGNvcHlpbmcsIGFuZCBwYXN0aW5nIGEgY29udGVudCB0aGF0IHN0YXJ0cyBhbmQgZW5kcyB3aXRo IGNhbnZhcyBlbGVtZW50cy4KK1RvIG1hbnVhbGx5IHRlc3QsIGNvcHkgYW5kIHBhc3RlIHRoZSBj b250ZW50IGJlbG93OgorCitCZWZvcmUgcGFzdGU6Cit8ICIKKyIKK3wgPGNhbnZhcz4KK3wgICBo ZWlnaHQ9IjEwMCIKK3wgICBzdHlsZT0iYm9yZGVyOiAxcHggc29saWQgYmxhY2siCit8ICAgd2lk dGg9IjEwMCIKK3wgIgorc29tZSB0ZXh0CisiCit8IDxjYW52YXM+Cit8ICAgaGVpZ2h0PSIxMDAi Cit8ICAgc3R5bGU9ImJvcmRlcjogMXB4IHNvbGlkIGJsYWNrIgorfCAgIHdpZHRoPSIxMDAiCit8 ICIKK3NvbWUgbW9yZSB0ZXh0CisiCit8IDxjYW52YXM+Cit8ICAgaGVpZ2h0PSIxMDAiCit8ICAg c3R5bGU9ImJvcmRlcjogMXB4IHNvbGlkIGJsYWNrIgorfCAgIHdpZHRoPSIxMDAiCit8ICIKKyIK KworQWZ0ZXIgcGFzdGU6Cit8IDxjYW52YXM+Cit8ICAgaGVpZ2h0PSIxMDAiCit8ICAgc3R5bGU9 ImJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOyIKK3wgICB3aWR0aD0iMTAwIgorfCAiwqAiCit8ICJz b21lIHRleHQiCit8ICLCoCIKK3wgPGNhbnZhcz4KK3wgICBoZWlnaHQ9IjEwMCIKK3wgICBzdHls ZT0iYm9yZGVyOiAxcHggc29saWQgYmxhY2s7IgorfCAgIHdpZHRoPSIxMDAiCit8ICLCoCIKK3wg InNvbWUgbW9yZSB0ZXh0IgorfCAiwqAiCit8IDxjYW52YXM+Cit8ICAgaGVpZ2h0PSIxMDAiCit8 ICAgc3R5bGU9ImJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOyIKK3wgICB3aWR0aD0iMTAwIgorfCA8 YnI+CkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvY29weS1wYXN0ZS1jb250 ZW50LXN0YXJ0aW5nLWFuZC1lbmRpbmctY2FudmFzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL2NvcHktcGFzdGUtY29udGVudC1zdGFydGluZy1hbmQt ZW5kaW5nLWNhbnZhcy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9w YXN0ZWJvYXJkL2NvcHktcGFzdGUtY29udGVudC1zdGFydGluZy1hbmQtZW5kaW5nLWNhbnZhcy5o dG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMzIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1s PgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPlRoaXMgdGVzdHMgc2VsZWN0aW5nIGFsbCwg Y29weWluZywgYW5kIHBhc3RpbmcgYSBjb250ZW50IHRoYXQgc3RhcnRzIGFuZCBlbmRzIHdpdGgg Y2FudmFzIGVsZW1lbnRzLgorVG8gbWFudWFsbHkgdGVzdCwgY29weSBhbmQgcGFzdGUgdGhlIGNv bnRlbnQgYmVsb3c6PC9wPgorPGRpdiBpZD0iZWRpdG9yIiBjb250ZW50ZWRpdGFibGU+Cis8Y2Fu dmFzIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiBzdHlsZT0iYm9yZGVyOiAxcHggc29saWQgYmxh Y2siPjwvY2FudmFzPgorc29tZSB0ZXh0Cis8Y2FudmFzIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAw IiBzdHlsZT0iYm9yZGVyOiAxcHggc29saWQgYmxhY2siPjwvY2FudmFzPgorc29tZSBtb3JlIHRl eHQKKzxjYW52YXMgd2lkdGg9IjEwMCIgaGVpZ2h0PSIxMDAiIHN0eWxlPSJib3JkZXI6IDFweCBz b2xpZCBibGFjayI+PC9jYW52YXM+Cis8L2Rpdj4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJj ZXMvZHVtcC1hcy1tYXJrdXAuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KKworTWFya3VwLmRlc2Ny aXB0aW9uKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdkZXNjcmlwdGlvbicpLnRleHRDb250ZW50 KTsKKwordmFyIGVkaXRvciA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdlZGl0b3InKTsKK2Vk aXRvci5mb2N1cygpOworZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ3NlbGVjdEFsbCcpOworCitkb2N1 bWVudC5leGVjQ29tbWFuZCgnY29weScpOworTWFya3VwLmR1bXAoZWRpdG9yLCAnQmVmb3JlIHBh c3RlJyk7CisKK2lmIChkb2N1bWVudC5xdWVyeUNvbW1hbmRTdXBwb3J0ZWQoJ2NvcHknKSAmJiBk b2N1bWVudC5xdWVyeUNvbW1hbmRTdXBwb3J0ZWQoJ3Bhc3RlJykpIHsKKyAgICBkb2N1bWVudC5l eGVjQ29tbWFuZCgncGFzdGUnKTsKKyAgICBNYXJrdXAuZHVtcChlZGl0b3IsICdBZnRlciBwYXN0 ZScpOworfSBlbHNlCisgICAgZWRpdG9yLm9ucGFzdGUgPSBmdW5jdGlvbiAoKSB7IHNldFRpbWVv dXQoZnVuY3Rpb24gKCkgeyBNYXJrdXAuZHVtcChlZGl0b3IsICdBZnRlciBwYXN0ZScpOyB9LCAw KTsgfQorCis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K