112317 2013-03-13 20:16:34 -0700 Need to use const String in HTMLVideoElement::posterImageURL 2013-03-18 09:14:25 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 michaelbai michaelbai darin eric.carlson esprehn+autocc feature-media-reviews jer.noble ojan.autocc webkit.review.bot oldest_to_newest 854903 0 michaelbai 2013-03-13 20:16:34 -0700 Need to use const String instead of "const AtomicString&" which means we’ll do an extra hash lookup 854907 1 193054 michaelbai 2013-03-13 20:23:36 -0700 Created attachment 193054 Patch 854909 2 193055 michaelbai 2013-03-13 20:29:45 -0700 Created attachment 193055 Patch 855269 3 193055 ap 2013-03-14 09:54:34 -0700 Comment on attachment 193055 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193055&action=review r=me with correction below. > Source/WebCore/ChangeLog:11 > + Need to use const String instead of const AtomicString& which means we will do an extra hash lookup We don't normally use const with local variables, so not "const String". > Source/WebCore/html/HTMLVideoElement.cpp:320 > + const String url = stripLeadingAndTrailingHTMLSpaces(imageSourceURL()); Should be "String", not "const String" 855272 4 193143 michaelbai 2013-03-14 10:04:03 -0700 Created attachment 193143 Patch 855275 5 193055 michaelbai 2013-03-14 10:04:47 -0700 Comment on attachment 193055 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193055&action=review >> Source/WebCore/ChangeLog:11 >> + Need to use const String instead of const AtomicString& which means we will do an extra hash lookup > > We don't normally use const with local variables, so not "const String". Change to use string. thanks 857177 6 193143 webkit.review.bot 2013-03-18 09:14:22 -0700 Comment on attachment 193143 Patch Clearing flags on attachment: 193143 Committed r146069: <http://trac.webkit.org/changeset/146069> 857179 7 webkit.review.bot 2013-03-18 09:14:25 -0700 All reviewed patches have been landed. Closing bug. 193054 2013-03-13 20:23:36 -0700 2013-03-13 20:29:44 -0700 Patch bug-112317-20130313201933.patch text/plain 1666 michaelbai U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQxZGRlYTE3YmNiMjk4 NjJjYzlmYzdjOGEyOGJkYWU3NGJlOWViZC4uOGRkNmYyYjE1YjUzZjdjYzYyMGUxNDE2OTA2YWE1 MWZhN2FiY2MwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTEzICBUYW8g QmFpICA8bWljaGFlbGJhaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTmVlZCB0byB1c2UgY29u c3QgU3RyaW5nIGluIEhUTUxWaWRlb0VsZW1lbnQ6OnBvc3RlckltYWdlVVJMCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIzMTcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBiZWhhdmlvcmFsIGNoYW5n ZXMuCisKKyAgICAgICAgVGhpcyBpcyB0aGUgZm9sbG93dXAgb2YgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDI2MworICAgICAgICBOZWVkIHRvIHVzZSBjb25zdCBT dHJpbmcgaW5zdGVhZCBvZiAgImNvbnN0IEF0b21pY1N0cmluZyYiIHdoaWNoIG1lYW5zIHdl4oCZ bGwgZG8gYW4gZXh0cmEgaGFzaCBsb29rdXAKKworICAgICAgICAqIGh0bWwvSFRNTFZpZGVvRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVmlkZW9FbGVtZW50Ojpwb3N0ZXJJbWFn ZVVSTCk6IENoYW5nZSB0byB1c2UgY29uc3QgU3RyaW5nIGZvciB1cmwKKwogMjAxMy0wMy0xMyAg UmFmYWVsIFdlaW5zdGVpbiAgPHJhZmFlbHdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtIVE1M VGVtcGxhdGVFbGVtZW50XSBFT0Ygc2hvdWxkIHVud2luZCB0aGUgc3RhY2sgb2YgdGVtcGxhdGUg aW5zZXJ0aW9uIG1vZGVzIGl0ZXJhdGl2ZWx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxWaWRlb0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVmlkZW9F bGVtZW50LmNwcAppbmRleCBiYTcwZGNlYWI5OGIwMTg0YjBlMTdhNTBhNDFmNTQwYWEyZTA0NGUx Li4yOThiMzQzZGFhNjdmNDRlOTE1NzY4NzM0OGE2ZjFmYzI4ZGM3NjhkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxWaWRlb0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTFZpZGVvRWxlbWVudC5jcHAKQEAgLTMxNyw3ICszMTcsNyBAQCB1bnNpZ25l ZCBIVE1MVmlkZW9FbGVtZW50Ojp3ZWJraXREcm9wcGVkRnJhbWVDb3VudCgpIGNvbnN0CiAKIEtV UkwgSFRNTFZpZGVvRWxlbWVudDo6cG9zdGVySW1hZ2VVUkwoKSBjb25zdAogewotICAgIGNvbnN0 IEF0b21pY1N0cmluZyYgdXJsID0gc3RyaXBMZWFkaW5nQW5kVHJhaWxpbmdIVE1MU3BhY2VzKGlt YWdlU291cmNlVVJMKCkpOworICAgIGNvbnN0IFN0cmluZyB1cmwgPSBzdHJpcExlYWRpbmdBbmRU cmFpbGluZ0hUTUxTcGFjZXMoaW1hZ2VTb3VyY2VVUkwoKSk7CiAgICAgaWYgKHVybC5pc0VtcHR5 KCkpCiAgICAgICAgIHJldHVybiBLVVJMKCk7CiAgICAgcmV0dXJuIGRvY3VtZW50KCktPmNvbXBs ZXRlVVJMKHVybCk7Cg== 193055 2013-03-13 20:29:45 -0700 2013-03-14 10:04:47 -0700 Patch bug-112317-20130313202542.patch text/plain 1663 michaelbai U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQxZGRlYTE3YmNiMjk4 NjJjYzlmYzdjOGEyOGJkYWU3NGJlOWViZC4uODVlZTEzYWY0MDQwOGY1OWEyZmZmN2ZjOTFlNTQx YWU1YTgwYzY3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTEzICBUYW8g QmFpICA8bWljaGFlbGJhaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTmVlZCB0byB1c2UgY29u c3QgU3RyaW5nIGluIEhUTUxWaWRlb0VsZW1lbnQ6OnBvc3RlckltYWdlVVJMCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIzMTcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBiZWhhdmlvcmFsIGNoYW5n ZXMuCisKKyAgICAgICAgVGhpcyBpcyB0aGUgZm9sbG93dXAgb2YgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDI2MworICAgICAgICBOZWVkIHRvIHVzZSBjb25zdCBT dHJpbmcgaW5zdGVhZCBvZiBjb25zdCBBdG9taWNTdHJpbmcmIHdoaWNoIG1lYW5zIHdlIHdpbGwg ZG8gYW4gZXh0cmEgaGFzaCBsb29rdXAKKworICAgICAgICAqIGh0bWwvSFRNTFZpZGVvRWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVmlkZW9FbGVtZW50Ojpwb3N0ZXJJbWFnZVVS TCk6IENoYW5nZSB0byB1c2UgY29uc3QgU3RyaW5nIGZvciB1cmwKKwogMjAxMy0wMy0xMyAgUmFm YWVsIFdlaW5zdGVpbiAgPHJhZmFlbHdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtIVE1MVGVt cGxhdGVFbGVtZW50XSBFT0Ygc2hvdWxkIHVud2luZCB0aGUgc3RhY2sgb2YgdGVtcGxhdGUgaW5z ZXJ0aW9uIG1vZGVzIGl0ZXJhdGl2ZWx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxWaWRlb0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVmlkZW9FbGVt ZW50LmNwcAppbmRleCBiYTcwZGNlYWI5OGIwMTg0YjBlMTdhNTBhNDFmNTQwYWEyZTA0NGUxLi4y OThiMzQzZGFhNjdmNDRlOTE1NzY4NzM0OGE2ZjFmYzI4ZGM3NjhkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxWaWRlb0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTFZpZGVvRWxlbWVudC5jcHAKQEAgLTMxNyw3ICszMTcsNyBAQCB1bnNpZ25lZCBI VE1MVmlkZW9FbGVtZW50Ojp3ZWJraXREcm9wcGVkRnJhbWVDb3VudCgpIGNvbnN0CiAKIEtVUkwg SFRNTFZpZGVvRWxlbWVudDo6cG9zdGVySW1hZ2VVUkwoKSBjb25zdAogewotICAgIGNvbnN0IEF0 b21pY1N0cmluZyYgdXJsID0gc3RyaXBMZWFkaW5nQW5kVHJhaWxpbmdIVE1MU3BhY2VzKGltYWdl U291cmNlVVJMKCkpOworICAgIGNvbnN0IFN0cmluZyB1cmwgPSBzdHJpcExlYWRpbmdBbmRUcmFp bGluZ0hUTUxTcGFjZXMoaW1hZ2VTb3VyY2VVUkwoKSk7CiAgICAgaWYgKHVybC5pc0VtcHR5KCkp CiAgICAgICAgIHJldHVybiBLVVJMKCk7CiAgICAgcmV0dXJuIGRvY3VtZW50KCktPmNvbXBsZXRl VVJMKHVybCk7Cg== 193143 2013-03-14 10:04:03 -0700 2013-03-18 09:14:22 -0700 Patch bug-112317-20130314095959.patch text/plain 1645 michaelbai U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQxZGRlYTE3YmNiMjk4 NjJjYzlmYzdjOGEyOGJkYWU3NGJlOWViZC4uZDEwOTUzZTcyNjM5NGFiYzJhNDlmM2Y3YjRmY2Y5 MTc0MDI2YmYyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTEzICBUYW8g QmFpICA8bWljaGFlbGJhaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTmVlZCB0byB1c2UgY29u c3QgU3RyaW5nIGluIEhUTUxWaWRlb0VsZW1lbnQ6OnBvc3RlckltYWdlVVJMCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIzMTcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBiZWhhdmlvcmFsIGNoYW5n ZXMuCisKKyAgICAgICAgVGhpcyBpcyB0aGUgZm9sbG93dXAgb2YgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDI2MworICAgICAgICBOZWVkIHRvIHVzZSBTdHJpbmcg aW5zdGVhZCBvZiBjb25zdCBBdG9taWNTdHJpbmcmIHdoaWNoIG1lYW5zIHdlIHdpbGwgZG8gYW4g ZXh0cmEgaGFzaCBsb29rdXAKKworICAgICAgICAqIGh0bWwvSFRNTFZpZGVvRWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MVmlkZW9FbGVtZW50Ojpwb3N0ZXJJbWFnZVVSTCk6IENo YW5nZSB0byB1c2UgU3RyaW5nIGZvciB1cmwKKwogMjAxMy0wMy0xMyAgUmFmYWVsIFdlaW5zdGVp biAgPHJhZmFlbHdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtIVE1MVGVtcGxhdGVFbGVtZW50 XSBFT0Ygc2hvdWxkIHVud2luZCB0aGUgc3RhY2sgb2YgdGVtcGxhdGUgaW5zZXJ0aW9uIG1vZGVz IGl0ZXJhdGl2ZWx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxWaWRlb0Vs ZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVmlkZW9FbGVtZW50LmNwcAppbmRl eCBiYTcwZGNlYWI5OGIwMTg0YjBlMTdhNTBhNDFmNTQwYWEyZTA0NGUxLi4wMmVjMmM0MWZjMmM2 ZTMyZTQ3MGQ4MTE2OTNkNjhiYzJhYzc1ZTYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxWaWRlb0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFZp ZGVvRWxlbWVudC5jcHAKQEAgLTMxNyw3ICszMTcsNyBAQCB1bnNpZ25lZCBIVE1MVmlkZW9FbGVt ZW50Ojp3ZWJraXREcm9wcGVkRnJhbWVDb3VudCgpIGNvbnN0CiAKIEtVUkwgSFRNTFZpZGVvRWxl bWVudDo6cG9zdGVySW1hZ2VVUkwoKSBjb25zdAogewotICAgIGNvbnN0IEF0b21pY1N0cmluZyYg dXJsID0gc3RyaXBMZWFkaW5nQW5kVHJhaWxpbmdIVE1MU3BhY2VzKGltYWdlU291cmNlVVJMKCkp OworICAgIFN0cmluZyB1cmwgPSBzdHJpcExlYWRpbmdBbmRUcmFpbGluZ0hUTUxTcGFjZXMoaW1h Z2VTb3VyY2VVUkwoKSk7CiAgICAgaWYgKHVybC5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiBL VVJMKCk7CiAgICAgcmV0dXJuIGRvY3VtZW50KCktPmNvbXBsZXRlVVJMKHVybCk7Cg==