112298 2013-03-13 16:24:27 -0700 [WebGL] array-bounds-clamping should use less dramatic numbers 2013-03-13 19:17:29 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino gman kbr webkit-bug-importer oldest_to_newest 854776 0 dino 2013-03-13 16:24:27 -0700 Some architectures seem unable to handle the cast int(infinity) (where infinity is a float) in GLSL, which causes array-bounds-clamping to fail. From what I've seen, they always return 0 in this case, so we're still doing acceptable clamping. Unfortunately we can't use the isinf() function to test for this because it isn't in GLSLES 1.0. I suggest replacing the MAX_NUMBER (infinity) values in the test with some large but not huge numbers, although maybe we should also be explicitly testing our casts from infinity as well? 854777 1 webkit-bug-importer 2013-03-13 16:25:05 -0700 <rdar://problem/13415829> 854783 2 193021 dino 2013-03-13 16:29:28 -0700 Created attachment 193021 Patch 854803 3 kbr 2013-03-13 17:13:07 -0700 I noticed this too on Windows platforms using ANGLE. It looks like Direct3D doesn't specify the result of HLSL intrinsics like clamp when the inputs are +/-infinity. 854810 4 193021 kbr 2013-03-13 17:25:20 -0700 Comment on attachment 193021 Patch Seems fine for this layout test. It would be good to add more tests verifying out-of-range access behavior works according to spec. Currently conformance/uniforms/out-of-bounds-uniform-array-access.html is the only conformance test in this area. r=me 854823 5 dino 2013-03-13 17:46:54 -0700 It's pretty disappointing how small a number can trigger this :( 854864 6 dino 2013-03-13 19:17:29 -0700 Committed r145780: <http://trac.webkit.org/changeset/145780> 193021 2013-03-13 16:29:28 -0700 2013-03-13 17:25:19 -0700 Patch bug-112298-20130314102524.patch text/plain 1567 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NzUxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjI5YWNkMzgyODk1N2YzNjFjNDVk NjM2OTYxNGE0MmQ5ZGY4ODlhYS4uZjFlNjYzMTU3OTU4NmY5Yjc5YjJiY2JkNDMyZDNjNmRkNWUz Y2VmYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAzLTEzICBEZWFuIEphY2tzb24gIDxk aW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViR0xdIGFycmF5LWJvdW5kcy1jbGFtcGluZyBz aG91bGQgdXNlIGxlc3MgZHJhbWF0aWMgbnVtYmVycworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMjk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwbGFjZSBOdW1iZXIuTUFYX1ZBTFVFIHdpdGggYSBu b24taW5maW5pdGUgbnVtYmVyLgorCisgICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvYXJyYXkt Ym91bmRzLWNsYW1waW5nLmh0bWw6CisKIDIwMTMtMDMtMTMgIFRhbyBCYWkgIDxtaWNoYWVsYmFp QGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgdGhlIGRlZmF1bHQgdmlkZW8gcG9zdGVyIGlm IGl0IGRvZXNuJ3QgZXhpc3QgaW4gdmlkZW8gdGFnCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2NhbnZhcy93ZWJnbC9hcnJheS1ib3VuZHMtY2xhbXBpbmcuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvY2FudmFzL3dlYmdsL2FycmF5LWJvdW5kcy1jbGFtcGluZy5odG1sCmluZGV4IGE5MGRl ZTc1NGQ1YTZmNzIyMjM2ZTk4NzQ2Y2ZmMDA0YTllMzdhODUuLjk2M2Q3OWU2ZTc2NjI1Mzk1ZjA4 YWVlMmMyYmQ3M2UwNmUwYzViYTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFz L3dlYmdsL2FycmF5LWJvdW5kcy1jbGFtcGluZy5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv Y2FudmFzL3dlYmdsL2FycmF5LWJvdW5kcy1jbGFtcGluZy5odG1sCkBAIC02Nyw3ICs2Nyw3IEBA IGZ1bmN0aW9uIGluaXQoKQogICAgICAgICAgICAgICAgICAgLy8gbGltaXRzIG9uIGVhY2ggc2lk ZSwgbmVhciB0aGUgbGltaXRzLCBhbmQgdGhlCiAgICAgICAgICAgICAgICAgICAvLyBleGFjdCBs aW1pdHMuCiAgICAgICAgICAgICAgICAgICAvLyBUaGlzIHNob3VsZCBiZSBjbGFtcGVkIHRvIFsw LCAwLCAwLCA3LCA3LCA3XQotICAgICAgICAgICAgICAgICAgbmV3IEZsb2F0MzJBcnJheShbIC1O dW1iZXIuTUFYX1ZBTFVFLCAtMSwgMCwgNywgOCwgTnVtYmVyLk1BWF9WQUxVRV0pLAorICAgICAg ICAgICAgICAgICAgbmV3IEZsb2F0MzJBcnJheShbIC0xMjM0NTY3ODksIC0xLCAwLCA3LCA4LCAx MjM0NTY3ODldKSwKICAgICAgICAgICAgICAgICAgIGdsLlNUQVRJQ19EUkFXKTsKICAgICBnbC5l bmFibGVWZXJ0ZXhBdHRyaWJBcnJheSgxKTsKICAgICBnbC52ZXJ0ZXhBdHRyaWJQb2ludGVyKDEs IDEsIGdsLkZMT0FULCBmYWxzZSwgMCwgMCk7Cg==