112291 2013-03-13 14:30:22 -0700 run-perf-tests should support content_shell 2013-03-13 15:36:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dpranke eric jochen rniwa webkit.review.bot oldest_to_newest 854627 0 abarth 2013-03-13 14:30:22 -0700 run-perf-tests should support content_shell 854628 1 192992 abarth 2013-03-13 14:30:34 -0700 Created attachment 192992 work in progress 854646 2 192997 abarth 2013-03-13 14:37:04 -0700 Created attachment 192997 Patch 854649 3 192997 eric 2013-03-13 14:39:21 -0700 Comment on attachment 192997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192997&action=review > Tools/Scripts/webkitpy/performance_tests/perftest.py:238 > + re.compile(r'INFO:SkFontHost_fontconfig.cpp'), > + re.compile(r'Running without the SUID sandbox'), You might want to mark that these are from content_shell in a comment. 854653 4 192997 jochen 2013-03-13 14:40:54 -0700 Comment on attachment 192997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192997&action=review >> Tools/Scripts/webkitpy/performance_tests/perftest.py:238 >> + re.compile(r'Running without the SUID sandbox'), > > You might want to mark that these are from content_shell in a comment. Or just install the SUID sandbox... https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment 854659 5 abarth 2013-03-13 14:45:54 -0700 > Or just install the SUID sandbox... https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment That would solve the problem for me, but other folks would run into the error. 854663 6 192998 abarth 2013-03-13 14:46:47 -0700 Created attachment 192998 Patch for landing 854665 7 jochen 2013-03-13 14:47:51 -0700 Doesn't the error include the link how to fix it? I think the idea is that running any browser without a sandbox is bad. However, since content_shell in DRT mode doesn't allow outgoing connections anyway, I guess it doesn't really matter. 854692 8 abarth 2013-03-13 15:02:41 -0700 > Doesn't the error include the link how to fix it? Yes, but I want to run performance tests, not fix configurations problems. :) > However, since content_shell in DRT mode doesn't allow outgoing connections anyway, I guess it doesn't really matter. Maybe I should fix it, but it should block me from profiling "<html>". 854727 9 192998 webkit.review.bot 2013-03-13 15:36:24 -0700 Comment on attachment 192998 Patch for landing Clearing flags on attachment: 192998 Committed r145764: <http://trac.webkit.org/changeset/145764> 854728 10 webkit.review.bot 2013-03-13 15:36:28 -0700 All reviewed patches have been landed. Closing bug. 192992 2013-03-13 14:30:34 -0700 2013-03-13 14:37:02 -0700 work in progress bug-112291-20130313142631.patch text/plain 1690 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NzQ3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTdhNTBmZGYxY2IyMWFlMGQxOGQyMTVmOGE1NmExNWQy Nzg5YzNjMi4uODFkMTc5NmUzY2QxYTU4YTM0ZTVkZTYwOTUyYTdhN2RjYmJlNzU1NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTAzLTEzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgcnVuLXBlcmYtdGVzdHMgc2hvdWxkIHN1cHBvcnQgY29udGVudF9zaGVsbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMjkxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weToKKyAgICAgICAgKFBlcmZUZXN0 c1J1bm5lci5fcGFyc2VfYXJncyk6CisKIDIwMTMtMDMtMTMgIFNpbW9uIEhhdXNtYW5uICA8c2lt b24uaGF1c21hbm5AZGlnaWEuY29tPgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCBwcm9zcGVj dGl2ZSBXaW5kb3dzIGJ1aWxkIGZpeApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weQppbmRleCBjNTg4MjEy MmQ3NTZkYTk3NTgyNTRlY2ZiY2ZjZDUwZmZkMDBkM2FkLi5hNWRkMGIxZGMwNTg1OTBiMzVjYTVi M2MwYTZlNDExNjNmYWUyOWY4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Bl cmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weQpAQCAtMTI3LDYgKzEy Nyw4IEBAIGNsYXNzIFBlcmZUZXN0c1J1bm5lcihvYmplY3QpOgogICAgICAgICAgICAgb3B0cGFy c2UubWFrZV9vcHRpb24oIi0tYWRkaXRpb25hbC1kcnQtZmxhZyIsIGFjdGlvbj0iYXBwZW5kIiwK ICAgICAgICAgICAgICAgICBkZWZhdWx0PVtdLCBoZWxwPSJBZGRpdGlvbmFsIGNvbW1hbmQgbGlu ZSBmbGFnIHRvIHBhc3MgdG8gRHVtcFJlbmRlclRyZWUgIgogICAgICAgICAgICAgICAgICAgICAg IlNwZWNpZnkgbXVsdGlwbGUgdGltZXMgdG8gYWRkIG11bHRpcGxlIGZsYWdzLiIpLAorICAgICAg ICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tZHJpdmVyLW5hbWUiLCB0eXBlPSJzdHJpbmci LAorICAgICAgICAgICAgICAgIGhlbHA9IkFsdGVybmF0aXZlIER1bXBSZW5kZXJUcmVlIGJpbmFy eSB0byB1c2UiKSwKICAgICAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXJlcGVhdCIs IGRlZmF1bHQ9MSwgdHlwZT0iaW50IiwKICAgICAgICAgICAgICAgICBoZWxwPSJTcGVjaWZ5IG51 bWJlciBvZiB0aW1lcyB0byBydW4gdGVzdCBzZXQgKGRlZmF1bHQ6IDEpLiIpLAogICAgICAgICAg ICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tdGVzdC1ydW5uZXItY291bnQiLCBkZWZhdWx0PURF RkFVTFRfVEVTVF9SVU5ORVJfQ09VTlQsIHR5cGU9ImludCIsCg== 192997 2013-03-13 14:37:04 -0700 2013-03-13 14:46:44 -0700 Patch bug-112291-20130313143302.patch text/plain 2364 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NzUyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTdhNTBmZGYxY2IyMWFlMGQxOGQyMTVmOGE1NmExNWQy Nzg5YzNjMi4uODFkMTc5NmUzY2QxYTU4YTM0ZTVkZTYwOTUyYTdhN2RjYmJlNzU1NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTAzLTEzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgcnVuLXBlcmYtdGVzdHMgc2hvdWxkIHN1cHBvcnQgY29udGVudF9zaGVsbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMjkxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weToKKyAgICAgICAgKFBlcmZUZXN0 c1J1bm5lci5fcGFyc2VfYXJncyk6CisKIDIwMTMtMDMtMTMgIFNpbW9uIEhhdXNtYW5uICA8c2lt b24uaGF1c21hbm5AZGlnaWEuY29tPgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCBwcm9zcGVj dGl2ZSBXaW5kb3dzIGJ1aWxkIGZpeApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv cGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3QucHkKaW5kZXggNGIyZTFjOWY4OWM1MDdkZDM5ODcy YWJlYzAxYTQ3NzI2MDNkNWI5Ni4uZTRmNTY2NzczMDIwZGJmMGQyZDQ5OGRkYzJlMjBlZGRjNTJm YmJkMCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0 cy9wZXJmdGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNlX3Rl c3RzL3BlcmZ0ZXN0LnB5CkBAIC0yMzQsNiArMjM0LDggQEAgY2xhc3MgUGVyZlRlc3Qob2JqZWN0 KToKICAgICAgICAgcmUuY29tcGlsZShyJ15Vbmtub3duIG9wdGlvbjonKSwKICAgICAgICAgcmUu Y29tcGlsZShyJ15cW1dBUk5JTkc6cHJveHlfc2VydmljZS5jYycpLAogICAgICAgICByZS5jb21w aWxlKHInXlxbSU5GTzonKSwKKyAgICAgICAgcmUuY29tcGlsZShyJ0lORk86U2tGb250SG9zdF9m b250Y29uZmlnLmNwcCcpLAorICAgICAgICByZS5jb21waWxlKHInUnVubmluZyB3aXRob3V0IHRo ZSBTVUlEIHNhbmRib3gnKSwKICAgICBdCiAKICAgICBfbGluZXNfdG9faWdub3JlX2luX3BhcnNl cl9yZXN1bHQgPSBbCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BlcmZvcm1h bmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVy Zm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyLnB5CmluZGV4IGM1ODgyMTIyZDc1NmRhOTc1 ODI1NGVjZmJjZmNkNTBmZmQwMGQzYWQuLmE1ZGQwYjFkYzA1ODU5MGIzNWNhNWIzYzBhNmU0MTE2 M2ZhZTI5ZjggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2Vf dGVzdHMvcGVyZnRlc3RzcnVubmVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVy Zm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyLnB5CkBAIC0xMjcsNiArMTI3LDggQEAgY2xh c3MgUGVyZlRlc3RzUnVubmVyKG9iamVjdCk6CiAgICAgICAgICAgICBvcHRwYXJzZS5tYWtlX29w dGlvbigiLS1hZGRpdGlvbmFsLWRydC1mbGFnIiwgYWN0aW9uPSJhcHBlbmQiLAogICAgICAgICAg ICAgICAgIGRlZmF1bHQ9W10sIGhlbHA9IkFkZGl0aW9uYWwgY29tbWFuZCBsaW5lIGZsYWcgdG8g cGFzcyB0byBEdW1wUmVuZGVyVHJlZSAiCiAgICAgICAgICAgICAgICAgICAgICAiU3BlY2lmeSBt dWx0aXBsZSB0aW1lcyB0byBhZGQgbXVsdGlwbGUgZmxhZ3MuIiksCisgICAgICAgICAgICBvcHRw YXJzZS5tYWtlX29wdGlvbigiLS1kcml2ZXItbmFtZSIsIHR5cGU9InN0cmluZyIsCisgICAgICAg ICAgICAgICAgaGVscD0iQWx0ZXJuYXRpdmUgRHVtcFJlbmRlclRyZWUgYmluYXJ5IHRvIHVzZSIp LAogICAgICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tcmVwZWF0IiwgZGVmYXVsdD0x LCB0eXBlPSJpbnQiLAogICAgICAgICAgICAgICAgIGhlbHA9IlNwZWNpZnkgbnVtYmVyIG9mIHRp bWVzIHRvIHJ1biB0ZXN0IHNldCAoZGVmYXVsdDogMSkuIiksCiAgICAgICAgICAgICBvcHRwYXJz ZS5tYWtlX29wdGlvbigiLS10ZXN0LXJ1bm5lci1jb3VudCIsIGRlZmF1bHQ9REVGQVVMVF9URVNU X1JVTk5FUl9DT1VOVCwgdHlwZT0iaW50IiwK 192998 2013-03-13 14:46:47 -0700 2013-03-13 15:36:24 -0700 Patch for landing bug-112291-20130313144244.patch text/plain 2437 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NzUyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTdhNTBmZGYxY2IyMWFlMGQxOGQyMTVmOGE1NmExNWQy Nzg5YzNjMi4uMzI5YzZlYTE3NDUwOWJkN2Y2MDBkOGI4ODgyYTIxZmFkY2M2MzdlMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTAzLTEzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgcnVuLXBlcmYtdGVzdHMgc2hvdWxkIHN1cHBvcnQgY29udGVudF9zaGVsbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMjkxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Bl cmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weToKKyAgICAgICAgKFBlcmZUZXN0c1J1 bm5lci5fcGFyc2VfYXJncyk6CisKIDIwMTMtMDMtMTMgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24u aGF1c21hbm5AZGlnaWEuY29tPgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCBwcm9zcGVjdGl2 ZSBXaW5kb3dzIGJ1aWxkIGZpeApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w ZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVy Zm9ybWFuY2VfdGVzdHMvcGVyZnRlc3QucHkKaW5kZXggNGIyZTFjOWY4OWM1MDdkZDM5ODcyYWJl YzAxYTQ3NzI2MDNkNWI5Ni4uMjlhNzk2ZjRhZjBmOGYwNzQwYzQ1NTBmOTcyOWYxZmFkNjJiODU3 MSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0cy9w ZXJmdGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNlX3Rlc3Rz L3BlcmZ0ZXN0LnB5CkBAIC0yMzQsNiArMjM0LDkgQEAgY2xhc3MgUGVyZlRlc3Qob2JqZWN0KToK ICAgICAgICAgcmUuY29tcGlsZShyJ15Vbmtub3duIG9wdGlvbjonKSwKICAgICAgICAgcmUuY29t cGlsZShyJ15cW1dBUk5JTkc6cHJveHlfc2VydmljZS5jYycpLAogICAgICAgICByZS5jb21waWxl KHInXlxbSU5GTzonKSwKKyAgICAgICAgIyBUaGVzZSBzdGRlcnIgbWVzc2FnZXMgY29tZSBmcm9t IGNvbnRlbnRfc2hlbGwgb24gY2hyb21pdW0tbGludXguCisgICAgICAgIHJlLmNvbXBpbGUocidJ TkZPOlNrRm9udEhvc3RfZm9udGNvbmZpZy5jcHAnKSwKKyAgICAgICAgcmUuY29tcGlsZShyJ1J1 bm5pbmcgd2l0aG91dCB0aGUgU1VJRCBzYW5kYm94JyksCiAgICAgXQogCiAgICAgX2xpbmVzX3Rv X2lnbm9yZV9pbl9wYXJzZXJfcmVzdWx0ID0gWwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weQppbmRleCBj NTg4MjEyMmQ3NTZkYTk3NTgyNTRlY2ZiY2ZjZDUwZmZkMDBkM2FkLi5hNWRkMGIxZGMwNTg1OTBi MzVjYTViM2MwYTZlNDExNjNmYWUyOWY4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weQpAQCAtMTI3 LDYgKzEyNyw4IEBAIGNsYXNzIFBlcmZUZXN0c1J1bm5lcihvYmplY3QpOgogICAgICAgICAgICAg b3B0cGFyc2UubWFrZV9vcHRpb24oIi0tYWRkaXRpb25hbC1kcnQtZmxhZyIsIGFjdGlvbj0iYXBw ZW5kIiwKICAgICAgICAgICAgICAgICBkZWZhdWx0PVtdLCBoZWxwPSJBZGRpdGlvbmFsIGNvbW1h bmQgbGluZSBmbGFnIHRvIHBhc3MgdG8gRHVtcFJlbmRlclRyZWUgIgogICAgICAgICAgICAgICAg ICAgICAgIlNwZWNpZnkgbXVsdGlwbGUgdGltZXMgdG8gYWRkIG11bHRpcGxlIGZsYWdzLiIpLAor ICAgICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tZHJpdmVyLW5hbWUiLCB0eXBlPSJz dHJpbmciLAorICAgICAgICAgICAgICAgIGhlbHA9IkFsdGVybmF0aXZlIER1bXBSZW5kZXJUcmVl IGJpbmFyeSB0byB1c2UiKSwKICAgICAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXJl cGVhdCIsIGRlZmF1bHQ9MSwgdHlwZT0iaW50IiwKICAgICAgICAgICAgICAgICBoZWxwPSJTcGVj aWZ5IG51bWJlciBvZiB0aW1lcyB0byBydW4gdGVzdCBzZXQgKGRlZmF1bHQ6IDEpLiIpLAogICAg ICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tdGVzdC1ydW5uZXItY291bnQiLCBkZWZh dWx0PURFRkFVTFRfVEVTVF9SVU5ORVJfQ09VTlQsIHR5cGU9ImludCIsCg==