112290 2013-03-13 14:24:23 -0700 [BlackBerry] Do not do scroll position adjustment if selecting in a subframe 2013-03-13 15:33:07 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 shuwu webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 854620 0 shuwu 2013-03-13 14:24:23 -0700 In SelectionHandler scroll position adjustment animation is based on main frame. If selecting in a subframe, don't do animation. 854644 1 192996 shuwu 2013-03-13 14:36:31 -0700 Created attachment 192996 Patch 854664 2 192996 rwlbuis 2013-03-13 14:47:48 -0700 Comment on attachment 192996 Patch LGTM. 854721 3 192996 webkit.review.bot 2013-03-13 15:33:04 -0700 Comment on attachment 192996 Patch Clearing flags on attachment: 192996 Committed r145763: <http://trac.webkit.org/changeset/145763> 854722 4 webkit.review.bot 2013-03-13 15:33:07 -0700 All reviewed patches have been landed. Closing bug. 192996 2013-03-13 14:36:31 -0700 2013-03-13 15:33:04 -0700 Patch 0001-2013-03-13-Iris-Wu-shuwu-blackberry.com.patch text/plain 3542 shuwu RnJvbSAyOTM2NWRmZDA2NDFjNjM1NzVjNjAxNzJiMDgxNmMwMWQxNDcxMjA5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJcmlzIFd1IDxzaHV3dUBibGFja2JlcnJ5LmNvbT4KRGF0ZTog V2VkLCAxMyBNYXIgMjAxMyAxNjoxMjozMyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTMtMDMt MTMgIElyaXMgV3UgIDxzaHV3dUBibGFja2JlcnJ5LmNvbT4KCiAgICAgICAgW0JsYWNrQmVycnld IERvIG5vdCBkbyBzY3JvbGwgcG9zaXRpb24gYWRqdXN0bWVudCBpZiBzZWxlY3RpbmcgaW4gYSBz dWJmcmFtZQogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTIyOTAKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFBSIDI2 NzM5NAoKICAgICAgICBJbiBTZWxlY3Rpb25IYW5kbGVyOjplbnN1cmVTZWxlY3RlZFRleHRWaXNp YmxlKCksIHNjcm9sbCBwb3NpdGlvbgogICAgICAgIGFuaW1hdGlvbiBpcyBiYXNlZCBvbiBtYWlu IGZyYW1lLiBJZiBzZWxlY3RpbmcgaW4gYSBzdWJmcmFtZSwgZG9uJ3QKICAgICAgICBkbyBhbmlt YXRpb24uCgogICAgICAgIEludGVybmFsbHkgUmV2aWV3ZWQgQnkgR2VuZXZpZXZlIE1hay4KCiAg ICAgICAgKiBXZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwOgogICAgICAgIChCbGFj a0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlvbkhhbmRsZXI6OmVuc3VyZVNlbGVjdGVkVGV4dFZpc2li bGUpOgotLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgIHwgICAxOCArKysrKysrKysrKysrKysrKysKIC4uLi9ibGFja2JlcnJ5L1dlYktpdFN1cHBv cnQvU2VsZWN0aW9uSGFuZGxlci5jcHAgIHwgICAgNiArKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwg MjIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5n ZUxvZwppbmRleCBkZDBkZDE4Li4yMzMwYTVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM b2cKQEAgLTEsNSArMSwyMyBAQAogMjAxMy0wMy0xMyAgSXJpcyBXdSAgPHNodXd1QGJsYWNrYmVy cnkuY29tPgogCisgICAgICAgIFtCbGFja0JlcnJ5XSBEbyBub3QgZG8gc2Nyb2xsIHBvc2l0aW9u IGFkanVzdG1lbnQgaWYgc2VsZWN0aW5nIGluIGEgc3ViZnJhbWUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjI5MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBSIDI2NzM5NAorCisgICAgICAgIEluIFNl bGVjdGlvbkhhbmRsZXI6OmVuc3VyZVNlbGVjdGVkVGV4dFZpc2libGUoKSwgc2Nyb2xsIHBvc2l0 aW9uCisgICAgICAgIGFuaW1hdGlvbiBpcyBiYXNlZCBvbiBtYWluIGZyYW1lLiBJZiBzZWxlY3Rp bmcgaW4gYSBzdWJmcmFtZSwgZG9uJ3QKKyAgICAgICAgZG8gYW5pbWF0aW9uLgorCisgICAgICAg IEludGVybmFsbHkgUmV2aWV3ZWQgQnkgR2VuZXZpZXZlIE1hay4KKworICAgICAgICAqIFdlYktp dFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJL aXQ6OlNlbGVjdGlvbkhhbmRsZXI6OmVuc3VyZVNlbGVjdGVkVGV4dFZpc2libGUpOgorCisyMDEz LTAzLTEzICBJcmlzIFd1ICA8c2h1d3VAYmxhY2tiZXJyeS5jb20+CisKICAgICAgICAgW0JsYWNr QmVycnldIFRvdWNoIEhvbGQgc2VsZWN0aW9uIGRvZXMgbm90IHNjcm9sbCB0ZXh0IGFyZWEgb3Ig b3RoZXIgc3ViZnJhbWUgdW50aWwgc2VsZWN0aW9uIHJlYWNoZXMgYm90dG9tIG9mIHRoZSBwYWdl LgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMjU5 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1Nl bGVjdGlvbkhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBv cnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKaW5kZXggNGRhZjVkNi4uZjE1MTM0NyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxl ci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0 aW9uSGFuZGxlci5jcHAKQEAgLTc4NCw2ICs3ODQsMTAgQEAgYm9vbCBTZWxlY3Rpb25IYW5kbGVy OjplbnN1cmVTZWxlY3RlZFRleHRWaXNpYmxlKGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiBwb2lu dCwKICAgICBpZiAoIXNjcm9sbElmTmVlZGVkKQogICAgICAgICByZXR1cm4gdmlld3BvcnRSZWN0 Lm1heFkoKSA+PSBwb2ludC55KCkgKyBtX3Njcm9sbE1hcmdpbi5oZWlnaHQoKTsKIAorICAgIC8v IFNjcm9sbCBwb3NpdGlvbiBhZGp1c3RtZW50IGhlcmUgaXMgYmFzZWQgb24gbWFpbiBmcmFtZS4g SWYgc2VsZWN0aW5nIGluIGEgc3ViZnJhbWUsIGRvbid0IGRvIGFuaW1hdGlvbi4KKyAgICBpZiAo IW1fc2VsZWN0aW9uVmlld3BvcnRSZWN0LmlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworCiAgICAgV2ViQ29yZTo6SW50UmVjdCBlbmRMb2NhdGlvbiA9IG1fYW5pbWF0aW9uT3Zlcmxh eUVuZFBvcy5hYnNvbHV0ZUNhcmV0Qm91bmRzKCk7CiAKICAgICBGcmFtZSogZm9jdXNlZEZyYW1l ID0gbV93ZWJQYWdlLT5mb2N1c2VkT3JNYWluRnJhbWUoKTsKQEAgLTgwMyw4ICs4MDcsNiBAQCBi b29sIFNlbGVjdGlvbkhhbmRsZXI6OmVuc3VyZVNlbGVjdGVkVGV4dFZpc2libGUoY29uc3QgV2Vi Q29yZTo6SW50UG9pbnQmIHBvaW50LAogICAgIGVuZExvY2F0aW9uLmluZmxhdGVYKG1fc2Nyb2xs TWFyZ2luLndpZHRoKCkpOwogICAgIGVuZExvY2F0aW9uLmluZmxhdGVZKG1fc2Nyb2xsTWFyZ2lu LmhlaWdodCgpKTsKIAotICAgIC8vIEZJWE1FOiBUaGUgc2Nyb2xsIHBvc2l0aW9uIGFkanVzdG1l bnQgaGVyZSBpcyBiYXNlZCBvbiBtYWluIGZyYW1lLgotICAgIC8vIElmIHNlbGVjdGluZyBpbiBh IHN1YmZyYW1lLCBkb24ndCBkbyBhbmltYXRpb24uCiAgICAgV2ViQ29yZTo6SW50UmVjdCByZXZl YWxSZWN0KGxheWVyLT5nZXRSZWN0VG9FeHBvc2Uodmlld3BvcnRSZWN0LCBlbmRMb2NhdGlvbiwg U2Nyb2xsQWxpZ25tZW50OjphbGlnblRvRWRnZUlmTmVlZGVkLCBTY3JvbGxBbGlnbm1lbnQ6OmFs aWduVG9FZGdlSWZOZWVkZWQpKTsKICAgICByZXZlYWxSZWN0LnNldFgoc3RkOjptaW4oc3RkOjpt YXgocmV2ZWFsUmVjdC54KCksIDApLCBtX3dlYlBhZ2UtPm1heGltdW1TY3JvbGxQb3NpdGlvbigp LngoKSkpOwogICAgIHJldmVhbFJlY3Quc2V0WShzdGQ6Om1pbihzdGQ6Om1heChyZXZlYWxSZWN0 LnkoKSwgMCksIG1fd2ViUGFnZS0+bWF4aW11bVNjcm9sbFBvc2l0aW9uKCkueSgpKSk7Ci0tIAox LjcuOS41Cgo=