112284 2013-03-13 13:19:46 -0700 Also don't log error messages from the GraphicsContext3D if webGLErrorsToConsoleEnabled is false 2013-03-13 15:26:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen abarth dino esprehn+autocc gman ojan.autocc piman webkit.review.bot oldest_to_newest 854554 0 jochen 2013-03-13 13:19:46 -0700 Also don't log error messages from the GraphicsContext3D if webGLErrorsToConsoleEnabled is false 854557 1 192982 jochen 2013-03-13 13:20:59 -0700 Created attachment 192982 Patch 854581 2 192982 abarth 2013-03-13 13:38:28 -0700 Comment on attachment 192982 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192982&action=review > Source/WebCore/ChangeLog:9 > + Since webGLErrorsToConsoleEnabled is false durin layout tests, this change makes durin -> during > Source/WebCore/html/canvas/WebGLRenderingContext.cpp:399 > + if (m_context->m_synthesizedErrorsToConsole) > + m_context->printGLErrorToConsole(message); Why isn't this needed in DRT? Perhaps the filtering is supposed to happen at another layer? 854586 3 192986 jochen 2013-03-13 13:42:45 -0700 Created attachment 192986 Patch 854597 4 jochen 2013-03-13 13:53:42 -0700 (In reply to comment #2) > (From update of attachment 192982 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=192982&action=review > > > Source/WebCore/ChangeLog:9 > > + Since webGLErrorsToConsoleEnabled is false durin layout tests, this change makes > > durin -> during > > > Source/WebCore/html/canvas/WebGLRenderingContext.cpp:399 > > + if (m_context->m_synthesizedErrorsToConsole) > > + m_context->printGLErrorToConsole(message); > > Why isn't this needed in DRT? Perhaps the filtering is supposed to happen at another layer? For DRT, we use WebGraphicsContext3DInProcessImpl which doesn't implement WebGraphicsContext3D::setErrorMessageCallback() If we instead not invoke the error message callback in the out-of-process version used in content shell, the error messages also won't show up in the regular log which might make debugging of real errors in the future more difficult. 854668 5 192986 abarth 2013-03-13 14:49:13 -0700 Comment on attachment 192986 Patch ok 854710 6 192986 webkit.review.bot 2013-03-13 15:26:23 -0700 Comment on attachment 192986 Patch Clearing flags on attachment: 192986 Committed r145761: <http://trac.webkit.org/changeset/145761> 854711 7 webkit.review.bot 2013-03-13 15:26:26 -0700 All reviewed patches have been landed. Closing bug. 192982 2013-03-13 13:20:59 -0700 2013-03-13 13:42:42 -0700 Patch bug-112284-20130313211655.patch text/plain 1986 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzEzNGI5MTkyYjc4NjM5 ZTU2ZWQyMjBjN2E4YWZlZmZjNDIzYTdiZS4uMGIwMWI0NzczMjAzNGJkYzFkNmVlMDExMjViYTk1 ODhhMjhkZjA0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTEzICBKb2No ZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFsc28gZG9uJ3Qg bG9nIGVycm9yIG1lc3NhZ2VzIGZyb20gdGhlIEdyYXBoaWNzQ29udGV4dDNEIGlmIHdlYkdMRXJy b3JzVG9Db25zb2xlRW5hYmxlZCBpcyBmYWxzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMjg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2hlbiBydW5uaW5nIGxheW91dCB0ZXN0cyBpbiBjb250ZW50 X3NoZWxsLCB3ZSBlbmQgdXAgbG9nZ2luZyBtb3JlIGluZm9ybWF0aW9uLgorICAgICAgICBTaW5j ZSB3ZWJHTEVycm9yc1RvQ29uc29sZUVuYWJsZWQgaXMgZmFsc2UgZHVyaW4gbGF5b3V0IHRlc3Rz LCB0aGlzIGNoYW5nZSBtYWtlcworICAgICAgICBzdXJlIHdlIG1hdGNoIHRoZSBiYXNlbGluZXMu CisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAg ICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHRF cnJvck1lc3NhZ2VDYWxsYmFjazo6b25FcnJvck1lc3NhZ2UpOgorCiAyMDEzLTAzLTEyICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTQ1NTE0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt bC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv Y2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKaW5kZXggNTI1Mjg1NmYwODg3MjRlNzg3 NDZmNWNhNzIxMmNkOGU5YmQyMTQwZi4uNTFhMzUyZGU2N2E3OTg2OGI2Mjg4NzgzOGRkMmNkNDAw ZjYzNGY5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5k ZXJpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJl bmRlcmluZ0NvbnRleHQuY3BwCkBAIC0zOTMsNyArMzkzLDExIEBAIGNsYXNzIFdlYkdMUmVuZGVy aW5nQ29udGV4dEVycm9yTWVzc2FnZUNhbGxiYWNrIDogcHVibGljIEdyYXBoaWNzQ29udGV4dDNE OjpFcnJvCiAgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAgZXhwbGlj aXQgV2ViR0xSZW5kZXJpbmdDb250ZXh0RXJyb3JNZXNzYWdlQ2FsbGJhY2soV2ViR0xSZW5kZXJp bmdDb250ZXh0KiBjYikgOiBtX2NvbnRleHQoY2IpIHsgfQotICAgIHZpcnR1YWwgdm9pZCBvbkVy cm9yTWVzc2FnZShjb25zdCBTdHJpbmcmIG1lc3NhZ2UsIEdDM0RpbnQpIHsgbV9jb250ZXh0LT5w cmludEdMRXJyb3JUb0NvbnNvbGUobWVzc2FnZSk7IH0KKyAgICB2aXJ0dWFsIHZvaWQgb25FcnJv ck1lc3NhZ2UoY29uc3QgU3RyaW5nJiBtZXNzYWdlLCBHQzNEaW50KQorICAgIHsKKyAgICAgICAg aWYgKG1fY29udGV4dC0+bV9zeW50aGVzaXplZEVycm9yc1RvQ29uc29sZSkKKyAgICAgICAgICAg IG1fY29udGV4dC0+cHJpbnRHTEVycm9yVG9Db25zb2xlKG1lc3NhZ2UpOworICAgIH0KICAgICB2 aXJ0dWFsIH5XZWJHTFJlbmRlcmluZ0NvbnRleHRFcnJvck1lc3NhZ2VDYWxsYmFjaygpIHsgfQog cHJpdmF0ZToKICAgICBXZWJHTFJlbmRlcmluZ0NvbnRleHQqIG1fY29udGV4dDsK 192986 2013-03-13 13:42:45 -0700 2013-03-13 15:26:23 -0700 Patch bug-112284-20130313213841.patch text/plain 1987 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzEzNGI5MTkyYjc4NjM5 ZTU2ZWQyMjBjN2E4YWZlZmZjNDIzYTdiZS4uNGJiMWE0ZjgxN2E5ZGMwMjUzMzFkN2I1ZTYwNTc3 MTk2Y2E1ZTU5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTEzICBKb2No ZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFsc28gZG9uJ3Qg bG9nIGVycm9yIG1lc3NhZ2VzIGZyb20gdGhlIEdyYXBoaWNzQ29udGV4dDNEIGlmIHdlYkdMRXJy b3JzVG9Db25zb2xlRW5hYmxlZCBpcyBmYWxzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMjg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2hlbiBydW5uaW5nIGxheW91dCB0ZXN0cyBpbiBjb250ZW50 X3NoZWxsLCB3ZSBlbmQgdXAgbG9nZ2luZyBtb3JlIGluZm9ybWF0aW9uLgorICAgICAgICBTaW5j ZSB3ZWJHTEVycm9yc1RvQ29uc29sZUVuYWJsZWQgaXMgZmFsc2UgZHVyaW5nIGxheW91dCB0ZXN0 cywgdGhpcyBjaGFuZ2UgbWFrZXMKKyAgICAgICAgc3VyZSB3ZSBtYXRjaCB0aGUgYmFzZWxpbmVz LgorCisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0 RXJyb3JNZXNzYWdlQ2FsbGJhY2s6Om9uRXJyb3JNZXNzYWdlKToKKwogMjAxMy0wMy0xMiAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjE0NTUxNC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCmluZGV4IDUyNTI4NTZmMDg4NzI0ZTc4 NzQ2ZjVjYTcyMTJjZDhlOWJkMjE0MGYuLjUxYTM1MmRlNjdhNzk4NjhiNjI4ODc4MzhkZDJjZDQw MGY2MzRmOTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVu ZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xS ZW5kZXJpbmdDb250ZXh0LmNwcApAQCAtMzkzLDcgKzM5MywxMSBAQCBjbGFzcyBXZWJHTFJlbmRl cmluZ0NvbnRleHRFcnJvck1lc3NhZ2VDYWxsYmFjayA6IHB1YmxpYyBHcmFwaGljc0NvbnRleHQz RDo6RXJybwogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgogICAgIGV4cGxp Y2l0IFdlYkdMUmVuZGVyaW5nQ29udGV4dEVycm9yTWVzc2FnZUNhbGxiYWNrKFdlYkdMUmVuZGVy aW5nQ29udGV4dCogY2IpIDogbV9jb250ZXh0KGNiKSB7IH0KLSAgICB2aXJ0dWFsIHZvaWQgb25F cnJvck1lc3NhZ2UoY29uc3QgU3RyaW5nJiBtZXNzYWdlLCBHQzNEaW50KSB7IG1fY29udGV4dC0+ cHJpbnRHTEVycm9yVG9Db25zb2xlKG1lc3NhZ2UpOyB9CisgICAgdmlydHVhbCB2b2lkIG9uRXJy b3JNZXNzYWdlKGNvbnN0IFN0cmluZyYgbWVzc2FnZSwgR0MzRGludCkKKyAgICB7CisgICAgICAg IGlmIChtX2NvbnRleHQtPm1fc3ludGhlc2l6ZWRFcnJvcnNUb0NvbnNvbGUpCisgICAgICAgICAg ICBtX2NvbnRleHQtPnByaW50R0xFcnJvclRvQ29uc29sZShtZXNzYWdlKTsKKyAgICB9CiAgICAg dmlydHVhbCB+V2ViR0xSZW5kZXJpbmdDb250ZXh0RXJyb3JNZXNzYWdlQ2FsbGJhY2soKSB7IH0K IHByaXZhdGU6CiAgICAgV2ViR0xSZW5kZXJpbmdDb250ZXh0KiBtX2NvbnRleHQ7Cg==