112283 2013-03-13 13:18:57 -0700 Set -webkit-font-smoothing: none in fast/regions/autoheight-break-after.html so reftest matches exactly in Mountain Lion 2013-03-14 02:37:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abucur dpranke hyatt mihnea simon.fraser WebkitBugTracker webkit.review.bot oldest_to_newest 854551 0 jamesr 2013-03-13 13:18:57 -0700 Set -webkit-font-smoothing: none in fast/regions/autoheight-break-after.html so reftest matches exactly in Mountain Lion 854555 1 192981 jamesr 2013-03-13 13:20:18 -0700 Created attachment 192981 Patch 854559 2 jamesr 2013-03-13 13:22:13 -0700 This fixes the immediate issue with this test, but I definitely wouldn't mind a more general solution. 854575 3 192981 jamesr 2013-03-13 13:32:48 -0700 Comment on attachment 192981 Patch I think we want to understand why this is different. 854587 4 192987 jamesr 2013-03-13 13:44:19 -0700 Created attachment 192987 Patch 854588 5 192987 hyatt 2013-03-13 13:44:49 -0700 Comment on attachment 192987 Patch r=me 854603 6 jamesr 2013-03-13 13:57:43 -0700 Committed r145749: <http://trac.webkit.org/changeset/145749> 855088 7 abucur 2013-03-14 02:37:31 -0700 Font smoothing seems to be taken into account only when painting the glyphs (Font::drawGlyphs). The flow thread is clipping the graphics context around the overflow rectangle so the smoothed pixels are not painted. In the reference file this is not happening unless overflow: hidden is specified. Why the fail is happening only on Mountain Lion? It seems glyphs can be both antialiased and smoothed (subpixel AA?). Skia's Font::drawGlyphs implementation states: if (!shouldUseSmoothing() || isRunningLayoutTest()) shouldSmoothFonts = false; This doesn't disable AA. Probably some agresive AA on Chromium Mountain Lion is the culprit for the failure. Antialiasing and font smoothing are both disabled if NoSmoothing is specified on the FontDescription and might explain why this is fixed when setting the property. 192981 2013-03-13 13:20:18 -0700 2013-03-13 13:44:16 -0700 Patch bug-112283-20130313131618.patch text/plain 2151 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NzM3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDE2YTVlM2U2ODBhY2UzNDcyMmZh ZWYyZTcyMGQwYTgyNjM3ODMxYy4uNjU5NzJmMWRhZTEyMjFiOTliYjQ2ZjJmZDY2MzAwMWJiOWVl MWEwMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTAzLTEzICBKYW1lcyBSb2JpbnNvbiAg PGphbWVzckBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgU2V0IC13ZWJraXQtZm9udC1zbW9vdGhp bmc6IG5vbmUgaW4gZmFzdC9yZWdpb25zL2F1dG9oZWlnaHQtYnJlYWstYWZ0ZXIuaHRtbCBzbyBy ZWZ0ZXN0IG1hdGNoZXMgZXhhY3RseSBpbiBNb3VudGFpbiBMaW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIyODMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbiBNb3VudGFpbiBMaW9uLCB0aGUgZWRn ZXMgb2YgdGhlIGFoZW0gZ2x5cGhzIHRoYXQgdG91Y2ggdGhlIGJvcmRlciBibGVuZCBzbGlnaHRs eSBkaWZmZXJlbnRseSBpbiB0aGUgdGVzdAorICAgICAgICBjb21wYXJlZCB0byB0aGUgcmVmZXJl bmNlIGlmIGZvbnQgc21vb3RoaW5nIGlzIGVuYWJsZWQuCisKKyAgICAgICAgKiBmYXN0L3JlZ2lv bnMvYXV0b2hlaWdodC1icmVhay1hZnRlci1leHBlY3RlZC5odG1sOgorICAgICAgICAqIGZhc3Qv cmVnaW9ucy9hdXRvaGVpZ2h0LWJyZWFrLWFmdGVyLmh0bWw6CisKKzIwMTMtMDMtMTMgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKwogICAgICAgICBDbGVhbiBvdXQgc29t ZSBzdGFsZSBjaHJvbWl1bSBUZXN0RXhwZWN0YXRpb25zIGVudHJpZXMuCiAKICAgICAgICAgKiBw bGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zOgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9yZWdpb25zL2F1dG9oZWlnaHQtYnJlYWstYWZ0ZXItZXhwZWN0ZWQuaHRtbCBiL0xh eW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9hdXRvaGVpZ2h0LWJyZWFrLWFmdGVyLWV4cGVjdGVkLmh0 bWwKaW5kZXggYTM4YzcyOWU2MTk1ZGI4ZTM3MmY3MzVjNjQ3Njc1YmI4YmViZmQ0NS4uNzAzYWNk OTEzZDQ4ZDU1YWY4NTc3MzY0ZTA4NzVlNDNiYjI2NDJkYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvZmFzdC9yZWdpb25zL2F1dG9oZWlnaHQtYnJlYWstYWZ0ZXItZXhwZWN0ZWQuaHRtbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvYXV0b2hlaWdodC1icmVhay1hZnRlci1leHBlY3Rl ZC5odG1sCkBAIC0yMCw2ICsyMCw3IEBACiAgICAgICAgICAgICB9CiAgICAgICAgICAgICAucmVn aW9uID4gcCB7CiAgICAgICAgICAgICAgICAgZm9udC1mYW1pbHk6IEFoZW07CisgICAgICAgICAg ICAgICAgLXdlYmtpdC1mb250LXNtb290aGluZzogbm9uZTsKICAgICAgICAgICAgICAgICBmb250 LXNpemU6IDEwcHg7CiAgICAgICAgICAgICB9CiAgICAgICAgIDwvc3R5bGU+CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvYXV0b2hlaWdodC1icmVhay1hZnRlci5odG1sIGIv TGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2F1dG9oZWlnaHQtYnJlYWstYWZ0ZXIuaHRtbAppbmRl eCBkM2ZkMDY1NmRiOTY5ZmUxMTI2MjQwZWFjNzZkN2IzZjY4ZGEwMjE0Li4xYWJiN2JjMTBiZDc0 OWM2NTlkMmEzZmViMzg5N2ViYWEzYWRjNjRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0 L3JlZ2lvbnMvYXV0b2hlaWdodC1icmVhay1hZnRlci5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvcmVnaW9ucy9hdXRvaGVpZ2h0LWJyZWFrLWFmdGVyLmh0bWwKQEAgLTE3LDYgKzE3LDcgQEAK ICAgICAgICAgICAgIH0KICAgICAgICAgICAgIC5jb250ZW50IHsKICAgICAgICAgICAgICAgICBm b250LWZhbWlseTogQWhlbTsKKyAgICAgICAgICAgICAgICAtd2Via2l0LWZvbnQtc21vb3RoaW5n OiBub25lOwogICAgICAgICAgICAgICAgIGZvbnQtc2l6ZTogMTBweDsKICAgICAgICAgICAgICAg ICAtd2Via2l0LWZsb3ctaW50bzogZmxvdzsKICAgICAgICAgICAgIH0K 192987 2013-03-13 13:44:19 -0700 2013-03-13 13:44:49 -0700 Patch bug-112283-20130313134019.patch text/plain 1585 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NzM3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDE2YTVlM2U2ODBhY2UzNDcyMmZh ZWYyZTcyMGQwYTgyNjM3ODMxYy4uNTVkZDViNmMzOGNlYjk2YmIxZTM0MDc5OWE0ODRmYThjMDFi ODlkMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTAzLTEzICBKYW1lcyBSb2JpbnNvbiAg PGphbWVzckBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgRm9yY2UgY2xpcCBpbiBmYXN0L3JlZ2lv bnMvYXV0b2hlaWdodC1icmVhay1hZnRlci1leHBlY3RlZC5odG1sIHRvIG1hdGNoIHRlc3QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjI4MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZ2lvbnMgYWx3 YXlzIHNldCBhIGNsaXAgcmVjdCB3aGVuIHJlbmRlcmluZyB0aGVpciBjb250ZW50cy4gT24gTW91 bnRhaW4gTGlvbiwgdGhlIEFoZW0gZ2x5cGhzIHZlcnkgc2xpZ2h0bHkKKyAgICAgICAgdmlzdWFs bHkgb3ZlcmZsb3cgdGhlaXIgYm91bmRzIGlmIHRoZXJlJ3Mgbm8gY2xpcCBzZXQuIFRoaXMgc2V0 cyBhIGNsaXAgaW4gdGhlIHJlZmVyZW5jZSBmaWxlIHNvIHdlIGdldCB0aGUgc2FtZQorICAgICAg ICByZW5kZXJpbmcuCisKKyAgICAgICAgKiBmYXN0L3JlZ2lvbnMvYXV0b2hlaWdodC1icmVhay1h ZnRlci1leHBlY3RlZC5odG1sOgorCisyMDEzLTAzLTEzICBKYW1lcyBSb2JpbnNvbiAgPGphbWVz ckBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgQ2xlYW4gb3V0IHNvbWUgc3RhbGUgY2hyb21pdW0g VGVzdEV4cGVjdGF0aW9ucyBlbnRyaWVzLgogCiAgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0v VGVzdEV4cGVjdGF0aW9uczoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9h dXRvaGVpZ2h0LWJyZWFrLWFmdGVyLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3Jl Z2lvbnMvYXV0b2hlaWdodC1icmVhay1hZnRlci1leHBlY3RlZC5odG1sCmluZGV4IGEzOGM3Mjll NjE5NWRiOGUzNzJmNzM1YzY0NzY3NWJiOGJlYmZkNDUuLmY1NzdjOTJlNWUwMjE3MmI2ZGY5YjA4 MTA5Yzk5ZmY4ODYxOTZiYjEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9h dXRvaGVpZ2h0LWJyZWFrLWFmdGVyLWV4cGVjdGVkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9yZWdpb25zL2F1dG9oZWlnaHQtYnJlYWstYWZ0ZXItZXhwZWN0ZWQuaHRtbApAQCAtNiw2ICs2 LDcgQEAKICAgICAgICAgICAgICAgICB3aWR0aDogMjAwcHg7CiAgICAgICAgICAgICAgICAgbWFy Z2luOiAxMHB4OwogICAgICAgICAgICAgICAgIGZsb2F0OiBsZWZ0OworICAgICAgICAgICAgICAg IG92ZXJmbG93OiBoaWRkZW47CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICAucmVnaW9uQXV0 byB7CiAgICAgICAgICAgICAgICAgYm9yZGVyOiB0aGljayBzb2xpZCByZWQ7Cg==