112272 2013-03-13 11:15:35 -0700 [GTK] Missing atk in install-dependencies script 2013-03-21 08:32:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 csaavedra webkit-unassigned gustavo mrobinson webkit.review.bot oldest_to_newest 854418 0 csaavedra 2013-03-13 11:15:35 -0700 [GTK] Missing atk dependency for gtk in jhbuild moduleset 854419 1 192950 csaavedra 2013-03-13 11:16:36 -0700 Created attachment 192950 Patch 854437 2 mrobinson 2013-03-13 11:45:51 -0700 (In reply to comment #1) > Created an attachment (id=192950) [details] > Patch The criteria for being in non-optional moduleset isn't whether or not there is a hard dependency, but whether or not a particular package requires a particular version to pass layout tests. 854446 3 csaavedra 2013-03-13 11:51:36 -0700 (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=192950) [details] [details] > > Patch > > The criteria for being in non-optional moduleset isn't whether or not there is a hard dependency, but whether or not a particular package requires a particular version to pass layout tests. I think jhbuild has a mechanism to suggest installing packages from the distro. As it is now you can't use update-webkitgtk-libs to bootstrap webkit. 854522 4 192950 mrobinson 2013-03-13 13:02:23 -0700 Comment on attachment 192950 Patch atk should go into install-dependencies instead of here. Only dependencies that require an exact version for layout tests to pass should go into the jhbuild moduleset. 860298 5 194252 csaavedra 2013-03-21 06:53:59 -0700 Created attachment 194252 Patch 860366 6 194252 webkit.review.bot 2013-03-21 08:32:10 -0700 Comment on attachment 194252 Patch Clearing flags on attachment: 194252 Committed r146472: <http://trac.webkit.org/changeset/146472> 860367 7 webkit.review.bot 2013-03-21 08:32:14 -0700 All reviewed patches have been landed. Closing bug. 192950 2013-03-13 11:16:36 -0700 2013-03-21 06:53:52 -0700 Patch bug-112272-20130313201232.patch text/plain 2593 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZThjZGFkZjljODVkODdkMjlkZDU0OWY1YzgwNjc0ZTZl ZWY1Njc4Ny4uY2U0MDc0OTdmM2U5NzkwYWRiMTJhMzllZDVkNzk0MmQ2NDA0Yzk1YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEzLTAzLTEzICBDbGF1ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUS10gTWlzc2luZyBhdGsgZGVwZW5kZW5jeSBmb3IgZ3RrIGluIGpoYnVp bGQgbW9kdWxlc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTIyNzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBHVEsrIGhhcyBhIGhhcmQtZGVwZW5kZW5jeSBvbiBBVEssIHNvIHRoaXMgc2hvdWxkbid0 IGJlCisgICAgICAgIGluIHRoZSBvcHRpb25hbCBtb2R1bGUgbGlzdC4KKworICAgICAgICAqIGd0 ay9qaGJ1aWxkLW9wdGlvbmFsLm1vZHVsZXM6IE1vdmUgZnJvbSBoZXJlLgorICAgICAgICAqIGd0 ay9qaGJ1aWxkLm1vZHVsZXM6IEhlcmUuCisKIDIwMTMtMDMtMTEgIEFuZHJlYXMgS2xpbmcgIDxh a2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdW1dLMV0gQWRkIHN1cHBvcnQgZm9yIGFs ZXJ0KCkgaW4gTWluaUJyb3dzZXIuCmRpZmYgLS1naXQgYS9Ub29scy9ndGsvamhidWlsZC1vcHRp b25hbC5tb2R1bGVzIGIvVG9vbHMvZ3RrL2poYnVpbGQtb3B0aW9uYWwubW9kdWxlcwppbmRleCBk ZTg1OGE4NDFlYzA4ZDA4NTA3ZGFiYWVmYzU4MjFlOTBhMWRlYjBmLi5lMjcyMjAzOThmYTQ2N2Jl OGRkMzQzOTRlMDYzNGE2YzhjMDZjOWYxIDEwMDY0NAotLS0gYS9Ub29scy9ndGsvamhidWlsZC1v cHRpb25hbC5tb2R1bGVzCisrKyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLW9wdGlvbmFsLm1vZHVsZXMK QEAgLTU2LDEyICs1Niw0IEBACiAgICAgICAgICAgICBoYXNoPSJzaGEyNTY6ZWU1MDUzOGRhY2E5 NDQ3YmU2YWQxZWQwZDA0OWZiYjJkYzVhMWJjYWVjZDEzZmRhODQ3YjliNjZmOTIyZWUzNyIvPgog ICA8L2F1dG90b29scz4KIAotICA8YXV0b3Rvb2xzIGlkPSJhdGsiCi0gICAgICAgICAgIGF1dG9n ZW4tc2g9ImNvbmZpZ3VyZSIKLSAgICAgICAgICAgYXV0b2dlbmFyZ3M9Ii0tZGlzYWJsZS1pbnRy b3NwZWN0aW9uIj4KLSAgICA8YnJhbmNoIG1vZHVsZT0iL3B1Yi9HTk9NRS9zb3VyY2VzL2F0ay8y LjUvYXRrLTIuNS4zLnRhci54eiIgdmVyc2lvbj0iMi41LjMiCi0gICAgICAgICAgICByZXBvPSJm dHAuZ25vbWUub3JnIgotICAgICAgICAgICAgaGFzaD0ic2hhMjU2OmFjMTE4ZWYzNGVmNTQ5MGZh MTEzY2Y1MGNmZmRmZjc3MzVkNjI5MzcyM2JmMzVkZjk1OGE4OWZiZGE4NzYzMTMiLz4KLSAgPC9h dXRvdG9vbHM+Ci0KIDwvbW9kdWxlc2V0PgpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2poYnVpbGQu bW9kdWxlcyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggOWFiZDkyZjgxYTk2NmU1 YTk0MjM5ZjgxM2JmMTdmYTJiY2IxMWVkNS4uMjAwYTU5MGRmYzhmZTAzYTI5NTc2OTQ3NTFiMDRh N2JhZGNjZGEyYSAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcworKysgYi9U b29scy9ndGsvamhidWlsZC5tb2R1bGVzCkBAIC0xMzcsNiArMTM3LDcgQEAKICAgICAgIDxkZXAg cGFja2FnZT0iZ2xpYiIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJjYWlybyIvPgogICAgICAgPGRl cCBwYWNrYWdlPSJnZGstcGl4YnVmIi8+CisgICAgICA8ZGVwIHBhY2thZ2U9ImF0ayIgLz4KICAg ICA8L2RlcGVuZGVuY2llcz4KICAgICA8YnJhbmNoIG1vZHVsZT0iL3B1Yi9HTk9NRS9zb3VyY2Vz L2d0aysvMy40L2d0aystMy40LjIudGFyLnh6IiB2ZXJzaW9uPSIzLjQuMiIKICAgICAgICAgICAg IHJlcG89ImZ0cC5nbm9tZS5vcmciCkBAIC0yMTcsNiArMjE4LDE0IEBACiAgICAgPC9icmFuY2g+ CiAgIDwvYXV0b3Rvb2xzPgogCisgIDxhdXRvdG9vbHMgaWQ9ImF0ayIKKyAgICAgICAgICAgYXV0 b2dlbi1zaD0iY29uZmlndXJlIgorICAgICAgICAgICBhdXRvZ2VuYXJncz0iLS1kaXNhYmxlLWlu dHJvc3BlY3Rpb24iPgorICAgIDxicmFuY2ggbW9kdWxlPSIvcHViL0dOT01FL3NvdXJjZXMvYXRr LzIuNS9hdGstMi41LjMudGFyLnh6IiB2ZXJzaW9uPSIyLjUuMyIKKyAgICAgICAgICAgIHJlcG89 ImZ0cC5nbm9tZS5vcmciCisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6YWMxMThlZjM0ZWY1NDkw ZmExMTNjZjUwY2ZmZGZmNzczNWQ2MjkzNzIzYmYzNWRmOTU4YTg5ZmJkYTg3NjMxMyIvPgorICA8 L2F1dG90b29scz4KKwogICA8YXV0b3Rvb2xzIGlkPSJhdC1zcGkyLWNvcmUiIAogICAgICAgICAg ICAgIGF1dG9nZW5hcmdzPSItLWRpc2FibGUtaW50cm9zcGVjdGlvbiI+CiAgICAgPGJyYW5jaCBt b2R1bGU9InB1Yi9HTk9NRS9zb3VyY2VzL2F0LXNwaTItY29yZS8yLjIvYXQtc3BpMi1jb3JlLTIu Mi4xLnRhci54eiIgdmVyc2lvbj0iMi4yLjEiCg== 194252 2013-03-21 06:53:59 -0700 2013-03-21 08:32:10 -0700 Patch bug-112272-20130321154946.patch text/plain 1283 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NDU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmEyYThiNjBhYjgxOTAxYmMzNDJiYTEyMzJjMDlhZThk ZGI2MzNlYi4uMGIwNTkwODk5NzVjMDdhOWI2NWZhOGIzZjI0MjVmOTQ4YjhiMGRjNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEyLTAzLTIxICBDbGF1ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUS10gTWlzc2luZyBhdGsgaW4gaW5zdGFsbC1kZXBlbmRlbmNpZXMgc2Ny aXB0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIy NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGd0 ay9pbnN0YWxsLWRlcGVuZGVuY2llczogQWRkIG1pc3NpbmcgYXRrIGRlcGVuZGVuY3kuCisKIDIw MTMtMDMtMjAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRVdT IGJvdHMgaGF2ZSBzdG9wcGVkIHVwbG9hZGluZyByZXN1bHRzIHRvIGJ1Z3ppbGxhCmRpZmYgLS1n aXQgYS9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMgYi9Ub29scy9ndGsvaW5zdGFsbC1k ZXBlbmRlbmNpZXMKaW5kZXggNmQ2NDMxOWQ5YjJiZmIwMGFkNjRkYWViNDkzODk3OGYyMzgyMTdj My4uN2Y5YWI4NmZlOWM4NjQ4ZmYyYWFmYjE3ZTg3YzI4YWQ2M2ExZDk5OSAxMDA3NTUKLS0tIGEv VG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCisrKyBiL1Rvb2xzL2d0ay9pbnN0YWxsLWRl cGVuZGVuY2llcwpAQCAtNDcsNiArNDcsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVz V2l0aEFwdCB7CiAgICAgICAgIGdwZXJmIFwKICAgICAgICAgZ3RrLWRvYy10b29scyBcCiAgICAg ICAgIGludGx0b29sIFwKKyAgICAgICAgbGliYXRrMS4wLWRldiBcCiAgICAgICAgIGxpYmVuY2hh bnQtZGV2IFwKICAgICAgICAgbGliZmFhZC1kZXYgXAogICAgICAgICBsaWJnYWlsLTMtZGV2IFwK QEAgLTEwNSw2ICsxMDYsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aFl1bSB7 CiAgICAgICAgIGF1dG9jb25mIFwKICAgICAgICAgYXV0b21ha2UgXAogICAgICAgICBiaXNvbiBc CisgICAgICAgIGF0ay1kZXZlbCBcCiAgICAgICAgIGNhaXJvLWRldmVsIFwKICAgICAgICAgZW5j aGFudC1kZXZlbCBcCiAgICAgICAgIGZsZXggXAo=