112271 2013-03-13 11:09:28 -0700 Calling WebInspectorClient::highlight() during a fade-out animation of the PageOverlay won't stop its animation 2013-03-13 11:49:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts graouts thorton timothy webkit-bug-importer webkit.review.bot oldest_to_newest 854410 0 graouts 2013-03-13 11:09:28 -0700 Calling WebInspectorClient::highlight() during a fade-out animation of the PageOverlay won't stop its animation 854416 1 192949 graouts 2013-03-13 11:13:45 -0700 Created attachment 192949 Patch 854417 2 webkit-bug-importer 2013-03-13 11:14:25 -0700 <rdar://problem/13412044> 854421 3 192949 thorton 2013-03-13 11:16:47 -0700 Comment on attachment 192949 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192949&action=review > Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:158 > + m_fadeAnimationTimer.stop(); Should you reset m_fractionFadedIn to ... something? 854424 4 graouts 2013-03-13 11:19:37 -0700 (In reply to comment #3) > (From update of attachment 192949 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=192949&action=review > > > Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:158 > > + m_fadeAnimationTimer.stop(); > > Should you reset m_fractionFadedIn to ... something? m_fractionFadedIn needs to be reset to 1.0 I would say. 854426 5 192951 graouts 2013-03-13 11:25:05 -0700 Created attachment 192951 Patch for landing 854444 6 192951 webkit.review.bot 2013-03-13 11:49:46 -0700 Comment on attachment 192951 Patch for landing Clearing flags on attachment: 192951 Committed r145731: <http://trac.webkit.org/changeset/145731> 854445 7 webkit.review.bot 2013-03-13 11:49:49 -0700 All reviewed patches have been landed. Closing bug. 192949 2013-03-13 11:13:45 -0700 2013-03-13 11:24:56 -0700 Patch bug-112271-20130313190937.patch text/plain 3314 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1Njk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDY3NjIyMTZlNWFlOGFj N2MyZTcwOTQxODA1ZGZlYmRlOWY4ZDdkYi4uNjYwYjJkMTg3OWY1MzQ2OGM5M2I3MWUwMTU5MjIw YzFlZjkwM2MwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAzLTEzICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgQ2FsbGluZyBXZWJJbnNw ZWN0b3JDbGllbnQ6OmhpZ2hsaWdodCgpIGR1cmluZyBhIGZhZGUtb3V0IGFuaW1hdGlvbiBvZiB0 aGUgUGFnZU92ZXJsYXkgd29uJ3Qgc3RvcCBpdHMgYW5pbWF0aW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIyNzEKKworICAgICAgICBBZGQgYSBu ZXcgc3RvcEZhZGVBbmltYXRpb24oKSBvbiBQYWdlT3ZlcmxheSB0aGF0IHdlIGNhbGwgd2hlbgor ICAgICAgICBXZWJJbnNwZWN0b3JDbGllbnQ6OmhpZ2hsaWdodCgpIGlzIGNhbGxlZCBhbmQgYSBw YWdlIG92ZXJsYXkKKyAgICAgICAgaXMgYWxyZWFkeSBhdmFpbGFibGUuIFRoaXMgZW5zdXJlcyB0 aGF0IGFueSBmYWRlLW91dCBhbmltYXRpb24KKyAgICAgICAgaXMgY2xlYXJlZCBiZWZvcmUgcHJv Y2VlZGluZyB3aXRoIHNob3dpbmcgdGhlIHBhZ2Ugb3ZlcmxheQorICAgICAgICBmb3IgdGhlIG5l dyBoaWdobGlnaHQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYklu c3BlY3RvckNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvckNsaWVudDo6 aGlnaGxpZ2h0KToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvUGFnZU92ZXJsYXkuY3Bw OgorICAgICAgICAoV2ViS2l0OjpQYWdlT3ZlcmxheTo6c3RvcEZhZGVBbmltYXRpb24pOgorICAg ICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvUGFnZU92ZXJsYXku aDoKKyAgICAgICAgKFBhZ2VPdmVybGF5KToKKwogMjAxMy0wMy0xMiAgQ2hyaXN0b3BoZSBEdW1l eiAgPGNoLmR1bWV6QHNpc2Euc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXSBld2tf cG9wdXBfbWVudV9jbG9zZSgpIGRvZXMgbm90IHdvcmsgYXMgaW50ZW5kZWQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xp ZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5z cGVjdG9yQ2xpZW50LmNwcAppbmRleCA5OTc4ZjllYWY0YmVhNGUzNDZiY2FlNTA4YjQxYTFiNTA1 YjU2MGEwLi5lMGY0ZGNjNTkyNjBjM2FjYTY4OTI0OWRlNmNjZTMzMTBjYjcxZmVlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3Rv ckNsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y dC9XZWJJbnNwZWN0b3JDbGllbnQuY3BwCkBAIC03Myw4ICs3MywxMCBAQCB2b2lkIFdlYkluc3Bl Y3RvckNsaWVudDo6aGlnaGxpZ2h0KCkKICAgICAgICAgUmVmUHRyPFBhZ2VPdmVybGF5PiBoaWdo bGlnaHRPdmVybGF5ID0gUGFnZU92ZXJsYXk6OmNyZWF0ZSh0aGlzKTsKICAgICAgICAgbV9oaWdo bGlnaHRPdmVybGF5ID0gaGlnaGxpZ2h0T3ZlcmxheS5nZXQoKTsKICAgICAgICAgbV9wYWdlLT5p bnN0YWxsUGFnZU92ZXJsYXkoaGlnaGxpZ2h0T3ZlcmxheS5yZWxlYXNlKCksIHRydWUpOwotICAg IH0gZWxzZQorICAgIH0gZWxzZSB7CisgICAgICAgIG1faGlnaGxpZ2h0T3ZlcmxheS0+c3RvcEZh ZGVBbmltYXRpb24oKTsKICAgICAgICAgbV9oaWdobGlnaHRPdmVybGF5LT5zZXROZWVkc0Rpc3Bs YXkoKTsKKyAgICB9CiB9CiAKIHZvaWQgV2ViSW5zcGVjdG9yQ2xpZW50OjpoaWRlSGlnaGxpZ2h0 KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9QYWdlT3Zl cmxheS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvUGFnZU92ZXJsYXku Y3BwCmluZGV4IDI3OWYxNWU4MGFjNmYxYzAyNDA4OTQ3MjQ1ZDkyMmIzOGFlNDRmZmUuLjJlZWMy Y2ZkMGUyMmNiMWQ4MmRjMjAwMTkzM2JmYWVhMzUyYThmYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9QYWdlT3ZlcmxheS5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1BhZ2VPdmVybGF5LmNwcApAQCAtMTUzLDYgKzE1Mywx MSBAQCB2b2lkIFBhZ2VPdmVybGF5OjpzdGFydEZhZGVBbmltYXRpb24oKQogICAgIG1fZmFkZUFu aW1hdGlvblRpbWVyLnN0YXJ0UmVwZWF0aW5nKDEgLyBmYWRlQW5pbWF0aW9uRnJhbWVSYXRlKTsK IH0KIAordm9pZCBQYWdlT3ZlcmxheTo6c3RvcEZhZGVBbmltYXRpb24oKQoreworICAgIG1fZmFk ZUFuaW1hdGlvblRpbWVyLnN0b3AoKTsKK30KKwogdm9pZCBQYWdlT3ZlcmxheTo6ZmFkZUFuaW1h dGlvblRpbWVyRmlyZWQoKQogewogICAgIGZsb2F0IGFuaW1hdGlvblByb2dyZXNzID0gKGN1cnJl bnRUaW1lKCkgLSBtX2ZhZGVBbmltYXRpb25TdGFydFRpbWUpIC8gbV9mYWRlQW5pbWF0aW9uRHVy YXRpb247CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvUGFn ZU92ZXJsYXkuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9QYWdlT3Zlcmxh eS5oCmluZGV4IGUyNDM0ODA3ZjBkMTkzZTRiNmNkODRjMDQwNWY3NThlYWM3OTVkMjQuLmE4ZDE4 ZGY5NzhjYWM4MzI0NzU0OTIwNjlmNGM2ZWY0OTljYTk0YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9QYWdlT3ZlcmxheS5oCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9QYWdlT3ZlcmxheS5oCkBAIC02Niw2ICs2Niw3IEBAIHB1 YmxpYzoKICAgICB2b2lkIGRyYXdSZWN0KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dCYsIGNvbnN0 IFdlYkNvcmU6OkludFJlY3QmIGRpcnR5UmVjdCk7CiAgICAgYm9vbCBtb3VzZUV2ZW50KGNvbnN0 IFdlYk1vdXNlRXZlbnQmKTsKIAorICAgIHZvaWQgc3RvcEZhZGVBbmltYXRpb24oKTsKICAgICB2 b2lkIHN0YXJ0RmFkZUluQW5pbWF0aW9uKCk7CiAgICAgdm9pZCBzdGFydEZhZGVPdXRBbmltYXRp b24oKTsKIAo= 192951 2013-03-13 11:25:05 -0700 2013-03-13 11:49:46 -0700 Patch for landing bug-112271-20130313192057.patch text/plain 3236 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1Njk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDY3NjIyMTZlNWFlOGFj N2MyZTcwOTQxODA1ZGZlYmRlOWY4ZDdkYi4uYWU5N2JmYTBkMDVlZGI1MWVjZDRkMGQ4ZTljMmRl Y2M4YWVkMjU2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAzLTEzICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgQ2FsbGluZyBXZWJJbnNw ZWN0b3JDbGllbnQ6OmhpZ2hsaWdodCgpIGR1cmluZyBhIGZhZGUtb3V0IGFuaW1hdGlvbiBvZiB0 aGUgUGFnZU92ZXJsYXkgd29uJ3Qgc3RvcCBpdHMgYW5pbWF0aW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIyNzEKKworICAgICAgICBSZXZpZXdl ZCBieSBUaW0gSG9ydG9uLgorCisgICAgICAgIEFkZCBhIG5ldyBzdG9wRmFkZU91dEFuaW1hdGlv bigpIG9uIFBhZ2VPdmVybGF5IHRoYXQgd2UgY2FsbCB3aGVuCisgICAgICAgIFdlYkluc3BlY3Rv ckNsaWVudDo6aGlnaGxpZ2h0KCkgaXMgY2FsbGVkIGFuZCBhIHBhZ2Ugb3ZlcmxheQorICAgICAg ICBpcyBhbHJlYWR5IGF2YWlsYWJsZS4gVGhpcyBlbnN1cmVzIHRoYXQgYW55IGZhZGUtb3V0IGFu aW1hdGlvbgorICAgICAgICBpcyBjbGVhcmVkIGJlZm9yZSBwcm9jZWVkaW5nIHdpdGggc2hvd2lu ZyB0aGUgcGFnZSBvdmVybGF5CisgICAgICAgIGZvciB0aGUgbmV3IGhpZ2hsaWdodC4KKworICAg ICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50LmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yQ2xpZW50OjpoaWdobGlnaHQpOgorICAgICAg ICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9QYWdlT3ZlcmxheS5jcHA6CisgICAgICAgIChXZWJLaXQ6 OlBhZ2VPdmVybGF5OjpzdG9wRmFkZU91dEFuaW1hdGlvbik6CisgICAgICAgIChXZWJLaXQpOgor ICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9QYWdlT3ZlcmxheS5oOgorICAgICAgICAoUGFn ZU92ZXJsYXkpOgorCiAyMDEzLTAzLTEyICBDaHJpc3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2lz YS5zYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIGV3a19wb3B1cF9tZW51X2Nsb3Nl KCkgZG9lcyBub3Qgd29yayBhcyBpbnRlbmRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuY3BwIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuY3Bw CmluZGV4IDk5NzhmOWVhZjRiZWE0ZTM0NmJjYWU1MDhiNDFhMWI1MDViNTYwYTAuLmZmODU1MTI5 OWNlNGUzOTA2ZDE2MTBkY2I3NTAxNGVhOWM1NTIwNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNs aWVudC5jcHAKQEAgLTczLDggKzczLDEwIEBAIHZvaWQgV2ViSW5zcGVjdG9yQ2xpZW50OjpoaWdo bGlnaHQoKQogICAgICAgICBSZWZQdHI8UGFnZU92ZXJsYXk+IGhpZ2hsaWdodE92ZXJsYXkgPSBQ YWdlT3ZlcmxheTo6Y3JlYXRlKHRoaXMpOwogICAgICAgICBtX2hpZ2hsaWdodE92ZXJsYXkgPSBo aWdobGlnaHRPdmVybGF5LmdldCgpOwogICAgICAgICBtX3BhZ2UtPmluc3RhbGxQYWdlT3Zlcmxh eShoaWdobGlnaHRPdmVybGF5LnJlbGVhc2UoKSwgdHJ1ZSk7Ci0gICAgfSBlbHNlCisgICAgfSBl bHNlIHsKKyAgICAgICAgbV9oaWdobGlnaHRPdmVybGF5LT5zdG9wRmFkZU91dEFuaW1hdGlvbigp OwogICAgICAgICBtX2hpZ2hsaWdodE92ZXJsYXktPnNldE5lZWRzRGlzcGxheSgpOworICAgIH0K IH0KIAogdm9pZCBXZWJJbnNwZWN0b3JDbGllbnQ6OmhpZGVIaWdobGlnaHQoKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1BhZ2VPdmVybGF5LmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9QYWdlT3ZlcmxheS5jcHAKaW5kZXggMjc5 ZjE1ZTgwYWM2ZjFjMDI0MDg5NDcyNDVkOTIyYjM4YWU0NGZmZS4uZDZhNDhmNTc5NmYxZDkxYjcw ZThkMTdhMzg0NzQzN2E4MmJiZDQ2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL1BhZ2VPdmVybGF5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvUGFnZU92ZXJsYXkuY3BwCkBAIC0xNDUsNiArMTQ1LDEyIEBAIHZvaWQgUGFn ZU92ZXJsYXk6OnN0YXJ0RmFkZU91dEFuaW1hdGlvbigpCiAgICAgc3RhcnRGYWRlQW5pbWF0aW9u KCk7CiB9CiAKK3ZvaWQgUGFnZU92ZXJsYXk6OnN0b3BGYWRlT3V0QW5pbWF0aW9uKCkKK3sKKyAg ICBtX2ZyYWN0aW9uRmFkZWRJbiA9IDEuMDsKKyAgICBtX2ZhZGVBbmltYXRpb25UaW1lci5zdG9w KCk7Cit9CisKIHZvaWQgUGFnZU92ZXJsYXk6OnN0YXJ0RmFkZUFuaW1hdGlvbigpCiB7CiAgICAg bV9mYWRlQW5pbWF0aW9uU3RhcnRUaW1lID0gY3VycmVudFRpbWUoKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9QYWdlT3ZlcmxheS5oIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1BhZ2VPdmVybGF5LmgKaW5kZXggZTI0MzQ4MDdmMGQx OTNlNGI2Y2Q4NGMwNDA1Zjc1OGVhYzc5NWQyNC4uZDYxMzZkZTEyYzcxMWI5MjBiZmFhNTAwM2Ji MWM2MWI2NmJhYzFmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1BhZ2VPdmVybGF5LmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L1BhZ2VPdmVybGF5LmgKQEAgLTY4LDYgKzY4LDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBzdGFy dEZhZGVJbkFuaW1hdGlvbigpOwogICAgIHZvaWQgc3RhcnRGYWRlT3V0QW5pbWF0aW9uKCk7Cisg ICAgdm9pZCBzdG9wRmFkZU91dEFuaW1hdGlvbigpOwogCiAgICAgZmxvYXQgZnJhY3Rpb25GYWRl ZEluKCkgY29uc3QgeyByZXR1cm4gbV9mcmFjdGlvbkZhZGVkSW47IH0KIAo=