112267 2013-03-13 09:22:04 -0700 [GTK] Build fixes after 145552 2013-03-13 12:48:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan gustavo mrobinson webkit.review.bot oldest_to_newest 854353 0 zan 2013-03-13 09:22:04 -0700 [GTK] Build fixes after 145552 854354 1 192935 zan 2013-03-13 09:25:07 -0700 Created attachment 192935 Patch 854359 2 zan 2013-03-13 09:26:38 -0700 I apologize for letting these mistakes creeping into the patch in the first place, though I still can't wrap my head around how building with the gold linker actually worked (the issue was discovered when using the GNU linker). 854403 3 192935 gustavo 2013-03-13 10:53:01 -0700 Comment on attachment 192935 Patch That happens to me all the time - things working with gold and not with the old ld, I think gold is less strict about its checking of unresolved symbols, and I assume that is one of the reasons why it's faster. 854490 4 192935 gustavo 2013-03-13 12:42:12 -0700 Comment on attachment 192935 Patch I'll take the liberty of doing cq+ since this is a build fix and people are popping up asking about the problem. 854495 5 192935 webkit.review.bot 2013-03-13 12:48:25 -0700 Comment on attachment 192935 Patch Clearing flags on attachment: 192935 Committed r145738: <http://trac.webkit.org/changeset/145738> 854496 6 webkit.review.bot 2013-03-13 12:48:28 -0700 All reviewed patches have been landed. Closing bug. 192935 2013-03-13 09:25:07 -0700 2013-03-13 12:48:25 -0700 Patch bug-112267-20130313172105.patch text/plain 3266 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAxMDA5NjVlMmZlOGFi NDA0ZDA4NzRhNjhhZTI4MmFmNGY2YTU3ODI2Li41M2M1NjZkZjdiNWEyZDM3YjE3NmU5YTAxN2Q2 YzI5ZDc2N2EwNDM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMy0xMyAg WmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gQnVp bGQgZml4ZXMgYWZ0ZXIgMTQ1NTUyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTIyNjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOiBJbmNsdWRlIHRoZSBzYW1lLWxldmVsIEdO VW1ha2VmaWxlLmxpc3QuYW0uCisgICAgICAgIEZpeCBhIHR5cG8gaW4gdGhlIGlubGluZSB2aXNp YmlsaXR5IGNvbXBpbGVyIGZsYWcuCisKIDIwMTMtMDMtMTIgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFJlbW92ZSBsYXN0IHZlc3RpZ2F0ZXMg b2YgV0VCS0lUX1VTSU5HX1Y4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjNlNjk5Y2Q3ZWU1N2U0M2UxZTdlODQy ODdkNGY1OGQ3NTA3ODRhZS4uYzdkYjU3NjEzZDliOTNmYWEwYTIxMzc2OWZjYzRmMzFlZjM3NjU3 MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAzLTEzICBaYW4gRG9iZXJzZWsg IDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBCdWlsZCBmaXhlcyBhZnRl ciAxNDU1NTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExMjI2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogR05VbWFrZWZpbGUuYW06IE5hcnJvdyBkb3duIHRoZSBkZXBlbmRlbmN5IENGTEFHUyBsaXN0 IHRvIG9ubHkgb25lcyB0aGF0IGFyZSBhY3R1YWxseSBuZWVkZWQKKyAgICAgICAgdG8gYnVpbGQg dGhlIHBsYXRmb3JtZ3RrX3NvdXJjZXMgaW50byBsaWJQbGF0Zm9ybUd0azIubGEuIEF0IHRoZSBt b21lbnQgdGhpcyBtZWFucyBvbmx5CisgICAgICAgIEdUSystMi4wIENGTEFHUyBhcmUgdXNlZC4K KwogMjAxMy0wMy0xMyAgSm9jZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAZGlnaWEu Y29tPgogCiAgICAgICAgIFtXSzJdW1F0XSBSZWdyZXNzaW9uKDE0NTUxNykgV2ViUHJvY2VzcyBh c3NlcnRzIGluIGRlYnVnIGJ1aWxkIG9uIFdlYktpdFRlc3RSdW5uZXIgc3RhcnQKZGlmZiAtLWdp dCBhL1NvdXJjZS9QbGF0Zm9ybS9HTlVtYWtlZmlsZS5hbSBiL1NvdXJjZS9QbGF0Zm9ybS9HTlVt YWtlZmlsZS5hbQppbmRleCBlNDU1OThiODIzOTM0YTI1YWY2MDU2ZTQ5YjE2NTNmMjExNzFiOTM1 Li41Zjk2MGNiNDVmYTVhNDkzZmEzYTAxNGVkMWM2NWYyYmYxMjZmYzljIDEwMDY0NAotLS0gYS9T b3VyY2UvUGxhdGZvcm0vR05VbWFrZWZpbGUuYW0KKysrIGIvU291cmNlL1BsYXRmb3JtL0dOVW1h a2VmaWxlLmFtCkBAIC02LDYgKzYsOCBAQAogIyBGb3Igbm93IHdlIG9ubHkgYnVpbGQgdGhlIGxp YlBsYXRmb3JtR3RrIGxpYnJhcnkgYXMgdGhlcmUgYXJlIG5vIHNvdXJjZSBmaWxlcyBpbiBwbGFj ZSB5ZXQKICMgdGhhdCBjb3VsZCBiZSBidWlsdCBpbnRvIGxpYlBsYXRmb3JtLgogCitpbmNsdWRl ICQoc3JjZGlyKS9Tb3VyY2UvUGxhdGZvcm0vR05VbWFrZWZpbGUubGlzdC5hbQorCiBwbGF0Zm9y bWd0a19jcHBmbGFncyArPSBcCiAJLURXRUJLSVRHVEtfQVBJX1ZFUlNJT05fU1RSSU5HPVwiQFdF QktJVEdUS19BUElfVkVSU0lPTkBcIiBcCiAJLUkkKHNyY2RpcikvU291cmNlL1BsYXRmb3JtL2d0 awpAQCAtMTcsNyArMTksNyBAQCBsaWJQbGF0Zm9ybUd0a19sYV9TT1VSQ0VTID0gXAogCSQocGxh dGZvcm1ndGtfc291cmNlcykKIAogbGliUGxhdGZvcm1HdGtfbGFfQ1hYRkxBR1MgPSBcCi0JLWZ2 aXNpYmlsaXR5LWlubGluZXMtaGlkZGVyIFwKKwktZnZpc2liaWxpdHktaW5saW5lcy1oaWRkZW4g XAogCSQoZ2xvYmFsX2N4eGZsYWdzKQogCiBsaWJQbGF0Zm9ybUd0a19sYV9DRkxBR1MgPSBcCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5hbSBiL1NvdXJjZS9XZWJLaXQy L0dOVW1ha2VmaWxlLmFtCmluZGV4IDZkNTZkN2MwMjQyZWQwODgyMjMwMGI0ZTM5OTg3ZTBjNzkw YTYwN2MuLjg4ZjM0NTc3ZTlkOTVjNGE2NzYwZWI2NzM4MDJmZmFmNWM4NzdjYzYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL0dOVW1ha2VmaWxlLmFtCisrKyBiL1NvdXJjZS9XZWJLaXQyL0dO VW1ha2VmaWxlLmFtCkBAIC01MDcsMjcgKzUwNyw3IEBAIGxpYlBsYXRmb3JtR3RrMl9sYV9DUFBG TEFHUyA9IFwKIAkkKHBsYXRmb3JtZ3RrX2NwcGZsYWdzKSBcCiAJJChqYXZhc2NyaXB0Y29yZV9j cHBmbGFncykgXAogCS1mbm8tc3RyaWN0LWFsaWFzaW5nIFwKLQkkKENBSVJPX0NGTEFHUykgXAot CSQoQ0xVVFRFUl9DRkxBR1MpIFwKLQkkKENPVkVSQUdFX0NGTEFHUykgXAotCSQoRU5DSEFOVF9D RkxBR1MpIFwKLQkkKEZSRUVUWVBFX0NGTEFHUykgXAotCSQoR0FJTF9DRkxBR1MpIFwKLQkkKEdB TUVQQURfQ0ZMQUdTKSBcCi0JJChHRU9DTFVFX0NGTEFHUykgXAotCSQoR0xJQl9DRkxBR1MpIFwK LQkkKEdTVFJFQU1FUl9DRkxBR1MpIFwKLQkkKEdUS19DRkxBR1MpIFwKLQkkKExJQlNFQ1JFVF9D RkxBR1MpIFwKLQkkKExJQlNPVVBfQ0ZMQUdTKSBcCi0JJChMSUJYTUxfQ0ZMQUdTKSBcCi0JJChM SUJYU0xUX0NGTEFHUykgXAotCSQoU1FMSVRFM19DRkxBR1MpIFwKLQkkKFVOSUNPREVfQ0ZMQUdT KSBcCi0JJChYQ09NUE9TSVRFX0NGTEFHUykgXAotCSQoWERBTUFHRV9DRkxBR1MpIFwKLQkkKFhS RU5ERVJfQ0ZMQUdTKSBcCi0JJChYVF9DRkxBR1MpCisJJChHVEsyX0NGTEFHUykKIAogIyBJbmpl Y3RlZCBCdW5kbGUKIGluamVjdGVkYnVuZGxlZGlyID0gJChsaWJkaXIpL3dlYmtpdDJndGstMy4w L2luamVjdGVkLWJ1bmRsZQo=