112249 2013-03-13 05:06:57 -0700 [WK2][Qt] Remove direct references to WK2 internals from QtWebPagePolicyClient. 2014-02-03 03:25:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 michael.bruning michael.bruning abecsi cmarcelo menard webkit.review.bot oldest_to_newest 854206 0 michael.bruning 2013-03-13 05:06:57 -0700 [WK2][Qt] Remove direct references to WK2 internals from QtWebPagePolicyClient. 854209 1 192903 michael.bruning 2013-03-13 05:09:47 -0700 Created attachment 192903 Patch 854251 2 192903 hausmann 2013-03-13 06:23:28 -0700 Comment on attachment 192903 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192903&action=review > Source/WebKit2/UIProcess/qt/QtWebPagePolicyClient.cpp:137 > + QString mimeType = adoptToQString(WKURLResponseCopyMIMEType(response)).toLower(); > + bool canShowMIMEType = WKFrameCanShowMIMEType(frame, adoptWK(WKStringCreateWithQString(mimeType)).get()); Hm, so this creates an intermediate QString just in order to call lower. I wonder if it would be better to make WKFrameCanShowMIMEType do the makeLower() inside and then allow us to pass the WKStringRef and avoid the QString conversion? 856946 3 michael.bruning 2013-03-18 03:22:08 -0700 I checked and it seems that if we want to do fix this for good, we should do it in MIMETypeRegistry in WebCore. 935675 4 192903 andersca 2013-10-02 21:25:02 -0700 Comment on attachment 192903 Patch Qt has been removed, clearing review flags. 975692 5 jturcotte 2014-02-03 03:25:20 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 192903 2013-03-13 05:09:47 -0700 2013-10-02 21:25:02 -0700 Patch bug-112249-20130313130544.patch text/plain 2963 michael.bruning U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjNlNjk5Y2Q3ZWU1N2U0 M2UxZTdlODQyODdkNGY1OGQ3NTA3ODRhZS4uNjJiMjAxZDhlYzMxZDBiNDM0ZWE3MjE0ZDJmOGJk NDM0NWQyNGZkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTEzICBNaWNo YWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQGRpZ2lhLmNvbT4KKworICAgICAgICBbV0sy XVtRdF0gUmVtb3ZlIGRpcmVjdCByZWZlcmVuY2VzIHRvIFdLMiBpbnRlcm5hbHMgZnJvbSBRdFdl YlBhZ2VQb2xpY3lDbGllbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTIyNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZW1vdmVzIHJlZmVyZW5jZXMgdG8gV2ViRnJhbWUsIFN0cmluZyBhbmQgV2Vi VVJMUmVzcG9uc2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvUXRXZWJQYWdlUG9saWN5Q2xp ZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UXRXZWJQYWdlUG9saWN5Q2xpZW50OjpkZWNpZGVQ b2xpY3lGb3JSZXNwb25zZSk6CisKIDIwMTMtMDMtMTMgIEpvY2VseW4gVHVyY290dGUgIDxqb2Nl bHluLnR1cmNvdHRlQGRpZ2lhLmNvbT4KIAogICAgICAgICBbV0syXVtRdF0gUmVncmVzc2lvbigx NDU1MTcpIFdlYlByb2Nlc3MgYXNzZXJ0cyBpbiBkZWJ1ZyBidWlsZCBvbiBXZWJLaXRUZXN0UnVu bmVyIHN0YXJ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQ YWdlUG9saWN5Q2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBh Z2VQb2xpY3lDbGllbnQuY3BwCmluZGV4IDFmMGFkMTQzMTY0MjljMGNiMjVjOGY3ZDYzZmRiNmFj NTMwNDRmZTEuLjcwMmQwMGE3ZGRmYzkxNGY4MDI3MTI4MzRmYTc3ZjA2YjRiOWMwZTAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQb2xpY3lDbGllbnQu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQb2xpY3lDbGll bnQuY3BwCkBAIC0yMiw2ICsyMiw3IEBACiAjaW5jbHVkZSAiUXRXZWJQYWdlUG9saWN5Q2xpZW50 LmgiCiAKICNpbmNsdWRlICJXS0ZyYW1lLmgiCisjaW5jbHVkZSAiV0tTdHJpbmdRdC5oIgogI2lu Y2x1ZGUgIldLVVJMUXQuaCIKICNpbmNsdWRlICJxcXVpY2t3ZWJ2aWV3X3BfcC5oIgogI2luY2x1 ZGUgInF3ZWJuYXZpZ2F0aW9ucmVxdWVzdF9wLmgiCkBAIC0yOSw2ICszMCw3IEBACiAjaW5jbHVk ZSA8V0tGcmFtZVBvbGljeUxpc3RlbmVyLmg+CiAjaW5jbHVkZSA8V0tSZXRhaW5QdHIuaD4KICNp bmNsdWRlIDxXS1VSTFJlcXVlc3QuaD4KKyNpbmNsdWRlIDxXS1VSTFJlc3BvbnNlLmg+CiAKIG5h bWVzcGFjZSBXZWJLaXQgewogCkBAIC0xMzEsOSArMTMzLDggQEAgdm9pZCBRdFdlYlBhZ2VQb2xp Y3lDbGllbnQ6OmRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24oV0tQYWdlUmVmLCBXS0Zy YW1lUmUKIAogdm9pZCBRdFdlYlBhZ2VQb2xpY3lDbGllbnQ6OmRlY2lkZVBvbGljeUZvclJlc3Bv bnNlKFdLUGFnZVJlZiBwYWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBXS1VSTFJlc3BvbnNlUmVmIHJl c3BvbnNlLCBXS1VSTFJlcXVlc3RSZWYsIFdLRnJhbWVQb2xpY3lMaXN0ZW5lclJlZiBsaXN0ZW5l ciwgV0tUeXBlUmVmLCBjb25zdCB2b2lkKikKIHsKLSAgICBTdHJpbmcgdHlwZSA9IHRvSW1wbChy ZXNwb25zZSktPnJlc291cmNlUmVzcG9uc2UoKS5taW1lVHlwZSgpOwotICAgIHR5cGUubWFrZUxv d2VyKCk7Ci0gICAgYm9vbCBjYW5TaG93TUlNRVR5cGUgPSB0b0ltcGwoZnJhbWUpLT5jYW5TaG93 TUlNRVR5cGUodHlwZSk7CisgICAgUVN0cmluZyBtaW1lVHlwZSA9IGFkb3B0VG9RU3RyaW5nKFdL VVJMUmVzcG9uc2VDb3B5TUlNRVR5cGUocmVzcG9uc2UpKS50b0xvd2VyKCk7CisgICAgYm9vbCBj YW5TaG93TUlNRVR5cGUgPSBXS0ZyYW1lQ2FuU2hvd01JTUVUeXBlKGZyYW1lLCBhZG9wdFdLKFdL U3RyaW5nQ3JlYXRlV2l0aFFTdHJpbmcobWltZVR5cGUpKS5nZXQoKSk7CiAKICAgICBpZiAoV0tQ YWdlR2V0TWFpbkZyYW1lKHBhZ2UpID09IGZyYW1lKSB7CiAgICAgICAgIGlmIChjYW5TaG93TUlN RVR5cGUpIHsKQEAgLTE0OCw3ICsxNDksNyBAQCB2b2lkIFF0V2ViUGFnZVBvbGljeUNsaWVudDo6 ZGVjaWRlUG9saWN5Rm9yUmVzcG9uc2UoV0tQYWdlUmVmIHBhZ2UsIFdLRnJhbWVSZWYgZgogCiAg ICAgLy8gV2Ugc2hvdWxkIGlnbm9yZSBkb3dubG9hZGFibGUgdG9wLWxldmVsIGNvbnRlbnQgZm9y IHN1YmZyYW1lcywgd2l0aCBhbiBleGNlcHRpb24gZm9yIHRleHQveG1sIGFuZCBhcHBsaWNhdGlv bi94bWwgc28gd2UgY2FuIHN0aWxsIHN1cHBvcnQgQWNpZDMgdGVzdC4KICAgICAvLyBJdCBtYWtl cyB0aGUgYnJvd3NlciBpbnRlbnRpb25hbGx5IGJlaGF2ZSBkaWZmZXJlbnRseSB3aGVuIGl0IGNv bWVzIHRvIHRleHQoYXBwbGljYXRpb24pL3htbCBjb250ZW50IGluIHN1YmZyYW1lcyB2cy4gbWFp bmZyYW1lLgotICAgIGlmICghY2FuU2hvd01JTUVUeXBlICYmICEodHlwZSA9PSAidGV4dC94bWwi IHx8IHR5cGUgPT0gImFwcGxpY2F0aW9uL3htbCIpKSB7CisgICAgaWYgKCFjYW5TaG93TUlNRVR5 cGUgJiYgIShtaW1lVHlwZSA9PSBRTGF0aW4xU3RyaW5nKCJ0ZXh0L3htbCIpIHx8IG1pbWVUeXBl ID09IFFMYXRpbjFTdHJpbmcoImFwcGxpY2F0aW9uL3htbCIpKSkgewogICAgICAgICBXS0ZyYW1l UG9saWN5TGlzdGVuZXJJZ25vcmUobGlzdGVuZXIpOwogICAgICAgICByZXR1cm47CiAgICAgfQo=