112244 2013-03-13 04:00:44 -0700 [BlackBerry] InRegionScrollableArea: fix call to visibleContentRect() 2013-03-14 01:19:10 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned cgarcia mifenton rwlbuis tonikitoo webkit.review.bot xan.lopez oldest_to_newest 854183 0 berto 2013-03-13 04:00:44 -0700 Since r143295 visibleContentRect() receives an enum, not a boolean. 854184 1 192899 berto 2013-03-13 04:02:11 -0700 Created attachment 192899 Patch 854257 2 192899 rwlbuis 2013-03-13 06:30:45 -0700 Comment on attachment 192899 Patch Ok. 855043 3 192899 webkit.review.bot 2013-03-14 01:19:06 -0700 Comment on attachment 192899 Patch Clearing flags on attachment: 192899 Committed r145792: <http://trac.webkit.org/changeset/145792> 855044 4 webkit.review.bot 2013-03-14 01:19:10 -0700 All reviewed patches have been landed. Closing bug. 192899 2013-03-13 04:02:11 -0700 2013-03-14 01:19:06 -0700 Patch 112244.diff text/plain 2527 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDA0MjY0YTguLmE3YmVmY2IgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTEzICBB bGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJy eV0gSW5SZWdpb25TY3JvbGxhYmxlQXJlYTogZml4IGNhbGwgdG8gdmlzaWJsZUNvbnRlbnRSZWN0 KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjI0 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNl IHIxNDMyOTUgdmlzaWJsZUNvbnRlbnRSZWN0KCkgcmVjZWl2ZXMgYW4gZW51bSwgbm90IGEgYm9v bGVhbi4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5SZWdpb25TY3JvbGxhYmxlQXJlYS5j cHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkluUmVnaW9uU2Nyb2xsYWJsZUFyZWE6 OkluUmVnaW9uU2Nyb2xsYWJsZUFyZWEpOgorCiAyMDEzLTAzLTEyICBNaWtlIEZlbnRvbiAgPG1p ZmVudG9uQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFByZXZlbnQgdGV4dCBzZWxl Y3Rpb24gaW5zaWRlIENvbG91ciBhbmQgRGF0ZS9UaW1lIGlucHV0IGZpZWxkcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5SZWdpb25TY3JvbGxh YmxlQXJlYS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JblJl Z2lvblNjcm9sbGFibGVBcmVhLmNwcAppbmRleCA3NDA0NDM1Li45OWVjY2IzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JblJlZ2lvblNjcm9sbGFi bGVBcmVhLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9J blJlZ2lvblNjcm9sbGFibGVBcmVhLmNwcApAQCAtODEsNyArODEsNyBAQCBJblJlZ2lvblNjcm9s bGFibGVBcmVhOjpJblJlZ2lvblNjcm9sbGFibGVBcmVhKFdlYlBhZ2VQcml2YXRlKiB3ZWJQYWdl LCBSZW5kZXJMYQogCiAgICAgICAgIG1fc2Nyb2xsUG9zaXRpb24gPSBtX3dlYlBhZ2UtPm1hcFRv VHJhbnNmb3JtZWQodmlldy0+c2Nyb2xsUG9zaXRpb24oKSk7CiAgICAgICAgIG1fY29udGVudHNT aXplID0gbV93ZWJQYWdlLT5tYXBUb1RyYW5zZm9ybWVkKHZpZXctPmNvbnRlbnRzU2l6ZSgpKTsK LSAgICAgICAgbV92aWV3cG9ydFNpemUgPSBtX3dlYlBhZ2UtPm1hcFRvVHJhbnNmb3JtZWQodmll dy0+dmlzaWJsZUNvbnRlbnRSZWN0KGZhbHNlIC8qaW5jbHVkZVNjcm9sbGJhcnMqLykpLnNpemUo KTsKKyAgICAgICAgbV92aWV3cG9ydFNpemUgPSBtX3dlYlBhZ2UtPm1hcFRvVHJhbnNmb3JtZWQo dmlldy0+dmlzaWJsZUNvbnRlbnRSZWN0KFNjcm9sbGFibGVBcmVhOjpFeGNsdWRlU2Nyb2xsYmFy cykpLnNpemUoKTsKICAgICAgICAgbV9kb2N1bWVudFZpZXdwb3J0UmVjdCA9IHZpZXctPmZyYW1l UmVjdCgpOwogCiAgICAgICAgIG1fc2Nyb2xsc0hvcml6b250YWxseSA9IHZpZXctPmNvbnRlbnRz V2lkdGgoKSA+IHZpZXctPnZpc2libGVXaWR0aCgpOwpAQCAtMTA1LDcgKzEwNSw3IEBAIEluUmVn aW9uU2Nyb2xsYWJsZUFyZWE6OkluUmVnaW9uU2Nyb2xsYWJsZUFyZWEoV2ViUGFnZVByaXZhdGUq IHdlYlBhZ2UsIFJlbmRlckxhCiAgICAgICAgIFNjcm9sbGFibGVBcmVhKiBzY3JvbGxhYmxlQXJl YSA9IHN0YXRpY19jYXN0PFNjcm9sbGFibGVBcmVhKj4obV9sYXllcik7CiAgICAgICAgIG1fc2Ny b2xsUG9zaXRpb24gPSBtX3dlYlBhZ2UtPm1hcFRvVHJhbnNmb3JtZWQoc2Nyb2xsYWJsZUFyZWEt PnNjcm9sbFBvc2l0aW9uKCkpOwogICAgICAgICBtX2NvbnRlbnRzU2l6ZSA9IG1fd2ViUGFnZS0+ bWFwVG9UcmFuc2Zvcm1lZChzY3JvbGxhYmxlQXJlYS0+Y29udGVudHNTaXplKCkpOwotICAgICAg ICBtX3ZpZXdwb3J0U2l6ZSA9IG1fd2ViUGFnZS0+bWFwVG9UcmFuc2Zvcm1lZChzY3JvbGxhYmxl QXJlYS0+dmlzaWJsZUNvbnRlbnRSZWN0KGZhbHNlIC8qaW5jbHVkZVNjcm9sbGJhcnMqLykpLnNp emUoKTsKKyAgICAgICAgbV92aWV3cG9ydFNpemUgPSBtX3dlYlBhZ2UtPm1hcFRvVHJhbnNmb3Jt ZWQoc2Nyb2xsYWJsZUFyZWEtPnZpc2libGVDb250ZW50UmVjdChTY3JvbGxhYmxlQXJlYTo6RXhj bHVkZVNjcm9sbGJhcnMpKS5zaXplKCk7CiAgICAgICAgIG1fZG9jdW1lbnRWaWV3cG9ydFJlY3Qg PSBlbmNsb3NpbmdJbnRSZWN0KGJveC0+YWJzb2x1dGVDbGlwcGVkT3ZlcmZsb3dSZWN0KCkpOwog CiAgICAgICAgIG1fc2Nyb2xsc0hvcml6b250YWxseSA9IGJveC0+c2Nyb2xsV2lkdGgoKSAhPSBi b3gtPmNsaWVudFdpZHRoKCk7Cg==