112226 2013-03-12 22:18:40 -0700 Regression: svg background-image on <body> never renders 2013-03-13 10:04:16 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 pdr pdr eric esprehn+autocc fmalita ojan.autocc schenney webkit.review.bot zimmermann oldest_to_newest 854061 0 192869 pdr 2013-03-12 22:18:40 -0700 Created attachment 192869 Testcase What a terrible regression! The SVG image rewrite exposed a latent bug in painting background images for <body>. SVG background images rely on this call to set their container size: fillLayer->image()->setContainerSizeForRenderer(this, fillTileSize, style()->effectiveZoom()); <body> backgrounds are special in that the body may not paint them. If the body is not the renderer that paints the background, we will set the container size with one renderer but try and fail to look it up using another. Patch forthcoming. Upstream: crbug.com/189127 854077 1 192871 pdr 2013-03-12 23:13:24 -0700 Created attachment 192871 Fix body background image geometry calculation 854297 2 192871 schenney 2013-03-13 08:02:14 -0700 Comment on attachment 192871 Fix body background image geometry calculation R=me. Good catch. 854375 3 192871 webkit.review.bot 2013-03-13 10:04:12 -0700 Comment on attachment 192871 Fix body background image geometry calculation Clearing flags on attachment: 192871 Committed r145726: <http://trac.webkit.org/changeset/145726> 854376 4 webkit.review.bot 2013-03-13 10:04:16 -0700 All reviewed patches have been landed. Closing bug. 192869 2013-03-12 22:18:40 -0700 2013-03-12 22:18:40 -0700 Testcase backgroundImageBug.html text/html 311 pdr PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPHN0eWxlPgpib2R5IHsKICAgIGJhY2tncm91 bmQtaW1hZ2U6dXJsKCJkYXRhOmltYWdlL3N2Zyt4bWwsPHN2ZyB4bWxucz0naHR0cDovL3d3dy53 My5vcmcvMjAwMC9zdmcnIHdpZHRoPScyMCcgaGVpZ2h0PScyMCc+PGNpcmNsZSBjeD0nMTAnIGN5 PScxMCcgcj0nMTAnIGZpbGw9J3llbGxvdycgLz48L3N2Zz4iKTsKfQo8L3N0eWxlPgo8L2hlYWQ+ Cjxib2R5PgogICAgWW91IHNob3VsZCBzZWUgYmVhdXRpZnVsIFNWRyBncmFwaGljcyBiZWhpbmQg dGhpcyB0ZXh0Lgo8L2JvZHk+CjwvaHRtbD4= 192871 2013-03-12 23:13:24 -0700 2013-03-13 10:04:12 -0700 Fix body background image geometry calculation 112226.1.patch text/plain 7018 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NTY4MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBACisyMDEzLTAzLTEyICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4IGJvZHkgYmFja2dyb3VuZCBp bWFnZSBnZW9tZXRyeSBjYWxjdWxhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMjI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgSW1hZ2VzIHRoYXQgZGVwZW5kIG9uIGEgY29udGFpbmVyIHNpemUg cmVxdWlyZSBhIGNhbGwgdG8gc2V0IHRoZSBjb250YWluZXIgc2l6ZSBiZWZvcmUKKyAgICAgICAg cmVuZGVyaW5nLCBhbmQgYSBjYWxsIHRvIGxvb2sgdXAgdGhlIGNvcnJlY3QgaW1hZ2UgZHVyaW5n IHBhaW50aW5nLgorCisgICAgICAgIFRoZSBib2R5J3MgcmVuZGVyZXIgaXMgc3BlY2lhbCBpbiB0 aGF0IGl0IG1heSBub3QgYmUgdGhlIHJlbmRlcmVyIHRoYXQgYWN0dWFsbHkgcGFpbnRzIGl0cwor ICAgICAgICBiYWNrZ3JvdW5kLiBUaGlzIHBhdGNoIGZpeGVzIGEgYnVnIHdoZXJlIHRoZSBjb3Jy ZWN0IFJlbmRlck9iamVjdCB3YXMgdXNlZCBmb3IgbG9va2luZyB1cAorICAgICAgICB0aGUgaW1h Z2UsIGJ1dCBub3QgZm9yIHNldHRpbmcgdGhlIGNvbnRhaW5lciBzaXplLiBUaGlzIGZpeGVzIFNW RyBiYWNrZ3JvdW5kIGltYWdlcyBvbiBib2R5LgorCisgICAgICAgIFRlc3Q6IHN2Zy9hcy1iYWNr Z3JvdW5kLWltYWdlL3N2Zy1hcy1iYWNrZ3JvdW5kLWJvZHkuaHRtbAorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckJveE1vZGVsT2JqZWN0OjpwYWludEZpbGxMYXllckV4dGVuZGVkKToKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckJveE1vZGVsT2JqZWN0OjpjYWxjdWxhdGVCYWNrZ3JvdW5kSW1hZ2VHZW9tZXRy eSk6CisKKyAgICAgICAgICAgIFRoaXMgY2hhbmdlIGludHJvZHVjZXMgY2xpZW50Rm9yQmFja2dy b3VuZEltYWdlIGluIHRoZSBiYWNrZ3JvdW5kIGdlb21ldHJ5IGNhbGN1bGF0aW9uLgorICAgICAg ICAgICAgVGhpcyBpcyB2ZXJ5IHNpbWlsYXIgdG8gaG93IHRoZSBjbGllbnQgaXMgbG9va2VkIHVw IGluIHBhaW50RmlsbExheWVyRXh0ZW5kZWQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy Qm94TW9kZWxPYmplY3QuaDoKKworICAgICAgICAgICAgVGhlIG5ldyBzaWduYXR1cmUgZm9yIGNh bGN1bGF0ZUJhY2tncm91bmRJbWFnZUdlb21ldHJ5IG5vdyBtaXJyb3JzCisgICAgICAgICAgICBw YWludEZpbGxMYXllckV4dGVuZGVkLCBjb250YWluaW5nIGEgcGFyYW1ldGVyIGZvciB0aGUgY29y cmVjdCBiYWNrZ3JvdW5kIHJlbmRlcmVyLgorCisgICAgICAgIChSZW5kZXJCb3hNb2RlbE9iamVj dCk6CisKIDIwMTMtMDMtMTIgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAg ICAgICAgIEJhc2ljIGNoaWxkIG9ic2N1cmF0aW9uIHRlc3QgZm9yIGJhY2tncm91bmRzCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5j cHAJKHJldmlzaW9uIDE0NTU3MykKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC b3hNb2RlbE9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkwNiw3ICs5MDYsNyBAQCB2b2lk IFJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWludEZpbGxMYXllCiAgICAgLy8gbm8gcHJvZ3Jlc3Np dmUgbG9hZGluZyBvZiB0aGUgYmFja2dyb3VuZCBpbWFnZQogICAgIGlmIChzaG91bGRQYWludEJh Y2tncm91bmRJbWFnZSkgewogICAgICAgICBCYWNrZ3JvdW5kSW1hZ2VHZW9tZXRyeSBnZW9tZXRy eTsKLSAgICAgICAgY2FsY3VsYXRlQmFja2dyb3VuZEltYWdlR2VvbWV0cnkoYmdMYXllciwgc2Ny b2xsZWRQYWludFJlY3QsIGdlb21ldHJ5KTsKKyAgICAgICAgY2FsY3VsYXRlQmFja2dyb3VuZElt YWdlR2VvbWV0cnkoYmdMYXllciwgc2Nyb2xsZWRQYWludFJlY3QsIGdlb21ldHJ5LCBiYWNrZ3Jv dW5kT2JqZWN0KTsKICAgICAgICAgZ2VvbWV0cnkuY2xpcChwYWludEluZm8ucmVjdCk7CiAgICAg ICAgIGlmICghZ2VvbWV0cnkuZGVzdFJlY3QoKS5pc0VtcHR5KCkpIHsKICAgICAgICAgICAgIENv bXBvc2l0ZU9wZXJhdG9yIGNvbXBvc2l0ZU9wID0gb3AgPT0gQ29tcG9zaXRlU291cmNlT3ZlciA/ IGJnTGF5ZXItPmNvbXBvc2l0ZSgpIDogb3A7CkBAIC0xMTQ1LDcgKzExNDUsNyBAQCBib29sIFJl bmRlckJveE1vZGVsT2JqZWN0OjpmaXhlZEJhY2tncm91CiB9CiAKIHZvaWQgUmVuZGVyQm94TW9k ZWxPYmplY3Q6OmNhbGN1bGF0ZUJhY2tncm91bmRJbWFnZUdlb21ldHJ5KGNvbnN0IEZpbGxMYXll ciogZmlsbExheWVyLCBjb25zdCBMYXlvdXRSZWN0JiBwYWludFJlY3QsCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBCYWNrZ3JvdW5k SW1hZ2VHZW9tZXRyeSYgZ2VvbWV0cnkpCisgICAgQmFja2dyb3VuZEltYWdlR2VvbWV0cnkmIGdl b21ldHJ5LCBSZW5kZXJPYmplY3QqIGJhY2tncm91bmRPYmplY3QpCiB7CiAgICAgTGF5b3V0VW5p dCBsZWZ0ID0gMDsKICAgICBMYXlvdXRVbml0IHRvcCA9IDA7CkBAIC0xMjA1LDggKzEyMDUsOSBA QCB2b2lkIFJlbmRlckJveE1vZGVsT2JqZWN0OjpjYWxjdWxhdGVCYWNrCiAgICAgICAgIHBvc2l0 aW9uaW5nQXJlYVNpemUgPSBnZW9tZXRyeS5kZXN0UmVjdCgpLnNpemUoKTsKICAgICB9CiAKKyAg ICBSZW5kZXJPYmplY3QqIGNsaWVudEZvckJhY2tncm91bmRJbWFnZSA9IGJhY2tncm91bmRPYmpl Y3QgPyBiYWNrZ3JvdW5kT2JqZWN0IDogdGhpczsKICAgICBJbnRTaXplIGZpbGxUaWxlU2l6ZSA9 IGNhbGN1bGF0ZUZpbGxUaWxlU2l6ZShmaWxsTGF5ZXIsIHBvc2l0aW9uaW5nQXJlYVNpemUpOwot ICAgIGZpbGxMYXllci0+aW1hZ2UoKS0+c2V0Q29udGFpbmVyU2l6ZUZvclJlbmRlcmVyKHRoaXMs IGZpbGxUaWxlU2l6ZSwgc3R5bGUoKS0+ZWZmZWN0aXZlWm9vbSgpKTsKKyAgICBmaWxsTGF5ZXIt PmltYWdlKCktPnNldENvbnRhaW5lclNpemVGb3JSZW5kZXJlcihjbGllbnRGb3JCYWNrZ3JvdW5k SW1hZ2UsIGZpbGxUaWxlU2l6ZSwgc3R5bGUoKS0+ZWZmZWN0aXZlWm9vbSgpKTsKICAgICBnZW9t ZXRyeS5zZXRUaWxlU2l6ZShmaWxsVGlsZVNpemUpOwogCiAgICAgRUZpbGxSZXBlYXQgYmFja2dy b3VuZFJlcGVhdFggPSBmaWxsTGF5ZXItPnJlcGVhdFgoKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5oCShyZXZpc2lvbiAxNDU1NzMp CisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuaAkod29y a2luZyBjb3B5KQpAQCAtMjM4LDcgKzIzOCw3IEBAIHByb3RlY3RlZDoKIAogICAgIExheW91dFBv aW50IGFkanVzdGVkUG9zaXRpb25SZWxhdGl2ZVRvT2Zmc2V0UGFyZW50KGNvbnN0IExheW91dFBv aW50JikgY29uc3Q7CiAKLSAgICB2b2lkIGNhbGN1bGF0ZUJhY2tncm91bmRJbWFnZUdlb21ldHJ5 KGNvbnN0IEZpbGxMYXllciosIGNvbnN0IExheW91dFJlY3QmIHBhaW50UmVjdCwgQmFja2dyb3Vu ZEltYWdlR2VvbWV0cnkmKTsKKyAgICB2b2lkIGNhbGN1bGF0ZUJhY2tncm91bmRJbWFnZUdlb21l dHJ5KGNvbnN0IEZpbGxMYXllciosIGNvbnN0IExheW91dFJlY3QmIHBhaW50UmVjdCwgQmFja2dy b3VuZEltYWdlR2VvbWV0cnkmLCBSZW5kZXJPYmplY3QqID0gMCk7CiAgICAgdm9pZCBnZXRCb3Jk ZXJFZGdlSW5mbyhjbGFzcyBCb3JkZXJFZGdlW10sIGNvbnN0IFJlbmRlclN0eWxlKiwgYm9vbCBp bmNsdWRlTG9naWNhbExlZnRFZGdlID0gdHJ1ZSwgYm9vbCBpbmNsdWRlTG9naWNhbFJpZ2h0RWRn ZSA9IHRydWUpIGNvbnN0OwogICAgIGJvb2wgYm9yZGVyT2JzY3VyZXNCYWNrZ3JvdW5kRWRnZShj b25zdCBGbG9hdFNpemUmIGNvbnRleHRTY2FsZSkgY29uc3Q7CiAgICAgYm9vbCBib3JkZXJPYnNj dXJlc0JhY2tncm91bmQoKSBjb25zdDsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NTY4MSkKKysrIExh eW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEz LTAzLTEyICBQaGlsaXAgUm9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4IGJv ZHkgYmFja2dyb3VuZCBpbWFnZSBnZW9tZXRyeSBjYWxjdWxhdGlvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMjI2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB0ZXN0IGlzIHJlcXVpcmVkIHRv IGhhdmUgYSByZXBlYXRpbmcgYmFja2dyb3VuZCwgYXMgd2Ugb3B0aW1pemUgbm9uLXJlcGVhdGlu ZworICAgICAgICBiYWNrZ3JvdW5kcyBzbyB0aGUgYnVnIGlzIG5vdCBoaXQuIEEgbGlnaHQgZ3Jl ZW4gY29sb3IgaXMgdXNlZCBzbyB0aGUgdGV4dCBpcyBzdGlsbAorICAgICAgICByZWFkYWJsZSwg YW5kIGdyaWRsaW5lcyBhcmUgcHJlc2VudCB0byBwcm92ZSB0aGUgY29ycmVjdCBjb250YWluZXIg c2l6ZSBpcyBiZWluZyB1c2VkLgorCisgICAgICAgICogc3ZnL2FzLWJhY2tncm91bmQtaW1hZ2Uv c3ZnLWFzLWJhY2tncm91bmQtYm9keS1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBz dmcvYXMtYmFja2dyb3VuZC1pbWFnZS9zdmctYXMtYmFja2dyb3VuZC1ib2R5Lmh0bWw6IEFkZGVk LgorCiAyMDEzLTAzLTEyICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQgaW5zcGVjdG9yIHRlc3QgZml4LgpJbmRleDogTGF5b3V0VGVz dHMvc3ZnL2FzLWJhY2tncm91bmQtaW1hZ2Uvc3ZnLWFzLWJhY2tncm91bmQtYm9keS1leHBlY3Rl ZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N2Zy9hcy1iYWNrZ3JvdW5kLWltYWdl L3N2Zy1hcy1iYWNrZ3JvdW5kLWJvZHktZXhwZWN0ZWQuaHRtbAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL3N2Zy9hcy1iYWNrZ3JvdW5kLWltYWdlL3N2Zy1hcy1iYWNrZ3JvdW5kLWJvZHkt ZXhwZWN0ZWQuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE0IEBACis8IURPQ1RZUEUg aHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+CitodG1sIHsKKyAgICBiYWNrZ3JvdW5kLWlt YWdlOnVybCgiZGF0YTppbWFnZS9zdmcreG1sLDxzdmcgeG1sbnM9J2h0dHA6Ly93d3cudzMub3Jn LzIwMDAvc3ZnJyB3aWR0aD0nMTAwcHgnIGhlaWdodD0nMTAwcHgnPjxyZWN0IHdpZHRoPScxMDBw eCcgaGVpZ2h0PScxMDBweCcgZmlsbD0nbGlnaHRncmVlbicgc3Ryb2tlPSdncmVlbicgc3Ryb2tl LXdpZHRoPScxcHgnLz48L3N2Zz4iKTsKKyAgICBiYWNrZ3JvdW5kLXJlcGVhdDogcmVwZWF0Owor fQorPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorICAgIFRlc3QgZm9yIFdLMTEyMjI2OiBUaGlz IHRlc3QgcGFzc2VzIGlmIHRoZSBib2R5J3MgYmFja2dyb3VuZCBpcyBsaWdodCBncmVlbiB3aXRo IGEgZ3JlZW4gZ3JpZGxpbmVzLgorPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5k IG9mIGZpbGUKSW5kZXg6IExheW91dFRlc3RzL3N2Zy9hcy1iYWNrZ3JvdW5kLWltYWdlL3N2Zy1h cy1iYWNrZ3JvdW5kLWJvZHkuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdmcvYXMt YmFja2dyb3VuZC1pbWFnZS9zdmctYXMtYmFja2dyb3VuZC1ib2R5Lmh0bWwJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9zdmcvYXMtYmFja2dyb3VuZC1pbWFnZS9zdmctYXMtYmFja2dyb3Vu ZC1ib2R5Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxNCBAQAorPCFET0NUWVBFIGh0 bWw+Cis8aHRtbD4KKzxoZWFkPgorPHN0eWxlPgorYm9keSB7CisgICAgYmFja2dyb3VuZC1pbWFn ZTp1cmwoImRhdGE6aW1hZ2Uvc3ZnK3htbCw8c3ZnIHhtbG5zPSdodHRwOi8vd3d3LnczLm9yZy8y MDAwL3N2Zycgd2lkdGg9JzEwMHB4JyBoZWlnaHQ9JzEwMHB4Jz48cmVjdCB3aWR0aD0nMTAwcHgn IGhlaWdodD0nMTAwcHgnIGZpbGw9J2xpZ2h0Z3JlZW4nIHN0cm9rZT0nZ3JlZW4nIHN0cm9rZS13 aWR0aD0nMXB4Jy8+PC9zdmc+Iik7CisgICAgYmFja2dyb3VuZC1yZXBlYXQ6IHJlcGVhdDsKK30K Kzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICBUZXN0IGZvciBXSzExMjIyNjogVGhpcyB0 ZXN0IHBhc3NlcyBpZiB0aGUgYm9keSdzIGJhY2tncm91bmQgaXMgbGlnaHQgZ3JlZW4gd2l0aCBh IGdyZWVuIGdyaWRsaW5lcy4KKzwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBv ZiBmaWxlCg==