112217 2013-03-12 18:09:59 -0700 REGRESSION(r145280): This patch broke chromium WebGL conformance tests (Requested by shawnsingh on #webkit). 2013-03-12 18:16:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111780 1 webkit.review.bot webkit.review.bot dino shawnsingh oldest_to_newest 853959 0 webkit.review.bot 2013-03-12 18:09:59 -0700 http://trac.webkit.org/changeset/145280 broke the build: This patch broke chromium WebGL conformance tests (Requested by shawnsingh on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 853962 1 192846 webkit.review.bot 2013-03-12 18:10:33 -0700 Created attachment 192846 ROLLOUT of r145280 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 853967 2 192846 webkit.review.bot 2013-03-12 18:16:45 -0700 Comment on attachment 192846 ROLLOUT of r145280 Clearing flags on attachment: 192846 Committed r145649: <http://trac.webkit.org/changeset/145649> 853968 3 webkit.review.bot 2013-03-12 18:16:48 -0700 All reviewed patches have been landed. Closing bug. 192846 2013-03-12 18:10:33 -0700 2013-03-12 18:16:45 -0700 ROLLOUT of r145280 bug-112217-20130313010631.patch text/plain 4836 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NjQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDYwM2EwNjY3NThiY2Qw YWFkZjdmNTljYjY5MjdhZjEzMWE5M2M3YS4uNTQ0MDY0YmJiZmNlMzAxYzJjZGI3OGEzMzBkOWI3 ZDBiMjllOTVjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTEyICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTQ1MjgwLgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xNDUyODAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExMjIxNworCisgICAgICAgIFRoaXMgcGF0Y2ggYnJva2UgY2hyb21pdW0gV2Vi R0wgY29uZm9ybWFuY2UgdGVzdHMgKFJlcXVlc3RlZAorICAgICAgICBieSBzaGF3bnNpbmdoIG9u ICN3ZWJraXQpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L0RyYXdpbmdCdWZm ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RHJhd2luZ0J1ZmZlcjo6cmVzZXQpOgorICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dwdS9EcmF3aW5nQnVmZmVyLmg6CisgICAgICAgIChEcmF3 aW5nQnVmZmVyKToKKwogMjAxMy0wMy0xMiAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+ CiAKICAgICAgICAgRG9uJ3Qgc2VuZCBldmVudHMgdG8gcGx1Z2lucyB0aGF0IGFyZSBiZWluZyBz bmFwc2hvdHRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3B1L0RyYXdpbmdCdWZmZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3B1L0RyYXdpbmdCdWZmZXIuY3BwCmluZGV4IDY1MTIxNDNiMTgzN2IzODllMjQ5YjZjNDk4ZDIx ZThmOWZmZTdmZTQuLmJkNDEyOWEzYTZlOTlmZjhlZTA5ZDViZjk3NzAxMmY3MjE2ZWJjZDEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9EcmF3aW5nQnVm ZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJhd2lu Z0J1ZmZlci5jcHAKQEAgLTE4OSwyNSArMTg5LDYgQEAgdm9pZCBEcmF3aW5nQnVmZmVyOjpjbGVh ckZyYW1lYnVmZmVycyhHQzNEYml0ZmllbGQgY2xlYXJNYXNrKQogICAgIH0KIH0KIAotLy8gT25s eSB3YXkgdG8gZW5zdXJlIHRoYXQgd2UncmUgbm90IGdldHRpbmcgYSBiYWQgZnJhbWVidWZmZXIg b24gc29tZSBBTUQvT1NYIGRldmljZXMuCi0vLyBGSVhNRTogVGhpcyBjYW4gYmUgcmVtb3ZlZCBv bmNlIHJlbmRlcmJ1ZmZlclN0b3JhZ2VNdWx0aXNhbXBsZSBzdGFydHMgcmVwb3J0aW5nIEdMX09V VF9PRl9NRU1PUlkgcHJvcGVybHkuCi1ib29sIERyYXdpbmdCdWZmZXI6OmNoZWNrQnVmZmVySW50 ZWdyaXR5KCkKLXsKLSAgICBpZiAoIW1fbXVsdGlzYW1wbGVGQk8pCi0gICAgICAgIHJldHVybiB0 cnVlOwotCi0gICAgbV9jb250ZXh0LT5iaW5kRnJhbWVidWZmZXIoR3JhcGhpY3NDb250ZXh0M0Q6 OkZSQU1FQlVGRkVSLCBtX211bHRpc2FtcGxlRkJPKTsKLSAgICBtX2NvbnRleHQtPmNsZWFyQ29s b3IoMS4wZiwgMC4wZiwgMS4wZiwgMS4wZik7Ci0gICAgbV9jb250ZXh0LT5jbGVhcihHcmFwaGlj c0NvbnRleHQzRDo6Q09MT1JfQlVGRkVSX0JJVCk7Ci0KLSAgICBjb21taXQoMCwgMCwgMSwgMSk7 Ci0KLSAgICB1bnNpZ25lZCBjaGFyIHBpeGVsWzRdID0gezAsIDAsIDAsIDB9OwotICAgIG1fY29u dGV4dC0+cmVhZFBpeGVscygwLCAwLCAxLCAxLCBHcmFwaGljc0NvbnRleHQzRDo6UkdCQSwgR3Jh cGhpY3NDb250ZXh0M0Q6OlVOU0lHTkVEX0JZVEUsICZwaXhlbCk7Ci0KLSAgICByZXR1cm4gKHBp eGVsWzBdID09IDB4RkYgJiYgcGl4ZWxbMV0gPT0gMHgwMCAmJiBwaXhlbFsyXSA9PSAweEZGICYm IHBpeGVsWzNdID09IDB4RkYpOwotfQotCiBib29sIERyYXdpbmdCdWZmZXI6OnJlc2V0KGNvbnN0 IEludFNpemUmIG5ld1NpemUpCiB7CiAgICAgaWYgKCFtX2NvbnRleHQpCkBAIC0yNTcsNiArMjM4 LDcgQEAgYm9vbCBEcmF3aW5nQnVmZmVyOjpyZXNldChjb25zdCBJbnRTaXplJiBuZXdTaXplKQog ICAgICAgICAgICAgaW50ZXJuYWxSZW5kZXJidWZmZXJGb3JtYXQgPSBFeHRlbnNpb25zM0Q6OlJH QjhfT0VTOwogICAgICAgICB9CiAKKwogICAgICAgICBkbyB7CiAgICAgICAgICAgICBtX3NpemUg PSBhZGp1c3RlZFNpemU7CiAgICAgICAgICAgICAvLyByZXNpemUgbXVsdGlzYW1wbGUgRkJPCkBA IC0yNzAsMTIgKzI1Miw2IEBAIGJvb2wgRHJhd2luZ0J1ZmZlcjo6cmVzZXQoY29uc3QgSW50U2l6 ZSYgbmV3U2l6ZSkKIAogICAgICAgICAgICAgICAgIG1fY29udGV4dC0+YmluZFJlbmRlcmJ1ZmZl cihHcmFwaGljc0NvbnRleHQzRDo6UkVOREVSQlVGRkVSLCBtX211bHRpc2FtcGxlQ29sb3JCdWZm ZXIpOwogICAgICAgICAgICAgICAgIG1fY29udGV4dC0+Z2V0RXh0ZW5zaW9ucygpLT5yZW5kZXJi dWZmZXJTdG9yYWdlTXVsdGlzYW1wbGUoR3JhcGhpY3NDb250ZXh0M0Q6OlJFTkRFUkJVRkZFUiwg c2FtcGxlQ291bnQsIGludGVybmFsUmVuZGVyYnVmZmVyRm9ybWF0LCBtX3NpemUud2lkdGgoKSwg bV9zaXplLmhlaWdodCgpKTsKLQotICAgICAgICAgICAgICAgIGlmIChtX2NvbnRleHQtPmdldEVy cm9yKCkgPT0gR3JhcGhpY3NDb250ZXh0M0Q6Ok9VVF9PRl9NRU1PUlkpIHsKLSAgICAgICAgICAg ICAgICAgICAgYWRqdXN0ZWRTaXplLnNjYWxlKHNfcmVzb3VyY2VBZGp1c3RlZFJhdGlvKTsKLSAg ICAgICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICAgICAgfQotCiAgICAgICAg ICAgICAgICAgbV9jb250ZXh0LT5mcmFtZWJ1ZmZlclJlbmRlcmJ1ZmZlcihHcmFwaGljc0NvbnRl eHQzRDo6RlJBTUVCVUZGRVIsIEdyYXBoaWNzQ29udGV4dDNEOjpDT0xPUl9BVFRBQ0hNRU5UMCwg R3JhcGhpY3NDb250ZXh0M0Q6OlJFTkRFUkJVRkZFUiwgbV9tdWx0aXNhbXBsZUNvbG9yQnVmZmVy KTsKICAgICAgICAgICAgICAgICByZXNpemVEZXB0aFN0ZW5jaWwoc2FtcGxlQ291bnQpOwogICAg ICAgICAgICAgICAgIGlmIChtX2NvbnRleHQtPmNoZWNrRnJhbWVidWZmZXJTdGF0dXMoR3JhcGhp Y3NDb250ZXh0M0Q6OkZSQU1FQlVGRkVSKSAhPSBHcmFwaGljc0NvbnRleHQzRDo6RlJBTUVCVUZG RVJfQ09NUExFVEUpIHsKQEAgLTMwMiwyMCArMjc4LDkgQEAgYm9vbCBEcmF3aW5nQnVmZmVyOjpy ZXNldChjb25zdCBJbnRTaXplJiBuZXdTaXplKQogCiAgICAgICAgICAgICBpZiAoIW11bHRpc2Ft cGxlKCkpCiAgICAgICAgICAgICAgICAgcmVzaXplRGVwdGhTdGVuY2lsKDApOwotICAgICAgICAg ICAgaWYgKG1fY29udGV4dC0+Y2hlY2tGcmFtZWJ1ZmZlclN0YXR1cyhHcmFwaGljc0NvbnRleHQz RDo6RlJBTUVCVUZGRVIpICE9IEdyYXBoaWNzQ29udGV4dDNEOjpGUkFNRUJVRkZFUl9DT01QTEVU RSkgewotICAgICAgICAgICAgICAgIGFkanVzdGVkU2l6ZS5zY2FsZShzX3Jlc291cmNlQWRqdXN0 ZWRSYXRpbyk7Ci0gICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICB9Ci0KLSNp ZiBPUyhEQVJXSU4pCi0gICAgICAgICAgICAvLyBGSVhNRTogVGhpcyBjYW4gYmUgcmVtb3ZlZCBv bmNlIHJlbmRlcmJ1ZmZlclN0b3JhZ2VNdWx0aXNhbXBsZSBzdGFydHMgcmVwb3J0aW5nIEdMX09V VF9PRl9NRU1PUlkgcHJvcGVybHkgb24gT1NYLgotICAgICAgICAgICAgaWYgKCFjaGVja0J1ZmZl ckludGVncml0eSgpKSB7Ci0gICAgICAgICAgICAgICAgYWRqdXN0ZWRTaXplLnNjYWxlKHNfcmVz b3VyY2VBZGp1c3RlZFJhdGlvKTsKLSAgICAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAg ICAgIH0KLSNlbmRpZgotCi0gICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIGlmIChtX2Nv bnRleHQtPmNoZWNrRnJhbWVidWZmZXJTdGF0dXMoR3JhcGhpY3NDb250ZXh0M0Q6OkZSQU1FQlVG RkVSKSA9PSBHcmFwaGljc0NvbnRleHQzRDo6RlJBTUVCVUZGRVJfQ09NUExFVEUpCisgICAgICAg ICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBhZGp1c3RlZFNpemUuc2NhbGUoc19yZXNvdXJj ZUFkanVzdGVkUmF0aW8pOwogCiAgICAgICAgIH0gd2hpbGUgKCFhZGp1c3RlZFNpemUuaXNFbXB0 eSgpKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1 L0RyYXdpbmdCdWZmZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9E cmF3aW5nQnVmZmVyLmgKaW5kZXggYjQ0NjEwMTIwNjc3MTNkNTFhNWExYjcwZmQwMTExYzYyZmYy MWY3Ni4uNjFhYTFjZTZiZWU3ZmY3MDM3MzFiZTg4ZjNjMzE2NGI2MWI4MzJiMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L0RyYXdpbmdCdWZmZXIuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJhd2luZ0J1ZmZlci5o CkBAIC0xNDAsOCArMTQwLDYgQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgaW5pdGlhbGl6ZShjb25z dCBJbnRTaXplJik7CiAKLSAgICBib29sIGNoZWNrQnVmZmVySW50ZWdyaXR5KCk7Ci0KICAgICBQ cmVzZXJ2ZURyYXdpbmdCdWZmZXIgbV9wcmVzZXJ2ZURyYXdpbmdCdWZmZXI7CiAgICAgQWxwaGFS ZXF1aXJlbWVudCBtX2FscGhhOwogICAgIGJvb2wgbV9zY2lzc29yRW5hYmxlZDsK