112210 2013-03-12 16:58:14 -0700 [Crash] Touch Events retargeting causes crashes on chrome on android. 2013-03-12 20:59:45 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hayato hayato esprehn+autocc ojan.autocc webcomponents-bugzilla webkit.review.bot oldest_to_newest 853916 0 hayato 2013-03-12 16:58:14 -0700 The bug on chromium here: http://code.google.com/p/chromium/issues/detail?id=181603 (This might be security-restricted). The possible cause: http://trac.webkit.org/changeset/144877 853918 1 192835 hayato 2013-03-12 17:03:44 -0700 Created attachment 192835 Fix crashes. 853944 2 192835 dglazkov 2013-03-12 17:41:25 -0700 Comment on attachment 192835 Fix crashes. View in context: https://bugs.webkit.org/attachment.cgi?id=192835&action=review > Source/WebCore/ChangeLog:10 > + No new tests - no new functionality. Don't we need a regression test for a crash? 853950 3 hayato 2013-03-12 18:00:55 -0700 Thank you for the review. (In reply to comment #2) > (From update of attachment 192835 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=192835&action=review > > > Source/WebCore/ChangeLog:10 > > + No new tests - no new functionality. > > Don't we need a regression test for a crash? Yes, we should. But I could not reproduce it yet. Could you see the http://code.google.com/p/chromium/issues/detail?id=181603 I added you to cc, so you can see the bug on chromium now and know the detail. I think this patch does not make things worse. So let me land this. 854033 4 192835 webkit.review.bot 2013-03-12 20:53:52 -0700 Comment on attachment 192835 Fix crashes. Clearing flags on attachment: 192835 Committed r145677: <http://trac.webkit.org/changeset/145677> 854034 5 webkit.review.bot 2013-03-12 20:53:55 -0700 All reviewed patches have been landed. Closing bug. 854035 6 hayato 2013-03-12 20:59:45 -0700 For the record, as per discussion on http://code.google.com/p/chromium/issues/detail?id=181603, this patch fixes the crash. Tough, I am not sure yet why touches(), targetTouches() or changedTouches() will becomes null. Let me repro that, and hopefully add a regression test in another patch. 192835 2013-03-12 17:03:44 -0700 2013-03-12 20:53:52 -0700 Fix crashes. bug-112210-20130313085942.patch text/plain 3498 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZThhYjJkMjUyM2ZlY2Jh YWUwYzJkMTcyMjc3MjU0MmVlNDA2ZmFlMy4uNmYzMTRlNDA5NjVmMjdmZTg1ZmEwYTM1ZmQyZmQ2 ZjllYzM0YWExMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTEyICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ3Jhc2hdIFRvdWNoIEV2 ZW50cyByZXRhcmdldGluZyBjYXVzZXMgY3Jhc2hlcyBvbiBjaHJvbWUgb24gYW5kcm9pZC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjIxMAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIG51bGwt Y2hlY2sgZm9yIFRvdWNoRXZlbnQncyB0b3VjaGVzKCksIHRhcmdldFRvdWNoZXMoKSBhbmQgY2hh bmdlZFRvdWNoZXMoKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgLSBubyBuZXcgZnVuY3Rpb25h bGl0eS4KKworICAgICAgICAqIGRvbS9FdmVudFJldGFyZ2V0ZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RXZlbnRSZXRhcmdldGVyOjphZGp1c3RGb3JUb3VjaEV2ZW50KToKKyAgICAgICAgKFdl YkNvcmU6OkV2ZW50UmV0YXJnZXRlcjo6YWRqdXN0VG91Y2hMaXN0KToKKyAgICAgICAgKiBkb20v RXZlbnRSZXRhcmdldGVyLmg6CisKIDIwMTMtMDMtMTIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxh cEBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wcm92ZSBsb2dnaW5nIGluIFJlc291cmNlSGFuZGxl TWFjLm1tCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRSZXRhcmdldGVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFJldGFyZ2V0ZXIuY3BwCmluZGV4IGE4Y2NlNDU2 ODliYmQyN2JhM2FkZjQ4OTVmMjgxN2FkYzY0M2ZmODIuLmJmNWI4ODM5NmE3ZDkzNWMyODE4ZGY1 YmU5ZGI2YTdmNjkyY2I5N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFJl dGFyZ2V0ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFJldGFyZ2V0ZXIuY3Bw CkBAIC0xMzgsMTcgKzEzOCwxOSBAQCB2b2lkIEV2ZW50UmV0YXJnZXRlcjo6YWRqdXN0Rm9yVG91 Y2hFdmVudChOb2RlKiBub2RlLCBjb25zdCBUb3VjaEV2ZW50JiB0b3VjaEV2ZQogICAgICAgICBl dmVudFBhdGhDaGFuZ2VkVG91Y2hlc1tpXSA9IHRvdWNoRXZlbnRDb250ZXh0LT5jaGFuZ2VkVG91 Y2hlcygpOwogICAgIH0KIAotICAgIGFkanVzdFRvdWNoTGlzdChub2RlLCAqdG91Y2hFdmVudC50 b3VjaGVzKCksIGV2ZW50UGF0aCwgZXZlbnRQYXRoVG91Y2hlcyk7Ci0gICAgYWRqdXN0VG91Y2hM aXN0KG5vZGUsICp0b3VjaEV2ZW50LnRhcmdldFRvdWNoZXMoKSwgZXZlbnRQYXRoLCBldmVudFBh dGhUYXJnZXRUb3VjaGVzKTsKLSAgICBhZGp1c3RUb3VjaExpc3Qobm9kZSwgKnRvdWNoRXZlbnQu Y2hhbmdlZFRvdWNoZXMoKSwgZXZlbnRQYXRoLCBldmVudFBhdGhDaGFuZ2VkVG91Y2hlcyk7Cisg ICAgYWRqdXN0VG91Y2hMaXN0KG5vZGUsIHRvdWNoRXZlbnQudG91Y2hlcygpLCBldmVudFBhdGgs IGV2ZW50UGF0aFRvdWNoZXMpOworICAgIGFkanVzdFRvdWNoTGlzdChub2RlLCB0b3VjaEV2ZW50 LnRhcmdldFRvdWNoZXMoKSwgZXZlbnRQYXRoLCBldmVudFBhdGhUYXJnZXRUb3VjaGVzKTsKKyAg ICBhZGp1c3RUb3VjaExpc3Qobm9kZSwgdG91Y2hFdmVudC5jaGFuZ2VkVG91Y2hlcygpLCBldmVu dFBhdGgsIGV2ZW50UGF0aENoYW5nZWRUb3VjaGVzKTsKIH0KIAotdm9pZCBFdmVudFJldGFyZ2V0 ZXI6OmFkanVzdFRvdWNoTGlzdChjb25zdCBOb2RlKiBub2RlLCBjb25zdCBUb3VjaExpc3QmIHRv dWNoTGlzdCwgY29uc3QgRXZlbnRQYXRoJiBldmVudFBhdGgsIEV2ZW50UGF0aFRvdWNoTGlzdHMm IGV2ZW50UGF0aFRvdWNoTGlzdHMpCit2b2lkIEV2ZW50UmV0YXJnZXRlcjo6YWRqdXN0VG91Y2hM aXN0KGNvbnN0IE5vZGUqIG5vZGUsIGNvbnN0IFRvdWNoTGlzdCogdG91Y2hMaXN0LCBjb25zdCBF dmVudFBhdGgmIGV2ZW50UGF0aCwgRXZlbnRQYXRoVG91Y2hMaXN0cyYgZXZlbnRQYXRoVG91Y2hM aXN0cykKIHsKKyAgICBpZiAoIXRvdWNoTGlzdCkKKyAgICAgICAgcmV0dXJuOwogICAgIHNpemVf dCBldmVudFBhdGhTaXplID0gZXZlbnRQYXRoLnNpemUoKTsKICAgICBBU1NFUlQoZXZlbnRQYXRo VG91Y2hMaXN0cy5zaXplKCkgPT0gZXZlbnRQYXRoU2l6ZSk7Ci0gICAgZm9yIChzaXplX3QgaSA9 IDA7IGkgPCB0b3VjaExpc3QubGVuZ3RoKCk7ICsraSkgewotICAgICAgICBjb25zdCBUb3VjaCYg dG91Y2ggPSAqdG91Y2hMaXN0Lml0ZW0oaSk7CisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCB0 b3VjaExpc3QtPmxlbmd0aCgpOyArK2kpIHsKKyAgICAgICAgY29uc3QgVG91Y2gmIHRvdWNoID0g KnRvdWNoTGlzdC0+aXRlbShpKTsKICAgICAgICAgQWRqdXN0ZWROb2RlcyBhZGp1c3RlZE5vZGVz OwogICAgICAgICBjYWxjdWxhdGVBZGp1c3RlZE5vZGVzKG5vZGUsIHRvdWNoLnRhcmdldCgpLT50 b05vZGUoKSwgRG9lc05vdFN0b3BBdEJvdW5kYXJ5LCBjb25zdF9jYXN0PEV2ZW50UGF0aCY+KGV2 ZW50UGF0aCksIGFkanVzdGVkTm9kZXMpOwogICAgICAgICBBU1NFUlQoYWRqdXN0ZWROb2Rlcy5z aXplKCkgPT0gZXZlbnRQYXRoU2l6ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20v RXZlbnRSZXRhcmdldGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRSZXRhcmdldGVyLmgK aW5kZXggZjJlYTA1OTM4NmJiNjE1NjMxNWVlYjUxYzc2YzA0NmUxNWUwY2M1Yy4uOTI2YTFhNWIw NTg0NjEwYTJjZTY0YmQyNDFkNmJmY2M2OTM0MDM4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZG9tL0V2ZW50UmV0YXJnZXRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFJl dGFyZ2V0ZXIuaApAQCAtNzIsNyArNzIsNyBAQCBwcml2YXRlOgogICAgIHN0YXRpYyB2b2lkIGJ1 aWxkUmVsYXRlZE5vZGVNYXAoY29uc3QgTm9kZSosIFJlbGF0ZWROb2RlTWFwJik7CiAgICAgc3Rh dGljIE5vZGUqIGZpbmRSZWxhdGVkTm9kZShUcmVlU2NvcGUqLCBSZWxhdGVkTm9kZU1hcCYpOwog I2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCi0gICAgc3RhdGljIHZvaWQgYWRqdXN0VG91Y2hMaXN0 KGNvbnN0IE5vZGUqLCBjb25zdCBUb3VjaExpc3QmLCBjb25zdCBFdmVudFBhdGgmLCBFdmVudFBh dGhUb3VjaExpc3RzJik7CisgICAgc3RhdGljIHZvaWQgYWRqdXN0VG91Y2hMaXN0KGNvbnN0IE5v ZGUqLCBjb25zdCBUb3VjaExpc3QqLCBjb25zdCBFdmVudFBhdGgmLCBFdmVudFBhdGhUb3VjaExp c3RzJik7CiAjZW5kaWYKIH07CiAK