112206 2013-03-12 16:28:55 -0700 Primary plugin hit detection needs to run after plugin creation 2013-03-12 18:01:34 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino thorton webkit-bug-importer oldest_to_newest 853894 0 dino 2013-03-12 16:28:55 -0700 We can't always guarantee that the didFinishLoad will happen before the plugins are created. Move the plugin hit detection to a more reliable spot. 853895 1 webkit-bug-importer 2013-03-12 16:29:13 -0700 <rdar://problem/13405856> 853896 2 thorton 2013-03-12 16:29:35 -0700 Let's not move it, let's just call it from more than one place. 853900 3 thorton 2013-03-12 16:30:33 -0700 (it was designed to allow calling it again later (the plan was on-plugin-creation), and will choose a primary snapshotted plugin then if there isn't already one) 853927 4 192838 dino 2013-03-12 17:12:30 -0700 Created attachment 192838 Patch 853951 5 dino 2013-03-12 18:01:34 -0700 Committed r145644: <http://trac.webkit.org/changeset/145644> 192838 2013-03-12 17:12:30 -0700 2013-03-12 17:13:26 -0700 Patch bug-112206-20130313110827.patch text/plain 3890 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWM4NTFmYTQ1NzAyZDlh ZWZlNTQyNzg4N2Y5MzllNDRiNDdmNmVmZi4uNzEzOTQ1ODA3MTFlNGFlZmI4OTI2YzA3YTA2OWE4 YzYwY2E3NjdjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAzLTEyICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBQcmltYXJ5IHBsdWdpbiBoaXQg ZGV0ZWN0aW9uIG5lZWRzIHRvIHJ1biBhZnRlciBwbHVnaW4gY3JlYXRpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjIwNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIHNvbWUgcGFnZXMsIHRoZSBw bHVnaW5zIGFyZSBjcmVhdGVkIGFmdGVyIHRoZSBwYWdlIGhhcyBsb2FkZWQsIGFuZAorICAgICAg ICB0aHVzIG91ciBoZXVyaXN0aWMgdG8gZGV0ZXJtaW5lIHRoZSBwcmltYXJ5IHBsdWdpbiBmYWls cy4gUnVuIHRoaXMKKyAgICAgICAgaGV1cmlzdGljIG1vcmUgb2Z0ZW46IGFmdGVyIGVhY2ggUGx1 Z2luVmlldyBpcyBjcmVhdGVkLiBJdCBhbHJlYWR5IGV4aXRzCisgICAgICAgIGVhcmx5IGlmIGl0 IGhhcyBmb3VuZCBhIHByaW1hcnkuIEJ1dCB3ZSBhbHNvIG5lZWQgdG8gbWFrZSBzdXJlIHRoYXQg aXQKKyAgICAgICAgZG9lc24ndCBydW4gYmVmb3JlIGxvYWQuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmFkZFBs dWdpblZpZXcpOiBSdW4gZGV0ZWN0aW9uIHdoZW4gdmlldyBpcyBhZGRlZC4KKyAgICAgICAgKFdl YktpdDo6V2ViUGFnZTo6ZGlkRmluaXNoTG9hZCk6IFJlbWVtYmVyIHRoYXQgd2UgaGF2ZSBsb2Fk ZWQuCisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmRldGVybWluZVByaW1hcnlTbmFwc2hvdHRl ZFBsdWdJbik6IExvb2sgYXQgdGhlIFBsdWdpblZpZXdzIHRvIHNlZSBpZiB3ZSBoYXZlIGEgcGx1 Z2luLgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpyZXNldFByaW1hcnlTbmFwc2hvdHRlZFBs dWdJbik6IFJlc2V0IGJvdGggZmxhZ3MuCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuaDoKKyAgICAgICAgKFdlYlBhZ2UpOiBOZXcgbWVtYmVyIHZhcmlhYmxlLCBtX3JlYWR5 VG9GaW5kUHJpbWFyeVNuYXBzaG90dGVkUGx1Z2luLgorCiAyMDEzLTAzLTEyICBaYW4gRG9iZXJz ZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBSZW1vdmUgSElMRE9O X0NQUEZMQUdTIGFuZCBISUxET05fQ0ZMQUdTIHJlZmVyZW5jZXMgZnJvbSBHTlVtYWtlZmlsZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNw cCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCBm OTdkZjYwMzRiNGQ3NDgxYzY4YTBlMWYzNThiODJlNjVmZTM3ZDNhLi4yNTAwYTQ0MDI4ZDVlNWYw YzA3YmNiMzE5Y2M2ODVlZTA5MTA3NTZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0yMzcsNiArMjM3LDcgQEAgV2ViUGFnZTo6V2ViUGFn ZSh1aW50NjRfdCBwYWdlSUQsIGNvbnN0IFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMmIHBhcmFt ZXRlcnMpCiAgICAgLCBtX3Njcm9sbGluZ1BlcmZvcm1hbmNlTG9nZ2luZ0VuYWJsZWQoZmFsc2Up CiAgICAgLCBtX21haW5GcmFtZUlzU2Nyb2xsYWJsZSh0cnVlKQogI2lmIEVOQUJMRShQUklNQVJZ X1NOQVBTSE9UVEVEX1BMVUdJTl9IRVVSSVNUSUMpCisgICAgLCBtX3JlYWR5VG9GaW5kUHJpbWFy eVNuYXBzaG90dGVkUGx1Z2luKGZhbHNlKQogICAgICwgbV9kaWRGaW5kUHJpbWFyeVNuYXBzaG90 dGVkUGx1Z2luKGZhbHNlKQogI2VuZGlmCiAjaWYgUExBVEZPUk0oTUFDKQpAQCAtMjg5Nyw2ICsy ODk4LDkgQEAgdm9pZCBXZWJQYWdlOjphZGRQbHVnaW5WaWV3KFBsdWdpblZpZXcqIHBsdWdpblZp ZXcpCiAgICAgQVNTRVJUKCFtX3BsdWdpblZpZXdzLmNvbnRhaW5zKHBsdWdpblZpZXcpKTsKIAog ICAgIG1fcGx1Z2luVmlld3MuYWRkKHBsdWdpblZpZXcpOworI2lmIEVOQUJMRShQUklNQVJZX1NO QVBTSE9UVEVEX1BMVUdJTl9IRVVSSVNUSUMpCisgICAgZGV0ZXJtaW5lUHJpbWFyeVNuYXBzaG90 dGVkUGx1Z0luKCk7CisjZW5kaWYKIH0KIAogdm9pZCBXZWJQYWdlOjpyZW1vdmVQbHVnaW5WaWV3 KFBsdWdpblZpZXcqIHBsdWdpblZpZXcpCkBAIC0zODYwLDYgKzM4NjQsNyBAQCB2b2lkIFdlYlBh Z2U6OmRpZENvbW1pdExvYWQoV2ViRnJhbWUqIGZyYW1lKQogdm9pZCBXZWJQYWdlOjpkaWRGaW5p c2hMb2FkKFdlYkZyYW1lKiBmcmFtZSkKIHsKICNpZiBFTkFCTEUoUFJJTUFSWV9TTkFQU0hPVFRF RF9QTFVHSU5fSEVVUklTVElDKQorICAgIG1fcmVhZHlUb0ZpbmRQcmltYXJ5U25hcHNob3R0ZWRQ bHVnaW4gPSB0cnVlOwogICAgIGRldGVybWluZVByaW1hcnlTbmFwc2hvdHRlZFBsdWdJbigpOwog I2VuZGlmCiB9CkBAIC0zODczLDcgKzM4NzgsMTAgQEAgc3RhdGljIGludCBwcmltYXJ5U25hcHNo b3R0ZWRQbHVnSW5NaW5pbXVtSGVpZ2h0ID0gMzAwOwogCiB2b2lkIFdlYlBhZ2U6OmRldGVybWlu ZVByaW1hcnlTbmFwc2hvdHRlZFBsdWdJbigpCiB7Ci0gICAgaWYgKCFjb3JlUGFnZSgpLT5oYXNT ZWVuQW55UGx1Z2luKCkpCisgICAgaWYgKCFtX3JlYWR5VG9GaW5kUHJpbWFyeVNuYXBzaG90dGVk UGx1Z2luKQorICAgICAgICByZXR1cm47CisKKyAgICBpZiAobV9wbHVnaW5WaWV3cy5pc0VtcHR5 KCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIGlmIChtX2RpZEZpbmRQcmltYXJ5U25hcHNob3R0 ZWRQbHVnaW4pCkBAIC0zOTQzLDYgKzM5NTEsNyBAQCB2b2lkIFdlYlBhZ2U6OmRldGVybWluZVBy aW1hcnlTbmFwc2hvdHRlZFBsdWdJbigpCiAKIHZvaWQgV2ViUGFnZTo6cmVzZXRQcmltYXJ5U25h cHNob3R0ZWRQbHVnSW4oKQogeworICAgIG1fcmVhZHlUb0ZpbmRQcmltYXJ5U25hcHNob3R0ZWRQ bHVnaW4gPSBmYWxzZTsKICAgICBtX2RpZEZpbmRQcmltYXJ5U25hcHNob3R0ZWRQbHVnaW4gPSBm YWxzZTsKIH0KICNlbmRpZiAvLyBFTkFCTEUoUFJJTUFSWV9TTkFQU0hPVFRFRF9QTFVHSU5fSEVV UklTVElDKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgKaW5k ZXggM2RmYWVkOTBiNTZhYjkxMTYyZDQ5MGVkZjFjOTg0N2JjY2UyYzkxNy4uM2JmOGE1YjMwZjAx M2MwZTc1ZjE5MDRlNTU3NmZhYjQ4MmYxYTY1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCkBAIC04NTYsNiArODU2LDcgQEAgcHJpdmF0ZToKICAgICBi b29sIG1fbWFpbkZyYW1lSXNTY3JvbGxhYmxlOwogCiAjaWYgRU5BQkxFKFBSSU1BUllfU05BUFNI T1RURURfUExVR0lOX0hFVVJJU1RJQykKKyAgICBib29sIG1fcmVhZHlUb0ZpbmRQcmltYXJ5U25h cHNob3R0ZWRQbHVnaW47CiAgICAgYm9vbCBtX2RpZEZpbmRQcmltYXJ5U25hcHNob3R0ZWRQbHVn aW47CiAjZW5kaWYKIAo=