112198 2013-03-12 15:20:07 -0700 Add a --build-directory argument to delete-stale-build-files 2013-03-12 15:41:07 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton rniwa simon.fraser oldest_to_newest 853838 0 thorton 2013-03-12 15:20:07 -0700 So that unconventional build setups can tell it where to look for build products. 853841 1 192824 thorton 2013-03-12 15:22:29 -0700 Created attachment 192824 patch 853852 2 192824 rniwa 2013-03-12 15:29:06 -0700 Comment on attachment 192824 patch View in context: https://bugs.webkit.org/attachment.cgi?id=192824&action=review > Tools/BuildSlaveSupport/delete-stale-build-files:35 > + parser.add_option("--build-dir", dest="directory") Could you instead use --build-directory to match run-webkit-tests? > Tools/BuildSlaveSupport/delete-stale-build-files:53 > + directory = options.directory I would have preferred to call this buildDirectory. If you rename the option and omit "dest", it'll automatically do that. 853862 3 thorton 2013-03-12 15:41:07 -0700 http://trac.webkit.org/changeset/145600 192824 2013-03-12 15:22:29 -0700 2013-03-12 15:29:06 -0700 patch dbp.diff text/plain 1631 thorton ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2RlbGV0ZS1zdGFsZS1idWlsZC1m aWxlcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2RlbGV0ZS1zdGFsZS1idWlsZC1maWxlcwpp bmRleCAzYjhiZDYzLi5hY2ZiNGIxIDEwMDc1NQotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9y dC9kZWxldGUtc3RhbGUtYnVpbGQtZmlsZXMKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZGVsZXRlLXN0YWxlLWJ1aWxkLWZpbGVzCkBAIC0zMiw2ICszMiw3IEBAIGltcG9ydCBzeXMKIGRl ZiBtYWluKCk6CiAgICAgcGFyc2VyID0gb3B0cGFyc2UuT3B0aW9uUGFyc2VyKCJ1c2FnZTogJXBy b2cgW29wdGlvbnNdIikKICAgICBwYXJzZXIuYWRkX29wdGlvbigiLS1wbGF0Zm9ybSIsIGRlc3Q9 InBsYXRmb3JtIikKKyAgICBwYXJzZXIuYWRkX29wdGlvbigiLS1idWlsZC1kaXIiLCBkZXN0PSJk aXJlY3RvcnkiKQogICAgIHBhcnNlci5hZGRfb3B0aW9uKCItLWRlYnVnIiwgYWN0aW9uPSJzdG9y ZV9jb25zdCIsIGNvbnN0PSJkZWJ1ZyIsIGRlc3Q9ImNvbmZpZ3VyYXRpb24iKQogICAgIHBhcnNl ci5hZGRfb3B0aW9uKCItLXJlbGVhc2UiLCBhY3Rpb249InN0b3JlX2NvbnN0IiwgY29uc3Q9InJl bGVhc2UiLCBkZXN0PSJjb25maWd1cmF0aW9uIikKIApAQCAtNDgsNyArNDksMTEgQEAgZGVmIG1h aW4oKToKICAgICAgICAgcHJpbnQgJ0V4aXRlZCB3aXRob3V0IHJlbW92aW5nIGFueSBmaWxlcy4n CiAgICAgICAgIHJldHVybiAwCiAKLSAgICBkaXJlY3RvcnkgPSB3ZWJraXRCdWlsZERpcmVjdG9y eShnZW5lcmljUGxhdGZvcm0sIG9wdGlvbnMuY29uZmlndXJhdGlvbikKKyAgICBpZiBvcHRpb25z LmRpcmVjdG9yeToKKyAgICAgICAgZGlyZWN0b3J5ID0gb3B0aW9ucy5kaXJlY3RvcnkKKyAgICBl bHNlOgorICAgICAgICBkaXJlY3RvcnkgPSB3ZWJraXRCdWlsZERpcmVjdG9yeShnZW5lcmljUGxh dGZvcm0sIG9wdGlvbnMuY29uZmlndXJhdGlvbikKKwogICAgIGV4aXRfY29kZSA9IDAKIAogICAg IGZvciByb290LCBfLCBmaWxlcyBpbiBvcy53YWxrKGRpcmVjdG9yeSk6CmRpZmYgLS1naXQgYS9U b29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZThjZGFkZi4uZmIzMWU4NCAx MDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEzIEBACisyMDEzLTAzLTEyICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUu Y29tPgorCisgICAgICAgIEFkZCBhIC0tYnVpbGQtZGlyIGFyZ3VtZW50IHRvIGRlbGV0ZS1zdGFs ZS1idWlsZC1maWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTEyMTk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9kZWxldGUtc3RhbGUtYnVpbGQtZmlsZXM6CisgICAg ICAgIChtYWluKTogQWRkIC0tYnVpbGQtZGlyIGFyZ3VtZW50LgorCiAyMDEzLTAzLTExICBBbmRy ZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXVtXSzFdIEFkZCBz dXBwb3J0IGZvciBhbGVydCgpIGluIE1pbmlCcm93c2VyLgo=