112189 2013-03-12 14:43:32 -0700 [Chromium] WebFrame event listener APIs are unused and can be removed 2013-03-12 18:21:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dglazkov fishd jamesr magreenblatt tkent+wkapi tony webkit.review.bot oldest_to_newest 853785 0 abarth 2013-03-12 14:43:32 -0700 [Chromium] WebFrame event listener APIs are unused and can be removed 853787 1 192809 abarth 2013-03-12 14:44:18 -0700 Created attachment 192809 Patch 853800 2 webkit.review.bot 2013-03-12 14:53:49 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 853817 3 abarth 2013-03-12 15:03:53 -0700 Marshall Greenblatt confirms that these APIs are not used in CEF. 853969 4 192809 webkit.review.bot 2013-03-12 18:21:19 -0700 Comment on attachment 192809 Patch Clearing flags on attachment: 192809 Committed r145651: <http://trac.webkit.org/changeset/145651> 853970 5 webkit.review.bot 2013-03-12 18:21:22 -0700 All reviewed patches have been landed. Closing bug. 192809 2013-03-12 14:44:18 -0700 2013-03-12 18:21:19 -0700 Patch bug-112189-20130312144017.patch text/plain 4452 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDdjM2UwOTk3ZTI0Zjg2YzhjZDE1YTBhMzkxZTJiZmM1OGMzMGY5YTEuLjk5MzY4NjU5YmQyODBm ZmQ5NWM2OTg3ZmZkNjI0MTRkZGMwZWI4YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTMtMDMtMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBbQ2hyb21pdW1dIFdlYkZyYW1lIGV2ZW50IGxpc3RlbmVyIEFQSXMgYXJl IHVudXNlZCBhbmQgY2FuIGJlIHJlbW92ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMjE4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFzIGZhciBhcyBJIGNhbiB0ZWxsLCB0aGVyZSBhcmUgbm8gY2Fs bGVycyBmb3IgdGhlc2UgQVBJcy4gVGhleSBhcHBlYXIKKyAgICAgICAgdG8gaGF2ZSBiZWVuIGFk ZGVkIGZvciBvdXQtb2YtcHJvY2VzcyBwb3N0TWVzc2FnZXMsIGJ1dCB0aG9zZSBhcmUgbm93Cisg ICAgICAgIGltcGxlbWVudGVkIHVzaW5nIGEgZGlmZmVyZW50IG1lY2hhbmlzbS4KKworICAgICAg ICAqIHB1YmxpYy9XZWJGcmFtZS5oOgorICAgICAgICAoV2ViRnJhbWUpOgorICAgICAgICAqIHNy Yy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuaDoKKyAgICAg ICAgKFdlYkZyYW1lSW1wbCk6CisKIDIwMTMtMDMtMTIgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5v QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXBsYWNlIHN0YXRpY19jYXN0cyB3aXRoIHRvKiBm dW5jdGlvbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJG cmFtZS5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaAppbmRleCBi MDA5MjNiYjY2MTI1M2RiZDRmNzBjYWIwNmQ0ZWU5MjQ1Y2U4ZWNlLi45NTM2MzRmYjQxZWY0ZjA1 NDEwNWEzMzhjY2Y2OTM3ODZkYTExMDAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJGcmFtZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYkZyYW1lLmgKQEAgLTYwOSwxNSArNjA5LDcgQEAgcHVibGljOgogCiAgICAgLy8gRXZlbnRz IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tCiAKLSAgICAvLyBUaGVzZSBmdW5jdGlvbnMgYWxsIHdvcmsgb24gdGhlIFdlYkZyYW1l J3MgRE9NV2luZG93LiBLZWVwIGluIG1pbmQKLSAgICAvLyB0aGF0IHRoZXNlIGV2ZW50cyBtaWdo dCBiZSBnZW5lcmF0ZWQgYnkgd2ViIGNvbnRlbnQgYW5kIG5vdCBnZW51aW5lCi0gICAgLy8gRE9N IGV2ZW50cy4KLQotICAgIHZpcnR1YWwgdm9pZCBhZGRFdmVudExpc3RlbmVyKGNvbnN0IFdlYlN0 cmluZyYgZXZlbnRUeXBlLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdlYkRP TUV2ZW50TGlzdGVuZXIqLCBib29sIHVzZUNhcHR1cmUpID0gMDsKLSAgICB2aXJ0dWFsIHZvaWQg cmVtb3ZlRXZlbnRMaXN0ZW5lcihjb25zdCBXZWJTdHJpbmcmIGV2ZW50VHlwZSwKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBXZWJET01FdmVudExpc3RlbmVyKiwgYm9vbCB1 c2VDYXB0dXJlKSA9IDA7Ci0gICAgdmlydHVhbCBib29sIGRpc3BhdGNoRXZlbnQoY29uc3QgV2Vi RE9NRXZlbnQmKSA9IDA7CisgICAgLy8gRGlzcGF0Y2hlcyBhIG1lc3NhZ2UgZXZlbnQgb24gdGhl IGN1cnJlbnQgRE9NV2luZG93IGluIHRoaXMgV2ViRnJhbWUuCiAgICAgdmlydHVhbCB2b2lkIGRp c3BhdGNoTWVzc2FnZUV2ZW50V2l0aE9yaWdpbkNoZWNrKAogICAgICAgICBjb25zdCBXZWJTZWN1 cml0eU9yaWdpbiYgaW50ZW5kZWRUYXJnZXRPcmlnaW4sCiAgICAgICAgIGNvbnN0IFdlYkRPTUV2 ZW50JikgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJh bWVJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAK aW5kZXggMzkxOGIxMmI5MDI4YzE3NzA3NWExYmJjOGIzYTMzMTgyZmNmN2M2MS4uMmYxZTY3NDkx Y2M1MzE5MTIxMWU5MmI3MDBmNDQzNDA4ZDU4ZDQ5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCkBAIC0xODUwLDI2ICsxODUwLDYgQEAgdm9pZCBXZWJG cmFtZUltcGw6OnNlbmRPcmllbnRhdGlvbkNoYW5nZUV2ZW50KGludCBvcmllbnRhdGlvbikKICNl bmRpZgogfQogCi12b2lkIFdlYkZyYW1lSW1wbDo6YWRkRXZlbnRMaXN0ZW5lcihjb25zdCBXZWJT dHJpbmcmIGV2ZW50VHlwZSwgV2ViRE9NRXZlbnRMaXN0ZW5lciogbGlzdGVuZXIsIGJvb2wgdXNl Q2FwdHVyZSkKLXsKLSAgICBET01XaW5kb3cqIHdpbmRvdyA9IGZyYW1lKCktPmRvY3VtZW50KCkt PmRvbVdpbmRvdygpOwotICAgIEV2ZW50TGlzdGVuZXJXcmFwcGVyKiBsaXN0ZW5lcldyYXBwZXIg PSBsaXN0ZW5lci0+Y3JlYXRlRXZlbnRMaXN0ZW5lcldyYXBwZXIoZXZlbnRUeXBlLCB1c2VDYXB0 dXJlLCB3aW5kb3cpOwotICAgIHdpbmRvdy0+YWRkRXZlbnRMaXN0ZW5lcihldmVudFR5cGUsIGFk b3B0UmVmKGxpc3RlbmVyV3JhcHBlciksIHVzZUNhcHR1cmUpOwotfQotCi12b2lkIFdlYkZyYW1l SW1wbDo6cmVtb3ZlRXZlbnRMaXN0ZW5lcihjb25zdCBXZWJTdHJpbmcmIGV2ZW50VHlwZSwgV2Vi RE9NRXZlbnRMaXN0ZW5lciogbGlzdGVuZXIsIGJvb2wgdXNlQ2FwdHVyZSkKLXsKLSAgICBET01X aW5kb3cqIHdpbmRvdyA9IGZyYW1lKCktPmRvY3VtZW50KCktPmRvbVdpbmRvdygpOwotICAgIEV2 ZW50TGlzdGVuZXJXcmFwcGVyKiBsaXN0ZW5lcldyYXBwZXIgPSBsaXN0ZW5lci0+Z2V0RXZlbnRM aXN0ZW5lcldyYXBwZXIoZXZlbnRUeXBlLCB1c2VDYXB0dXJlLCB3aW5kb3cpOwotICAgIHdpbmRv dy0+cmVtb3ZlRXZlbnRMaXN0ZW5lcihldmVudFR5cGUsIGxpc3RlbmVyV3JhcHBlciwgdXNlQ2Fw dHVyZSk7Ci19Ci0KLWJvb2wgV2ViRnJhbWVJbXBsOjpkaXNwYXRjaEV2ZW50KGNvbnN0IFdlYkRP TUV2ZW50JiBldmVudCkKLXsKLSAgICBBU1NFUlQoIWV2ZW50LmlzTnVsbCgpKTsKLSAgICByZXR1 cm4gZnJhbWUoKS0+ZG9jdW1lbnQoKS0+ZG9tV2luZG93KCktPmRpc3BhdGNoRXZlbnQoZXZlbnQp OwotfQotCiB2b2lkIFdlYkZyYW1lSW1wbDo6ZGlzcGF0Y2hNZXNzYWdlRXZlbnRXaXRoT3JpZ2lu Q2hlY2soY29uc3QgV2ViU2VjdXJpdHlPcmlnaW4mIGludGVuZGVkVGFyZ2V0T3JpZ2luLCBjb25z dCBXZWJET01FdmVudCYgZXZlbnQpCiB7CiAgICAgQVNTRVJUKCFldmVudC5pc051bGwoKSk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCmluZGV4IDIwODg4MGFjYTU4 MGI5ZTFmZDVhMGYwNDc4ZjU3NjNhY2NhODUzMTMuLmRlODllZjY4MjM2ZmU2MGE3NTkwYTNmMDk1 MGJmYWViNzg5ZTU5ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YkZyYW1lSW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1w bC5oCkBAIC0yMjEsMTEgKzIyMSw2IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBzZW5k T3JpZW50YXRpb25DaGFuZ2VFdmVudChpbnQgb3JpZW50YXRpb24pOwogCi0gICAgdmlydHVhbCB2 b2lkIGFkZEV2ZW50TGlzdGVuZXIoY29uc3QgV2ViU3RyaW5nJiBldmVudFR5cGUsCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgV2ViRE9NRXZlbnRMaXN0ZW5lciosIGJvb2wgdXNl Q2FwdHVyZSk7Ci0gICAgdmlydHVhbCB2b2lkIHJlbW92ZUV2ZW50TGlzdGVuZXIoY29uc3QgV2Vi U3RyaW5nJiBldmVudFR5cGUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg V2ViRE9NRXZlbnRMaXN0ZW5lciosIGJvb2wgdXNlQ2FwdHVyZSk7Ci0gICAgdmlydHVhbCBib29s IGRpc3BhdGNoRXZlbnQoY29uc3QgV2ViRE9NRXZlbnQmKTsKICAgICB2aXJ0dWFsIHZvaWQgZGlz cGF0Y2hNZXNzYWdlRXZlbnRXaXRoT3JpZ2luQ2hlY2soCiAgICAgICAgIGNvbnN0IFdlYlNlY3Vy aXR5T3JpZ2luJiBpbnRlbmRlZFRhcmdldE9yaWdpbiwKICAgICAgICAgY29uc3QgV2ViRE9NRXZl bnQmKTsK