112183 2013-03-12 13:24:28 -0700 DFG generic array access cases should not be guarded by CheckStructure even of the profiling tells us that it could be 2013-03-12 13:40:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 853735 0 fpizlo 2013-03-12 13:24:28 -0700 Patch forthcoming. 853736 1 192794 fpizlo 2013-03-12 13:25:50 -0700 Created attachment 192794 the patch 853743 2 fpizlo 2013-03-12 13:40:51 -0700 Landed in http://trac.webkit.org/changeset/145578 192794 2013-03-12 13:25:50 -0700 2013-03-12 13:31:45 -0700 the patch blah.patch text/plain 3437 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ1NTc2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTAzLTEyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIGdlbmVyaWMgYXJyYXkgYWNjZXNzIGNhc2VzIHNob3VsZCBub3QgYmUgZ3VhcmRlZCBieSBD aGVja1N0cnVjdHVyZSBldmVuIG9mIHRoZSBwcm9maWxpbmcgdGVsbHMgdXMgdGhhdCBpdCBjb3Vs ZCBiZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEy MTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAg ICAgICBTbGlnaHQgc3BlZWQtdXAgb24gc3RyaW5nLXVucGFjay1jb2RlLgorCisgICAgICAgICog ZGZnL0RGR0ZpeHVwUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkZpeHVwUGhhc2U6OmZp bmRBbmRSZW1vdmVVbm5lY2Vzc2FyeVN0cnVjdHVyZUNoZWNrKToKKyAgICAgICAgKEZpeHVwUGhh c2UpOgorICAgICAgICAoSlNDOjpERkc6OkZpeHVwUGhhc2U6OmNoZWNrQXJyYXkpOgorICAgICAg ICAoSlNDOjpERkc6OkZpeHVwUGhhc2U6OmJsZXNzQXJyYXlPcGVyYXRpb24pOgorCiAyMDEzLTAz LTEyICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KIAogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMTQxCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAJKHJldmlzaW9uIDE0NTU2MykK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTgzOCw3ICs4MzgsMjYgQEAgcHJpdmF0ZToKICAgICAgICAgbV9pbnNlcnRpb25T ZXQuZXhlY3V0ZShibG9jayk7CiAgICAgfQogICAgIAotICAgIE5vZGUqIGNoZWNrQXJyYXkoQXJy YXlNb2RlIGFycmF5TW9kZSwgQ29kZU9yaWdpbiBjb2RlT3JpZ2luLCBOb2RlKiBhcnJheSwgTm9k ZSogaW5kZXgsIGJvb2wgKCpzdG9yYWdlQ2hlY2spKGNvbnN0IEFycmF5TW9kZSYpID0gY2FuQ1NF U3RvcmFnZSkKKyAgICB2b2lkIGZpbmRBbmRSZW1vdmVVbm5lY2Vzc2FyeVN0cnVjdHVyZUNoZWNr KE5vZGUqIGFycmF5LCBjb25zdCBDb2RlT3JpZ2luJiBjb2RlT3JpZ2luKQorICAgIHsKKyAgICAg ICAgZm9yICh1bnNpZ25lZCBpbmRleCA9IG1faW5kZXhJbkJsb2NrOyBpbmRleC0tOykgeworICAg ICAgICAgICAgTm9kZSogcHJldmlvdXNOb2RlID0gbV9ibG9jay0+YXQoaW5kZXgpOworICAgICAg ICAgICAgaWYgKHByZXZpb3VzTm9kZS0+Y29kZU9yaWdpbiAhPSBjb2RlT3JpZ2luKQorICAgICAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgaWYgKHByZXZpb3Vz Tm9kZS0+b3AoKSAhPSBDaGVja1N0cnVjdHVyZSkKKyAgICAgICAgICAgICAgICBjb250aW51ZTsK KyAgICAgICAgICAgIAorICAgICAgICAgICAgaWYgKHByZXZpb3VzTm9kZS0+Y2hpbGQxKCkgIT0g YXJyYXkpCisgICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICAKKyAgICAgICAg ICAgIHByZXZpb3VzTm9kZS0+Y2hpbGQxKCkgPSBFZGdlKCk7CisgICAgICAgICAgICBwcmV2aW91 c05vZGUtPmNvbnZlcnRUb1BoYW50b20oKTsKKyAgICAgICAgICAgIHJldHVybjsgLy8gQXNzdW1l IHdlIHdlcmUgc21hcnQgZW5vdWdoIHRvIG9ubHkgaW5zZXJ0IG9uZSBDaGVja1N0cnVjdHVyZSBv biB0aGUgYXJyYXkuCisgICAgICAgIH0KKyAgICB9CisgICAgCisgICAgTm9kZSogY2hlY2tBcnJh eShBcnJheU1vZGUgYXJyYXlNb2RlLCBjb25zdCBDb2RlT3JpZ2luJiBjb2RlT3JpZ2luLCBOb2Rl KiBhcnJheSwgTm9kZSogaW5kZXgsIGJvb2wgKCpzdG9yYWdlQ2hlY2spKGNvbnN0IEFycmF5TW9k ZSYpID0gY2FuQ1NFU3RvcmFnZSkKICAgICB7CiAgICAgICAgIEFTU0VSVChhcnJheU1vZGUuaXNT cGVjaWZpYygpKTsKICAgICAgICAgCkBAIC04NTAsMTIgKzg2OSw5IEBAIHByaXZhdGU6CiAgICAg ICAgICAgICBpZiAoc3RydWN0dXJlKSB7CiAgICAgICAgICAgICAgICAgaWYgKG1faW5kZXhJbkJs b2NrID4gMCkgewogICAgICAgICAgICAgICAgICAgICAvLyBJZiB0aGUgcHJldmlvdXMgbm9kZSB3 YXMgYSBDaGVja1N0cnVjdHVyZSBpbnNlcnRlZCBiZWNhdXNlIG9mIHN0dWZmCi0gICAgICAgICAg ICAgICAgICAgIC8vIHRoYXQgdGhlIGFycmF5IHByb2ZpbGUgdG9sZCB1cywgdGhlbiByZW1vdmUg aXQuCi0gICAgICAgICAgICAgICAgICAgIE5vZGUqIHByZXZpb3VzTm9kZSA9IG1fYmxvY2stPmF0 KG1faW5kZXhJbkJsb2NrIC0gMSk7Ci0gICAgICAgICAgICAgICAgICAgIGlmIChwcmV2aW91c05v ZGUtPm9wKCkgPT0gQ2hlY2tTdHJ1Y3R1cmUKLSAgICAgICAgICAgICAgICAgICAgICAgICYmIHBy ZXZpb3VzTm9kZS0+Y2hpbGQxKCkgPT0gYXJyYXkKLSAgICAgICAgICAgICAgICAgICAgICAgICYm IHByZXZpb3VzTm9kZS0+Y29kZU9yaWdpbiA9PSBjb2RlT3JpZ2luKQotICAgICAgICAgICAgICAg ICAgICAgICAgcHJldmlvdXNOb2RlLT5jb252ZXJ0VG9QaGFudG9tKCk7CisgICAgICAgICAgICAg ICAgICAgIC8vIHRoYXQgdGhlIGFycmF5IHByb2ZpbGUgdG9sZCB1cywgdGhlbiByZW1vdmUgaXQs IHNpbmNlIHdlJ3JlIGdvaW5nIHRvIGJlCisgICAgICAgICAgICAgICAgICAgIC8vIGRvaW5nIGFy cmF5aWZpY2F0aW9uIGluc3RlYWQuCisgICAgICAgICAgICAgICAgICAgIGZpbmRBbmRSZW1vdmVV bm5lY2Vzc2FyeVN0cnVjdHVyZUNoZWNrKGFycmF5LCBjb2RlT3JpZ2luKTsKICAgICAgICAgICAg ICAgICB9CiAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgbV9pbnNlcnRpb25TZXQu aW5zZXJ0Tm9kZSgKQEAgLTkwOCw2ICs5MjQsNyBAQCBwcml2YXRlOgogICAgICAgICAgICAgcmV0 dXJuOwogICAgICAgICAgICAgCiAgICAgICAgIGNhc2UgQXJyYXk6OkdlbmVyaWM6CisgICAgICAg ICAgICBmaW5kQW5kUmVtb3ZlVW5uZWNlc3NhcnlTdHJ1Y3R1cmVDaGVjayhiYXNlLm5vZGUoKSwg bm9kZS0+Y29kZU9yaWdpbik7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICAKICAg ICAgICAgZGVmYXVsdDogewo=