11218 2006-10-08 08:41:56 -0700 REGRESSION: Assertion failure in -[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:] when going back from a file: or data: URL 2006-10-08 13:47:15 -0700 1 1 1 Unclassified WebKit Page Loading 420+ Mac OS X 10.4 RESOLVED FIXED P1 Normal --- 1 mitz darin mjs oldest_to_newest 53800 0 mitz 2006-10-08 08:41:56 -0700 ASSERTION FAILED: [self policyDataSource] || [[self provisionalDataSource] unreachableURL] != nil (WebKit/Loader/WebFrameLoader.m:1273 -[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]) To reproduce, go to any URL, then navigate in the same Safari window to a file: or data: URL, then choose History > Back. 53784 1 10987 darin 2006-10-08 13:43:03 -0700 Created attachment 10987 patch to fix this with a small additional tweak (no change log or test) 53785 2 10987 mitz 2006-10-08 13:45:00 -0700 Comment on attachment 10987 patch to fix this with a small additional tweak (no change log or test) r=me 53786 3 darin 2006-10-08 13:47:15 -0700 Committed revision 16889. 10987 2006-10-08 13:43:03 -0700 2006-10-08 13:45:00 -0700 patch to fix this with a small additional tweak (no change log or test) BackForwardPatch.txt text/plain 3392 darin SW5kZXg6IExvYWRlci9XZWJGcmFtZUxvYWRlci5tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExvYWRlci9XZWJG cmFtZUxvYWRlci5tCShyZXZpc2lvbiAxNjg4NykKKysrIExvYWRlci9XZWJGcmFtZUxvYWRlci5t CSh3b3JraW5nIGNvcHkpCkBAIC0yNjQsNyArMjY0LDcgQEAKIAogICAgIFtwb2xpY3lEb2N1bWVu dExvYWRTdGF0ZSByZWxlYXNlXTsKICAgICBbbG9hZFN0YXRlIHJldGFpbl07Ci0gICAgcG9saWN5 RG9jdW1lbnRMb2FkU3RhdGUgPSBuaWw7CisgICAgcG9saWN5RG9jdW1lbnRMb2FkU3RhdGUgPSBs b2FkU3RhdGU7CiB9CiAgICAKIC0gKHZvaWQpY2xlYXJEYXRhU291cmNlCkBAIC04NDgsMTggKzg0 OCwzMyBAQCBzdGF0aWMgQk9PTCBpc0Nhc2VJbnNlbnNpdGl2ZUVxdWFsKE5TU3RyCiAgICAgbGlz dGVuZXIgPSBuaWw7CiB9CiAKK3N0YXRpYyBpbmxpbmUgQk9PTCBpc0JhY2tGb3J3YXJkTG9hZFR5 cGUoV2ViRnJhbWVMb2FkVHlwZSB0eXBlKQoreworICAgIHN3aXRjaCAodHlwZSkgeworICAgICAg ICBjYXNlIFdlYkZyYW1lTG9hZFR5cGVTdGFuZGFyZDoKKyAgICAgICAgY2FzZSBXZWJGcmFtZUxv YWRUeXBlUmVsb2FkOgorICAgICAgICBjYXNlIFdlYkZyYW1lTG9hZFR5cGVSZWxvYWRBbGxvd2lu Z1N0YWxlRGF0YToKKyAgICAgICAgY2FzZSBXZWJGcmFtZUxvYWRUeXBlU2FtZToKKyAgICAgICAg Y2FzZSBXZWJGcmFtZUxvYWRUeXBlSW50ZXJuYWw6CisgICAgICAgIGNhc2UgV2ViRnJhbWVMb2Fk VHlwZVJlcGxhY2U6CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIGNhc2UgV2Vi RnJhbWVMb2FkVHlwZUJhY2s6CisgICAgICAgIGNhc2UgV2ViRnJhbWVMb2FkVHlwZUZvcndhcmQ6 CisgICAgICAgIGNhc2UgV2ViRnJhbWVMb2FkVHlwZUluZGV4ZWRCYWNrRm9yd2FyZDoKKyAgICAg ICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAg ICByZXR1cm4gZmFsc2U7Cit9CisKIC0gKEJPT0wpc2hvdWxkUmVsb2FkVG9IYW5kbGVVbnJlYWNo YWJsZVVSTEZyb21SZXF1ZXN0OihOU1VSTFJlcXVlc3QgKilyZXF1ZXN0CiB7CiAgICAgTlNVUkwg KnVucmVhY2hhYmxlVVJMID0gW3JlcXVlc3QgX3dlYkRhdGFSZXF1ZXN0VW5yZWFjaGFibGVVUkxd OwotICAgIGlmICh1bnJlYWNoYWJsZVVSTCA9PSBuaWwpIHsKKyAgICBpZiAodW5yZWFjaGFibGVV UkwgPT0gbmlsKQogICAgICAgICByZXR1cm4gTk87Ci0gICAgfQogICAgIAotICAgIGlmIChwb2xp Y3lMb2FkVHlwZSAhPSBXZWJGcmFtZUxvYWRUeXBlRm9yd2FyZAotICAgICAgICAmJiBwb2xpY3lM b2FkVHlwZSAhPSBXZWJGcmFtZUxvYWRUeXBlQmFjawotICAgICAgICAmJiBwb2xpY3lMb2FkVHlw ZSAhPSBXZWJGcmFtZUxvYWRUeXBlSW5kZXhlZEJhY2tGb3J3YXJkKSB7CisgICAgaWYgKCFpc0Jh Y2tGb3J3YXJkTG9hZFR5cGUocG9saWN5TG9hZFR5cGUpKQogICAgICAgICByZXR1cm4gTk87Ci0g ICAgfQogICAgIAogICAgIC8vIFdlIG9ubHkgdHJlYXQgdW5yZWFjaGFibGVVUkxzIHNwZWNpYWxs eSBkdXJpbmcgdGhlIGRlbGVnYXRlIGNhbGxiYWNrcwogICAgIC8vIGZvciBwcm92aXNpb25hbCBs b2FkIGVycm9ycyBhbmQgbmF2aWdhdGlvbiBwb2xpY3kgZGVjaXNpb25zLiBUaGUgZm9ybWVyCkBA IC0xMTg2LDExICsxMjAxLDggQEAgc3RhdGljIEJPT0wgaXNDYXNlSW5zZW5zaXRpdmVFcXVhbChO U1N0cgogICAgIC8vIFdlIGFyZSBhbHdheXMgd2lsbGluZyB0byBzaG93IGFsdGVybmF0ZSBjb250 ZW50IGZvciB1bnJlYWNoYWJsZSBVUkxzOwogICAgIC8vIHRyZWF0IGl0IGxpa2UgYSByZWxvYWQg c28gaXQgbWFpbnRhaW5zIHRoZSByaWdodCBzdGF0ZSBmb3IgYi9mIGxpc3QuCiAgICAgaWYgKFty ZXF1ZXN0IF93ZWJEYXRhUmVxdWVzdFVucmVhY2hhYmxlVVJMXSAhPSBuaWwpIHsKLSAgICAgICAg aWYgKHBvbGljeUxvYWRUeXBlID09IFdlYkZyYW1lTG9hZFR5cGVGb3J3YXJkCi0gICAgICAgICAg ICAgICAgfHwgcG9saWN5TG9hZFR5cGUgPT0gV2ViRnJhbWVMb2FkVHlwZUJhY2sKLSAgICAgICAg ICAgICAgICB8fCBwb2xpY3lMb2FkVHlwZSA9PSBXZWJGcmFtZUxvYWRUeXBlSW5kZXhlZEJhY2tG b3J3YXJkKSB7CisgICAgICAgIGlmIChpc0JhY2tGb3J3YXJkTG9hZFR5cGUocG9saWN5TG9hZFR5 cGUpKQogICAgICAgICAgICAgcG9saWN5TG9hZFR5cGUgPSBXZWJGcmFtZUxvYWRUeXBlUmVsb2Fk OwotICAgICAgICB9CiAgICAgICAgIFt0YXJnZXQgcGVyZm9ybVNlbGVjdG9yOnNlbGVjdG9yIHdp dGhPYmplY3Q6cmVxdWVzdCB3aXRoT2JqZWN0Om5pbF07CiAgICAgICAgIHJldHVybjsKICAgICB9 CkBAIC0xMjg4LDE0ICsxMzAwLDEzIEBAIHN0YXRpYyBCT09MIGlzQ2FzZUluc2Vuc2l0aXZlRXF1 YWwoTlNTdHIKICAgICAgICAgICAgIFtjbGllbnQgX2NsaWVudFJlZGlyZWN0Q2FuY2VsbGVkT3JG aW5pc2hlZDpOT107CiAKICAgICAgICAgW3NlbGYgX3NldFBvbGljeURvY3VtZW50TG9hZFN0YXRl Om5pbF07CisKICAgICAgICAgLy8gSWYgdGhlIG5hdmlnYXRpb24gcmVxdWVzdCBjYW1lIGZyb20g dGhlIGJhY2svZm9yd2FyZCBtZW51LCBhbmQgd2UgcHVudCBvbiBpdCwgd2UgaGF2ZSB0aGUgCiAg ICAgICAgIC8vIHByb2JsZW0gdGhhdCB3ZSBoYXZlIG9wdGltaXN0aWNhbGx5IG1vdmVkIHRoZSBi L2YgY3Vyc29yIGFscmVhZHksIHNvIG1vdmUgaXQgYmFjay4gIEZvciBzYW5pdHksIAogICAgICAg ICAvLyB3ZSBvbmx5IGRvIHRoaXMgd2hlbiBwdW50aW5nIGEgbmF2aWdhdGlvbiBmb3IgdGhlIHRh cmdldCBmcmFtZSBvciB0b3AtbGV2ZWwgZnJhbWUuICAKLSAgICAgICAgaWYgKChpc1RhcmdldEl0 ZW0gfHwgW1tjbGllbnQgd2ViVmlld10gbWFpbkZyYW1lXSA9PSBjbGllbnQpCi0gICAgICAgICAg ICAmJiAocG9saWN5TG9hZFR5cGUgPT0gV2ViRnJhbWVMb2FkVHlwZUZvcndhcmQKLSAgICAgICAg ICAgICAgICB8fCBwb2xpY3lMb2FkVHlwZSA9PSBXZWJGcmFtZUxvYWRUeXBlQmFjawotICAgICAg ICAgICAgICAgIHx8IHBvbGljeUxvYWRUeXBlID09IFdlYkZyYW1lTG9hZFR5cGVJbmRleGVkQmFj a0ZvcndhcmQpKQorICAgICAgICBpZiAoKGlzVGFyZ2V0SXRlbSB8fCBbW2NsaWVudCB3ZWJWaWV3 XSBtYWluRnJhbWVdID09IGNsaWVudCkgJiYgaXNCYWNrRm9yd2FyZExvYWRUeXBlKHBvbGljeUxv YWRUeXBlKSkKICAgICAgICAgICAgIFsoV2ViRnJhbWUgPFdlYkZyYW1lTG9hZGVyQ2xpZW50PiAq KVtbY2xpZW50IHdlYlZpZXddIG1haW5GcmFtZV0gX3Jlc2V0QmFja0ZvcndhcmRMaXN0XTsKKwog ICAgICAgICByZXR1cm47CiAgICAgfQogICAgIAo=