112178 2013-03-12 12:46:32 -0700 Make CheckedArithmetic slightly more sane 2013-03-12 14:07:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver benjamin cmarcelo ojan.autocc webkit.review.bot oldest_to_newest 853711 0 oliver 2013-03-12 12:46:32 -0700 Make CheckedArithmetic slightly more sane 853712 1 192789 oliver 2013-03-12 12:49:15 -0700 Created attachment 192789 Patch 853714 2 192789 ggaren 2013-03-12 12:54:54 -0700 Comment on attachment 192789 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192789&action=review r=me > Source/WTF/wtf/CheckedArithmetic.h:73 > + HasOverflowed, > + Safe I think this would be clearer if the two states were called "DidOverflow" and "DidNotOverflow". Whether something is "safe" is a value judgement this data cannot make. 853760 3 oliver 2013-03-12 14:07:48 -0700 Committed r145580: <http://trac.webkit.org/changeset/145580> 192789 2013-03-12 12:49:15 -0700 2013-03-12 12:54:54 -0700 Patch bug-112178-20130312124515.patch text/plain 3503 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGY0OGJlNTVkMDQxMDAwZjYxM2IwOTgz ODFjZDBjYWQ3YjIxMzlkN2QuLjZkZDIyNjQ2YmQ2ODJiM2FlMjA4MDQ3ZjA3MWQ0ZmFhN2RjNTIw ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTMtMDMtMTIgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIENoZWNrZWRBcml0aG1ldGljIHNsaWdodGx5IG1v cmUgc2FuZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTEyMTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIGFuIGVudW0gdHlwZSBmb3Igc2FmZUdldCByYXRoZXIgdGhhbiB1c2luZyBhIGJvb2wsCisg ICAgICAgIGFuZCBjb3JyZWN0bHkgaGFuZGxlIHVuc2lnbmVkICogdW5zaWduZWQsIHdoZW4gb25l IHZhbHVlCisgICAgICAgIGlzIDAuCisKKyAgICAgICAgKiB3dGYvQ2hlY2tlZEFyaXRobWV0aWMu aDoKKyAgICAgICAgKFdURjo6RU5VTV9DTEFTUyk6CisgICAgICAgIChXVEYpOgorICAgICAgICAo V1RGOjpvcGVyYXRvcispOgorICAgICAgICAoV1RGOjpvcGVyYXRvci0pOgorICAgICAgICAoV1RG OjpvcGVyYXRvciopOgorCiAyMDEzLTAzLTExICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBw bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LiAgUm9sbGluZyBvdXQgaW5h ZHZlcnRlbnQgc2V0dGluZyBvZiBEQVRBX0xPR19UT19GSUxFLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dURi93dGYvQ2hlY2tlZEFyaXRobWV0aWMuaCBiL1NvdXJjZS9XVEYvd3RmL0NoZWNrZWRBcml0 aG1ldGljLmgKaW5kZXggZjVkM2I3NTUwMGEwMmE0MmZhYTU1ZjhjZGE2YWE0YTVkYTEwNTk5ZS4u NDU1ODc5N2ZkNzQzMTU4YzdiYmRhODJiODE1MjVkYmE2ZGFlMmI5MSAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvQ2hlY2tlZEFyaXRobWV0aWMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9DaGVj a2VkQXJpdGhtZXRpYy5oCkBAIC0yNyw2ICsyNyw3IEBACiAjZGVmaW5lIENoZWNrZWRBcml0aG1l dGljX2gKIAogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CisjaW5jbHVkZSA8d3RmL0VudW1D bGFzcy5oPgogI2luY2x1ZGUgPHd0Zi9UeXBlVHJhaXRzLmg+CiAKICNpbmNsdWRlIDxsaW1pdHM+ CkBAIC02Niw2ICs2NywxMiBAQAogCiBuYW1lc3BhY2UgV1RGIHsKIAorRU5VTV9DTEFTUyhDaGVj a2VkU3RhdGUpCit7CisgICAgSGFzT3ZlcmZsb3dlZCwKKyAgICBTYWZlCit9IEVOVU1fQ0xBU1Nf RU5EKENoZWNrZWRTdGF0ZSk7CisgICAgCiBjbGFzcyBDcmFzaE9uT3ZlcmZsb3cgewogcHJvdGVj dGVkOgogICAgIE5PX1JFVFVSTl9EVUVfVE9fQ1JBU0ggdm9pZCBvdmVyZmxvd2VkKCkKQEAgLTMx Niw3ICszMjMsNyBAQCB0ZW1wbGF0ZSA8dHlwZW5hbWUgTEhTLCB0eXBlbmFtZSBSSFMsIHR5cGVu YW1lIFJlc3VsdFR5cGU+IHN0cnVjdCBBcml0aG1ldGljT3BlcgogICAgIHsKICAgICAgICAgUmVz dWx0VHlwZSB0ZW1wID0gbGhzICogcmhzOwogICAgICAgICBpZiAodGVtcCA8IGxocykKLSAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgICAgIHJldHVybiAhcmhzOwogICAgICAgICBy ZXN1bHQgPSB0ZW1wOwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CkBAIC01MzQsMTAgKzU0 MSwxMiBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBtX3ZhbHVlOwogICAgIH0KICAgICAKLSAg ICBib29sIHNhZmVHZXQoVCYgdmFsdWUpIGNvbnN0IFdBUk5fVU5VU0VEX1JFVFVSTgorICAgIGlu bGluZSBDaGVja2VkU3RhdGUgc2FmZUdldChUJiB2YWx1ZSkgY29uc3QgV0FSTl9VTlVTRURfUkVU VVJOCiAgICAgewogICAgICAgICB2YWx1ZSA9IG1fdmFsdWU7Ci0gICAgICAgIHJldHVybiB0aGlz LT5oYXNPdmVyZmxvd2VkKCk7CisgICAgICAgIGlmICh0aGlzLT5oYXNPdmVyZmxvd2VkKCkpCisg ICAgICAgICAgICByZXR1cm4gQ2hlY2tlZFN0YXRlOjpIYXNPdmVyZmxvd2VkOworICAgICAgICBy ZXR1cm4gQ2hlY2tlZFN0YXRlOjpTYWZlOwogICAgIH0KIAogICAgIC8vIE11dGF0aW5nIGFzc2ln bm1lbnQKQEAgLTYzOCw3ICs2NDcsNyBAQCB0ZW1wbGF0ZSA8dHlwZW5hbWUgVSwgdHlwZW5hbWUg ViwgdHlwZW5hbWUgT3ZlcmZsb3dIYW5kbGVyPiBzdGF0aWMgaW5saW5lIENoZWNrZQogewogICAg IFUgeCA9IDA7CiAgICAgViB5ID0gMDsKLSAgICBib29sIG92ZXJmbG93ZWQgPSBsaHMuc2FmZUdl dCh4KSB8fCByaHMuc2FmZUdldCh5KTsKKyAgICBib29sIG92ZXJmbG93ZWQgPSBsaHMuc2FmZUdl dCh4KSA9PSBDaGVja2VkU3RhdGU6Okhhc092ZXJmbG93ZWQgfHwgcmhzLnNhZmVHZXQoeSkgPT0g Q2hlY2tlZFN0YXRlOjpIYXNPdmVyZmxvd2VkOwogICAgIHR5cGVuYW1lIFJlc3VsdDxVLCBWPjo6 UmVzdWx0VHlwZSByZXN1bHQgPSAwOwogICAgIG92ZXJmbG93ZWQgfD0gIXNhZmVBZGQoeCwgeSwg cmVzdWx0KTsKICAgICBpZiAob3ZlcmZsb3dlZCkKQEAgLTY1MCw3ICs2NTksNyBAQCB0ZW1wbGF0 ZSA8dHlwZW5hbWUgVSwgdHlwZW5hbWUgViwgdHlwZW5hbWUgT3ZlcmZsb3dIYW5kbGVyPiBzdGF0 aWMgaW5saW5lIENoZWNrZQogewogICAgIFUgeCA9IDA7CiAgICAgViB5ID0gMDsKLSAgICBib29s IG92ZXJmbG93ZWQgPSBsaHMuc2FmZUdldCh4KSB8fCByaHMuc2FmZUdldCh5KTsKKyAgICBib29s IG92ZXJmbG93ZWQgPSBsaHMuc2FmZUdldCh4KSA9PSBDaGVja2VkU3RhdGU6Okhhc092ZXJmbG93 ZWQgfHwgcmhzLnNhZmVHZXQoeSkgPT0gQ2hlY2tlZFN0YXRlOjpIYXNPdmVyZmxvd2VkOwogICAg IHR5cGVuYW1lIFJlc3VsdDxVLCBWPjo6UmVzdWx0VHlwZSByZXN1bHQgPSAwOwogICAgIG92ZXJm bG93ZWQgfD0gIXNhZmVTdWIoeCwgeSwgcmVzdWx0KTsKICAgICBpZiAob3ZlcmZsb3dlZCkKQEAg LTY2Miw3ICs2NzEsNyBAQCB0ZW1wbGF0ZSA8dHlwZW5hbWUgVSwgdHlwZW5hbWUgViwgdHlwZW5h bWUgT3ZlcmZsb3dIYW5kbGVyPiBzdGF0aWMgaW5saW5lIENoZWNrZQogewogICAgIFUgeCA9IDA7 CiAgICAgViB5ID0gMDsKLSAgICBib29sIG92ZXJmbG93ZWQgPSBsaHMuc2FmZUdldCh4KSB8fCBy aHMuc2FmZUdldCh5KTsKKyAgICBib29sIG92ZXJmbG93ZWQgPSBsaHMuc2FmZUdldCh4KSA9PSBD aGVja2VkU3RhdGU6Okhhc092ZXJmbG93ZWQgfHwgcmhzLnNhZmVHZXQoeSkgPT0gQ2hlY2tlZFN0 YXRlOjpIYXNPdmVyZmxvd2VkOwogICAgIHR5cGVuYW1lIFJlc3VsdDxVLCBWPjo6UmVzdWx0VHlw ZSByZXN1bHQgPSAwOwogICAgIG92ZXJmbG93ZWQgfD0gIXNhZmVNdWx0aXBseSh4LCB5LCByZXN1 bHQpOwogICAgIGlmIChvdmVyZmxvd2VkKQo=