112174 2013-03-12 11:50:45 -0700 XHTML MP 1.1 and 1.2 give errors for entities 2013-03-13 14:50:29 -0700 1 1 1 Unclassified WebKit XML 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 1 lquinn lquinn hausmann jkjiang leoyang webkit.review.bot oldest_to_newest 853678 0 lquinn 2013-03-12 11:50:45 -0700 When an XHTML Mobile Profile 1.1 or 1.2 document contains an XHTML entity such as &copy; or &nbsp;, WebKit's XML parser gives an error. When an XHTML Mobile Profile 1.0 document does the same thing, it works as expected. The XML parser has a list of public doctypes for which it resolves XHTML entities. This list includes XHTML MP 1.0 but not XHTML MP 1.1 or 1.2. We should treat XHTML MP 1.1 and 1.2 the same as 1.0 in this respect. 853685 1 192782 lquinn 2013-03-12 12:04:39 -0700 Created attachment 192782 Patch 854547 2 192782 rwlbuis 2013-03-13 13:16:42 -0700 Comment on attachment 192782 Patch LGTM. 854565 3 192782 webkit.review.bot 2013-03-13 13:27:05 -0700 Comment on attachment 192782 Patch Clearing flags on attachment: 192782 Committed r145744: <http://trac.webkit.org/changeset/145744> 854566 4 webkit.review.bot 2013-03-13 13:27:07 -0700 All reviewed patches have been landed. Closing bug. 854654 5 192782 hausmann 2013-03-13 14:41:29 -0700 Comment on attachment 192782 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192782&action=review > Source/WebCore/xml/parser/XMLDocumentParserQt.cpp:644 > + || (publicId == QLatin1String("-//WAPFORUM//DTD XHTML Mobile 1.0//EN") > + || (publicId == QLatin1String("-//WAPFORUM//DTD XHTML Mobile 1.1//EN") This part broke the Qt build. The line starts with an opening parentheses, the next opening parentheses is the one after QLatin1String but then there's only one closing parentheses. 854661 6 hausmann 2013-03-13 14:46:17 -0700 Prospective fix landed in http://trac.webkit.org/changeset/145756 - hope it works 854671 7 lquinn 2013-03-13 14:50:29 -0700 (In reply to comment #6) > Prospective fix landed in http://trac.webkit.org/changeset/145756 - hope it works Thanks Simon--that change looks fine. I'm sorry for breaking the build. 192782 2013-03-12 12:04:39 -0700 2013-03-13 14:41:29 -0700 Patch bug-112174-20130312145715.patch text/plain 7041 lquinn U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2JkNzRjMGUyNTQxNTky MGYzMjkwNDJiYTA4OWUwZTAxZTdhYWNlYy4uNmJkNjYyNzYyMzQ4OTQ3ZDJiNmQ4MTliOGVlN2Vh ZmViMTYxYmE2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAzLTEyICBMaWFt IFF1aW5uICA8bHF1aW5uQGJsYWNrYmVycnkuY29tPgorCisgICAgICAgIEhhbmRsZSBYSFRNTCBl bnRpdGllcyBpbiBYSFRNTCBNb2JpbGUgUHJvZmlsZSAxLjEgYW5kIDEuMi4gV2UgcHJldmlvdXNs eSBvbmx5IGhhbmRsZWQgdGhlbSBpbiBYSFRNTCBNb2JpbGUgUHJvZmlsZSAxLjAuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIxNzQKKyAgICAgICAg UklNIFBSIDMwOTAzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAg ICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IExlbyBZYW5nLgorCisgICAgICAgIENoZWNrIGZv ciB0aGUgMS4xIGFuZCAxLjIgZG9jdHlwZXMgYWxvbmdzaWRlIHRoZSAxLjAgZG9jdHlwZS4KKwor ICAgICAgICBUZXN0czogZmFzdC9kb2N0eXBlcy94aHRtbC13aXRoLXhodG1sbXAxMS1kb2N0eXBl LnhodG1sCisgICAgICAgICAgICAgICBmYXN0L2RvY3R5cGVzL3hodG1sLXdpdGgteGh0bWxtcDEy LWRvY3R5cGUueGh0bWwKKworICAgICAgICAqIHhtbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJzZXJM aWJ4bWwyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmV4dGVybmFsU3Vic2V0SGFuZGxlcik6Cisg ICAgICAgICogeG1sL3BhcnNlci9YTUxEb2N1bWVudFBhcnNlclF0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlhNTERvY3VtZW50UGFyc2VyOjpwYXJzZUR0ZCk6CisKIDIwMTItMTEtMjQgIExpYW0g UXVpbm4gIDxscXVpbm5AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gUlRTUCBzaG91 bGQgdXNlIHRoZSBzYW1lIE1lZGlhRG9jdW1lbnQgYXMgSFRUUCB2aWRlb3MuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5jcHAK aW5kZXggZTViZDIyM2Q4Yjk4NzE0NGZkM2M3ZjNiNWFiMWYzZDcyOTVlY2NkMC4uYmJhMGMwZWJk YmJiODE2NGEwNGM3YmVkYWZlZjZkY2I3MzQyNTdmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUveG1sL3BhcnNlci9YTUxEb2N1bWVudFBhcnNlckxpYnhtbDIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3htbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJzZXJMaWJ4bWwyLmNwcApAQCAtMTI5MSw3 ICsxMjkxLDkgQEAgc3RhdGljIHZvaWQgZXh0ZXJuYWxTdWJzZXRIYW5kbGVyKHZvaWQqIGNsb3N1 cmUsIGNvbnN0IHhtbENoYXIqLCBjb25zdCB4bWxDaGFyKgogICAgICAgICB8fCAoZXh0SWQgPT0g Ii0vL1czQy8vRFREIFhIVE1MIEJhc2ljIDEuMC8vRU4iKQogICAgICAgICB8fCAoZXh0SWQgPT0g Ii0vL1czQy8vRFREIFhIVE1MIDEuMSBwbHVzIE1hdGhNTCAyLjAvL0VOIikKICAgICAgICAgfHwg KGV4dElkID09ICItLy9XM0MvL0RURCBYSFRNTCAxLjEgcGx1cyBNYXRoTUwgMi4wIHBsdXMgU1ZH IDEuMS8vRU4iKQotICAgICAgICB8fCAoZXh0SWQgPT0gIi0vL1dBUEZPUlVNLy9EVEQgWEhUTUwg TW9iaWxlIDEuMC8vRU4iKSkKKyAgICAgICAgfHwgKGV4dElkID09ICItLy9XQVBGT1JVTS8vRFRE IFhIVE1MIE1vYmlsZSAxLjAvL0VOIikKKyAgICAgICAgfHwgKGV4dElkID09ICItLy9XQVBGT1JV TS8vRFREIFhIVE1MIE1vYmlsZSAxLjEvL0VOIikKKyAgICAgICAgfHwgKGV4dElkID09ICItLy9X QVBGT1JVTS8vRFREIFhIVE1MIE1vYmlsZSAxLjIvL0VOIikpCiAgICAgICAgIGdldFBhcnNlcihj bG9zdXJlKS0+c2V0SXNYSFRNTERvY3VtZW50KHRydWUpOyAvLyBjb250cm9scyBpZiB3ZSByZXBs YWNlIGVudGl0aWVzIG9yIG5vdC4KIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUveG1s L3BhcnNlci9YTUxEb2N1bWVudFBhcnNlclF0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3htbC9wYXJz ZXIvWE1MRG9jdW1lbnRQYXJzZXJRdC5jcHAKaW5kZXggYmY4Y2ZiOTNmODRiNmM3NWFlZTU5ODM2 NGRhMzYzNjFhMThjNTI2YS4uZmRkNjY4MzhlNzY4MDg4MTM0NGEzZGRjMDBjZjAyNWQxZWI4YmNh ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUveG1sL3BhcnNlci9YTUxEb2N1bWVudFBhcnNl clF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL1hNTERvY3VtZW50UGFyc2Vy UXQuY3BwCkBAIC02NDAsNyArNjQwLDkgQEAgdm9pZCBYTUxEb2N1bWVudFBhcnNlcjo6cGFyc2VE dGQoKQogICAgICAgICB8fCAocHVibGljSWQgPT0gUUxhdGluMVN0cmluZygiLS8vVzNDLy9EVEQg WEhUTUwgQmFzaWMgMS4wLy9FTiIpKQogICAgICAgICB8fCAocHVibGljSWQgPT0gUUxhdGluMVN0 cmluZygiLS8vVzNDLy9EVEQgWEhUTUwgMS4xIHBsdXMgTWF0aE1MIDIuMC8vRU4iKSkKICAgICAg ICAgfHwgKHB1YmxpY0lkID09IFFMYXRpbjFTdHJpbmcoIi0vL1czQy8vRFREIFhIVE1MIDEuMSBw bHVzIE1hdGhNTCAyLjAgcGx1cyBTVkcgMS4xLy9FTiIpKQotICAgICAgICB8fCAocHVibGljSWQg PT0gUUxhdGluMVN0cmluZygiLS8vV0FQRk9SVU0vL0RURCBYSFRNTCBNb2JpbGUgMS4wLy9FTiIp KQorICAgICAgICB8fCAocHVibGljSWQgPT0gUUxhdGluMVN0cmluZygiLS8vV0FQRk9SVU0vL0RU RCBYSFRNTCBNb2JpbGUgMS4wLy9FTiIpCisgICAgICAgIHx8IChwdWJsaWNJZCA9PSBRTGF0aW4x U3RyaW5nKCItLy9XQVBGT1JVTS8vRFREIFhIVE1MIE1vYmlsZSAxLjEvL0VOIikKKyAgICAgICAg fHwgKHB1YmxpY0lkID09IFFMYXRpbjFTdHJpbmcoIi0vL1dBUEZPUlVNLy9EVEQgWEhUTUwgTW9i aWxlIDEuMi8vRU4iKSkKICAgICAgICApCiAgICAgICAgIHNldElzWEhUTUxEb2N1bWVudCh0cnVl KTsgLy8gY29udHJvbHMgaWYgd2UgcmVwbGFjZSBlbnRpdGllcyBvciBub3QuCiAgICAgaWYgKCFt X3BhcnNpbmdGcmFnbWVudCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5ZjM0ZTZmZmEwOWEyOTIzYTg1YTgwZmJjMjNjMzcy MDU3OTg0NGY0Li4zZTZiMzNhZDljZjcxZGVhNWFjNTIzM2FlNDdhMjhhYWVhYjVjZjM3IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDMtMTIgIExpYW0gUXVpbm4gIDxscXVpbm5AYmxhY2ti ZXJyeS5jb20+CisKKyAgICAgICAgTmV3IHRlc3RzIHRvIGNoZWNrIHRoYXQgWEhUTUwgZW50aXRp ZXMgYXJlIHN1cHBvcnRlZCBpbiBYSFRNTCBNb2JpbGUgUHJvZmlsZSAxLjEgYW5kIDEuMi4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjE3NAorICAg ICAgICBSSU0gUFIgMzA5MDM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgTGVvIFlhbmcuCisKKyAgICAgICAgKiBm YXN0L2RvY3R5cGVzL3hodG1sLXdpdGgteGh0bWxtcDExLWRvY3R5cGUtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvY3R5cGVzL3hodG1sLXdpdGgteGh0bWxtcDExLWRvY3R5 cGUueGh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9jdHlwZXMveGh0bWwtd2l0aC14aHRt bG1wMTItZG9jdHlwZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9jdHlw ZXMveGh0bWwtd2l0aC14aHRtbG1wMTItZG9jdHlwZS54aHRtbDogQWRkZWQuCisKIDIwMTMtMDMt MTIgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQgR1RLIGdhcmRlbmluZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9jdHlw ZXMveGh0bWwtd2l0aC14aHRtbG1wMTEtZG9jdHlwZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9mYXN0L2RvY3R5cGVzL3hodG1sLXdpdGgteGh0bWxtcDExLWRvY3R5cGUtZXhwZWN0ZWQudHh0 Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLmY2M2Q3NWMwMzg0NDY2YTUxODBhODdlMzJlZmM1MzM2NDA4YzMxMjEKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvY3R5cGVzL3hodG1sLXdpdGgteGh0 bWxtcDExLWRvY3R5cGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorVGVzdCB0aGF0IFhI VE1MIGVudGl0aWVzIGFyZSByZWNvZ25pemVkIGluIGRvY3VtZW50cyB3aXRoIHhodG1sLW1vYmls ZTExIERURC4KKworU1VDQ0VTUyAodW5sZXNzIHRoZXJlIGlzIGNsZWFyIHNpZ24gb2YgZmFpbHVy ZSBuZWFyYnksIGxpa2UgYSBiaWcgcmVkIGVycm9yIGJveCkuwqAKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvZG9jdHlwZXMveGh0bWwtd2l0aC14aHRtbG1wMTEtZG9jdHlwZS54aHRtbCBi L0xheW91dFRlc3RzL2Zhc3QvZG9jdHlwZXMveGh0bWwtd2l0aC14aHRtbG1wMTEtZG9jdHlwZS54 aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi5iMGIyMTAzZjZmNzU2OTZjNDlkMDk3MWMzZGYzNDdjMDY3NDM0ZmIy Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb2N0eXBlcy94aHRtbC13aXRo LXhodG1sbXAxMS1kb2N0eXBlLnhodG1sCkBAIC0wLDAgKzEsMTcgQEAKKzw/eG1sIHZlcnNpb249 IjEuMCIgZW5jb2Rpbmc9IlVURi04Ij8+Cis8IURPQ1RZUEUgaHRtbCBQVUJMSUMgIi0vL1dBUEZP UlVNLy9EVEQgWEhUTUwgTW9iaWxlIDEuMS8vRU4iCisiaHR0cDovL3d3dy5vcGVubW9iaWxlYWxs aWFuY2Uub3JnL3RlY2gvRFREL3hodG1sLW1vYmlsZTExLmR0ZCI+Cis8aHRtbCB4bWxucz0iaHR0 cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCI+Cis8aGVhZD4KKzx0aXRsZS8+Cis8L2hlYWQ+Cis8 Ym9keT4KKzxwPlRlc3QgdGhhdCBYSFRNTCBlbnRpdGllcyBhcmUgcmVjb2duaXplZCBpbiBkb2N1 bWVudHMgd2l0aCB4aHRtbC1tb2JpbGUxMSBEVEQuPC9wPgorPHNjcmlwdD4KK2lmICh3aW5kb3cu dGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKzwvc2NyaXB0PgorPHAg c3R5bGU9ImRpc3BsYXk6bm9uZSI+RkFJTCAtIG5vdCB0cmVhdGVkIGFzIFhIVE1MLjwvcD4KKzxw PlNVQ0NFU1MgKHVubGVzcyB0aGVyZSBpcyBjbGVhciBzaWduIG9mIGZhaWx1cmUgbmVhcmJ5LCBs aWtlIGEgYmlnIHJlZCBlcnJvciBib3gpLiZuYnNwOzwvcD4KKzwvYm9keT4KKzwvaHRtbD4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9jdHlwZXMveGh0bWwtd2l0aC14aHRtbG1wMTIt ZG9jdHlwZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvY3R5cGVzL3hodG1sLXdp dGgteGh0bWxtcDEyLWRvY3R5cGUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjhjZDhhM2Y2YWE2 ZjEyYzEzMTBhZjcxNDdlNWJjZGQ5MDlmMWVmMTYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2RvY3R5cGVzL3hodG1sLXdpdGgteGh0bWxtcDEyLWRvY3R5cGUtZXhwZWN0ZWQu dHh0CkBAIC0wLDAgKzEsMyBAQAorVGVzdCB0aGF0IFhIVE1MIGVudGl0aWVzIGFyZSByZWNvZ25p emVkIGluIGRvY3VtZW50cyB3aXRoIHhodG1sLW1vYmlsZTEyIERURC4KKworU1VDQ0VTUyAodW5s ZXNzIHRoZXJlIGlzIGNsZWFyIHNpZ24gb2YgZmFpbHVyZSBuZWFyYnksIGxpa2UgYSBiaWcgcmVk IGVycm9yIGJveCkuwqAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9jdHlwZXMveGh0 bWwtd2l0aC14aHRtbG1wMTItZG9jdHlwZS54aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9jdHlw ZXMveGh0bWwtd2l0aC14aHRtbG1wMTItZG9jdHlwZS54aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mNzVkNjAz ZGY4MzU5ZDVkZWE1MjA4ZTE3YjNiNWRmZTBlNzZjMzllCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9kb2N0eXBlcy94aHRtbC13aXRoLXhodG1sbXAxMi1kb2N0eXBlLnhodG1s CkBAIC0wLDAgKzEsMTcgQEAKKzw/eG1sIHZlcnNpb249IjEuMCIgZW5jb2Rpbmc9IlVURi04Ij8+ Cis8IURPQ1RZUEUgaHRtbCBQVUJMSUMgIi0vL1dBUEZPUlVNLy9EVEQgWEhUTUwgTW9iaWxlIDEu Mi8vRU4iCisiaHR0cDovL3d3dy5vcGVubW9iaWxlYWxsaWFuY2Uub3JnL3RlY2gvRFREL3hodG1s LW1vYmlsZTEyLmR0ZCI+Cis8aHRtbCB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRt bCI+Cis8aGVhZD4KKzx0aXRsZS8+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPlRlc3QgdGhhdCBYSFRN TCBlbnRpdGllcyBhcmUgcmVjb2duaXplZCBpbiBkb2N1bWVudHMgd2l0aCB4aHRtbC1tb2JpbGUx MiBEVEQuPC9wPgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVu bmVyLmR1bXBBc1RleHQoKTsKKzwvc2NyaXB0PgorPHAgc3R5bGU9ImRpc3BsYXk6bm9uZSI+RkFJ TCAtIG5vdCB0cmVhdGVkIGFzIFhIVE1MLjwvcD4KKzxwPlNVQ0NFU1MgKHVubGVzcyB0aGVyZSBp cyBjbGVhciBzaWduIG9mIGZhaWx1cmUgbmVhcmJ5LCBsaWtlIGEgYmlnIHJlZCBlcnJvciBib3gp LiZuYnNwOzwvcD4KKzwvYm9keT4KKzwvaHRtbD4K