112169 2013-03-12 11:07:05 -0700 [GTK] Enforce the C++11 standard when compiling WebKit2 2013-03-18 01:01:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan a.renevier cgarcia gustavo mrobinson webkit.review.bot oldest_to_newest 853631 0 zan 2013-03-12 11:07:05 -0700 [GTK] Enforce the C++11 standard when compiling WebKit2 853642 1 192772 zan 2013-03-12 11:15:35 -0700 Created attachment 192772 Patch 853647 2 webkit.review.bot 2013-03-12 11:20:48 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 853701 3 192772 gustavo 2013-03-12 12:36:15 -0700 Comment on attachment 192772 Patch What does this gain us? Is the mac wk2 already built like this? 853720 4 zan 2013-03-12 12:57:49 -0700 Yes, mac-wk2 already builds WebKit2 in such way, though they are using libc++ as the standard library and enforce the gnu++0x standard. I don't think enforcing c++11 instead of gnu++0x is problematic, at least not at the moment. I also plan to propose this patch for merging into webkit-2.0 for reasons I've detailed here: https://bugs.webkit.org/show_bug.cgi?id=109932#c15 856293 5 192772 gustavo 2013-03-15 14:38:51 -0700 Comment on attachment 192772 Patch OK, then =) 856326 6 zan 2013-03-15 15:13:46 -0700 \o/ Thanks! 856329 7 192772 zan 2013-03-15 15:15:03 -0700 Comment on attachment 192772 Patch Clearing flags on attachment: 192772 Committed r145951: <http://trac.webkit.org/changeset/145951> 856330 8 zan 2013-03-15 15:15:08 -0700 All reviewed patches have been landed. Closing bug. 856886 9 zan 2013-03-18 01:01:50 -0700 *** Bug 112034 has been marked as a duplicate of this bug. *** 192772 2013-03-12 11:15:35 -0700 2013-03-15 15:15:03 -0700 Patch bug-112169-20130312191134.patch text/plain 5695 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2MzZWJiMWU0ZTIzNmVi ZjA5MzVmNmI3Yzg4ZTFhODNkM2NlMTQ3Ni4uZTc5Y2NhN2MzMzVlOGI4MTgzYWQ0MWQ0YjEyOTUw NGExYzA2ZDk2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEzLTAzLTEyICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBFbmZvcmNl IHRoZSBDKysxMSBzdGFuZGFyZCB3aGVuIGNvbXBpbGluZyBXZWJLaXQyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIxNjkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaXRoIGEgbGltaXRlZCBzZXQgb2Yg c3VwcG9ydGVkIGNvbXBpbGVycyB0aGUgV2ViS2l0MiBzb3VyY2UgY29kZSBjYW4gbm93CisgICAg ICAgIGJlIGJ1aWx0IHdpdGggdGhlIEMrKzExIGxhbmd1YWdlIHN0YW5kYXJkIGVuZm9yY2VkLgor CisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0V2ViQ29udGV4dC5jcHA6CisgICAgICAgIChpbmplY3RlZEJ1bmRsZURpcmVjdG9yeSk6 IEFkanVzdCB0aGUgc3RyaW5nIGxpdGVyYWxzIGNvbmNhdGVuYXRpb24sIG1vdmluZyBhd2F5IGZy b20gZW1wdHkgc3RyaW5ncworICAgICAgICAod2hpY2ggQysrMTEgcmVmdXNlcyB0byBoYW5kbGUg YXMgY29uY2F0ZW5hdGlvbiBvcGVyYXRvcnMpIGFuZCB1c2luZyB3aGl0ZXNwYWNlIGluc3RlYWQu CisgICAgICAgICogVUlQcm9jZXNzL0luc3BlY3RvclNlcnZlci9ndGsvV2ViSW5zcGVjdG9yU2Vy dmVyR3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yU2VydmVyOjpwbGF0Zm9y bVJlc291cmNlRm9yUGF0aCk6IERpdHRvLgorICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvV2ViSW5z cGVjdG9yUHJveHlHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjppbnNwZWN0b3JGaWxlc0Jhc2VQ YXRoKTogRGl0dG8uCisKKzIwMTMtMDMtMTIgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2Fs aWEuY29tPgorCiAgICAgICAgIFtHVEtdIFNldCB1cCB0aGUgbGliUGxhdGZvcm1HdGsubGEgbGli cmFyeQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEx NzM4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0dOVW1ha2VmaWxlLmFtIGIvU291cmNl L1dlYktpdDIvR05VbWFrZWZpbGUuYW0KaW5kZXggMDQ3MDFjOWFjZTg2MWFhOTJhZDUyOTFhNTkw YTlkMTM1YzM3YzJhYS4uMTNlZWI0NTg1MDllZTAxYmZjZjU2YTQ0MjM3MGExYWRkOGExNmE2YSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvR05VbWFrZWZpbGUuYW0KKysrIGIvU291cmNlL1dl YktpdDIvR05VbWFrZWZpbGUuYW0KQEAgLTM3LDYgKzM3LDcgQEAgbGlid2Via2l0Mmd0a19AV0VC S0lUR1RLX0FQSV9NQUpPUl9WRVJTSU9OQF9AV0VCS0lUR1RLX0FQSV9NSU5PUl9WRVJTSU9OQF9s YV9TT1UKIGxpYndlYmtpdDJndGtfQFdFQktJVEdUS19BUElfTUFKT1JfVkVSU0lPTkBfQFdFQktJ VEdUS19BUElfTUlOT1JfVkVSU0lPTkBfbGFfQ1BQRkxBR1MgPSBcCiAJLWZuby1zdHJpY3QtYWxp YXNpbmcgXAogCS1EUEFDS0FHRV9MT0NBTEVfRElSPVwiJChsb2NhbGVkaXIpXCIgXAorCS1zdGQ9 YysrMTEgXAogCSQoZ2xvYmFsX2NwcGZsYWdzKSBcCiAJLWluY2x1ZGUgJChzcmNkaXIpL1NvdXJj ZS9XZWJLaXQyL1dlYktpdDJQcmVmaXguaCBcCiAJLUkkKHNyY2RpcikvU291cmNlL1dlYktpdC9n dGsgXApAQCAtNDI4LDYgKzQyOSw3IEBAIFByb2dyYW1zX1dlYktpdFdlYlByb2Nlc3NfQ1BQRkxB R1MgPSBcCiAJLUkkKHRvcF9idWlsZGRpcikvRGVyaXZlZFNvdXJjZXMvV2ViS2l0MiBcCiAJLUkk KHRvcF9idWlsZGRpcikvRGVyaXZlZFNvdXJjZXMvV2ViS2l0Mi9pbmNsdWRlIFwKIAktSSQodG9w X2J1aWxkZGlyKS9EZXJpdmVkU291cmNlcy9XZWJLaXQyL2luY2x1ZGUvV2ViQ29yZSBcCisJLXN0 ZD1jKysxMSBcCiAJJChnbG9iYWxfY3BwZmxhZ3MpIFwKIAkkKGphdmFzY3JpcHRjb3JlX2NwcGZs YWdzKQogCkBAIC01NTUsNiArNTU3LDcgQEAgbGlid2Via2l0Mmd0a2luamVjdGVkYnVuZGxlX2xh X0NQUEZMQUdTID0gXAogCS1JJChzcmNkaXIpL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5q ZWN0ZWRCdW5kbGUvQVBJL2MgXAogCS1JJCh0b3BfYnVpbGRkaXIpL0Rlcml2ZWRTb3VyY2VzL0lu amVjdGVkQnVuZGxlIFwKIAktSSQodG9wX2J1aWxkZGlyKS9EZXJpdmVkU291cmNlcy9XZWJLaXQy L2luY2x1ZGUgXAorCS1zdGQ9YysrMTEgXAogCSQoZ2xvYmFsX2NwcGZsYWdzKSBcCiAJJChqYXZh c2NyaXB0Y29yZV9jcHBmbGFncykgXAogCSQoR0xJQl9DRkxBR1MpCkBAIC01OTIsNiArNTk1LDcg QEAgUHJvZ3JhbXNfV2ViS2l0UGx1Z2luUHJvY2Vzc19DUFBGTEFHUyA9IFwKIAktREdUS19BUElf VkVSU0lPTl8yPTEgXAogCS1ERU5BQkxFX1BMVUdJTl9QUk9DRVNTPTEgXAogCS1ETElCRVhFQ0RJ Uj1cIiIkKGxpYmV4ZWNkaXIpIlwiIFwKKwktc3RkPWMrKzExIFwKIAkkKGdsb2JhbF9jcHBmbGFn cykgXAogCSQocGxhdGZvcm1ndGtfY3BwZmxhZ3MpIFwKIAkkKHdlYmNvcmVfY3BwZmxhZ3MpIFwK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNv bnRleHQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29u dGV4dC5jcHAKaW5kZXggMGZkZDQ3YzRjOTczZGZhZGM5ZTllODI2ZmRjMDFiYjcyMzM2ZjBjZi4u ZWQyM2NkMDY3NTg5Mzg2ZGIyYTY0MzIzYTAzZDViOGM3YjY0ODA4NSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5jcHAKQEAg LTE3NSw3ICsxNzUsOCBAQCBzdGF0aWMgQ1N0cmluZyBpbmplY3RlZEJ1bmRsZURpcmVjdG9yeSgp CiAgICAgaWYgKGNvbnN0IGNoYXIqIGJ1bmRsZURpcmVjdG9yeSA9IGdfZ2V0ZW52KCJXRUJLSVRf SU5KRUNURURfQlVORExFX1BBVEgiKSkKICAgICAgICAgcmV0dXJuIGJ1bmRsZURpcmVjdG9yeTsK IAotICAgIHN0YXRpYyBjb25zdCBjaGFyKiBpbmplY3RlZEJ1bmRsZVBhdGggPSBMSUJESVIiIkdf RElSX1NFUEFSQVRPUl9TIndlYmtpdDJndGstIldFQktJVEdUS19BUElfVkVSU0lPTl9TVFJJTkci IkdfRElSX1NFUEFSQVRPUl9TImluamVjdGVkLWJ1bmRsZSJHX0RJUl9TRVBBUkFUT1JfUzsKKyAg ICBzdGF0aWMgY29uc3QgY2hhciogaW5qZWN0ZWRCdW5kbGVQYXRoID0gTElCRElSIEdfRElSX1NF UEFSQVRPUl9TICJ3ZWJraXQyZ3RrLSIgV0VCS0lUR1RLX0FQSV9WRVJTSU9OX1NUUklORworICAg ICAgICBHX0RJUl9TRVBBUkFUT1JfUyAiaW5qZWN0ZWQtYnVuZGxlIiBHX0RJUl9TRVBBUkFUT1Jf UzsKICAgICByZXR1cm4gaW5qZWN0ZWRCdW5kbGVQYXRoOwogfQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvSW5zcGVjdG9yU2VydmVyL2d0ay9XZWJJbnNwZWN0b3JTZXJ2 ZXJHdGsuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNlcnZlci9ndGsv V2ViSW5zcGVjdG9yU2VydmVyR3RrLmNwcAppbmRleCA3NzYyZGU5MWY4ZDdkM2I4ZTE1MzU1NTcz MWQ5NWVmNGMzODc0YWFmLi4wZjVhZDJlMGUwNzQ5YjJmMDljYjBiYzZlYTFhNjAyNDcxZWIyZjY1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvSW5zcGVjdG9yU2VydmVyL2d0 ay9XZWJJbnNwZWN0b3JTZXJ2ZXJHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9JbnNwZWN0b3JTZXJ2ZXIvZ3RrL1dlYkluc3BlY3RvclNlcnZlckd0ay5jcHAKQEAgLTUzLDcg KzUzLDcgQEAgYm9vbCBXZWJJbnNwZWN0b3JTZXJ2ZXI6OnBsYXRmb3JtUmVzb3VyY2VGb3JQYXRo KGNvbnN0IFN0cmluZyYgcGF0aCwgVmVjdG9yPGNoYXIKICAgICAgICAgcmV0dXJuIGZhbHNlOwog CiAgICAgR1JlZlB0cjxHRmlsZT4gZmlsZSA9IGFkb3B0R1JlZihnX2ZpbGVfbmV3X2Zvcl9wYXRo KGxvY2FsUGF0aC5kYXRhKCkpKTsKLSAgICBHUmVmUHRyPEdGaWxlSW5mbz4gZmlsZUluZm8gPSBh ZG9wdEdSZWYoZ19maWxlX3F1ZXJ5X2luZm8oZmlsZS5nZXQoKSwgR19GSUxFX0FUVFJJQlVURV9T VEFOREFSRF9TSVpFIiwiR19GSUxFX0FUVFJJQlVURV9TVEFOREFSRF9GQVNUX0NPTlRFTlRfVFlQ RSwgR19GSUxFX1FVRVJZX0lORk9fTk9ORSwgMCwgMCkpOworICAgIEdSZWZQdHI8R0ZpbGVJbmZv PiBmaWxlSW5mbyA9IGFkb3B0R1JlZihnX2ZpbGVfcXVlcnlfaW5mbyhmaWxlLmdldCgpLCBHX0ZJ TEVfQVRUUklCVVRFX1NUQU5EQVJEX1NJWkUgIiwiIEdfRklMRV9BVFRSSUJVVEVfU1RBTkRBUkRf RkFTVF9DT05URU5UX1RZUEUsIEdfRklMRV9RVUVSWV9JTkZPX05PTkUsIDAsIDApKTsKICAgICBp ZiAoIWZpbGVJbmZvKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJJbnNwZWN0b3JQcm94eUd0ay5jcHAKaW5kZXggZWJh M2NhYjQyZmU4YTEwNWU2NmM5NjdlYWM4ZTI0ZmM1Mzc1Zjg0Yi4uZWFiZDJkNmI0MTk1OTBhZDk4 ZmUzMzlhZGM3NzNkNmVjZjIzZjZhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL2d0ay9XZWJJbnNwZWN0b3JQcm94eUd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2d0ay9XZWJJbnNwZWN0b3JQcm94eUd0ay5jcHAKQEAgLTQ5LDkgKzQ5LDggQEAgc3Rh dGljIGNvbnN0IGNoYXIqIGluc3BlY3RvckZpbGVzQmFzZVBhdGgoKQogICAgIGlmIChlbnZpcm9u bWVudFBhdGggJiYgZ19maWxlX3Rlc3QoZW52aXJvbm1lbnRQYXRoLCBHX0ZJTEVfVEVTVF9JU19E SVIpKQogICAgICAgICByZXR1cm4gZW52aXJvbm1lbnRQYXRoOwogCi0gICAgc3RhdGljIGNvbnN0 IGNoYXIqIGluc3BlY3RvckZpbGVzUGF0aCA9IERBVEFfRElSIiJHX0RJUl9TRVBBUkFUT1JfUwot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAid2Via2l0Z3RrLSJX RUJLSVRHVEtfQVBJX1ZFUlNJT05fU1RSSU5HIiJHX0RJUl9TRVBBUkFUT1JfUwotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAid2ViaW5zcGVjdG9yIkdfRElSX1NF UEFSQVRPUl9TOworICAgIHN0YXRpYyBjb25zdCBjaGFyKiBpbnNwZWN0b3JGaWxlc1BhdGggPSBE QVRBX0RJUiBHX0RJUl9TRVBBUkFUT1JfUyAid2Via2l0Z3RrLSIgV0VCS0lUR1RLX0FQSV9WRVJT SU9OX1NUUklORworICAgICAgICBHX0RJUl9TRVBBUkFUT1JfUyAid2ViaW5zcGVjdG9yIiBHX0RJ Ul9TRVBBUkFUT1JfUzsKICAgICByZXR1cm4gaW5zcGVjdG9yRmlsZXNQYXRoOwogfQogCg==