112153 2013-03-12 07:47:07 -0700 Web Inspector: [CodeMirror] Handle "enter" key in {|} situation 2013-03-13 09:26:03 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 lushnikov lushnikov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 853450 0 lushnikov 2013-03-12 07:47:07 -0700 Step-by-step: 1. Type following: function foo(a, b){|} 2. Hit enter Expected: function foo(a, b){ | } Actual: function foo(a, b){ |} 853452 1 192735 lushnikov 2013-03-12 07:49:56 -0700 Created attachment 192735 Patch 854208 2 192735 vsevik 2013-03-13 05:09:45 -0700 Comment on attachment 192735 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192735&action=review > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:493 > + if (line.substr(cursor.ch - 1, 2) === "{}") { You should if the selection range is empty here. 854338 3 192931 lushnikov 2013-03-13 09:01:21 -0700 Created attachment 192931 Patch 854355 4 192931 webkit.review.bot 2013-03-13 09:25:59 -0700 Comment on attachment 192931 Patch Clearing flags on attachment: 192931 Committed r145724: <http://trac.webkit.org/changeset/145724> 854357 5 webkit.review.bot 2013-03-13 09:26:03 -0700 All reviewed patches have been landed. Closing bug. 192735 2013-03-12 07:49:56 -0700 2013-03-13 09:01:17 -0700 Patch bug-112153-20130312184553.patch text/plain 2595 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGU3OWYxNDk2NjFmYTVi MWM4MzhhMmUyOTUwYTNlOTYzMzQ4NjA3Ny4uMDc2NjFjNmQ4MGJhMTVlODdhMDA2ZThkYjM3NTJk NGNhNzMxNjU5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTEyICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBbQ29kZU1pcnJvcl0gSGFuZGxlICJlbnRlciIga2V5IGluIHt8fSBzaXR1YXRpb24K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjE1Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGtl eW1hcCB0byBoYW5kbGUgIkVudGVyIiBrZXkgYW5kIG92ZXJyaWRlIGl0IGluIGNhc2Ugb2Yge3x9 CisgICAgICAgIHNpdHVhdGlvbi4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5Db2RlTWlycm9yVGV4dEVkaXRvci5CbG9ja0luZGVudENvbnRyb2xsZXIpOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yLkJsb2NrSW5kZW50Q29udHJvbGxlci5w cm90b3R5cGUuRW50ZXIpOgorCiAyMDEzLTAzLTEyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZp ZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTQ1 NDk0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db2Rl TWlycm9yVGV4dEVkaXRvci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv Q29kZU1pcnJvclRleHRFZGl0b3IuanMKaW5kZXggYjUxNGZiNDhjMGYxYzllNTM1ODE3NGIyNDRm YjQ4N2Q0MjdhMGM0OS4uNjdlMzc2YmQyMmYwZDVjOTNiM2YxNzU4ZWYyYjg4NGI3NjQwYzdiOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db2RlTWlycm9y VGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Nv ZGVNaXJyb3JUZXh0RWRpdG9yLmpzCkBAIC02NSw2ICs2NSw3IEBAIFdlYkluc3BlY3Rvci5Db2Rl TWlycm9yVGV4dEVkaXRvciA9IGZ1bmN0aW9uKHVybCwgZGVsZWdhdGUpCiAgICAgfQogCiAgICAg dGhpcy5fdG9rZW5IaWdobGlnaHRlciA9IG5ldyBXZWJJbnNwZWN0b3IuQ29kZU1pcnJvclRleHRF ZGl0b3IuVG9rZW5IaWdobGlnaHRlcih0aGlzLl9jb2RlTWlycm9yKTsKKyAgICB0aGlzLl9ibG9j a0luZGVudENvbnRyb2xsZXIgPSBuZXcgV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9y LkJsb2NrSW5kZW50Q29udHJvbGxlcih0aGlzLl9jb2RlTWlycm9yKTsKIAogICAgIHRoaXMuX2Nv ZGVNaXJyb3Iub24oImNoYW5nZSIsIHRoaXMuX2NoYW5nZS5iaW5kKHRoaXMpKTsKICAgICB0aGlz Ll9jb2RlTWlycm9yLm9uKCJndXR0ZXJDbGljayIsIHRoaXMuX2d1dHRlckNsaWNrLmJpbmQodGhp cykpOwpAQCAtNDc2LDMgKzQ3NywyNCBAQCBXZWJJbnNwZWN0b3IuQ29kZU1pcnJvclRleHRFZGl0 b3IuVG9rZW5IaWdobGlnaHRlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX2NvZGVNaXJy b3IuYWRkT3ZlcmxheSh0aGlzLl9vdmVybGF5TW9kZSk7CiAgICAgfQogfQorCitXZWJJbnNwZWN0 b3IuQ29kZU1pcnJvclRleHRFZGl0b3IuQmxvY2tJbmRlbnRDb250cm9sbGVyID0gZnVuY3Rpb24o Y29kZU1pcnJvcikKK3sKKyAgICBjb2RlTWlycm9yLmFkZEtleU1hcCh0aGlzKTsKK30KKworV2Vi SW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yLkJsb2NrSW5kZW50Q29udHJvbGxlci5wcm90 b3R5cGUgPSB7CisgICAgbmFtZTogImJsb2NrSW5kZW50S2V5bWFwIiwKKworICAgIEVudGVyOiBm dW5jdGlvbihjb2RlTWlycm9yKQorICAgIHsKKyAgICAgICAgdmFyIGN1cnNvciA9IGNvZGVNaXJy b3IuZ2V0Q3Vyc29yKCk7CisgICAgICAgIHZhciBsaW5lID0gY29kZU1pcnJvci5nZXRMaW5lKGN1 cnNvci5saW5lKTsKKyAgICAgICAgaWYgKGxpbmUuc3Vic3RyKGN1cnNvci5jaCAtIDEsIDIpID09 PSAie30iKSB7CisgICAgICAgICAgICBjb2RlTWlycm9yLmV4ZWNDb21tYW5kKCJuZXdsaW5lQW5k SW5kZW50Iik7CisgICAgICAgICAgICBjb2RlTWlycm9yLnNldEN1cnNvcihjdXJzb3IpOworICAg ICAgICAgICAgY29kZU1pcnJvci5leGVjQ29tbWFuZCgibmV3bGluZUFuZEluZGVudCIpOworICAg ICAgICB9IGVsc2UKKyAgICAgICAgICAgIHJldHVybiBDb2RlTWlycm9yLlBhc3M7CisgICAgfQor fQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK 192931 2013-03-13 09:01:21 -0700 2013-03-13 09:25:59 -0700 Patch bug-112153-20130313195718.patch text/plain 2677 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGU3OWYxNDk2NjFmYTVi MWM4MzhhMmUyOTUwYTNlOTYzMzQ4NjA3Ny4uMDc2NjFjNmQ4MGJhMTVlODdhMDA2ZThkYjM3NTJk NGNhNzMxNjU5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTEyICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBbQ29kZU1pcnJvcl0gSGFuZGxlICJlbnRlciIga2V5IGluIHt8fSBzaXR1YXRpb24K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjE1Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGtl eW1hcCB0byBoYW5kbGUgIkVudGVyIiBrZXkgYW5kIG92ZXJyaWRlIGl0IGluIGNhc2Ugb2Yge3x9 CisgICAgICAgIHNpdHVhdGlvbi4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5Db2RlTWlycm9yVGV4dEVkaXRvci5CbG9ja0luZGVudENvbnRyb2xsZXIpOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yLkJsb2NrSW5kZW50Q29udHJvbGxlci5w cm90b3R5cGUuRW50ZXIpOgorCiAyMDEzLTAzLTEyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZp ZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTQ1 NDk0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db2Rl TWlycm9yVGV4dEVkaXRvci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv Q29kZU1pcnJvclRleHRFZGl0b3IuanMKaW5kZXggYjUxNGZiNDhjMGYxYzllNTM1ODE3NGIyNDRm YjQ4N2Q0MjdhMGM0OS4uYjY4NWNjMDAxNzAyODI2NTVjNzZjZjBlNGE0OGIyMjBiMzZmN2Q1ZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db2RlTWlycm9y VGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Nv ZGVNaXJyb3JUZXh0RWRpdG9yLmpzCkBAIC02NSw2ICs2NSw3IEBAIFdlYkluc3BlY3Rvci5Db2Rl TWlycm9yVGV4dEVkaXRvciA9IGZ1bmN0aW9uKHVybCwgZGVsZWdhdGUpCiAgICAgfQogCiAgICAg dGhpcy5fdG9rZW5IaWdobGlnaHRlciA9IG5ldyBXZWJJbnNwZWN0b3IuQ29kZU1pcnJvclRleHRF ZGl0b3IuVG9rZW5IaWdobGlnaHRlcih0aGlzLl9jb2RlTWlycm9yKTsKKyAgICB0aGlzLl9ibG9j a0luZGVudENvbnRyb2xsZXIgPSBuZXcgV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9y LkJsb2NrSW5kZW50Q29udHJvbGxlcih0aGlzLl9jb2RlTWlycm9yKTsKIAogICAgIHRoaXMuX2Nv ZGVNaXJyb3Iub24oImNoYW5nZSIsIHRoaXMuX2NoYW5nZS5iaW5kKHRoaXMpKTsKICAgICB0aGlz Ll9jb2RlTWlycm9yLm9uKCJndXR0ZXJDbGljayIsIHRoaXMuX2d1dHRlckNsaWNrLmJpbmQodGhp cykpOwpAQCAtNDc2LDMgKzQ3NywyNiBAQCBXZWJJbnNwZWN0b3IuQ29kZU1pcnJvclRleHRFZGl0 b3IuVG9rZW5IaWdobGlnaHRlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX2NvZGVNaXJy b3IuYWRkT3ZlcmxheSh0aGlzLl9vdmVybGF5TW9kZSk7CiAgICAgfQogfQorCitXZWJJbnNwZWN0 b3IuQ29kZU1pcnJvclRleHRFZGl0b3IuQmxvY2tJbmRlbnRDb250cm9sbGVyID0gZnVuY3Rpb24o Y29kZU1pcnJvcikKK3sKKyAgICBjb2RlTWlycm9yLmFkZEtleU1hcCh0aGlzKTsKK30KKworV2Vi SW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yLkJsb2NrSW5kZW50Q29udHJvbGxlci5wcm90 b3R5cGUgPSB7CisgICAgbmFtZTogImJsb2NrSW5kZW50S2V5bWFwIiwKKworICAgIEVudGVyOiBm dW5jdGlvbihjb2RlTWlycm9yKQorICAgIHsKKyAgICAgICAgaWYgKGNvZGVNaXJyb3Iuc29tZXRo aW5nU2VsZWN0ZWQoKSkKKyAgICAgICAgICAgIHJldHVybiBDb2RlTWlycm9yLlBhc3M7CisgICAg ICAgIHZhciBjdXJzb3IgPSBjb2RlTWlycm9yLmdldEN1cnNvcigpOworICAgICAgICB2YXIgbGlu ZSA9IGNvZGVNaXJyb3IuZ2V0TGluZShjdXJzb3IubGluZSk7CisgICAgICAgIGlmIChsaW5lLnN1 YnN0cihjdXJzb3IuY2ggLSAxLCAyKSA9PT0gInt9IikgeworICAgICAgICAgICAgY29kZU1pcnJv ci5leGVjQ29tbWFuZCgibmV3bGluZUFuZEluZGVudCIpOworICAgICAgICAgICAgY29kZU1pcnJv ci5zZXRDdXJzb3IoY3Vyc29yKTsKKyAgICAgICAgICAgIGNvZGVNaXJyb3IuZXhlY0NvbW1hbmQo Im5ld2xpbmVBbmRJbmRlbnQiKTsKKyAgICAgICAgfSBlbHNlCisgICAgICAgICAgICByZXR1cm4g Q29kZU1pcnJvci5QYXNzOworICAgIH0KK30KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==