112145 2013-03-12 06:47:27 -0700 LLINT C loop warning fix for GCC 2013-03-13 05:15:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy fpizlo galpeter mark.lam ossy webkit.review.bot zherczeg oldest_to_newest 853413 0 ossy 2013-03-12 06:47:27 -0700 C loop backend isn't buildable for JSVALUE32_64 platforms now: https://bugs.webkit.org/show_bug.cgi?id=112141 After the fix proposed in this bug the build fails with false positive warnings: generated/LLIntAssembly.h: In static member function 'static JSC::JSValue JSC::LLInt::CLoop::execute(JSC::CallFrame*, JSC::OpcodeID, bool)': generated/LLIntAssembly.h:3444:80: error: 't0.JSC::CLoopRegister::<anonymous>.JSC::CLoopRegister::<anonymous union>::instruction' may be used uninitialized in this function [-Werror=uninitialized] /home/oszi/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:305:19: note: 't0.JSC::CLoopRegister::<anonymous>.JSC::CLoopRegister::<anonymous union>::instruction' was declared here generated/LLIntAssembly.h:3279:80: error: 't1.JSC::CLoopRegister::<anonymous>.JSC::CLoopRegister::<anonymous union>::i' may be used uninitialized in this function [-Werror=uninitialized] /home/oszi/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:305:23: note: 't1.JSC::CLoopRegister::<anonymous>.JSC::CLoopRegister::<anonymous union>::i' was declared here cc1plus: all warnings being treated as errors We should shut this warning down for GCC similar to MSVC. :) Patch is coming soon. 853417 1 192726 ossy 2013-03-12 06:50:02 -0700 Created attachment 192726 Patch 853481 2 192726 fpizlo 2013-03-12 08:19:55 -0700 Comment on attachment 192726 Patch r=me 853488 3 fpizlo 2013-03-12 08:21:54 -0700 Actually, I think there may be a better way. I think that the initializations to zero are necessary on all smart compilers. We should make them unconditional. 853489 4 192726 fpizlo 2013-03-12 08:22:55 -0700 Comment on attachment 192726 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192726&action=review My review still stands since this is a build fix and you probably want to land it quickly. Your call if you want to try my improved version in this patch or in another one. > Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:300 > -#if COMPILER(MSVC) > +#if COMPILER(MSVC) || COMPILER(GCC) Maybe just remove this, and then #endif? 854145 5 192887 ossy 2013-03-13 02:26:34 -0700 Created attachment 192887 updated patch for EWS 854146 6 ossy 2013-03-13 02:27:39 -0700 (In reply to comment #5) > Created an attachment (id=192887) [details] > updated patch for EWS It wasn't so important to land the original patch, let's see if we can make all compiler happy with unconditional initialization. 854213 7 192887 webkit.review.bot 2013-03-13 05:15:39 -0700 Comment on attachment 192887 updated patch for EWS Clearing flags on attachment: 192887 Committed r145703: <http://trac.webkit.org/changeset/145703> 854214 8 webkit.review.bot 2013-03-13 05:15:42 -0700 All reviewed patches have been landed. Closing bug. 192726 2013-03-12 06:50:02 -0700 2013-03-13 02:26:30 -0700 Patch bug-112145-20130312064644.patch text/plain 1376 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy Y2E5MDJhOGQ5MjA2NmRhYjU1MWJiY2YzNjM4NDc1ZmRlODU5YWNjLi4wYjNjNjM1ZGM2Mzk4NjUx M2VmMjRmOGYyMGNjMDFmN2FlZTA3NWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0wMy0xMiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIExMSU5UIEMgbG9vcCB3YXJuaW5nIGZpeCBmb3IgR0NDCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIxNDUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxsaW50L0xvd0xldmVs SW50ZXJwcmV0ZXIuY3BwOgorICAgICAgICAoSlNDOjpDTG9vcDo6ZXhlY3V0ZSk6CisKIDIwMTMt MDMtMTIgIEdhYm9yIFJhcGNzYW55aSAgPHJnYWJvckB3ZWJraXQub3JnPgogCiAgICAgICAgIE1h a2luZyBtb3JlIHNvcGhpc3RpY2F0ZWQgY2FjaGUgZmx1c2ggb24gQVJNIExpbnV4IHBsYXRmb3Jt CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnBy ZXRlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRl ci5jcHAKaW5kZXggZDNjNzNiMDM1OGUyOGViNWNiY2VkZWU1YWE0MmYzNjJmOTQ1N2JiNS4uMjEy NGQxMWU0MjQ0ODBkNmZkYzc1YzY1ODk0NTA2MWQzM2U4NTg5ZCAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmNwcApAQCAtMjk3LDcg KzI5Nyw3IEBAIEpTVmFsdWUgQ0xvb3A6OmV4ZWN1dGUoQ2FsbEZyYW1lKiBjYWxsRnJhbWUsIE9w Y29kZUlEIGJvb3RzdHJhcE9wY29kZUlkLAogICAgIENMb29wUmVnaXN0ZXIgclJldFZQQzsKICAg ICBDTG9vcERvdWJsZVJlZ2lzdGVyIGQwLCBkMTsKIAotI2lmIENPTVBJTEVSKE1TVkMpCisjaWYg Q09NUElMRVIoTVNWQykgfHwgQ09NUElMRVIoR0NDKQogICAgIC8vIEtlZXAgdGhlIGNvbXBpbGVy IGhhcHB5LiBXZSBkb24ndCByZWFsbHkgbmVlZCB0aGlzLCBidXQgdGhlIGNvbXBpbGVyCiAgICAg Ly8gd2lsbCBjb21wbGFpbi4gVGhpcyBtYWtlcyB0aGUgd2FybmluZyBnbyBhd2F5LgogICAgIHQw LmkgPSAwOwo= 192887 2013-03-13 02:26:34 -0700 2013-03-13 05:15:39 -0700 updated patch for EWS bug-112145-20130313102316.patch text/plain 1461 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NjkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy NzQ4Mjk2NmJhYjUyNWRkZTI0ZmVkNzg3ZDQ2YWZlZWY0NzhiNmFhLi5mYTE1ZGFkM2Y0NGNhY2U2 M2FjODgxNjc5MWNjODQ5OWYyMmIzOGRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0wMy0xMyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIExMSU5UIEMgbG9vcCB3YXJuaW5nIGZpeCBmb3IgR0NDCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIxNDUKKworICAgICAg ICBSZXZpZXdlZCBieSBGaWxpcCBQaXpsby4KKworICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50 ZXJwcmV0ZXIuY3BwOgorICAgICAgICAoSlNDOjpDTG9vcDo6ZXhlY3V0ZSk6CisKIDIwMTMtMDMt MTMgIFBldGVyIEdhbCAgPGdhbHBldGVyQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBUb2tl biAnbm90JyBpcyBpZ25vcmVkIGluIHRoZSBvZmZsaW5lYXNtLgpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuY3BwCmluZGV4IDE4NmM2NTk5 YTUxNjk4ZDI0NWJkMzUyZTM5NzZiOTAxYjZkODNhYTkuLjkxODEyMDg2YTY3YjJkNmMzMWJhNDI2 OThhM2FhYWU2MTg0OTIwODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGlu dC9Mb3dMZXZlbEludGVycHJldGVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxp bnQvTG93TGV2ZWxJbnRlcnByZXRlci5jcHAKQEAgLTMwOCwxMiArMzA4LDEwIEBAIEpTVmFsdWUg Q0xvb3A6OmV4ZWN1dGUoQ2FsbEZyYW1lKiBjYWxsRnJhbWUsIE9wY29kZUlEIGJvb3RzdHJhcE9w Y29kZUlkLAogICAgIENMb29wUmVnaXN0ZXIgclJldFZQQzsKICAgICBDTG9vcERvdWJsZVJlZ2lz dGVyIGQwLCBkMTsKIAotI2lmIENPTVBJTEVSKE1TVkMpCiAgICAgLy8gS2VlcCB0aGUgY29tcGls ZXIgaGFwcHkuIFdlIGRvbid0IHJlYWxseSBuZWVkIHRoaXMsIGJ1dCB0aGUgY29tcGlsZXIKICAg ICAvLyB3aWxsIGNvbXBsYWluLiBUaGlzIG1ha2VzIHRoZSB3YXJuaW5nIGdvIGF3YXkuCiAgICAg dDAuaSA9IDA7CiAgICAgdDEuaSA9IDA7Ci0jZW5kaWYKIAogICAgIC8vIEluc3RhbnRpYXRlIHRo ZSBwc2V1ZG8gSklUIHN0YWNrIGZyYW1lIHVzZWQgYnkgdGhlIExMSU5UIEMgTG9vcCBiYWNrZW5k OgogICAgIEpJVFN0YWNrRnJhbWUgaml0U3RhY2tGcmFtZTsK