112137 2013-03-12 05:24:04 -0700 Web Inspector: Fix JSDocs in TimelinePanel.js 2013-03-12 05:47:48 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eustas eustas apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 853368 0 eustas 2013-03-12 05:24:04 -0700 Source/WebCore/inspector/front-end/TimelinePanel.js:355: WARNING - actual parameter 1 of WebInspector.createFileSelectorElement does not match formal parameter found : function (string): undefined required: function (File): ? this._fileSelectorElement = WebInspector.createFileSelectorElement(this._loadFromFile.bind(this)); ^ Source/WebCore/inspector/front-end/TimelinePanel.js:384: WARNING - actual parameter 1 of WebInspector.TimelineModel.prototype.loadFromFile does not match formal parameter found : string required: Blob this._model.loadFromFile(fileName, progressIndicator); ^ 853372 1 192716 eustas 2013-03-12 05:26:30 -0700 Created attachment 192716 Patch 853389 2 192716 webkit.review.bot 2013-03-12 05:47:44 -0700 Comment on attachment 192716 Patch Clearing flags on attachment: 192716 Committed r145537: <http://trac.webkit.org/changeset/145537> 853391 3 webkit.review.bot 2013-03-12 05:47:48 -0700 All reviewed patches have been landed. Closing bug. 192716 2013-03-12 05:26:30 -0700 2013-03-12 05:47:44 -0700 Patch bug-112137-20130312162228.patch text/plain 1553 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzEzNGI5MTkyYjc4NjM5 ZTU2ZWQyMjBjN2E4YWZlZmZjNDIzYTdiZS4uYTY4MGE3NzI2ZGEzNmIzYTdhODI2NWFiOTI3YTc3 NWE4ZDliNzAzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAzLTEyICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IEZpeCBKU0RvY3MgaW4gVGltZWxpbmVQYW5lbC5qcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMTM3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHBhcmFtZXRlciB0eXBlIGFubm90YXRp b24gb2YgX2xvYWRGcm9tRmlsZS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGlt ZWxpbmVQYW5lbC5qczogRml4ZWQgSlNEb2MuCisKIDIwMTMtMDMtMTIgIFNoZXJpZmYgQm90ICA8 d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHIxNDU1MTQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1RpbWVsaW5lUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1RpbWVsaW5lUGFuZWwuanMKaW5kZXggYjZiNWM0Njg3OGVkZWQ2ZGE1NDVhY2YxMzI3Yjlk NzNiMmZlNDhmOC4uNzg3MWViZGVmYTc2YmI0ODllYmU2N2QzNjUwNGUyM2RhODFmZDlhZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVs LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5l bC5qcwpAQCAtMzc0LDE0ICszNzQsMTQgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJv dG90eXBlID0gewogICAgIH0sCiAKICAgICAvKioKLSAgICAgKiBAcGFyYW0ge3N0cmluZ30gZmls ZU5hbWUKKyAgICAgKiBAcGFyYW0geyFGaWxlfSBmaWxlCiAgICAgICovCi0gICAgX2xvYWRGcm9t RmlsZTogZnVuY3Rpb24oZmlsZU5hbWUpCisgICAgX2xvYWRGcm9tRmlsZTogZnVuY3Rpb24oZmls ZSkKICAgICB7CiAgICAgICAgIHZhciBwcm9ncmVzc0luZGljYXRvciA9IHRoaXMuX3ByZXBhcmVU b0xvYWRUaW1lbGluZSgpOwogICAgICAgICBpZiAoIXByb2dyZXNzSW5kaWNhdG9yKQogICAgICAg ICAgICAgcmV0dXJuOwotICAgICAgICB0aGlzLl9tb2RlbC5sb2FkRnJvbUZpbGUoZmlsZU5hbWUs IHByb2dyZXNzSW5kaWNhdG9yKTsKKyAgICAgICAgdGhpcy5fbW9kZWwubG9hZEZyb21GaWxlKGZp bGUsIHByb2dyZXNzSW5kaWNhdG9yKTsKICAgICAgICAgdGhpcy5fY3JlYXRlRmlsZVNlbGVjdG9y KCk7CiAgICAgfSwKIAo=