112133 2013-03-12 04:19:57 -0700 [BlackBerry] SelectionHandler: fix truncated line 2013-03-12 05:31:50 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned cgarcia mifenton rwlbuis tonikitoo webkit.review.bot xan.lopez oldest_to_newest 853320 0 berto 2013-03-12 04:19:57 -0700 One of the call to fatFingersResult.nodeAsElementIfApplicable() was somehow truncated when the selection start animation was upstreamed in r144640. http://trac.webkit.org/changeset/144640/trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 853328 1 192707 berto 2013-03-12 04:21:58 -0700 Created attachment 192707 Patch 853352 2 192707 cgarcia 2013-03-12 05:04:19 -0700 Comment on attachment 192707 Patch Oooops 853378 3 192707 webkit.review.bot 2013-03-12 05:31:46 -0700 Comment on attachment 192707 Patch Clearing flags on attachment: 192707 Committed r145534: <http://trac.webkit.org/changeset/145534> 853379 4 webkit.review.bot 2013-03-12 05:31:50 -0700 All reviewed patches have been landed. Closing bug. 192707 2013-03-12 04:21:58 -0700 2013-03-12 05:31:46 -0700 Patch 112133.diff text/plain 1883 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDMzMWU4OTEuLjIyZjc0MDEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTEyICBB bGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJy eV0gU2VsZWN0aW9uSGFuZGxlcjogZml4IHRydW5jYXRlZCBsaW5lCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIxMzMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbmUgb2YgdGhlIGNhbGxzIHRvIGZhdEZp bmdlcnNSZXN1bHQubm9kZUFzRWxlbWVudElmQXBwbGljYWJsZSgpCisgICAgICAgIHdhcyBzb21l aG93IHRydW5jYXRlZCB3aGVuIHRoZSBzZWxlY3Rpb24gc3RhcnQgYW5pbWF0aW9uIHdhcworICAg ICAgICB1cHN0cmVhbWVkIGluIHIxNDQ2NDAuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L1Nl bGVjdGlvbkhhbmRsZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rp b25IYW5kbGVyOjpzZWxlY3RBdFBvaW50KToKKwogMjAxMy0wMy0xMSAgSm9jaGVuIEVpc2luZ2Vy ICA8am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW5hbWUgRGVmaW5pdGVseVByb2Nl c3NpbmdVc2VyR2VzdHVyZSB0byBEZWZpbml0ZWx5UHJvY2Vzc2luZ05ld1VzZXJHZXN0dXJlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rp b25IYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1Nl bGVjdGlvbkhhbmRsZXIuY3BwCmluZGV4IDQ4ZWFiNzQuLmRmZTNmOTUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhh bmRsZXIuY3BwCkBAIC02NDgsNyArNjQ4LDcgQEAgdm9pZCBTZWxlY3Rpb25IYW5kbGVyOjpzZWxl Y3RBdFBvaW50KGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiBsb2NhdGlvbiwgU2VsZWN0aW8KICAg ICBGYXRGaW5nZXJzUmVzdWx0IGZhdEZpbmdlcnNSZXN1bHQgPSBtX3dlYlBhZ2UtPm1fdG91Y2hF dmVudEhhbmRsZXItPmxhc3RGYXRGaW5nZXJzUmVzdWx0KCk7CiAgICAgaWYgKHNlbGVjdE5vZGVJ ZkZhdEZpbmdlcnNSZXN1bHRJc0xpbmsoZmF0RmluZ2Vyc1Jlc3VsdCkpCiAgICAgICAgIHJldHVy bjsKLSAgICBpZiAoIWZhdEZpbmdlcnNSZXN1bHQucmVzdWx0TWF0Y2hlcyhsb2NhdGlvbiwgRmF0 RmluZ2Vyczo6VGV4dCkgfHwgIWZhdEZpbmdlcnNSZXN1bHQucG9zaXRpb25XYXNBZGp1c3RlZCgp IHx8ICFmYXRGaW5nZXJzUmVzdWx0Lm5vZGVBc0VsZW0KKyAgICBpZiAoIWZhdEZpbmdlcnNSZXN1 bHQucmVzdWx0TWF0Y2hlcyhsb2NhdGlvbiwgRmF0RmluZ2Vyczo6VGV4dCkgfHwgIWZhdEZpbmdl cnNSZXN1bHQucG9zaXRpb25XYXNBZGp1c3RlZCgpIHx8ICFmYXRGaW5nZXJzUmVzdWx0Lm5vZGVB c0VsZW1lbnRJZkFwcGxpY2FibGUoKSkKICAgICAgICAgZmF0RmluZ2Vyc1Jlc3VsdCA9IEZhdEZp bmdlcnMobV93ZWJQYWdlLCBsb2NhdGlvbiwgRmF0RmluZ2Vyczo6VGV4dCkuZmluZEJlc3RQb2lu dCgpOwogCiAgICAgaWYgKCFmYXRGaW5nZXJzUmVzdWx0LnBvc2l0aW9uV2FzQWRqdXN0ZWQoKSkg ewo=