112131 2013-03-12 04:07:39 -0700 [BlackBerry] Fix visible_units.h includes 2013-03-12 05:14:13 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned cgarcia mifenton rwlbuis tonikitoo webkit.review.bot xan.lopez oldest_to_newest 853305 0 berto 2013-03-12 04:07:39 -0700 This file was renamed to VisibleUnits.h in r144911 http://trac.webkit.org/changeset/144911 853308 1 192706 berto 2013-03-12 04:10:18 -0700 Created attachment 192706 Patch 853317 2 webkit.review.bot 2013-03-12 04:17:04 -0700 Attachment 192706 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp']" exit_code: 1 Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:40: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:68: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 853329 3 192706 cgarcia 2013-03-12 04:25:09 -0700 Comment on attachment 192706 Patch Please, fix the style issues. Thanks! 853338 4 192709 berto 2013-03-12 04:37:06 -0700 Created attachment 192709 Patch 853351 5 192709 cgarcia 2013-03-12 05:04:01 -0700 Comment on attachment 192709 Patch Thanks 853358 6 192709 webkit.review.bot 2013-03-12 05:14:09 -0700 Comment on attachment 192709 Patch Clearing flags on attachment: 192709 Committed r145529: <http://trac.webkit.org/changeset/145529> 853359 7 webkit.review.bot 2013-03-12 05:14:13 -0700 All reviewed patches have been landed. Closing bug. 192706 2013-03-12 04:10:18 -0700 2013-03-12 04:37:06 -0700 Patch 112131.diff text/plain 2753 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDMzMWU4OTEuLmZmYzcwOGMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTEyICBB bGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJy eV0gRml4IHZpc2libGVfdW5pdHMuaCBpbmNsdWRlcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBmaWxlIHdhcyByZW5hbWVkIHRvIFZpc2libGVV bml0cy5oIGluIHIxNDQ5MTEuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQu Y3BwOgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKKyAgICAgICAg KiBXZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwOgorICAgICAgICAqIFdlYktpdFN1 cHBvcnQvU3BlbGxpbmdIYW5kbGVyLmNwcDoKKwogMjAxMy0wMy0xMSAgSm9jaGVuIEVpc2luZ2Vy ICA8am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW5hbWUgRGVmaW5pdGVseVByb2Nl c3NpbmdVc2VyR2VzdHVyZSB0byBEZWZpbml0ZWx5UHJvY2Vzc2luZ05ld1VzZXJHZXN0dXJlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBw b3J0LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBv cnQuY3BwCmluZGV4IGJlMGFlNGMuLjY3ZGJiMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwCkBAIC0zNyw3ICszNyw3 IEBACiAjaW5jbHVkZSAiVmlzaWJsZVNlbGVjdGlvbi5oIgogCiAjaW5jbHVkZSAiaHRtbGVkaXRp bmcuaCIKLSNpbmNsdWRlICJ2aXNpYmxlX3VuaXRzLmgiCisjaW5jbHVkZSAiVmlzaWJsZVVuaXRz LmgiCiAKICNpbmNsdWRlIDxsaW1pdHM+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCmluZGV4IDc4NGMzZjUuLmVj ZmI5ZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0 L0lucHV0SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvSW5wdXRIYW5kbGVyLmNwcApAQCAtNjUsNyArNjUsNyBAQAogI2luY2x1ZGUgIldlYlBh Z2VfcC5oIgogI2luY2x1ZGUgIldlYlNldHRpbmdzLmgiCiAjaW5jbHVkZSAiaHRtbGVkaXRpbmcu aCIKLSNpbmNsdWRlICJ2aXNpYmxlX3VuaXRzLmgiCisjaW5jbHVkZSAiVmlzaWJsZVVuaXRzLmgi CiAKICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1EZXZpY2VJbmZvLmg+CiAjaW5jbHVkZSA8 QmxhY2tCZXJyeVBsYXRmb3JtSU1GLmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCmluZGV4IDQ4ZWFi NzQuLjUxZDgxMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCkBAIC0zNiw3ICszNiw3IEBACiAj aW5jbHVkZSAiV2ViUGFnZV9wLmgiCiAKICNpbmNsdWRlICJodG1sZWRpdGluZy5oIgotI2luY2x1 ZGUgInZpc2libGVfdW5pdHMuaCIKKyNpbmNsdWRlICJWaXNpYmxlVW5pdHMuaCIKIAogI2luY2x1 ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUtleWJvYXJkRXZlbnQuaD4KICNpbmNsdWRlIDxCbGFja0Jl cnJ5UGxhdGZvcm1Mb2cuaD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9X ZWJLaXRTdXBwb3J0L1NwZWxsaW5nSGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViS2l0U3VwcG9ydC9TcGVsbGluZ0hhbmRsZXIuY3BwCmluZGV4IDlkZDU5YTkuLjNlMjIx YTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1Nw ZWxsaW5nSGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvU3BlbGxpbmdIYW5kbGVyLmNwcApAQCAtOSw3ICs5LDcgQEAKICNpbmNsdWRlICJJbnB1 dEhhbmRsZXIuaCIKICNpbmNsdWRlICJSYW5nZS5oIgogI2luY2x1ZGUgIlNwZWxsQ2hlY2tlci5o IgotI2luY2x1ZGUgInZpc2libGVfdW5pdHMuaCIKKyNpbmNsdWRlICJWaXNpYmxlVW5pdHMuaCIK IAogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUlNRi5oPgogI2luY2x1ZGUgPEJsYWNrQmVy cnlQbGF0Zm9ybUxvZy5oPgo= 192709 2013-03-12 04:37:06 -0700 2013-03-12 05:14:09 -0700 Patch 112131.diff text/plain 3048 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDMzMWU4OTEuLmZmYzcwOGMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTEyICBB bGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJy eV0gRml4IHZpc2libGVfdW5pdHMuaCBpbmNsdWRlcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBmaWxlIHdhcyByZW5hbWVkIHRvIFZpc2libGVV bml0cy5oIGluIHIxNDQ5MTEuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQu Y3BwOgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKKyAgICAgICAg KiBXZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwOgorICAgICAgICAqIFdlYktpdFN1 cHBvcnQvU3BlbGxpbmdIYW5kbGVyLmNwcDoKKwogMjAxMy0wMy0xMSAgSm9jaGVuIEVpc2luZ2Vy ICA8am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW5hbWUgRGVmaW5pdGVseVByb2Nl c3NpbmdVc2VyR2VzdHVyZSB0byBEZWZpbml0ZWx5UHJvY2Vzc2luZ05ld1VzZXJHZXN0dXJlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBw b3J0LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBv cnQuY3BwCmluZGV4IGJlMGFlNGMuLjRhNTZmMWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwCkBAIC0zNSw5ICszNSw5 IEBACiAjaW5jbHVkZSAiVGV4dEl0ZXJhdG9yLmgiCiAjaW5jbHVkZSAiVmlzaWJsZVBvc2l0aW9u LmgiCiAjaW5jbHVkZSAiVmlzaWJsZVNlbGVjdGlvbi5oIgorI2luY2x1ZGUgIlZpc2libGVVbml0 cy5oIgogCiAjaW5jbHVkZSAiaHRtbGVkaXRpbmcuaCIKLSNpbmNsdWRlICJ2aXNpYmxlX3VuaXRz LmgiCiAKICNpbmNsdWRlIDxsaW1pdHM+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCmluZGV4IDc4NGMzZjUuLmE2 NzA3YWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0 L0lucHV0SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvSW5wdXRIYW5kbGVyLmNwcApAQCAtNjEsMTEgKzYxLDExIEBACiAjaW5jbHVkZSAiVGV4 dENoZWNrZXJDbGllbnQuaCIKICNpbmNsdWRlICJUZXh0SXRlcmF0b3IuaCIKICNpbmNsdWRlICJW aXNpYmxlUG9zaXRpb24uaCIKKyNpbmNsdWRlICJWaXNpYmxlVW5pdHMuaCIKICNpbmNsdWRlICJX ZWJQYWdlQ2xpZW50LmgiCiAjaW5jbHVkZSAiV2ViUGFnZV9wLmgiCiAjaW5jbHVkZSAiV2ViU2V0 dGluZ3MuaCIKICNpbmNsdWRlICJodG1sZWRpdGluZy5oIgotI2luY2x1ZGUgInZpc2libGVfdW5p dHMuaCIKIAogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybURldmljZUluZm8uaD4KICNpbmNs dWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1JTUYuaD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKaW5kZXgg NDhlYWI3NC4uZDc5MDAwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dl YktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKQEAgLTMyLDExICszMiwx MSBAQAogI2luY2x1ZGUgIlJlbmRlckxheWVyLmgiCiAjaW5jbHVkZSAiU2VsZWN0aW9uT3Zlcmxh eS5oIgogI2luY2x1ZGUgIlRvdWNoRXZlbnRIYW5kbGVyLmgiCisjaW5jbHVkZSAiVmlzaWJsZVVu aXRzLmgiCiAjaW5jbHVkZSAiV2ViUGFnZUNsaWVudC5oIgogI2luY2x1ZGUgIldlYlBhZ2VfcC5o IgogCiAjaW5jbHVkZSAiaHRtbGVkaXRpbmcuaCIKLSNpbmNsdWRlICJ2aXNpYmxlX3VuaXRzLmgi CiAKICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1LZXlib2FyZEV2ZW50Lmg+CiAjaW5jbHVk ZSA8QmxhY2tCZXJyeVBsYXRmb3JtTG9nLmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TcGVsbGluZ0hhbmRsZXIuY3BwIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU3BlbGxpbmdIYW5kbGVyLmNwcAppbmRleCA5ZGQ1 OWE5Li4zZTIyMWE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9TcGVsbGluZ0hhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L1NwZWxsaW5nSGFuZGxlci5jcHAKQEAgLTksNyArOSw3IEBACiAjaW5j bHVkZSAiSW5wdXRIYW5kbGVyLmgiCiAjaW5jbHVkZSAiUmFuZ2UuaCIKICNpbmNsdWRlICJTcGVs bENoZWNrZXIuaCIKLSNpbmNsdWRlICJ2aXNpYmxlX3VuaXRzLmgiCisjaW5jbHVkZSAiVmlzaWJs ZVVuaXRzLmgiCiAKICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1JTUYuaD4KICNpbmNsdWRl IDxCbGFja0JlcnJ5UGxhdGZvcm1Mb2cuaD4K